)]}'
{"novaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"c5c0ed6464df4e93aae829014aeb264bb95f13d8","unresolved":false,"context_lines":[{"line_number":1658,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/os-aggregates/1/action\u0027, body, pos\u003d-2)"},{"line_number":1659,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/os-aggregates/1\u0027, pos\u003d-1)"},{"line_number":1660,"context_line":""},{"line_number":1661,"context_line":"    def test_aggregate_show_by_id(self):"},{"line_number":1662,"context_line":"        self.run_command(\u0027aggregate-show 1\u0027)"},{"line_number":1663,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/os-aggregates/1\u0027)"},{"line_number":1664,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_0c3703e4","line":1661,"updated":"2016-03-14 16:00:43.000000000","message":"This eliminates the tests on the aggregate-details command.  I want to see tests added for the new aggregate-show, not existing tests changed in such a way as to eliminate some testing.","commit_id":"5ec34590e97bab6a1f7f763b3b1eab8bff9230e4"}],"novaclient/v2/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"c5c0ed6464df4e93aae829014aeb264bb95f13d8","unresolved":false,"context_lines":[{"line_number":3779,"context_line":"    \u0027aggregate\u0027, metavar\u003d\u0027\u003caggregate\u003e\u0027,"},{"line_number":3780,"context_line":"    help\u003d_(\u0027Name or ID of aggregate.\u0027))"},{"line_number":3781,"context_line":"def do_aggregate_details(cs, args):"},{"line_number":3782,"context_line":"    \"\"\"Deprecated\"\"\""},{"line_number":3783,"context_line":"    aggregate \u003d _find_aggregate(cs, args.aggregate)"},{"line_number":3784,"context_line":"    _print_aggregate_details(aggregate)"},{"line_number":3785,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_e1b74084","line":3782,"updated":"2016-03-14 16:00:43.000000000","message":"This isn\u0027t the standard used for deprecation throughout this file.  See, for instance, the docstring in the do_rename() function, or any of a number of other deprecated commands.","commit_id":"5ec34590e97bab6a1f7f763b3b1eab8bff9230e4"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9827868b7547a08e9a37ffbc2e2241df6b3893f4","unresolved":false,"context_lines":[{"line_number":3780,"context_line":"    help\u003d_(\u0027Name or ID of aggregate.\u0027))"},{"line_number":3781,"context_line":"def do_aggregate_details(cs, args):"},{"line_number":3782,"context_line":"    \"\"\"Deprecated\"\"\""},{"line_number":3783,"context_line":"    aggregate \u003d _find_aggregate(cs, args.aggregate)"},{"line_number":3784,"context_line":"    _print_aggregate_details(aggregate)"},{"line_number":3785,"context_line":""},{"line_number":3786,"context_line":""},{"line_number":3787,"context_line":"@utils.arg("}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_8ce84512","line":3784,"range":{"start_line":3783,"start_character":4,"end_line":3784,"end_character":39},"updated":"2016-03-14 11:49:59.000000000","message":"please, replace it with ``do_aggregate_show(cs, args)`` call. It will allow to reduce code duplication and make make sure that outputs are equal.","commit_id":"5ec34590e97bab6a1f7f763b3b1eab8bff9230e4"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"d5862c50ebc28d947a56e3fc6196865b5edfd1ea","unresolved":false,"context_lines":[{"line_number":3781,"context_line":"def do_aggregate_details(cs, args):"},{"line_number":3782,"context_line":"    \"\"\"DEPRECATED, use aggregate-show instead.\"\"\""},{"line_number":3783,"context_line":"    aggregate \u003d _find_aggregate(cs, args.aggregate)"},{"line_number":3784,"context_line":"    _print_aggregate_details(aggregate)"},{"line_number":3785,"context_line":""},{"line_number":3786,"context_line":""},{"line_number":3787,"context_line":"@utils.arg("}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_f5018139","line":3784,"updated":"2016-03-17 19:06:16.000000000","message":"You do not appear to have addressed Andrey Kurilin\u0027s comment regarding replacing the two lines above with a direct call to the new do_aggregate_show() function, which, as he points out, would reduce code duplication.","commit_id":"bd0c4d3befcb62c1b41c00c8674ede5cec47b0c4"}]}