)]}'
{"id":"openstack%2Fpython-novaclient~29241","triplet_id":"openstack%2Fpython-novaclient~master~Ic8b466a57554018092c31c6d6b3ea62f181d7000","project":"openstack/python-novaclient","branch":"master","topic":"bug/1180393","hashtags":[],"change_id":"Ic8b466a57554018092c31c6d6b3ea62f181d7000","subject":"Make ManagerWithFind abstract and fix its descendants","status":"MERGED","created":"2013-05-15 13:46:58.000000000","updated":"2013-05-20 17:16:08.000000000","submitted":"2013-05-20 17:16:08.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1c70255730f048fa79d69233ef2f8c7cc3f07f40","_number":29241,"virtual_id_number":29241,"owner":{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-05-20 17:16:08.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-05-15 18:50:35.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},{"value":2,"date":"2013-05-20 14:38:09.000000000","_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":2,"date":"2013-05-15 18:51:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-05-15 18:47:08.000000000","_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},{"value":1,"date":"2013-05-20 14:38:09.000000000","_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"date":"2013-05-15 18:51:06.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2013-05-17 21:11:59.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-15 18:51:06.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-05-17 21:11:59.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2013-05-20 14:38:09.000000000","updated_by":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"reviewer":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"state":"REVIEWER"},{"updated":"2013-05-20 17:16:08.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d7573c7d7283a5b240bcb513b99f3e59f3734b36","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-15 14:39:22.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/29241/1/check/gate-python-novaclient-pep8/1481 : SUCCESS in 13s\n- http://docs-draft.openstack.org/29241/1/check/gate-python-novaclient-docs/1172/doc/build/html/ : SUCCESS in 1m 05s\n- http://logs.openstack.org/29241/1/check/gate-python-novaclient-python26/1271 : SUCCESS in 1m 00s\n- http://logs.openstack.org/29241/1/check/gate-python-novaclient-python27/1490 : SUCCESS in 47s\n- http://logs.openstack.org/29241/1/check/gate-tempest-devstack-vm-full/16075 : SUCCESS in 40m 23s\n- http://logs.openstack.org/29241/1/check/gate-tempest-devstack-vm-postgres-full/15791 : FAILURE in 52m 13s (non-voting)\n- http://logs.openstack.org/29241/1/check/gate-tempest-devstack-vm-quantum/22559 : SUCCESS in 20m 52s\n- http://logs.openstack.org/29241/1/check/gate-grenade-devstack-vm/3702 : FAILURE in 10m 03s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"34878aadd780b65356760a16e551e490812a9529","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-05-15 15:51:38.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(4 inline comments)\n\nManagerWithFind.list() is now multiply defined, and there\u0027s a backwards-compatibility issue in hosts…","accounts_in_message":[],"_revision_number":1},{"id":"2ba0cb5c1f03083dfb74fee9febe7796c7d7b868","author":{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},"date":"2013-05-15 18:47:08.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"06d800ce329d3cd9b4242948794a05709e71af12","author":{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},"date":"2013-05-15 18:47:15.000000000","message":"Patch Set 1: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"00a331dff10259b8de164dc64504ece79d6f53c2","author":{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},"date":"2013-05-15 18:50:35.000000000","message":"Patch Set 2:\n\nThank you, Kevin!\n\nI\u0027m working on a common client library, so I face some hidden errors in OpenStack clients.\n\nI think that there will be no benefit in setting __metaclass__ \u003d abc.ABCMeta for other Managers, but specifying ManagerWithFind as abstract we can reveal errors early (that\u0027s why I have discovered improper descendants).","accounts_in_message":[],"_revision_number":2},{"id":"ec5f0ab80e9db08a36e20be15a21826283a404ef","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-05-15 18:51:06.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"7281ca6de045ea2a6a5dbc6a0129278af664baa5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-15 19:42:40.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/29241/2/check/gate-python-novaclient-pep8/1482 : SUCCESS in 16s\n- http://docs-draft.openstack.org/29241/2/check/gate-python-novaclient-docs/1173/doc/build/html/ : SUCCESS in 1m 01s\n- http://logs.openstack.org/29241/2/check/gate-python-novaclient-python26/1272 : SUCCESS in 59s\n- http://logs.openstack.org/29241/2/check/gate-python-novaclient-python27/1491 : SUCCESS in 55s\n- http://logs.openstack.org/29241/2/check/gate-tempest-devstack-vm-full/16139 : SUCCESS in 50m 36s\n- http://logs.openstack.org/29241/2/check/gate-tempest-devstack-vm-postgres-full/15855 : FAILURE in 46m 42s (non-voting)\n- http://logs.openstack.org/29241/2/check/gate-tempest-devstack-vm-quantum/22636 : SUCCESS in 20m 26s\n- http://logs.openstack.org/29241/2/check/gate-grenade-devstack-vm/3757 : FAILURE in 9m 35s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"747b4a6632d441d185886a01b81a15002e41f526","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2013-05-20 14:38:09.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"f58fcbfcaf2804227be64d4df6098d9972998b4b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-20 14:38:11.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"fa87f77c8ee70637a0acaa39acc31e07a31b825c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-20 15:33:24.000000000","message":"Patch Set 2: Fails\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://docs-draft.openstack.org/29241/2/gate/gate-python-novaclient-docs/1203/doc/build/html/ : SUCCESS in 1m 26s\n- http://logs.openstack.org/29241/2/gate/gate-python-novaclient-pep8/1512 : SUCCESS in 15s\n- http://logs.openstack.org/29241/2/gate/gate-python-novaclient-python26/1302 : SUCCESS in 1m 18s\n- http://logs.openstack.org/29241/2/gate/gate-python-novaclient-python27/1521 : SUCCESS in 1m 05s\n- http://logs.openstack.org/29241/2/gate/gate-tempest-devstack-vm-full/16916 : SUCCESS in 45m 44s\n- http://logs.openstack.org/29241/2/gate/gate-tempest-devstack-vm-postgres-full/16631 : FAILURE in 45m 58s (non-voting)\n- http://logs.openstack.org/29241/2/gate/gate-tempest-devstack-vm-quantum/23525 : FAILURE in 28m 08s\n- http://logs.openstack.org/29241/2/gate/gate-grenade-devstack-vm/4473 : FAILURE in 13m 03s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"4a47539d65af906ab7e588ea8f4dbe2143263435","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-05-20 15:49:51.000000000","message":"Patch Set 2:\n\nreverify no bug","accounts_in_message":[],"_revision_number":2},{"id":"c67c11dc2de8cafd253d7efee0b840a284db3f5a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-20 15:49:59.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"ef54a5d1dd955defc49feb72f02126b5e5721dcd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-20 17:16:08.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"000082604be87646e386f1900a0818155f3616d7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-20 17:16:08.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/29241/2/gate/gate-python-novaclient-docs/1207/doc/build/html/ : SUCCESS in 1m 43s\n- http://logs.openstack.org/29241/2/gate/gate-python-novaclient-pep8/1516 : SUCCESS in 19s\n- http://logs.openstack.org/29241/2/gate/gate-python-novaclient-python26/1306 : SUCCESS in 1m 20s\n- http://logs.openstack.org/29241/2/gate/gate-python-novaclient-python27/1525 : SUCCESS in 53s\n- http://logs.openstack.org/29241/2/gate/gate-tempest-devstack-vm-full/16940 : SUCCESS in 51m 03s\n- http://logs.openstack.org/29241/2/gate/gate-tempest-devstack-vm-postgres-full/16655 : FAILURE in 46m 17s (non-voting)\n- http://logs.openstack.org/29241/2/gate/gate-tempest-devstack-vm-quantum/23554 : SUCCESS in 22m 02s\n- http://logs.openstack.org/29241/2/gate/gate-grenade-devstack-vm/4495 : FAILURE in 11m 51s (non-voting)\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c9fc9b5b8ff12218e26a71e0660f774bb3546eb3","revisions":{"d96f948ee76c86ec2da1ff764cc4db21c89ae9a6":{"kind":"REWORK","_number":1,"created":"2013-05-15 13:46:58.000000000","uploader":{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},"ref":"refs/changes/41/29241/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/41/29241/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/29241/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/29241/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/29241/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/41/29241/1"}}},"commit":{"parents":[{"commit":"64e43fde43e478af8dc95ccc0904dfca0d0dbe0c","subject":"Merge \"Cleanup some flavor commands\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/64e43fde43e478af8dc95ccc0904dfca0d0dbe0c"}]}],"author":{"name":"Alessio Ababilov","email":"aababilov@griddynamics.com","date":"2013-05-15 13:45:01.000000000","tz":180},"committer":{"name":"Alessio Ababilov","email":"aababilov@griddynamics.com","date":"2013-05-15 13:47:06.000000000","tz":180},"subject":"Make ManagerWithFind abstract and fix its descendants","message":"Make ManagerWithFind abstract and fix its descendants\n\nManagerWithFind requires list() method in its descendants.\nMake it abstract and fix its improper descendants that do\nnot implement list() (SecurityGroupRuleManager and many others).\n\nFixes: bug #1180393\nChange-Id: Ic8b466a57554018092c31c6d6b3ea62f181d7000\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d96f948ee76c86ec2da1ff764cc4db21c89ae9a6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d96f948ee76c86ec2da1ff764cc4db21c89ae9a6"}]},"branch":"refs/heads/master"},"c9fc9b5b8ff12218e26a71e0660f774bb3546eb3":{"kind":"REWORK","_number":2,"created":"2013-05-15 18:47:08.000000000","uploader":{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},"ref":"refs/changes/41/29241/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/41/29241/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/29241/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/29241/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/29241/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/41/29241/2"}}},"commit":{"parents":[{"commit":"64e43fde43e478af8dc95ccc0904dfca0d0dbe0c","subject":"Merge \"Cleanup some flavor commands\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/64e43fde43e478af8dc95ccc0904dfca0d0dbe0c"}]}],"author":{"name":"Alessio Ababilov","email":"aababilov@griddynamics.com","date":"2013-05-15 13:45:01.000000000","tz":180},"committer":{"name":"Alessio Ababilov","email":"aababilov@griddynamics.com","date":"2013-05-15 18:47:05.000000000","tz":180},"subject":"Make ManagerWithFind abstract and fix its descendants","message":"Make ManagerWithFind abstract and fix its descendants\n\nManagerWithFind requires list() method in its descendants.\nMake it abstract and fix its improper descendants that do\nnot implement list() (SecurityGroupRuleManager and many others).\n\nFixes: bug #1180393\nChange-Id: Ic8b466a57554018092c31c6d6b3ea62f181d7000\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c9fc9b5b8ff12218e26a71e0660f774bb3546eb3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c9fc9b5b8ff12218e26a71e0660f774bb3546eb3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}