)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"645a45e2f238c4139cdc4d9017678e798c133b52","unresolved":false,"context_lines":[{"line_number":9,"context_line":"as a new entity. This behavior seems inconsistent from the viewpoint"},{"line_number":10,"context_line":"of whole Nova API."},{"line_number":11,"context_line":"The changes made in nova are dependent on this patch.This patch changes"},{"line_number":12,"context_line":"\"Agent_id\" to \"Id\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: 1306381"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1af94dfe_7538d1ef","line":12,"updated":"2016-03-17 19:14:35.000000000","message":"This commit message is formatted improperly.  Please see [1] for an overview of how we like commit messages formatted.  The main problem here is the lack of an initial summary line (recommended length: 50 characters) offset from the description by a blank line.\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"667ec9037ba9d0dfffdad0ae1dcd0cc9580bb339"}],"novaclient/v2/shell.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b19fe411419a02879b029648551ee06903458438","unresolved":false,"context_lines":[{"line_number":3612,"context_line":"def do_agent_list(cs, args):"},{"line_number":3613,"context_line":"    \"\"\"List all builds.\"\"\""},{"line_number":3614,"context_line":"    result \u003d cs.agents.list(args.hypervisor)"},{"line_number":3615,"context_line":"    columns \u003d [\"Id\", \"Hypervisor\", \"OS\", \"Architecture\", \"Version\","},{"line_number":3616,"context_line":"               \u0027Md5hash\u0027, \u0027Url\u0027]"},{"line_number":3617,"context_line":"    utils.print_list(result, columns)"},{"line_number":3618,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_f7e23b2e","line":3615,"range":{"start_line":3615,"start_character":14,"end_line":3615,"end_character":19},"updated":"2016-03-17 13:51:33.000000000","message":"This will not help. Agent object (https://github.com/openstack/python-novaclient/blob/3.3.0/novaclient/v2/agents.py#L23 ) do not have \"id\" property, just \"agent_id\". You can add it like:\n\n    @property\n    def id(self):\n        self.agent_id\n\nand your change will work.\n\nAlso, while we are here, it would be nice to fix __repr__ method of Agent. There is no \"agent\" property, so it would be nice if you change it to id.","commit_id":"667ec9037ba9d0dfffdad0ae1dcd0cc9580bb339"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"645a45e2f238c4139cdc4d9017678e798c133b52","unresolved":false,"context_lines":[{"line_number":3612,"context_line":"def do_agent_list(cs, args):"},{"line_number":3613,"context_line":"    \"\"\"List all builds.\"\"\""},{"line_number":3614,"context_line":"    result \u003d cs.agents.list(args.hypervisor)"},{"line_number":3615,"context_line":"    columns \u003d [\"Id\", \"Hypervisor\", \"OS\", \"Architecture\", \"Version\","},{"line_number":3616,"context_line":"               \u0027Md5hash\u0027, \u0027Url\u0027]"},{"line_number":3617,"context_line":"    utils.print_list(result, columns)"},{"line_number":3618,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_d07a9376","line":3615,"range":{"start_line":3615,"start_character":14,"end_line":3615,"end_character":19},"in_reply_to":"1af94dfe_f7e23b2e","updated":"2016-03-17 19:14:35.000000000","message":"For the record, I observed a proposed nova review that proposed to change the \"agent_id\" attribute of the payload to \"id\", and I believe the proposer is unaware of the requirement to use a microversion, as well as the blueprint process.\n\nI would recommend that you read [2] if you have not already.  Pay particular attention to references regarding microversions and the spec/blueprint process.\n\n[2] http://docs.openstack.org/developer/nova/","commit_id":"667ec9037ba9d0dfffdad0ae1dcd0cc9580bb339"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"dba6d414b7023357fe779ea1561c6f25b1904a32","unresolved":false,"context_lines":[{"line_number":3612,"context_line":"def do_agent_list(cs, args):"},{"line_number":3613,"context_line":"    \"\"\"List all builds.\"\"\""},{"line_number":3614,"context_line":"    result \u003d cs.agents.list(args.hypervisor)"},{"line_number":3615,"context_line":"    for i in result:"},{"line_number":3616,"context_line":"        if \"agent_id\" in i.__dict__:"},{"line_number":3617,"context_line":"            i.__dict__[\"id\"] \u003d i.__dict__.pop(\"agent_id\")"},{"line_number":3618,"context_line":"    columns \u003d [\"ID\", \"Hypervisor\", \"OS\", \"Architecture\", \"Version\","},{"line_number":3619,"context_line":"               \u0027Md5hash\u0027, \u0027Url\u0027]"},{"line_number":3620,"context_line":"    utils.print_list(result, columns)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_90d196d0","line":3617,"range":{"start_line":3615,"start_character":1,"end_line":3617,"end_character":57},"updated":"2016-05-06 14:17:05.000000000","message":"I prefer to not apply such hacks, we have formatters for such actions( https://github.com/openstack/python-novaclient/blob/master/novaclient/utils.py#L164). I can be done something like\n\n    utils.print_list(result, columns, formatters\u003d{\"ID\": lambda o: o.agent_id})","commit_id":"670a99236e8ec360198ac4487464e752dded78e3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"dba6d414b7023357fe779ea1561c6f25b1904a32","unresolved":false,"context_lines":[{"line_number":3640,"context_line":"                              args.md5hash, args.hypervisor)"},{"line_number":3641,"context_line":"    if \"agent_id\" in result._info:"},{"line_number":3642,"context_line":"        result._info[\"id\"] \u003d result._info.pop(\"agent_id\")"},{"line_number":3643,"context_line":"    utils.print_dict(result._info.copy())"},{"line_number":3644,"context_line":""},{"line_number":3645,"context_line":""},{"line_number":3646,"context_line":"@utils.arg(\u0027id\u0027, metavar\u003d\u0027\u003cid\u003e\u0027, help\u003d_(\u0027ID of the agent-build.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_b0749acf","line":3643,"range":{"start_line":3643,"start_character":4,"end_line":3643,"end_character":41},"updated":"2016-05-06 14:17:05.000000000","message":"I think it would be nice to extend print_dict with formatters too.","commit_id":"670a99236e8ec360198ac4487464e752dded78e3"}]}