)]}'
{"id":"openstack%2Fpython-novaclient~29375","triplet_id":"openstack%2Fpython-novaclient~master~Ibd82d8404bdd64e4bca2f8b25756bfaff7b28194","project":"openstack/python-novaclient","branch":"master","topic":"secgroupnew","hashtags":[],"change_id":"Ibd82d8404bdd64e4bca2f8b25756bfaff7b28194","subject":"Cleanup nova subcommands for security groups and rules","status":"MERGED","created":"2013-05-16 14:39:32.000000000","updated":"2013-05-21 07:56:30.000000000","submitted":"2013-05-21 07:56:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4c31671c9fc805d1ebb7d20519996993741826c3","_number":29375,"virtual_id_number":29375,"owner":{"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-05-21 07:56:30.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-05-20 15:51:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"date":"2013-05-20 15:32:27.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"},{"value":2,"date":"2013-05-21 04:29:16.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-05-20 15:28:56.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"date":"2013-05-18 12:18:18.000000000","_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"},{"value":1,"date":"2013-05-21 04:29:16.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-17 21:10:50.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2013-05-20 15:28:56.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-05-21 04:29:16.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2013-05-21 07:56:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e784a6ddd3edbb0361a93df87782da702185828b","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-05-16 15:13:03.000000000","message":"Patch Set 1:\n\nLooks good.  I\u0027d appreciate some test coverage on your sanity checks, though.\n\nThis is associated with a nova change; would you mind including the link to the nova change in the commit message?  I don\u0027t want to let this into novaclient until the corresponding nova change goes in.","accounts_in_message":[],"_revision_number":1},{"id":"4d9b90f162b574c6e3a89fa2a6024c39f054c639","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-16 15:32:09.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/29375/1/check/gate-python-novaclient-pep8/1484 : SUCCESS in 15s\n- http://docs-draft.openstack.org/29375/1/check/gate-python-novaclient-docs/1175/doc/build/html/ : SUCCESS in 1m 06s\n- http://logs.openstack.org/29375/1/check/gate-python-novaclient-python26/1274 : SUCCESS in 1m 02s\n- http://logs.openstack.org/29375/1/check/gate-python-novaclient-python27/1493 : SUCCESS in 46s\n- http://logs.openstack.org/29375/1/check/gate-tempest-devstack-vm-full/16312 : SUCCESS in 45m 22s\n- http://logs.openstack.org/29375/1/check/gate-tempest-devstack-vm-postgres-full/16028 : FAILURE in 52m 14s (non-voting)\n- http://logs.openstack.org/29375/1/check/gate-tempest-devstack-vm-quantum/22834 : SUCCESS in 22m 06s\n- http://logs.openstack.org/29375/1/check/gate-grenade-devstack-vm/3914 : FAILURE in 10m 42s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"18b5b78595df433e86bdb919b8f100ff2d0500e9","author":{"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"},"date":"2013-05-18 12:18:18.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4be789bce080d0951e56afe9352a2b9894e8ea14","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-18 13:09:05.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/29375/2/check/gate-python-novaclient-pep8/1490 : SUCCESS in 12s\n- http://docs-draft.openstack.org/29375/2/check/gate-python-novaclient-docs/1181/doc/build/html/ : SUCCESS in 55s\n- http://logs.openstack.org/29375/2/check/gate-python-novaclient-python26/1280 : SUCCESS in 59s\n- http://logs.openstack.org/29375/2/check/gate-python-novaclient-python27/1499 : SUCCESS in 41s\n- http://logs.openstack.org/29375/2/check/gate-tempest-devstack-vm-full/16680 : SUCCESS in 43m 56s\n- http://logs.openstack.org/29375/2/check/gate-tempest-devstack-vm-postgres-full/16395 : FAILURE in 50m 37s (non-voting)\n- http://logs.openstack.org/29375/2/check/gate-tempest-devstack-vm-quantum/23249 : SUCCESS in 21m 16s\n- http://logs.openstack.org/29375/2/check/gate-grenade-devstack-vm/4256 : FAILURE in 9m 24s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"da611457f4674d1d6e57d550d3f5559754483c95","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-05-20 15:28:56.000000000","message":"Patch Set 2:\n\nDoes this depend on a nova change?","accounts_in_message":[],"_revision_number":2},{"id":"7c77a6b801d2d000f928fc2b81ec0de10fb7ec22","author":{"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"},"date":"2013-05-20 15:32:27.000000000","message":"Patch Set 2:\n\n@Kevin L. Mitchell\n\nHi Kevin,\n\nNo.\n\nThanks.","accounts_in_message":[],"_revision_number":2},{"id":"06e44d7b318e7f954a6f5b6441d69a8f3f1dc5a9","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-05-20 15:51:05.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"102bc68ef506876c18362d042a3d69bf82344959","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2013-05-21 04:29:16.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"1498d6096f2b84e0b97b22daed3659d2afe872af","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-21 04:29:19.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"54ccf701015bc92d835a6f78db4e7d6634519d2d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-21 05:33:35.000000000","message":"Patch Set 2: Fails\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://docs-draft.openstack.org/29375/2/gate/gate-python-novaclient-docs/1209/doc/build/html/ : SUCCESS in 57s\n- http://logs.openstack.org/29375/2/gate/gate-python-novaclient-pep8/1518 : SUCCESS in 28s\n- http://logs.openstack.org/29375/2/gate/gate-python-novaclient-python26/1308 : SUCCESS in 1m 17s\n- http://logs.openstack.org/29375/2/gate/gate-python-novaclient-python27/1527 : SUCCESS in 55s\n- http://logs.openstack.org/29375/2/gate/gate-tempest-devstack-vm-full/17199 : SUCCESS in 49m 40s\n- http://logs.openstack.org/29375/2/gate/gate-tempest-devstack-vm-postgres-full/16909 : FAILURE in 44m 31s (non-voting)\n- http://logs.openstack.org/29375/2/gate/gate-tempest-devstack-vm-quantum/23851 : FAILURE in 27m 47s\n- http://logs.openstack.org/29375/2/gate/gate-grenade-devstack-vm/4746 : FAILURE in 10m 52s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"071c9bdc49d144f47fdc1911767114f59d508f43","author":{"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"},"date":"2013-05-21 06:57:49.000000000","message":"Patch Set 2:\n\nreverify no bug","accounts_in_message":[],"_revision_number":2},{"id":"0e55539220de1e48c5f1055baf908dccc9408568","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-21 06:57:50.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"61ffd70f9ee4e4c8f1ee59adba7739babfc08bd2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-21 07:56:30.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/29375/2/gate/gate-python-novaclient-docs/1217/doc/build/html/ : SUCCESS in 1m 03s\n- http://logs.openstack.org/29375/2/gate/gate-python-novaclient-pep8/1526 : SUCCESS in 26s\n- http://logs.openstack.org/29375/2/gate/gate-python-novaclient-python26/1316 : SUCCESS in 1m 12s\n- http://logs.openstack.org/29375/2/gate/gate-python-novaclient-python27/1535 : SUCCESS in 58s\n- http://logs.openstack.org/29375/2/gate/gate-tempest-devstack-vm-full/17226 : SUCCESS in 49m 56s\n- http://logs.openstack.org/29375/2/gate/gate-tempest-devstack-vm-postgres-full/16936 : FAILURE in 44m 36s (non-voting)\n- http://logs.openstack.org/29375/2/gate/gate-tempest-devstack-vm-quantum/23880 : SUCCESS in 19m 16s\n- http://logs.openstack.org/29375/2/gate/gate-grenade-devstack-vm/4773 : FAILURE in 11m 06s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"564c737ea17b9edf78bb66cfee447ba7682ebe2a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-21 07:56:30.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b1802a59bb275b204bf8306048a466dd16aa546c","revisions":{"2c46eb3d6ba2da03e999ebb9811f566abe564b89":{"kind":"REWORK","_number":1,"created":"2013-05-16 14:39:32.000000000","uploader":{"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"},"ref":"refs/changes/75/29375/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/75/29375/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/75/29375/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/75/29375/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/75/29375/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/75/29375/1"}}},"commit":{"parents":[{"commit":"64e43fde43e478af8dc95ccc0904dfca0d0dbe0c","subject":"Merge \"Cleanup some flavor commands\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/64e43fde43e478af8dc95ccc0904dfca0d0dbe0c"}]}],"author":{"name":"Shane Wang","email":"shane.wang@intel.com","date":"2013-05-16 06:30:22.000000000","tz":480},"committer":{"name":"Shane Wang","email":"shane.wang@intel.com","date":"2013-05-16 14:38:24.000000000","tz":480},"subject":"Cleanup nova subcommands for security groups and rules","message":"Cleanup nova subcommands for security groups and rules\n\nThe Changes include:\n  - Sanity check for from_port, to_port, and IP protocol when adding\n    a security rule\n  - Print one more column \u0027Id\u0027 for security groups\n  - If there are multiple security groups with the same name, the group\n    can\u0027t be deleted unless an ID is specified. However, there is no code\n    to search and delete security group by ID. So, _get_secgroup() will\n    get group by ID if the input is like a UUID. If not found, then get\n    group by name.\n  - Some corresponding changes for help messages.\n  - Test case changes after adding sanity check.\n\nChange-Id: Ibd82d8404bdd64e4bca2f8b25756bfaff7b28194\nSigned-off-by: Shane Wang \u003cshane.wang@intel.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2c46eb3d6ba2da03e999ebb9811f566abe564b89"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2c46eb3d6ba2da03e999ebb9811f566abe564b89"}]},"branch":"refs/heads/master"},"b1802a59bb275b204bf8306048a466dd16aa546c":{"kind":"REWORK","_number":2,"created":"2013-05-18 12:18:18.000000000","uploader":{"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"},"ref":"refs/changes/75/29375/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/75/29375/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/75/29375/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/75/29375/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/75/29375/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/75/29375/2"}}},"commit":{"parents":[{"commit":"64e43fde43e478af8dc95ccc0904dfca0d0dbe0c","subject":"Merge \"Cleanup some flavor commands\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/64e43fde43e478af8dc95ccc0904dfca0d0dbe0c"}]}],"author":{"name":"Shane Wang","email":"shane.wang@intel.com","date":"2013-05-16 06:30:22.000000000","tz":480},"committer":{"name":"Shane Wang","email":"shane.wang@intel.com","date":"2013-05-18 12:16:21.000000000","tz":480},"subject":"Cleanup nova subcommands for security groups and rules","message":"Cleanup nova subcommands for security groups and rules\n\nThe Changes include:\n  - Sanity check for from_port, to_port, and IP protocol when adding\n    a security rule\n  - Print one more column \u0027Id\u0027 for security groups\n  - If there are multiple security groups with the same name, the group\n    can\u0027t be deleted unless an ID is specified. However, there is no code\n    to search and delete security group by ID. So, _get_secgroup() will\n    get group by ID if the input is like a UUID. If not found, then get\n    group by name.\n  - Some corresponding changes for help messages.\n  - Test case changes after adding sanity check.\n\nChange-Id: Ibd82d8404bdd64e4bca2f8b25756bfaff7b28194\nSigned-off-by: Shane Wang \u003cshane.wang@intel.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b1802a59bb275b204bf8306048a466dd16aa546c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b1802a59bb275b204bf8306048a466dd16aa546c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}