)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"5d63c3f9a7f9227a2b17e0a991b9e4a5c47258b2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     abhishek.talwar \u003cabhishek.talwar@tcs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-22 14:36:28 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"flavor postional argument in nova boot help"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The help for boot specifies flavor as a"},{"line_number":10,"context_line":"optional parameter, where as running the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa0719c6_d3b660db","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":16},"updated":"2016-03-22 11:37:26.000000000","message":"s/postional/positional","commit_id":"c6f3c6d6356e379735bd6813ffb70905189964a9"}],"novaclient/v2/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b33525641c7e0bd0f3053688ba645400497af262","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    help\u003d_(\"Name or ID of flavor (see \u0027nova flavor-list\u0027).\"))"},{"line_number":370,"context_line":"@utils.arg("},{"line_number":371,"context_line":"    \u0027--flavor\u0027,"},{"line_number":372,"context_line":"    default\u003d[],"},{"line_number":373,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":374,"context_line":"    help\u003dargparse.SUPPRESS)"},{"line_number":375,"context_line":"@utils.arg("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_97af7e29","line":372,"updated":"2016-03-30 16:29:53.000000000","message":"Why are you changing flavor input to a list?  The original is a single value.  Also, you have not set the action on --flavor to a DeprecatedAction.\n\nI think you\u0027ve probably misunderstood how the example I pointed you to operates.  Perhaps it would help if you read through the documentation of the standard library package \"argparse\", which is what these decorators use under the hood; check out [1] for these options.  Of course, DeprecatedAction is specific to novaclient, but you only need to concern yourself with the added parameters \"real_action\" (don\u0027t set at all for this particular usage) and \"use\".\n\n[1] https://docs.python.org/2/library/argparse.html#argparse.ArgumentParser.add_argument","commit_id":"bbae08152e57a1b66e3460199378922ad585e0fc"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"f5a5350e9b5f38531b9e4eee884c3b44774bac42","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    help\u003d_(\"Name or ID of flavor (see \u0027nova flavor-list\u0027).\"))"},{"line_number":370,"context_line":"@utils.arg("},{"line_number":371,"context_line":"    \u0027--flavor\u0027,"},{"line_number":372,"context_line":"    default\u003d[],"},{"line_number":373,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":374,"context_line":"    help\u003dargparse.SUPPRESS)"},{"line_number":375,"context_line":"@utils.arg("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_3a18d674","line":372,"in_reply_to":"ba0121b8_4d97fd47","updated":"2016-03-31 18:48:56.000000000","message":"Use \"action\u003dshell.DeprecatedAction\" (see line 5044 of this file) and an appropriate \"use\u003d_(…)\" text; I suggest commenting that the option will be removed in 3.6.0 or something like that—definitely not 3.3.0, as that\u0027s already been released.","commit_id":"bbae08152e57a1b66e3460199378922ad585e0fc"},{"author":{"_account_id":12140,"name":"Abhishek Talwar","email":"abhishek.talwar@tcs.com","username":"abhishek.talwar"},"change_message_id":"7e6c14c7c2cc382c7dd16fb64c2ace8eeea02cde","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    help\u003d_(\"Name or ID of flavor (see \u0027nova flavor-list\u0027).\"))"},{"line_number":370,"context_line":"@utils.arg("},{"line_number":371,"context_line":"    \u0027--flavor\u0027,"},{"line_number":372,"context_line":"    default\u003d[],"},{"line_number":373,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":374,"context_line":"    help\u003dargparse.SUPPRESS)"},{"line_number":375,"context_line":"@utils.arg("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_4d97fd47","line":372,"in_reply_to":"ba0121b8_97af7e29","updated":"2016-03-31 07:50:43.000000000","message":"Hi Kevin, \n\nI just checked on the link you referred and corrected the flavor input from a list to a single value only. The command now works fine for flavor as a positional parameter (nova boot --image 1f4c2e62-bdb6-4b9b-9bb8-b6bb0ae966dc 1 test2) but stills fails for the --flavor option as I have not found a way to change the action to the Deprecated one. \n\nThe code now looks like this :\n\n@cliutils.arg(\n    \u0027flavor\u0027,\n    metavar\u003d\u0027\u003cflavor\u003e\u0027,\n    default\u003dargparse.SUPPRESS,\n    help\u003d_(\"Name or ID of flavor (see \u0027nova flavor-list\u0027).\"))\n@cliutils.arg(\n    \u0027--flavor\u0027,\n    action\u003d\u0027append\u0027,\n    help\u003dargparse.SUPPRESS) \n-----------------------------------------------------------\nAlso for the test cases, I will surely add some new test cases that care of all the scenarios.\n\n\nThanks and Regards\nAbhishek Talwar","commit_id":"bbae08152e57a1b66e3460199378922ad585e0fc"}]}
