)]}'
{"id":"openstack%2Fpython-novaclient~296079","triplet_id":"openstack%2Fpython-novaclient~master~Ib6ef0a3e8f32f2724314c166d7de50d591c0e949","project":"openstack/python-novaclient","branch":"master","topic":"bandit_integration","hashtags":[],"change_id":"Ib6ef0a3e8f32f2724314c166d7de50d591c0e949","subject":"Adding tox support for bandit","status":"MERGED","created":"2016-03-22 21:39:58.000000000","updated":"2016-03-25 19:24:53.000000000","submitted":"2016-03-25 19:24:53.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a1663b6e5bf4b58caa6e20d2a8f27bef5d4f9e10","_number":296079,"virtual_id_number":296079,"owner":{"_account_id":17277,"name":"Christopher J Schaefer","email":"cjschaef@us.ibm.com","username":"cjschaef"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-03-25 19:24:53.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-03-22 22:22:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2016-03-25 18:23:11.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2016-03-25 18:23:11.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-22 22:22:35.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-03-25 18:23:11.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2016-03-25 19:24:53.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"219d5d1da9245df4b4a88bf246be5d7c69fef7a9","author":{"_account_id":17277,"name":"Christopher J Schaefer","email":"cjschaef@us.ibm.com","username":"cjschaef"},"date":"2016-03-22 21:39:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0f36d21b0f7c053c9ce29f7d7e4ba2b8407ef26f","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-03-22 22:22:35.000000000","message":"Patch Set 1: Code-Review+2\n\nLooks good to me.  Do you have a sample report for novaclient as it is today?","accounts_in_message":[],"_revision_number":1},{"id":"9c071b48af683c284364334c783c2d07dfb48ff1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-22 22:46:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs http://docs-draft.openstack.org/79/296079/1/check/gate-python-novaclient-docs/dff78fe//doc/build/html/ : SUCCESS in 2m 22s\n- gate-python-novaclient-pep8 http://logs.openstack.org/79/296079/1/check/gate-python-novaclient-pep8/92ab2a5/ : SUCCESS in 2m 39s\n- gate-python-novaclient-python27 http://logs.openstack.org/79/296079/1/check/gate-python-novaclient-python27/92326d0/ : SUCCESS in 2m 52s\n- gate-python-novaclient-python34 http://logs.openstack.org/79/296079/1/check/gate-python-novaclient-python34/16c4f64/ : SUCCESS in 14m 28s\n- gate-python-novaclient-requirements http://logs.openstack.org/79/296079/1/check/gate-python-novaclient-requirements/a45a96b/ : SUCCESS in 1m 59s\n- gate-python-novaclient-pypy http://logs.openstack.org/79/296079/1/check/gate-python-novaclient-pypy/bc392c1/ : SUCCESS in 15m 41s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/79/296079/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/b530648/ : SUCCESS in 59m 34s\n- gate-python-novaclient-releasenotes http://docs-draft.openstack.org/79/296079/1/check/gate-python-novaclient-releasenotes/c0f2b2d//releasenotes/build/html/ : SUCCESS in 1m 56s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/79/296079/1/check/gate-novaclient-dsvm-functional/6cb33c9/ : SUCCESS in 35m 04s","accounts_in_message":[],"_revision_number":1},{"id":"8238e07d8e239bcc23a128872878a244dd0cf96f","author":{"_account_id":17277,"name":"Christopher J Schaefer","email":"cjschaef@us.ibm.com","username":"cjschaef"},"date":"2016-03-23 15:16:57.000000000","message":"Patch Set 1:\n\nHi Kevin,\n\nThe current bandit results (26 hits) can be found here for novaclient:  http://paste.openstack.org/show/491605/\nI have not yet analyzed them however.","accounts_in_message":[],"_revision_number":1},{"id":"6b02cb1ba246d6c9efde5ef9f9ef9f1c4109e1a1","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-03-23 16:39:57.000000000","message":"Patch Set 1:\n\nCool.  Looks like most of the complaints have to do with \u0027pass\u0027 in an \u0027except\u0027 clause.  There are a couple that show up that would be a definite problem in a service, like nova, but shouldn\u0027t be too much of an issue with novaclient—e.g., the \u0027os.system()\u0027 call in do_ssh()…","accounts_in_message":[],"_revision_number":1},{"id":"b442c5d909a2a2006891d8c2ed27b0ee2cb64144","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-03-25 18:18:39.000000000","message":"Patch Set 1:\n\nI don\u0027t really understand why we\u0027d need this in novaclient. I can understand why you\u0027d want it in a service, like nova, to avoid issues that could compromise the host, but it seems less important for a command line shell client.","accounts_in_message":[],"_revision_number":1},{"id":"7566db88566de4d74a7d08b48a3175ba1b908776","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-03-25 18:23:11.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nSince novaclient is more than just a shell, it\u0027s also the python binding API that other services use, like heat and manila, it\u0027s worth having this in here.","accounts_in_message":[],"_revision_number":1},{"id":"2124ec886566a369b0df99e4a2984c5e5f232057","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-25 18:23:17.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"25de1a9ef5a380ee2213ae23cf3b76e60b107bd6","date":"2016-03-25 19:24:53.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"3ed74bd0ad9a00c933706ba23578a2aa2e0b20a8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-25 19:24:53.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs http://docs-draft.openstack.org/79/296079/1/gate/gate-python-novaclient-docs/bb5032e//doc/build/html/ : SUCCESS in 2m 59s\n- gate-python-novaclient-pep8 http://logs.openstack.org/79/296079/1/gate/gate-python-novaclient-pep8/5ce3fbb/ : SUCCESS in 1m 41s\n- gate-python-novaclient-python27 http://logs.openstack.org/79/296079/1/gate/gate-python-novaclient-python27/01bd344/ : SUCCESS in 2m 57s\n- gate-python-novaclient-python34 http://logs.openstack.org/79/296079/1/gate/gate-python-novaclient-python34/c4902aa/ : SUCCESS in 14m 57s\n- gate-python-novaclient-requirements http://logs.openstack.org/79/296079/1/gate/gate-python-novaclient-requirements/f332202/ : SUCCESS in 1m 15s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/79/296079/1/gate/gate-tempest-dsvm-neutron-src-python-novaclient/45696ad/ : SUCCESS in 1h 01m 10s\n- gate-python-novaclient-releasenotes http://docs-draft.openstack.org/79/296079/1/gate/gate-python-novaclient-releasenotes/99585e6//releasenotes/build/html/ : SUCCESS in 1m 56s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/79/296079/1/gate/gate-novaclient-dsvm-functional/eba608c/ : SUCCESS in 38m 54s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c5272b349b62f7707c146bfd0a46b304c86e866a","revisions":{"c5272b349b62f7707c146bfd0a46b304c86e866a":{"kind":"REWORK","_number":1,"created":"2016-03-22 21:39:58.000000000","uploader":{"_account_id":17277,"name":"Christopher J Schaefer","email":"cjschaef@us.ibm.com","username":"cjschaef"},"ref":"refs/changes/79/296079/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/79/296079/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/79/296079/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/79/296079/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/79/296079/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/79/296079/1"}}},"commit":{"parents":[{"commit":"abe6707d26859c08a031d53ca316d31aaff6bc3b","subject":"Merge \"Wrap interface_list by proper resource class\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/abe6707d26859c08a031d53ca316d31aaff6bc3b"}]}],"author":{"name":"Christopher J Schaefer","email":"cjschaef@us.ibm.com","date":"2016-03-22 21:34:51.000000000","tz":-300},"committer":{"name":"Christopher J Schaefer","email":"cjschaef@us.ibm.com","date":"2016-03-22 21:39:11.000000000","tz":-300},"subject":"Adding tox support for bandit","message":"Adding tox support for bandit\n\nBandit is a code linter which is used to help identify potential\nsecurity vulnerabilities. As part of the plan to integrate bandit\ninto each OpenStack project, support for a tox testenv is step one.\nLater, gate tests will also be incorporated.\n\nChange-Id: Ib6ef0a3e8f32f2724314c166d7de50d591c0e949\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c5272b349b62f7707c146bfd0a46b304c86e866a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c5272b349b62f7707c146bfd0a46b304c86e866a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}