)]}'
{"novaclient/base.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"594c47c09dc4607ffb2ff45c9e93002e14fb50e0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        return obj"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def get_home_dir():"},{"line_number":51,"context_line":"    return os.path.expanduser(utils.env(\u0027NOVACLIENT_UUID_CACHE_DIR\u0027,"},{"line_number":52,"context_line":"                                        default\u003d\"~/.novaclient\"))"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_58c06f50","line":50,"updated":"2016-04-26 14:46:31.000000000","message":"I think we should use appdirs instead - https://pypi.python.org/pypi/appdirs (which is what occ uses).\n\nuser_cache_dir will return the right place for a cache without needing to care about env.","commit_id":"f370bed3ae3c02ff195fe880e6db2cbfcaa062f0"}],"novaclient/cache.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"5dc4737a033494774d830dcdd42167e325febf64","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":"import re"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from dogpile.cache import make_region"},{"line_number":20,"context_line":"from oslo_utils import strutils"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from novaclient import base"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_7ad9ae56","line":19,"updated":"2016-03-31 18:58:39.000000000","message":"Import modules rather than objects from modules; I was looking around in this file for a function named \"make_region()\" and wondering what it does.","commit_id":"dfd7bfaa981045525c40574e5fdc7892c6a73539"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"594c47c09dc4607ffb2ff45c9e93002e14fb50e0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    if _cache_enabled is None:"},{"line_number":37,"context_line":"        _cache_enabled \u003d strutils.bool_from_string("},{"line_number":38,"context_line":"            utils.env(\u0027OS_NOVACLIENT_USE_CACHE\u0027, default\u003dTrue))"},{"line_number":39,"context_line":"    return _cache_enabled"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _function_key_generator(namespace, fn, **kw):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_f8d21bff","line":39,"updated":"2016-04-26 14:46:31.000000000","message":"I would rather make it so that there is a \"nova clear-cache\" command and just assume we\u0027re always going to have some caching anyway.","commit_id":"f370bed3ae3c02ff195fe880e6db2cbfcaa062f0"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"594c47c09dc4607ffb2ff45c9e93002e14fb50e0","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                expiration_time\u003dexpiration_time,"},{"line_number":106,"context_line":"                to_str\u003d_to_str,"},{"line_number":107,"context_line":"                namespace\u003dnamespace)(func)"},{"line_number":108,"context_line":"    return wrapper"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_58698ff8","line":108,"updated":"2016-04-26 14:46:31.000000000","message":"I\u0027m having a bit of a hard time here with this. I\u0027d rather our use of the cache is more explicit than decorator based at this point. I\u0027d rather have discover_version be:\n\nif version \u003d cache.get(\u0027version\u0027):\n   return version\n\n...\n\n# find the version\n...\n\ncache.set(\u0027version\u0027, version, ttl\u003d300)\nreturn version","commit_id":"f370bed3ae3c02ff195fe880e6db2cbfcaa062f0"}]}