)]}'
{"id":"openstack%2Fpython-novaclient~300032","triplet_id":"openstack%2Fpython-novaclient~master~I2dd2988cd015d1dfb576fe004cb9461b02b55db3","project":"openstack/python-novaclient","branch":"master","topic":"cache","hashtags":[],"change_id":"I2dd2988cd015d1dfb576fe004cb9461b02b55db3","subject":"[tests] initialize client objects inside setUp","status":"MERGED","created":"2016-03-31 15:32:44.000000000","updated":"2016-04-04 17:30:19.000000000","submitted":"2016-04-04 17:30:19.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e78fd5c069e4750e07a2b3c41163af3108ea0cd9","_number":300032,"virtual_id_number":300032,"owner":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-04-04 17:30:19.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-04-04 16:03:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2016-04-04 11:43:45.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-04-04 16:03:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-04 11:43:45.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2016-04-04 16:03:50.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-04-04 17:30:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a14c0bac1e388660ceb101876ba052550aa883fe","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-03-31 15:32:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"97a56cd2b46ef5f924ebaaf4c06dd6007dcfd08f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-31 16:54:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs http://docs-draft.openstack.org/32/300032/1/check/gate-python-novaclient-docs/fef2a09//doc/build/html/ : SUCCESS in 1m 44s\n- gate-python-novaclient-pep8 http://logs.openstack.org/32/300032/1/check/gate-python-novaclient-pep8/4a776d3/ : SUCCESS in 1m 46s\n- gate-python-novaclient-python27 http://logs.openstack.org/32/300032/1/check/gate-python-novaclient-python27/d080416/ : SUCCESS in 3m 54s\n- gate-python-novaclient-python34 http://logs.openstack.org/32/300032/1/check/gate-python-novaclient-python34/1265ec8/ : SUCCESS in 3m 29s\n- gate-python-novaclient-pypy http://logs.openstack.org/32/300032/1/check/gate-python-novaclient-pypy/bf18e82/ : SUCCESS in 2m 49s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/32/300032/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/f89ba17/ : SUCCESS in 1h 01m 23s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/32/300032/1/check/gate-novaclient-dsvm-functional/33a5994/ : SUCCESS in 42m 47s","accounts_in_message":[],"_revision_number":1},{"id":"4a60bda678103b29b0f80a38bfef61df3faf7286","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-03-31 18:59:52.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"daec598417ff110ba945d46773b3f235694c4e58","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-04-01 17:29:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b025a38767e8aec67607fec3edeae0cfcd67a687","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-04-01 18:18:33.000000000","message":"Patch Set 2:\n\nHmmm…there\u0027s so much duplicated code here that I\u0027m tempted to suggest creating a base test class that already has this defined in its setUp() method.  Is that something we can do?","accounts_in_message":[],"_revision_number":2},{"id":"9e48106ccbdc94996c2c0deca1484e1e8f062457","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-01 18:35:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs http://docs-draft.openstack.org/32/300032/2/check/gate-python-novaclient-docs/bfdfb86//doc/build/html/ : SUCCESS in 3m 18s\n- gate-python-novaclient-pep8 http://logs.openstack.org/32/300032/2/check/gate-python-novaclient-pep8/20d9e36/ : SUCCESS in 1m 31s\n- gate-python-novaclient-python27 http://logs.openstack.org/32/300032/2/check/gate-python-novaclient-python27/5163118/ : SUCCESS in 2m 37s\n- gate-python-novaclient-python34 http://logs.openstack.org/32/300032/2/check/gate-python-novaclient-python34/29c36ae/ : SUCCESS in 3m 13s\n- gate-python-novaclient-pypy http://logs.openstack.org/32/300032/2/check/gate-python-novaclient-pypy/3b741ab/ : SUCCESS in 6m 20s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/32/300032/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/ade421b/ : SUCCESS in 1h 01m 57s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/32/300032/2/check/gate-novaclient-dsvm-functional/f0169c3/ : SUCCESS in 48m 13s","accounts_in_message":[],"_revision_number":2},{"id":"6afb323ebcd973d617910e16a54178edf0981339","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-04-04 11:43:45.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"e16323274e67db9d868e47bc1d5ca2cbb909a2c8","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-04-04 11:53:32.000000000","message":"Patch Set 2:\n\n@Kevin: Basically, the number of duplicated lines will be decreased while merging the next patches in chain. Maybe this patch should be moved to the end, but I want to make test a bit better quickly.","accounts_in_message":[],"_revision_number":2},{"id":"0e1caddf217088d7a93baf56da7ed9c6c5aacf1b","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-04-04 16:03:50.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nOK, if this is part of a chain that includes the refactor I suggested, good.  The new Gerrit interface makes it difficult for me to discern chains of reviews :/","accounts_in_message":[],"_revision_number":2},{"id":"98da2999200f320083884687a229f6bd1f5a769e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-04 16:03:56.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"85b540bd7369fcf8209021c8526bfdba64f2236c","date":"2016-04-04 17:30:19.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"86c087f0519393c67bd269196ac6a5e490c5eb5a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-04 17:30:19.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs http://docs-draft.openstack.org/32/300032/2/gate/gate-python-novaclient-docs/78e2641//doc/build/html/ : SUCCESS in 1m 44s\n- gate-python-novaclient-pep8 http://logs.openstack.org/32/300032/2/gate/gate-python-novaclient-pep8/36c611d/ : SUCCESS in 1m 37s\n- gate-python-novaclient-python27 http://logs.openstack.org/32/300032/2/gate/gate-python-novaclient-python27/a760e8e/ : SUCCESS in 2m 57s\n- gate-python-novaclient-python34 http://logs.openstack.org/32/300032/2/gate/gate-python-novaclient-python34/870ba96/ : SUCCESS in 2m 39s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/32/300032/2/gate/gate-tempest-dsvm-neutron-src-python-novaclient/9df9540/ : SUCCESS in 58m 25s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/32/300032/2/gate/gate-novaclient-dsvm-functional/20b798c/ : SUCCESS in 39m 14s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7d8db71964922197443f85c74ac0e4510e3f58a0","revisions":{"9ac0a35af275fabae4d3500df32ca1743052d13b":{"kind":"REWORK","_number":1,"created":"2016-03-31 15:32:44.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/32/300032/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/32/300032/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/32/300032/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/32/300032/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/32/300032/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/32/300032/1"}}},"commit":{"parents":[{"commit":"263652bbac41db7a0a73c648c948173a6c240ff0","subject":"Add support of caching","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/263652bbac41db7a0a73c648c948173a6c240ff0"}]}],"author":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2016-03-31 15:18:42.000000000","tz":180},"committer":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2016-03-31 15:30:58.000000000","tz":180},"subject":"[tests] initialize client object inside setUp","message":"[tests] initialize client object inside setUp\n\nChange-Id: I2dd2988cd015d1dfb576fe004cb9461b02b55db3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9ac0a35af275fabae4d3500df32ca1743052d13b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9ac0a35af275fabae4d3500df32ca1743052d13b"}]},"branch":"refs/heads/master"},"7d8db71964922197443f85c74ac0e4510e3f58a0":{"kind":"REWORK","_number":2,"created":"2016-04-01 17:29:16.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/32/300032/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/32/300032/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/32/300032/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/32/300032/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/32/300032/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/32/300032/2"}}},"commit":{"parents":[{"commit":"8c204ac1a27f7b645e151d67ee38a4c18dd2201b","subject":"Merge \"Handle error response for webob\u003e\u003d1.6.0\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8c204ac1a27f7b645e151d67ee38a4c18dd2201b"}]}],"author":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2016-03-31 15:18:42.000000000","tz":180},"committer":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2016-04-01 16:23:33.000000000","tz":180},"subject":"[tests] initialize client objects inside setUp","message":"[tests] initialize client objects inside setUp\n\nAll tests from contrib dir inizialize fakeclient at module level.\nIt is bad practice and we should do preparatory steps at setUp method.\n\nChange-Id: I2dd2988cd015d1dfb576fe004cb9461b02b55db3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7d8db71964922197443f85c74ac0e4510e3f58a0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7d8db71964922197443f85c74ac0e4510e3f58a0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}