)]}'
{"id":"openstack%2Fpython-novaclient~30467","triplet_id":"openstack%2Fpython-novaclient~master~I9cfbc68761f158754aa4b339238d29cc587c91e1","project":"openstack/python-novaclient","branch":"master","topic":"secgroup-tests","hashtags":[],"change_id":"I9cfbc68761f158754aa4b339238d29cc587c91e1","subject":"100% test coverage for security groups and rules","status":"MERGED","created":"2013-05-24 17:23:32.000000000","updated":"2013-05-29 18:50:50.000000000","submitted":"2013-05-29 18:50:50.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e5a58cea6af884dbb228a3a2692ef70de7129f28","_number":30467,"virtual_id_number":30467,"owner":{"_account_id":7655,"name":"Emanuele Rocca","email":"ema@linux.it","username":"ema"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-05-29 18:50:50.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7655,"name":"Emanuele Rocca","email":"ema@linux.it","username":"ema"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7655,"name":"Emanuele Rocca","email":"ema@linux.it","username":"ema"},{"value":2,"date":"2013-05-29 15:46:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2013-05-29 17:59:31.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-05-29 08:34:32.000000000","_account_id":7655,"name":"Emanuele Rocca","email":"ema@linux.it","username":"ema"},{"value":0,"date":"2013-05-29 15:46:33.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2013-05-29 17:59:31.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7655,"name":"Emanuele Rocca","email":"ema@linux.it","username":"ema"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7655,"name":"Emanuele Rocca","email":"ema@linux.it","username":"ema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-29 15:46:33.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-05-29 17:59:31.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-05-29 18:50:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"fa092cbd36468a530910a8f3bce41a7709ecf134","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-24 18:09:08.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/30467/1/check/gate-python-novaclient-pep8/1551 : SUCCESS in 22s\n- http://docs-draft.openstack.org/30467/1/check/gate-python-novaclient-docs/1242/doc/build/html/ : SUCCESS in 51s\n- http://logs.openstack.org/30467/1/check/gate-python-novaclient-python26/1341 : SUCCESS in 1m 18s\n- http://logs.openstack.org/30467/1/check/gate-python-novaclient-python27/1560 : SUCCESS in 1m 03s\n- http://logs.openstack.org/30467/1/check/gate-tempest-devstack-vm-full/18391 : SUCCESS in 43m 48s\n- http://logs.openstack.org/30467/1/check/gate-tempest-devstack-vm-postgres-full/18101 : FAILURE in 45m 23s (non-voting)\n- http://logs.openstack.org/30467/1/check/gate-tempest-devstack-vm-quantum/25165 : SUCCESS in 20m 37s\n- http://logs.openstack.org/30467/1/check/gate-grenade-devstack-vm/5845 : SUCCESS in 14m 44s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"d62d91345827a44b450ca826a8ebd310b371ea71","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-05-28 18:38:50.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"fa7b621c7b342b0cf2516d80d4e460c5404bdd26","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-05-28 23:58:33.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"3c3164f4c73664d506097efc212d941edc5803a0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-28 23:58:34.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"b1eed267f71b8ce8fbd0813c9e0001494a52f55c","date":"2013-05-29 00:48:43.000000000","message":"Your change could not be merged due to a path conflict.\n\nPlease merge (or rebase) the change locally and upload the resolution for review.","accounts_in_message":[],"_revision_number":1},{"id":"9b0d68aea6300cc3c5c808f5fb3ed96670705bb0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-29 00:48:43.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/30467/1/gate/gate-python-novaclient-docs/1260/doc/build/html/ : SUCCESS in 1m 10s\n- http://logs.openstack.org/30467/1/gate/gate-python-novaclient-pep8/1569 : SUCCESS in 57s\n- http://logs.openstack.org/30467/1/gate/gate-python-novaclient-python26/1359 : SUCCESS in 1m 23s\n- http://logs.openstack.org/30467/1/gate/gate-python-novaclient-python27/1578 : SUCCESS in 1m 15s\n- http://logs.openstack.org/30467/1/gate/gate-tempest-devstack-vm-full/18994 : SUCCESS in 49m 58s\n- http://logs.openstack.org/30467/1/gate/gate-tempest-devstack-vm-postgres-full/18702 : FAILURE in 45m 02s (non-voting)\n- http://logs.openstack.org/30467/1/gate/gate-tempest-devstack-vm-quantum/25845 : SUCCESS in 21m 06s\n- http://logs.openstack.org/30467/1/gate/gate-grenade-devstack-vm/6422 : SUCCESS in 14m 52s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"2cbae6cc1a46fa0bf15ca78af8d2e8813fd0bf5b","author":{"_account_id":7655,"name":"Emanuele Rocca","email":"ema@linux.it","username":"ema"},"date":"2013-05-29 08:34:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"070758bdbbb8df71acbd2b85206323488a155086","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-29 09:25:39.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/30467/2/check/gate-python-novaclient-pep8/1572 : SUCCESS in 41s\n- http://docs-draft.openstack.org/30467/2/check/gate-python-novaclient-docs/1263/doc/build/html/ : SUCCESS in 54s\n- http://logs.openstack.org/30467/2/check/gate-python-novaclient-python26/1362 : SUCCESS in 1m 17s\n- http://logs.openstack.org/30467/2/check/gate-python-novaclient-python27/1581 : SUCCESS in 59s\n- http://logs.openstack.org/30467/2/check/gate-tempest-devstack-vm-full/19043 : SUCCESS in 49m 32s\n- http://logs.openstack.org/30467/2/check/gate-tempest-devstack-vm-postgres-full/18751 : FAILURE in 50m 43s (non-voting)\n- http://logs.openstack.org/30467/2/check/gate-tempest-devstack-vm-quantum/25904 : SUCCESS in 20m 21s\n- http://logs.openstack.org/30467/2/check/gate-grenade-devstack-vm/6468 : SUCCESS in 16m 10s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"a0f899728c96746273dd7ce877b7cc60b61f65c1","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-05-29 15:46:33.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"6d19f665ae8f69d2d23e3aa95a5c195f07edb225","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-05-29 17:59:31.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"50d300c293e179a34fbcd1a862734b9089959fc2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-29 17:59:33.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"2dde9cde13fa6ad5b49a40692cf6d129704d5a19","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-29 18:50:50.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"562c316ce615eaf4cf2e55ac550d60b1baada73b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-29 18:50:50.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/30467/2/gate/gate-python-novaclient-docs/1270/doc/build/html/ : SUCCESS in 43s\n- http://logs.openstack.org/30467/2/gate/gate-python-novaclient-pep8/1579 : SUCCESS in 37s\n- http://logs.openstack.org/30467/2/gate/gate-python-novaclient-python26/1369 : SUCCESS in 1m 11s\n- http://logs.openstack.org/30467/2/gate/gate-python-novaclient-python27/1588 : SUCCESS in 52s\n- http://logs.openstack.org/30467/2/gate/gate-tempest-devstack-vm-full/19210 : SUCCESS in 41m 59s\n- http://logs.openstack.org/30467/2/gate/gate-tempest-devstack-vm-postgres-full/18918 : FAILURE in 51m 08s (non-voting)\n- http://logs.openstack.org/30467/2/gate/gate-tempest-devstack-vm-quantum/26088 : SUCCESS in 18m 40s\n- http://logs.openstack.org/30467/2/gate/gate-grenade-devstack-vm/6632 : SUCCESS in 14m 43s (non-voting)\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ff85bd4025db92d318e19bd4d933848a344d5ab4","revisions":{"b54c2e81ee0b862aefb6ac383d7027d70c000e84":{"kind":"REWORK","_number":1,"created":"2013-05-24 17:23:32.000000000","uploader":{"_account_id":7655,"name":"Emanuele Rocca","email":"ema@linux.it","username":"ema"},"ref":"refs/changes/67/30467/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/67/30467/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/30467/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/30467/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/30467/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/67/30467/1"}}},"commit":{"parents":[{"commit":"c07f05ed33b382d14def6d4cef8fd194ddfc9f49","subject":"Merge \"Only add logging handlers if there currently aren\u0027t any\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c07f05ed33b382d14def6d4cef8fd194ddfc9f49"}]}],"author":{"name":"Emanuele Rocca","email":"ema@linux.it","date":"2013-05-24 17:04:37.000000000","tz":120},"committer":{"name":"Emanuele Rocca","email":"ema@linux.it","date":"2013-05-24 17:04:37.000000000","tz":120},"subject":"100% test coverage for security groups and rules","message":"100% test coverage for security groups and rules\n\nThis patch achieves full test coverage for security_group and\nsecurity_group_rules by:\n\n- Fixing the arguments used in test_invalid_parameters_create\n- Testing the __str__ and delete methods of SecurityGroupRule\n- Adding a test for the ___str__ method of SecurityGroup\n\nChange-Id: I9cfbc68761f158754aa4b339238d29cc587c91e1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b54c2e81ee0b862aefb6ac383d7027d70c000e84"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b54c2e81ee0b862aefb6ac383d7027d70c000e84"}]},"branch":"refs/heads/master"},"ff85bd4025db92d318e19bd4d933848a344d5ab4":{"kind":"REWORK","_number":2,"created":"2013-05-29 08:34:32.000000000","uploader":{"_account_id":7655,"name":"Emanuele Rocca","email":"ema@linux.it","username":"ema"},"ref":"refs/changes/67/30467/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/67/30467/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/30467/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/30467/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/30467/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/67/30467/2"}}},"commit":{"parents":[{"commit":"c34c371e963f04f44339c07dfcd40b7814e3217f","subject":"Move tests into the novaclient package.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c34c371e963f04f44339c07dfcd40b7814e3217f"}]}],"author":{"name":"Emanuele Rocca","email":"ema@linux.it","date":"2013-05-24 17:04:37.000000000","tz":120},"committer":{"name":"Emanuele Rocca","email":"ema@linux.it","date":"2013-05-29 08:18:01.000000000","tz":120},"subject":"100% test coverage for security groups and rules","message":"100% test coverage for security groups and rules\n\nThis patch achieves full test coverage for security_group and\nsecurity_group_rules by:\n\n- Fixing the arguments used in test_invalid_parameters_create\n- Testing the __str__ and delete methods of SecurityGroupRule\n- Adding a test for the ___str__ method of SecurityGroup\n\nChange-Id: I9cfbc68761f158754aa4b339238d29cc587c91e1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ff85bd4025db92d318e19bd4d933848a344d5ab4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ff85bd4025db92d318e19bd4d933848a344d5ab4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}