)]}'
{"id":"openstack%2Fpython-novaclient~310341","triplet_id":"openstack%2Fpython-novaclient~master~I7bc8a76fd390a7dd30eecbb5c7e641b6ccfb40c0","project":"openstack/python-novaclient","branch":"master","topic":"fix-private-func-name","hashtags":[],"change_id":"I7bc8a76fd390a7dd30eecbb5c7e641b6ccfb40c0","subject":"[Trivial] change some functions in novaclient/utils.py to public","status":"MERGED","created":"2016-04-27 04:15:53.000000000","updated":"2016-04-28 13:31:40.000000000","submitted":"2016-04-28 13:31:40.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0325717deb418e2b376246369bcc74e704510af8","_number":310341,"virtual_id_number":310341,"owner":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-04-28 13:31:40.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-04-27 05:55:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2016-04-28 12:31:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2016-04-28 12:31:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-27 05:55:58.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-04-28 12:31:49.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2016-04-28 13:31:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"eebb71b78a0a18705e1e8ae70f31810463eece2b","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-27 04:15:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4f584f72b42c371becacebf71cc64ca47c6ec523","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-27 05:11:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs http://docs-draft.openstack.org/41/310341/1/check/gate-python-novaclient-docs/fdd6138//doc/build/html/ : SUCCESS in 1m 31s\n- gate-python-novaclient-pep8 http://logs.openstack.org/41/310341/1/check/gate-python-novaclient-pep8/fdd0abd/ : SUCCESS in 2m 01s\n- gate-python-novaclient-python27 http://logs.openstack.org/41/310341/1/check/gate-python-novaclient-python27/03c0d8a/ : SUCCESS in 2m 27s\n- gate-python-novaclient-python34 http://logs.openstack.org/41/310341/1/check/gate-python-novaclient-python34/0098301/ : SUCCESS in 3m 10s\n- gate-python-novaclient-pypy http://logs.openstack.org/41/310341/1/check/gate-python-novaclient-pypy/36d5830/ : SUCCESS in 3m 19s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/41/310341/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/6e92d44/ : SUCCESS in 55m 05s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/41/310341/1/check/gate-novaclient-dsvm-functional/6b3e595/ : SUCCESS in 35m 55s","accounts_in_message":[],"_revision_number":1},{"id":"50d087f089d305d2039fc3c8ce9742389faeaeb0","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-04-27 05:55:58.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nOne note on the assumption in the commit message, but otherwise this seems appropriate to me; novaclient.utils is not something novaclient consumers would typically explicitly import, so dropping the \u0027_\u0027 prefix to save a little typing elsewhere makes sense to me.","accounts_in_message":[],"_revision_number":1},{"id":"9881f123bc50766ac4ac17eb2f01ee20dc9a1493","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-04-28 12:31:49.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"e11b2c47c19219ee1b0f0a845aa7b783d573801b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-28 12:31:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"787b859e1eae71bf5e54028045bd1b113f3a757f","date":"2016-04-28 13:31:40.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"cc4f7fba2c3795ed52d800c2ccba2356e77d6249","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-28 13:31:40.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs http://docs-draft.openstack.org/41/310341/1/gate/gate-python-novaclient-docs/b3560f1//doc/build/html/ : SUCCESS in 1m 32s\n- gate-python-novaclient-pep8 http://logs.openstack.org/41/310341/1/gate/gate-python-novaclient-pep8/46ede82/ : SUCCESS in 2m 11s\n- gate-python-novaclient-python27 http://logs.openstack.org/41/310341/1/gate/gate-python-novaclient-python27/9e8f952/ : SUCCESS in 2m 11s\n- gate-python-novaclient-python34 http://logs.openstack.org/41/310341/1/gate/gate-python-novaclient-python34/fa8678b/ : SUCCESS in 4m 26s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/41/310341/1/gate/gate-tempest-dsvm-neutron-src-python-novaclient/a3a6dc7/ : SUCCESS in 58m 29s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/41/310341/1/gate/gate-novaclient-dsvm-functional/89d7338/ : SUCCESS in 36m 28s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c22cbb6fac2230c3111ca60748edcc1591e26c13","revisions":{"c22cbb6fac2230c3111ca60748edcc1591e26c13":{"kind":"REWORK","_number":1,"created":"2016-04-27 04:15:53.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/41/310341/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/41/310341/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/310341/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/310341/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/310341/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/41/310341/1"}}},"commit":{"parents":[{"commit":"3bed5446d7b15901ba8956e5331bcc2054fdd3a9","subject":"Merge \"Use common find_server from v2.shell\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3bed5446d7b15901ba8956e5331bcc2054fdd3a9"}]}],"author":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-04-27 12:13:45.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-04-27 12:13:45.000000000","tz":480},"subject":"[Trivial] change some functions in novaclient/utils.py to public","message":"[Trivial] change some functions in novaclient/utils.py to public\n\nThere are some functions in novaclient/utils.py which have name with\nprefix `_`, in Python, this means it is a private function which\nshould be only used in its own module. However, these functions are\nused in other modules such as novaclient/v2/shell.py.\n\nThis patch removes the prefix _ for these functions.\n\nChange-Id: I7bc8a76fd390a7dd30eecbb5c7e641b6ccfb40c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c22cbb6fac2230c3111ca60748edcc1591e26c13"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c22cbb6fac2230c3111ca60748edcc1591e26c13"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
