)]}'
{"novaclient/v2/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"aeea15435e94209672d9cccee923a94ceb1cc28c","unresolved":false,"context_lines":[{"line_number":879,"context_line":"@utils.arg("},{"line_number":880,"context_line":"    \u0027--tenant\u0027, metavar\u003d\u0027\u003ctenant_id\u003e\u0027,"},{"line_number":881,"context_line":"    action\u003dshell.DeprecatedAction,"},{"line_number":882,"context_line":"    help\u003d_(\u0027(Deprecated) This option is not supported and will be removed in \u0027"},{"line_number":883,"context_line":"           \u0027version 5.0.0.\u0027))"},{"line_number":884,"context_line":"def do_flavor_access_list(cs, args):"},{"line_number":885,"context_line":"    \"\"\"Print access information about the given flavor.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_1f27e1b6","line":882,"range":{"start_line":882,"start_character":12,"end_line":882,"end_character":24},"updated":"2016-05-16 19:26:58.000000000","message":"This text is already added at the end of the help text by DeprecatedAction.  Given that you\u0027re not using the \u0027use\u0027 option, the help text would look like this, as written:\n\n    (Deprecated) This option is not supported and will be\n    removed in version 5.0.0. (Deprecated)\n\nAdditionally, if the option were to be used, the following deprecation warning would be issued:\n\n    WARNING: Option \"--tenant\" is deprecated\n\nBTW, since we\u0027re not referencing \u0027args.tenant\u0027 anymore, I\u0027d suggest setting \"real_action\u003d\u0027nothing\u0027\".  We could also use the \u0027use\u0027 option to indicate the deprecation.  With all my suggestions in place, this would be written like so:\n\n    @utils.arg(\n        \u0027--tenant\u0027, metavar\u003d\u0027\u003ctenant_id\u003e\u0027,\n        action\u003dshell.DeprecatedAction,\n        real_action\u003d\u0027nothing\u0027,\n        help\u003d_(\u0027Filter results by tenant ID.\u0027),\n        use\u003d_(\u0027this option is not supported, and will be \u0027\n              \u0027removed in version 5.0.0.\u0027))\n\nWith this, the help text would be:\n\n    Filter results by tenant ID. (Deprecated; this option\n    is not supported, and will be removed in version 5.0.0.)\n\nAnd the deprecation warning would be:\n\n    WARNING: Option \"--tenant\" is deprecated; this option\n    is not supported, and will be removed in version 5.0.0.\n\nI think that result looks a little better.","commit_id":"f5c80ec9021bd2a067a8b64b453ea1214bac05dd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b98dbe5fb90f25e3fe29931c09a25c3efa1d2e3f","unresolved":false,"context_lines":[{"line_number":879,"context_line":"@utils.arg("},{"line_number":880,"context_line":"    \u0027--tenant\u0027, metavar\u003d\u0027\u003ctenant_id\u003e\u0027,"},{"line_number":881,"context_line":"    action\u003dshell.DeprecatedAction,"},{"line_number":882,"context_line":"    help\u003d_(\u0027(Deprecated) This option is not supported and will be removed in \u0027"},{"line_number":883,"context_line":"           \u0027version 5.0.0.\u0027))"},{"line_number":884,"context_line":"def do_flavor_access_list(cs, args):"},{"line_number":885,"context_line":"    \"\"\"Print access information about the given flavor.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_07243a0b","line":882,"range":{"start_line":882,"start_character":12,"end_line":882,"end_character":24},"in_reply_to":"dab17558_1f27e1b6","updated":"2016-05-18 18:08:58.000000000","message":"OK, thanks, I\u0027ll go with that. I\u0027m not sure we really need:\n\nhelp\u003d_(\u0027Filter results by tenant ID.\u0027),\n\nSince it\u0027s not used at all, so having the help and then saying it\u0027s not supported is kind of confusing, but whatever, I\u0027ll copy yours since you tested it. I honestly didn\u0027t have the time to pull this down and test it for real in devstack.","commit_id":"f5c80ec9021bd2a067a8b64b453ea1214bac05dd"}]}