)]}'
{"novaclient/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"8cdfdecf56969af3dbfcb6282629af59828fdf0b","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        #                thinking usage-list --end is ambiguous; but it"},{"line_number":624,"context_line":"        #                works fine with only --endpoint-type present"},{"line_number":625,"context_line":"        #                Go figure."},{"line_number":626,"context_line":"        if \u0027--endpoint_type\u0027 in argv:"},{"line_number":627,"context_line":"            spot \u003d argv.index(\u0027--endpoint_type\u0027)"},{"line_number":628,"context_line":"            argv[spot] \u003d \u0027--endpoint-type\u0027"},{"line_number":629,"context_line":"            # NOTE(Vek): Not emitting a warning here, as that will"}],"source_content_type":"text/x-python","patch_set":10,"id":"bab6814e_594b93c9","line":626,"updated":"2016-05-19 14:54:06.000000000","message":"--endpoint_type is also deprecated, as this code essentially just translates it to --endpoint-type, which you removed above.","commit_id":"946dcf10667dcb9ca4671f88a2734bbc315ae518"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"038c904eefee126b9378b2a29691597db16118db","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        #                thinking usage-list --end is ambiguous; but it"},{"line_number":624,"context_line":"        #                works fine with only --endpoint-type present"},{"line_number":625,"context_line":"        #                Go figure."},{"line_number":626,"context_line":"        if \u0027--endpoint_type\u0027 in argv:"},{"line_number":627,"context_line":"            spot \u003d argv.index(\u0027--endpoint_type\u0027)"},{"line_number":628,"context_line":"            argv[spot] \u003d \u0027--endpoint-type\u0027"},{"line_number":629,"context_line":"            # NOTE(Vek): Not emitting a warning here, as that will"}],"source_content_type":"text/x-python","patch_set":10,"id":"bab6814e_21bf4aab","line":626,"in_reply_to":"bab6814e_594b93c9","updated":"2016-05-26 07:58:59.000000000","message":"Done","commit_id":"946dcf10667dcb9ca4671f88a2734bbc315ae518"}],"novaclient/tests/functional/test_auth.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"aaaf6174e4ab8e4712e08eeee040206ce6a4d6f5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        url \u003d parse.urlparse(self.cli_clients.uri)"},{"line_number":22,"context_line":"        url \u003d parse.urlunparse("},{"line_number":23,"context_line":"            (url.scheme, url.netloc,"},{"line_number":24,"context_line":"             \u0027/identity/v%s\u0027 % identity_api_version,"},{"line_number":25,"context_line":"             url.params, url.query, url.fragment))"},{"line_number":26,"context_line":"        flags \u003d (\u0027--os-username %s --os-tenant-name %s --os-password %s \u0027"},{"line_number":27,"context_line":"                 \u0027--os-auth-url %s --os-endpoint-type publicURL\u0027 % ("}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_cd4ada82","line":24,"updated":"2016-05-26 15:05:06.000000000","message":"This doesn\u0027t seem related; can you go into a little more depth about why you added this?","commit_id":"57349b83cc408e2e12ead61f5917610475c0b7b9"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a8d894429f709fdd6ebea7f4551bfe478d05e3dd","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        url \u003d parse.urlparse(self.cli_clients.uri)"},{"line_number":22,"context_line":"        url \u003d parse.urlunparse("},{"line_number":23,"context_line":"            (url.scheme, url.netloc,"},{"line_number":24,"context_line":"             \u0027/identity/v%s\u0027 % identity_api_version,"},{"line_number":25,"context_line":"             url.params, url.query, url.fragment))"},{"line_number":26,"context_line":"        flags \u003d (\u0027--os-username %s --os-tenant-name %s --os-password %s \u0027"},{"line_number":27,"context_line":"                 \u0027--os-auth-url %s --os-endpoint-type publicURL\u0027 % ("}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_ec934ba1","line":24,"in_reply_to":"bab6814e_b1cfec7d","updated":"2016-05-26 22:41:36.000000000","message":"So, in other words, this isn\u0027t related to this review at all.  That really needs to be a separate review…","commit_id":"57349b83cc408e2e12ead61f5917610475c0b7b9"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"3fd3d266e6c323123baeac22b104c2735c812c7e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        url \u003d parse.urlparse(self.cli_clients.uri)"},{"line_number":22,"context_line":"        url \u003d parse.urlunparse("},{"line_number":23,"context_line":"            (url.scheme, url.netloc,"},{"line_number":24,"context_line":"             \u0027/identity/v%s\u0027 % identity_api_version,"},{"line_number":25,"context_line":"             url.params, url.query, url.fragment))"},{"line_number":26,"context_line":"        flags \u003d (\u0027--os-username %s --os-tenant-name %s --os-password %s \u0027"},{"line_number":27,"context_line":"                 \u0027--os-auth-url %s --os-endpoint-type publicURL\u0027 % ("}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_b1cfec7d","line":24,"in_reply_to":"bab6814e_cd4ada82","updated":"2016-05-26 15:44:27.000000000","message":"sure, I will update in the next patchset if needed, it is due to: https://review.openstack.org/#/c/193894/ please check the test log of the previous patchset, also do you have any suggestions? And it seems the tempest.lib is installed as a package during testing, and the test I made in tempest is in master so it seems not working, I have already added it to dependency, do you have any suggestion?","commit_id":"57349b83cc408e2e12ead61f5917610475c0b7b9"}],"releasenotes/notes/remove-deprecated-option-in-3.3.0-82a413157838570d.yaml":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"154160ed460b0b5570dfa7f7fa5c9b453e80464d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The following deprecated options have been removed:"},{"line_number":4,"context_line":"  create instances: ``--num-instances``, ``--key_name``,"},{"line_number":5,"context_line":"  ``--user_data``, ``--availability_zone``, ``--security_groups``,"},{"line_number":6,"context_line":"  ``--block_device_mapping``;"},{"line_number":7,"context_line":"  list servers: ``--reservation_id``, ``--instance_name``,"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_f306231f","line":4,"updated":"2016-05-18 16:05:40.000000000","message":"A lot of these options were deprecated in favour of other options. Could you mention them? It should be really helpful. Something like:\n\n  \"--num-instances\" was removed in favour of \"--min-count\" and \"--max-count","commit_id":"be7666eb89e6681507bd14cc82719918f414d580"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"516624e4b0a75ac9169938521e9b14e5833ea17a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The following deprecated options have been removed:"},{"line_number":4,"context_line":"  create instances: ``--num-instances``, ``--key_name``,"},{"line_number":5,"context_line":"  ``--user_data``, ``--availability_zone``, ``--security_groups``,"},{"line_number":6,"context_line":"  ``--block_device_mapping``;"},{"line_number":7,"context_line":"  list servers: ``--reservation_id``, ``--instance_name``,"},{"line_number":8,"context_line":"  ``--all_tenants``;"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_07c9e178","line":5,"updated":"2016-05-18 16:02:08.000000000","message":"This makes this invalid YAML, which is why you have the parse error.","commit_id":"be7666eb89e6681507bd14cc82719918f414d580"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"8cdfdecf56969af3dbfcb6282629af59828fdf0b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"update:"},{"line_number":3,"context_line":"   - The following deprecated options have been removed:"},{"line_number":4,"context_line":"     - create instances:"},{"line_number":5,"context_line":"       - --num-instance"},{"line_number":6,"context_line":"       - --key_name"},{"line_number":7,"context_line":"       - --user_data"},{"line_number":8,"context_line":"       - --availability_zone"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bab6814e_b9d55fba","line":5,"updated":"2016-05-19 14:54:06.000000000","message":"I have to agree with Andrey; the release note should indicate what, if anything, replaced the removed options.","commit_id":"946dcf10667dcb9ca4671f88a2734bbc315ae518"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b2d9c0886524b78c27899576043b13e8ec329db3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"update:"},{"line_number":3,"context_line":"   - The following deprecated options have been removed:"},{"line_number":4,"context_line":"     - create instances:"},{"line_number":5,"context_line":"       - --num-instance replaced by --min-count and --max-count"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"df140735_eb12c261","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":6},"updated":"2017-06-05 17:16:48.000000000","message":"There is no \u0027update\u0027 section in reno:\n\nhttps://docs.openstack.org/developer/reno/usage.html#editing-a-release-note\n\nAnd the bullet list needs to be in rst format so needs to use - |.","commit_id":"6f8667990cdb3cd662d51be2403cca5859559f04"}]}