)]}'
{"novaclient/v2/contrib/host_evacuate.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a3cc6543c6acd6ab7babd909ab6835658ad0e616","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"from novaclient import api_versions"},{"line_number":16,"context_line":"from novaclient import base"},{"line_number":17,"context_line":"from novaclient.i18n import _"},{"line_number":18,"context_line":"from novaclient import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_92fea603","line":15,"updated":"2016-05-24 15:33:41.000000000","message":"femtonit: please preserve the blank line separating the license header from the imports.","commit_id":"f5e7556f93f3313843014401447d76329ec25412"},{"author":{"_account_id":17898,"name":"Jinquan Ni","email":"ni.jinquan@zte.com.cn","username":"jinquanni"},"change_message_id":"2b3300b41865b46c32bc27d31391d9c6d3e6476f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    success \u003d True"},{"line_number":28,"context_line":"    error_message \u003d \"\""},{"line_number":29,"context_line":"    try:"},{"line_number":30,"context_line":"        on_shared_storage \u003d getattr(args, \u0027on_shared_storage\u0027, None)"},{"line_number":31,"context_line":"        if api_versions.APIVersion(\"2.14\") \u003c\u003d cs.api_version:"},{"line_number":32,"context_line":"            # if microversion \u003e\u003d 2.14"},{"line_number":33,"context_line":"            cs.servers.evacuate(server\u003dserver[\u0027uuid\u0027], host\u003dargs.target_host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_e8be1063","line":30,"range":{"start_line":30,"start_character":63,"end_line":30,"end_character":68},"updated":"2016-05-25 02:15:39.000000000","message":"It\u0027s look good at me, but if s/None/false will be better consider that the default value of --on_shared_storage is False in  microversion 2.0 - 2.13.","commit_id":"fc90f825f478ac20762c30ec2c84d538acb3ea84"},{"author":{"_account_id":8716,"name":"Sampath Priyankara","email":"sam47priya@gmail.com","username":"sampath"},"change_message_id":"7632218dff2fe7b7f6f670dc2dfa86737840e1ca","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    success \u003d True"},{"line_number":28,"context_line":"    error_message \u003d \"\""},{"line_number":29,"context_line":"    try:"},{"line_number":30,"context_line":"        on_shared_storage \u003d getattr(args, \u0027on_shared_storage\u0027, None)"},{"line_number":31,"context_line":"        if api_versions.APIVersion(\"2.14\") \u003c\u003d cs.api_version:"},{"line_number":32,"context_line":"            # if microversion \u003e\u003d 2.14"},{"line_number":33,"context_line":"            cs.servers.evacuate(server\u003dserver[\u0027uuid\u0027], host\u003dargs.target_host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_b4729d0f","line":30,"range":{"start_line":30,"start_character":63,"end_line":30,"end_character":68},"in_reply_to":"bab6814e_3ed4cebb","updated":"2016-05-25 04:09:32.000000000","message":"Thanks for the comments. I will leave this as None.","commit_id":"fc90f825f478ac20762c30ec2c84d538acb3ea84"},{"author":{"_account_id":17898,"name":"Jinquan Ni","email":"ni.jinquan@zte.com.cn","username":"jinquanni"},"change_message_id":"0cea3601f9fb451ad8f2450f52d84884db4d8681","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    success \u003d True"},{"line_number":28,"context_line":"    error_message \u003d \"\""},{"line_number":29,"context_line":"    try:"},{"line_number":30,"context_line":"        on_shared_storage \u003d getattr(args, \u0027on_shared_storage\u0027, None)"},{"line_number":31,"context_line":"        if api_versions.APIVersion(\"2.14\") \u003c\u003d cs.api_version:"},{"line_number":32,"context_line":"            # if microversion \u003e\u003d 2.14"},{"line_number":33,"context_line":"            cs.servers.evacuate(server\u003dserver[\u0027uuid\u0027], host\u003dargs.target_host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_3ed4cebb","line":30,"range":{"start_line":30,"start_character":63,"end_line":30,"end_character":68},"in_reply_to":"bab6814e_5eb432f1","updated":"2016-05-25 03:14:36.000000000","message":"Oh, i make a mistake.The \u0027on_shared_storage\u0027 always has value in  microversion 2.0 - 2.13. Sorry for -1. I remove it now！","commit_id":"fc90f825f478ac20762c30ec2c84d538acb3ea84"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"12203fb4decee1bf22fcdbf9fd5374d2b39164bf","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    success \u003d True"},{"line_number":28,"context_line":"    error_message \u003d \"\""},{"line_number":29,"context_line":"    try:"},{"line_number":30,"context_line":"        on_shared_storage \u003d getattr(args, \u0027on_shared_storage\u0027, None)"},{"line_number":31,"context_line":"        if api_versions.APIVersion(\"2.14\") \u003c\u003d cs.api_version:"},{"line_number":32,"context_line":"            # if microversion \u003e\u003d 2.14"},{"line_number":33,"context_line":"            cs.servers.evacuate(server\u003dserver[\u0027uuid\u0027], host\u003dargs.target_host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_5eb432f1","line":30,"range":{"start_line":30,"start_character":63,"end_line":30,"end_character":68},"in_reply_to":"bab6814e_e8be1063","updated":"2016-05-25 03:04:17.000000000","message":"In the case that \u0027on_shared_storage\u0027 is not in args, we\u0027re on version 2.14 where the arg has no meaning i.e. it won\u0027t be passed to servers.evacuate. So, None seems appropriate IMHO","commit_id":"fc90f825f478ac20762c30ec2c84d538acb3ea84"}]}
