)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bb12451ab195b2ce24718c94e20e8423691e5b60","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Functional tests for microversion 2.19 have been added. They include"},{"line_number":10,"context_line":"several actions with server\u0027s description mentioned in Testing section"},{"line_number":11,"context_line":"of goo.gl/4q92ZI (not all of them are implemented here)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ieab77bf5569871380987769c47e9f4dab2ec9e4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_b36d6934","line":11,"updated":"2016-05-25 17:09:25.000000000","message":"I\u0027d like to see this documented in the commit message itself.  One of the functions of a commit message is to provide enough information that someone browsing the git repository without network access can still understand the purpose of the commit.","commit_id":"e2ca6f2c9afdf13b4cdce6ff061b0dc9a7b71087"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"69280d4ca36868edce0a3ed2f28cca7edfade50e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Functional tests for microversion 2.19 have been added. They include"},{"line_number":10,"context_line":"several actions with server\u0027s description mentioned in Testing section"},{"line_number":11,"context_line":"of the appropriate spec (goo.gl/4q92ZI) for Python nova-client and"},{"line_number":12,"context_line":"openstack-client, namely:"},{"line_number":13,"context_line":"- Add a description to the tests that create a server"},{"line_number":14,"context_line":"- Add a description to the tests that rebuild a server"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9abb7d3a_7e3b2639","line":11,"range":{"start_line":11,"start_character":25,"end_line":11,"end_character":38},"updated":"2016-06-02 15:17:15.000000000","message":"Much better, and an appropriate use of a link.  However, I\u0027d prefer you use the full link, rather than a shortened link like this, for a variety of reasons—not the least of which is that Google apparently isn\u0027t reachable from some locales.  I\u0027d suggest using a footnote style for including it, e.g.:\n\n    … of the appropriate spec[1] for Python nova-client …\n\n    …\n    [1] http://…\n\n(I\u0027ll call this a femtonit, meaning I don\u0027t intend to -1 for just this bit, but if you re-roll the patch, I\u0027d appreciate you adjusting the commit message accordingly.)","commit_id":"887518442e7c795ba603c1756e462be16a3f0bfc"},{"author":{"_account_id":16437,"name":"Anna Babich","email":"anna.v.babich@gmail.com","username":"ababich"},"change_message_id":"b0328a6d937b1fb58183840dd8ed54b561b065c9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Functional tests for microversion 2.19 have been added. They include"},{"line_number":10,"context_line":"several actions with server\u0027s description mentioned in Testing section"},{"line_number":11,"context_line":"of the appropriate spec (goo.gl/4q92ZI) for Python nova-client and"},{"line_number":12,"context_line":"openstack-client, namely:"},{"line_number":13,"context_line":"- Add a description to the tests that create a server"},{"line_number":14,"context_line":"- Add a description to the tests that rebuild a server"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9abb7d3a_d957cc24","line":11,"range":{"start_line":11,"start_character":25,"end_line":11,"end_character":38},"in_reply_to":"9abb7d3a_7e3b2639","updated":"2016-06-02 15:35:23.000000000","message":"I\u0027m planning to add test case \"Check that the description is returned as part of server details for a server list\" in the not too distant future (\u0027nova list\u0027 command doesn\u0027t display  servers\u0027 descriptions by default, but it\u0027s possible to use --fields parameter to implement it), and will fix commit message accordingly to your remark","commit_id":"887518442e7c795ba603c1756e462be16a3f0bfc"}],"novaclient/tests/functional/v2/test_servers.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bb12451ab195b2ce24718c94e20e8423691e5b60","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from novaclient.tests.functional.v2.legacy import test_servers"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import novaclient.v2.shell"},{"line_number":17,"context_line":"import random, string"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class TestServersBootNovaClient(test_servers.TestServersBootNovaClient):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_b63a77cb","line":17,"updated":"2016-05-25 17:09:25.000000000","message":"1. Imports should be grouped into three groups, separated by blank lines: group 1 is standard library imports, e.g., random and string; group 2 is third-party imports (no examples here); and group 3 is imports from within the package itself, e.g., the novaclient.v2.shell import.\n\n2. Within each group, the imports should be in alphabetical order by the fully qualified name of the thing being imported; thus, because \u0027v\u0027 is later than \u0027t\u0027, the novaclient.v2.shell import would come after the import for novaclient.tests.functional.v2.legacy.test_servers.\n\n3. Each import should import only one thing, so the imports for random and string should be separate.  (Also, just for future reference, that one thing imported should be the module itself, rather than any object within the module.)","commit_id":"e2ca6f2c9afdf13b4cdce6ff061b0dc9a7b71087"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bb12451ab195b2ce24718c94e20e8423691e5b60","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return server, descr"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_create(self):"},{"line_number":68,"context_line":"        # Add a description to the tests that create a server"},{"line_number":69,"context_line":"        server, descr \u003d self._boot_server_with_description()"},{"line_number":70,"context_line":"        output \u003d self.nova(\"show %s\" % server.id)"},{"line_number":71,"context_line":"        self.assertEqual(descr, self._get_value_from_the_table(output,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_b641d73b","line":68,"updated":"2016-05-25 17:09:25.000000000","message":"You added this comment, but I don\u0027t see any changes to this test method.  Were there no changes necessary here?","commit_id":"e2ca6f2c9afdf13b4cdce6ff061b0dc9a7b71087"},{"author":{"_account_id":16437,"name":"Anna Babich","email":"anna.v.babich@gmail.com","username":"ababich"},"change_message_id":"ceae4cc25af1ebead4693bd25046c36d16bb15d1","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return server, descr"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_create(self):"},{"line_number":68,"context_line":"        # Add a description to the tests that create a server"},{"line_number":69,"context_line":"        server, descr \u003d self._boot_server_with_description()"},{"line_number":70,"context_line":"        output \u003d self.nova(\"show %s\" % server.id)"},{"line_number":71,"context_line":"        self.assertEqual(descr, self._get_value_from_the_table(output,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_af029970","line":68,"in_reply_to":"bab6814e_b641d73b","updated":"2016-06-02 07:51:03.000000000","message":"The added comments are taken from the Testing section of the spec mentioned in Commit message. They are only for better clarification which test cases are implemented here","commit_id":"e2ca6f2c9afdf13b4cdce6ff061b0dc9a7b71087"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bb12451ab195b2ce24718c94e20e8423691e5b60","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        self.nova(\"update %s --description \u0027%s\u0027\" % (server.id, descr))"},{"line_number":100,"context_line":"        output \u003d self.nova(\"show %s\" % server.id)"},{"line_number":101,"context_line":"        self.assertEqual(descr, self._get_value_from_the_table(output,"},{"line_number":102,"context_line":"                                                             \"description\"))"},{"line_number":103,"context_line":"        self.nova(\"update %s --description \u0027\u0027\" % server.id)"},{"line_number":104,"context_line":"        output \u003d self.nova(\"show %s\" % server.id)"},{"line_number":105,"context_line":"        self.assertEqual(\"-\", self._get_value_from_the_table(output,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_b6af17e2","line":102,"updated":"2016-05-25 17:09:25.000000000","message":"This should be indented a little deeper so that \"description\" lines up with \u0027output\u0027.","commit_id":"e2ca6f2c9afdf13b4cdce6ff061b0dc9a7b71087"}]}