)]}'
{"novaclient/v1_1/flavors.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"27fda7bffa844725cabcace457898ba770875364","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Flavor interface."},{"line_number":4,"context_line":"\"\"\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"import urllib"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"from novaclient import base"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F%2FzA%3D","line":6,"updated":"2012-01-23 17:30:40.000000000","message":"Is this used anywhere?","commit_id":"9c31fa065f156e0270ff21fa14aee7fd1550aa6b"},{"author":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"change_message_id":"72e470fc71a63cdda8e43e295f1b27beedf47aa3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        :rtype: :class:`Flavor`"},{"line_number":65,"context_line":"        \"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # stuff"},{"line_number":68,"context_line":"        body \u003d {"},{"line_number":69,"context_line":"            \"flavor\": {"},{"line_number":70,"context_line":"                \"name\": name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEH%2F%2F%2Fsc%3D","line":67,"updated":"2012-01-23 19:27:46.000000000","message":"don\u0027t need this comment :)","commit_id":"2a9e7325a41454f1118c58061993dea228b9bee1"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"e7dcc11d85c2c88a42810b981ca47c0a87310d94","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        :rtype: :class:`Flavor`"},{"line_number":65,"context_line":"        \"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # stuff"},{"line_number":68,"context_line":"        body \u003d {"},{"line_number":69,"context_line":"            \"flavor\": {"},{"line_number":70,"context_line":"                \"name\": name,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAEH%2F%2F%2Bpk%3D","line":67,"updated":"2012-01-24 22:02:54.000000000","message":"This comment doesn\u0027t need to be here ;)","commit_id":"0f888a96bb5b8b753c724ea2d5dc2d15c68b2442"}],"novaclient/v1_1/shell.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"e7dcc11d85c2c88a42810b981ca47c0a87310d94","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"@utils.arg(\u0027id\u0027,"},{"line_number":316,"context_line":"     metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":317,"context_line":"     help\u003d\"Unique ID of the flavor to delete\")"},{"line_number":318,"context_line":"def do_flavor_delete(cs, args):"},{"line_number":319,"context_line":"    \"\"\"Delete a specific flavor\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAEH%2F%2F%2Bpc%3D","line":316,"updated":"2012-01-24 22:02:54.000000000","message":"This should be:\n\nmetavar\u003d\u0027\u003cid\u003e\u0027,","commit_id":"0f888a96bb5b8b753c724ea2d5dc2d15c68b2442"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"e7dcc11d85c2c88a42810b981ca47c0a87310d94","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    \"\"\"Create a new flavor\"\"\""},{"line_number":348,"context_line":"    f \u003d cs.flavors.create(args.name, args.ram, args.vcpus, args.disk, args.id,"},{"line_number":349,"context_line":"                          args.swap, args.rxtx_factor)"},{"line_number":350,"context_line":"    _print_flavor_list([f])"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"def do_image_list(cs, args):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAEH%2F%2F%2BpU%3D","line":350,"updated":"2012-01-24 22:02:54.000000000","message":"This might be a bit misleading to print the same view of a \u0027flavor-list\u0027 for a single flavor. Somebody may interpret that as having overwritten the full list of flavors. It might be time to create a single flavor view, or at least print out something like \"Created flavor X:\\n\" before this table is printed. What do you think?","commit_id":"0f888a96bb5b8b753c724ea2d5dc2d15c68b2442"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"593206c73d0911aec0c40659a2b6858631b930a2","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    \"\"\"Create a new flavor\"\"\""},{"line_number":348,"context_line":"    f \u003d cs.flavors.create(args.name, args.ram, args.vcpus, args.disk, args.id,"},{"line_number":349,"context_line":"                          args.swap, args.rxtx_factor)"},{"line_number":350,"context_line":"    _print_flavor_list([f])"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"def do_image_list(cs, args):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAEH%2F%2F%2Bnc%3D","line":350,"in_reply_to":"AAAAEH%2F%2F%2Bno%3D","updated":"2012-01-24 22:28:33.000000000","message":"Thanks for the explanation. With that understanding, I\u0027m cool with the pattern you\u0027re using.","commit_id":"0f888a96bb5b8b753c724ea2d5dc2d15c68b2442"},{"author":{"_account_id":1783,"name":"Cole Robinson","email":"crobinso@redhat.com","username":"crobinso"},"change_message_id":"5c0a9d84a716e7efaf7c1e1a93eb8ece4c4db8e2","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    \"\"\"Create a new flavor\"\"\""},{"line_number":348,"context_line":"    f \u003d cs.flavors.create(args.name, args.ram, args.vcpus, args.disk, args.id,"},{"line_number":349,"context_line":"                          args.swap, args.rxtx_factor)"},{"line_number":350,"context_line":"    _print_flavor_list([f])"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"def do_image_list(cs, args):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAEH%2F%2F%2Bno%3D","line":350,"in_reply_to":"AAAAEH%2F%2F%2BpU%3D","updated":"2012-01-24 22:26:04.000000000","message":"The shell code has 2 idioms: ips, dns, security use the above pattern, others like images and volumes don\u0027t print a thing and silently exit.\n\nI don\u0027t think it\u0027s likely users will interpret the output as having been destructive to other flavors, but then again I don\u0027t think printing the list info is all that useful either and a simple \u0027Flavor \u0027%(name)\u0027 created.\u0027 is probably ideal. Though no commands seem to do that :)\n\nHowever having flavor_create do that at this point would create 3 different patterns for *_create commands which is even less helpful. IMO it\u0027s a job for a separate cleanup patch to unify all output, which I\u0027d be happy to provide separate of this patch if there\u0027s consensus on ideal output.\n\nI\u0027ll resubmit with the same pattern as above but please push back if you disagree (new submission will fix the nits you reported)","commit_id":"0f888a96bb5b8b753c724ea2d5dc2d15c68b2442"}],"tests/v1_1/test_flavors.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"27fda7bffa844725cabcace457898ba770875364","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            }"},{"line_number":52,"context_line":"        }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/os-flavor-lifecycle\u0027, body)"},{"line_number":55,"context_line":"        self.assertTrue(isinstance(f, flavors.Flavor))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F%2Fy4%3D","line":54,"updated":"2012-01-23 17:30:40.000000000","message":"Should this not be calling POST /flavors?","commit_id":"9c31fa065f156e0270ff21fa14aee7fd1550aa6b"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"27fda7bffa844725cabcace457898ba770875364","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_delete(self):"},{"line_number":58,"context_line":"        cs.flavors.delete(\"flavordelete\")"},{"line_number":59,"context_line":"        cs.assert_called(\u0027DELETE\u0027, \u0027/os-flavor-lifecycle/flavordelete\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F%2Fy0%3D","line":59,"updated":"2012-01-23 17:30:40.000000000","message":"As above.","commit_id":"9c31fa065f156e0270ff21fa14aee7fd1550aa6b"}],"tests/v1_1/test_shell.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"27fda7bffa844725cabcace457898ba770875364","unresolved":false,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    def test_flavor_delete(self):"},{"line_number":333,"context_line":"        self.run_command(\"flavor-delete flavordelete\")"},{"line_number":334,"context_line":"        self.assert_called(\u0027DELETE\u0027, \u0027/os-flavor-lifecycle/flavordelete\u0027)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def test_flavor_create(self):"},{"line_number":337,"context_line":"        self.run_command(\"flavor-create flavorcreate 1234 512 10 1 --swap 1024\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F%2Fyw%3D","line":334,"updated":"2012-01-23 17:30:40.000000000","message":"Should this not be calling DELETE /flavors?","commit_id":"9c31fa065f156e0270ff21fa14aee7fd1550aa6b"},{"author":{"_account_id":1783,"name":"Cole Robinson","email":"crobinso@redhat.com","username":"crobinso"},"change_message_id":"617d43799cd56b3b8ed3eef799e8664b35ec2d6d","unresolved":false,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    def test_flavor_delete(self):"},{"line_number":333,"context_line":"        self.run_command(\"flavor-delete flavordelete\")"},{"line_number":334,"context_line":"        self.assert_called(\u0027DELETE\u0027, \u0027/os-flavor-lifecycle/flavordelete\u0027)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def test_flavor_create(self):"},{"line_number":337,"context_line":"        self.run_command(\"flavor-create flavorcreate 1234 512 10 1 --swap 1024\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F%2Ft4%3D","line":334,"in_reply_to":"AAAAEH%2F%2F%2Fyw%3D","updated":"2012-01-23 18:50:43.000000000","message":"Yeah I was sloppy, will be fixed in v3 (forgot to drop the unused import on v2... doh )","commit_id":"9c31fa065f156e0270ff21fa14aee7fd1550aa6b"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"27fda7bffa844725cabcace457898ba770875364","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            }"},{"line_number":349,"context_line":"        }"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/os-flavor-lifecycle\u0027, body, pos\u003d-2)"},{"line_number":352,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/flavors/1\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F%2Fys%3D","line":351,"updated":"2012-01-23 17:30:40.000000000","message":"As above.","commit_id":"9c31fa065f156e0270ff21fa14aee7fd1550aa6b"}]}