)]}'
{"novaclient/tests/unit/v2/fakes.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7e1e309fd27723c2770ff2c4662f69478526ba4d","unresolved":false,"context_lines":[{"line_number":757,"context_line":"                keys.remove(\u0027onSharedStorage\u0027)"},{"line_number":758,"context_line":"            if \u0027force\u0027 in keys:"},{"line_number":759,"context_line":"                keys.remove(\u0027force\u0027)"},{"line_number":760,"context_line":"            assert set(keys) \u003d\u003d set([])"},{"line_number":761,"context_line":"        else:"},{"line_number":762,"context_line":"            raise AssertionError(\"Unexpected server action: %s\" % action)"},{"line_number":763,"context_line":"        _headers.update(FAKE_RESPONSE_HEADERS)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_a8b534ce","line":760,"range":{"start_line":760,"start_character":36,"end_line":760,"end_character":38},"updated":"2016-06-20 20:56:23.000000000","message":"attonit: \"set()\" is identical to \"set([])\"","commit_id":"c0105ef3cc8ace231c4e9f3902292f7d80e4f61a"}],"novaclient/v2/contrib/host_evacuate.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7e1e309fd27723c2770ff2c4662f69478526ba4d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \u0027--force\u0027,"},{"line_number":70,"context_line":"    dest\u003d\u0027force\u0027,"},{"line_number":71,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":72,"context_line":"    default\u003dNone,"},{"line_number":73,"context_line":"    help\u003d_(\u0027Force to not verify the scheduler if a host is provided.\u0027),"},{"line_number":74,"context_line":"    start_version\u003d\u00272.29\u0027)"},{"line_number":75,"context_line":"def do_host_evacuate(cs, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_e851fc63","line":72,"range":{"start_line":72,"start_character":4,"end_line":72,"end_character":16},"updated":"2016-06-20 20:56:23.000000000","message":"I generally prefer \"default\u003dTrue\" for simple boolean arguments like --force.","commit_id":"c0105ef3cc8ace231c4e9f3902292f7d80e4f61a"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"82abe19d6faf2cae497b340ae9a5110016a1dcbf","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    error_message \u003d \"\""},{"line_number":29,"context_line":"    try:"},{"line_number":30,"context_line":"        on_shared_storage \u003d getattr(args, \u0027on_shared_storage\u0027, None)"},{"line_number":31,"context_line":"        force \u003d getattr(args, \u0027force\u0027, None)"},{"line_number":32,"context_line":"        if api_versions.APIVersion(\"2.29\") \u003c\u003d cs.api_version:"},{"line_number":33,"context_line":"            # if microversion \u003e\u003d 2.29"},{"line_number":34,"context_line":"            cs.servers.evacuate(server\u003dserver[\u0027uuid\u0027], host\u003dargs.target_host,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_75fcfa3e","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":44},"updated":"2016-06-21 17:10:27.000000000","message":"I don\u0027t know why do it for 2.0-2.13, but imo, it is better to move obtaining version specific arguments inside proper if blocks.","commit_id":"5ab9009738cad83d2162b403ca122ed6149f3b34"}],"novaclient/v2/servers.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7e1e309fd27723c2770ff2c4662f69478526ba4d","unresolved":false,"context_lines":[{"line_number":495,"context_line":"                        on shared storage."},{"line_number":496,"context_line":"        :param password: string to set as admin password on the evacuated"},{"line_number":497,"context_line":"                         server."},{"line_number":498,"context_line":"        :param: force to not verify the scheduler if a host is provided."},{"line_number":499,"context_line":"        :returns: An instance of novaclient.base.TupleWithMeta"},{"line_number":500,"context_line":"        \"\"\""},{"line_number":501,"context_line":"        return self.manager.evacuate(self, host, on_shared_storage, password)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_e83c5c31","line":498,"range":{"start_line":498,"start_character":8,"end_line":498,"end_character":21},"updated":"2016-06-20 20:56:23.000000000","message":"\":param force:\" is the proper syntax.  Also, this should document the parameter rather than the \"--force\" option, meaning I\u0027d like to see a mention that this should, for instance, be a boolean.  (That latter part is a femtonit; fixing the param clause needs to be done before I can +2.)","commit_id":"c0105ef3cc8ace231c4e9f3902292f7d80e4f61a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"053a2811c5ed8771dbaf407ac92fdd59b5178b77","unresolved":false,"context_lines":[{"line_number":495,"context_line":"                        on shared storage."},{"line_number":496,"context_line":"        :param password: string to set as admin password on the evacuated"},{"line_number":497,"context_line":"                         server."},{"line_number":498,"context_line":"        :param: force to not verify the scheduler if a host is provided."},{"line_number":499,"context_line":"        :returns: An instance of novaclient.base.TupleWithMeta"},{"line_number":500,"context_line":"        \"\"\""},{"line_number":501,"context_line":"        return self.manager.evacuate(self, host, on_shared_storage, password)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_2cca3350","line":498,"range":{"start_line":498,"start_character":8,"end_line":498,"end_character":21},"in_reply_to":"5a9d85d2_0dcd5b5d","updated":"2016-06-21 16:28:07.000000000","message":"Argh, bad rebase when I had a merge conflict...","commit_id":"c0105ef3cc8ace231c4e9f3902292f7d80e4f61a"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f6c3b0df7a8c33db14b6fc528e3e9b57ae336f15","unresolved":false,"context_lines":[{"line_number":495,"context_line":"                        on shared storage."},{"line_number":496,"context_line":"        :param password: string to set as admin password on the evacuated"},{"line_number":497,"context_line":"                         server."},{"line_number":498,"context_line":"        :param: force to not verify the scheduler if a host is provided."},{"line_number":499,"context_line":"        :returns: An instance of novaclient.base.TupleWithMeta"},{"line_number":500,"context_line":"        \"\"\""},{"line_number":501,"context_line":"        return self.manager.evacuate(self, host, on_shared_storage, password)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_0dcd5b5d","line":498,"range":{"start_line":498,"start_character":8,"end_line":498,"end_character":21},"in_reply_to":"5a9d85d2_e83c5c31","updated":"2016-06-21 11:25:41.000000000","message":"it looks like this parameter is redundant here;) wrong microversion","commit_id":"c0105ef3cc8ace231c4e9f3902292f7d80e4f61a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7e1e309fd27723c2770ff2c4662f69478526ba4d","unresolved":false,"context_lines":[{"line_number":1702,"context_line":"        :param server: The :class:`Server` (or its ID) to share onto."},{"line_number":1703,"context_line":"        :param host: Name of the target host."},{"line_number":1704,"context_line":"        :param password: string to set as password on the evacuated server."},{"line_number":1705,"context_line":"        :param force: force to not verify the scheduler if host is provided."},{"line_number":1706,"context_line":"        :returns: An instance of novaclient.base.TupleWithMeta"},{"line_number":1707,"context_line":"        \"\"\""},{"line_number":1708,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_482130fb","line":1705,"range":{"start_line":1705,"start_character":8,"end_line":1705,"end_character":76},"updated":"2016-06-20 20:56:23.000000000","message":"Could stand some consistency across all these.","commit_id":"c0105ef3cc8ace231c4e9f3902292f7d80e4f61a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"053a2811c5ed8771dbaf407ac92fdd59b5178b77","unresolved":false,"context_lines":[{"line_number":1702,"context_line":"        :param server: The :class:`Server` (or its ID) to share onto."},{"line_number":1703,"context_line":"        :param host: Name of the target host."},{"line_number":1704,"context_line":"        :param password: string to set as password on the evacuated server."},{"line_number":1705,"context_line":"        :param force: force to not verify the scheduler if host is provided."},{"line_number":1706,"context_line":"        :returns: An instance of novaclient.base.TupleWithMeta"},{"line_number":1707,"context_line":"        \"\"\""},{"line_number":1708,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_0cff7735","line":1705,"range":{"start_line":1705,"start_character":8,"end_line":1705,"end_character":76},"in_reply_to":"5a9d85d2_482130fb","updated":"2016-06-21 16:28:07.000000000","message":"Done","commit_id":"c0105ef3cc8ace231c4e9f3902292f7d80e4f61a"}],"novaclient/v2/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7e1e309fd27723c2770ff2c4662f69478526ba4d","unresolved":false,"context_lines":[{"line_number":4692,"context_line":"    \u0027--force\u0027,"},{"line_number":4693,"context_line":"    dest\u003d\u0027force\u0027,"},{"line_number":4694,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":4695,"context_line":"    default\u003dNone,"},{"line_number":4696,"context_line":"    help\u003d_(\u0027Force to not verify the scheduler if a host is provided.\u0027),"},{"line_number":4697,"context_line":"    start_version\u003d\u00272.29\u0027)"},{"line_number":4698,"context_line":"def do_evacuate(cs, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_e86a9c19","line":4695,"range":{"start_line":4695,"start_character":4,"end_line":4695,"end_character":16},"updated":"2016-06-20 20:56:23.000000000","message":"I generally prefer False; then the \"if force is not None\" can become simply \"if force\".","commit_id":"c0105ef3cc8ace231c4e9f3902292f7d80e4f61a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"053a2811c5ed8771dbaf407ac92fdd59b5178b77","unresolved":false,"context_lines":[{"line_number":4692,"context_line":"    \u0027--force\u0027,"},{"line_number":4693,"context_line":"    dest\u003d\u0027force\u0027,"},{"line_number":4694,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":4695,"context_line":"    default\u003dNone,"},{"line_number":4696,"context_line":"    help\u003d_(\u0027Force to not verify the scheduler if a host is provided.\u0027),"},{"line_number":4697,"context_line":"    start_version\u003d\u00272.29\u0027)"},{"line_number":4698,"context_line":"def do_evacuate(cs, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_2c2513c2","line":4695,"range":{"start_line":4695,"start_character":4,"end_line":4695,"end_character":16},"in_reply_to":"5a9d85d2_e86a9c19","updated":"2016-06-21 16:28:07.000000000","message":"Done","commit_id":"c0105ef3cc8ace231c4e9f3902292f7d80e4f61a"}]}