)]}'
{"novaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"18af214d9d9e51c97061cadfe22784b38c097621","unresolved":false,"context_lines":[{"line_number":2851,"context_line":"                 #   headers, and is tested in test_api_versions, but is"},{"line_number":2852,"context_line":"                 #   not explicitly tested via wraps and _SUBSTITUTIONS."},{"line_number":2853,"context_line":"            28,  # doesn\u0027t require any changes in novaclient"},{"line_number":2854,"context_line":"            29,  # doesn\u0027t require any changes in novaclient"},{"line_number":2855,"context_line":"            30,  # doesn\u0027t require any changes in novaclient"},{"line_number":2856,"context_line":"            31,  # doesn\u0027t require any changes in novaclient"},{"line_number":2857,"context_line":"        ])"},{"line_number":2858,"context_line":"        versions_supported \u003d set(range(0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b0a8e578","line":2855,"range":{"start_line":2854,"start_character":0,"end_line":2855,"end_character":60},"updated":"2016-06-28 15:30:03.000000000","message":"You\u0027re adding this on top of the 2.30 microversion change; you shouldn\u0027t have to do anything to this array to accommodate microversions 2.29 or 2.30.  If the previous two microversions introduced bugs by failing to update this array, then that should be a separate change.","commit_id":"38e2b2fc7c129f2751bd4b5991d5afe8dc283cd5"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"56483b85af012c90ce3426e8fbb8a42cb2210b95","unresolved":false,"context_lines":[{"line_number":2851,"context_line":"                 #   headers, and is tested in test_api_versions, but is"},{"line_number":2852,"context_line":"                 #   not explicitly tested via wraps and _SUBSTITUTIONS."},{"line_number":2853,"context_line":"            28,  # doesn\u0027t require any changes in novaclient"},{"line_number":2854,"context_line":"            29,  # doesn\u0027t require any changes in novaclient"},{"line_number":2855,"context_line":"            30,  # doesn\u0027t require any changes in novaclient"},{"line_number":2856,"context_line":"            31,  # doesn\u0027t require any changes in novaclient"},{"line_number":2857,"context_line":"        ])"},{"line_number":2858,"context_line":"        versions_supported \u003d set(range(0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b94c5177","line":2855,"range":{"start_line":2854,"start_character":0,"end_line":2855,"end_character":60},"in_reply_to":"3aaa91ec_b02aa58e","updated":"2016-06-28 15:53:14.000000000","message":"If they truly caused a test failure, then that would be a bug with the 2.29 and 2.30 microversion changes, and presumably also this very test in that it failed to notice them when they were proposed and merged (which doesn\u0027t seem likely :)  In any case, a bug fix for that should be a separate change; you could base this change on top of that fix, if it\u0027s necessary, but I\u0027d like to get to the bottom of the actual bug (if there is one, and not just a transient testing failure) so we can fix it properly.  Further, this list should be absolutely minimalistic, listing only those microversions that don\u0027t require any changes in novaclient, or are special cases such as 2.27 or 2.18.  Obviously, though, 2.31 does need to be listed here, as it demonstrably requires no substantive changes to novaclient…","commit_id":"38e2b2fc7c129f2751bd4b5991d5afe8dc283cd5"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"1e5bf7697bf33aa7b2af1cb0d65d654851891cfe","unresolved":false,"context_lines":[{"line_number":2851,"context_line":"                 #   headers, and is tested in test_api_versions, but is"},{"line_number":2852,"context_line":"                 #   not explicitly tested via wraps and _SUBSTITUTIONS."},{"line_number":2853,"context_line":"            28,  # doesn\u0027t require any changes in novaclient"},{"line_number":2854,"context_line":"            29,  # doesn\u0027t require any changes in novaclient"},{"line_number":2855,"context_line":"            30,  # doesn\u0027t require any changes in novaclient"},{"line_number":2856,"context_line":"            31,  # doesn\u0027t require any changes in novaclient"},{"line_number":2857,"context_line":"        ])"},{"line_number":2858,"context_line":"        versions_supported \u003d set(range(0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b02aa58e","line":2855,"range":{"start_line":2854,"start_character":0,"end_line":2855,"end_character":60},"in_reply_to":"3aaa91ec_b0a8e578","updated":"2016-06-28 15:35:22.000000000","message":"Kevin I added these lines because they were absent and that caused a test failure?","commit_id":"38e2b2fc7c129f2751bd4b5991d5afe8dc283cd5"}]}