)]}'
{"novaclient/v2/quotas.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"64f69cbc27793bfdcdd41c157dd611f8dde995ed","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            params \u003d {\u0027tenant_id\u0027: tenant_id, \u0027user_id\u0027: user_id}"},{"line_number":44,"context_line":"            url +\u003d \u0027?user_id\u003d%(user_id)s\u0027"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            params \u003d {\u0027tenant_id\u0027: tenant_id}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        return self._get(url % params, \"quota_set\")"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_f9f6a05b","line":46,"updated":"2016-06-29 14:50:20.000000000","message":"Suggestion:  Reorganize this as:\n\n    params \u003d {\u0027tenant_id\u0027: tenant_id}\n    if user_id:\n        params[\u0027user_id\u0027]: user_id\n        url +\u003d \u0027?user_id\u003d%(user_id)s\u0027\n\n(femtonit)","commit_id":"0b2de530053d93cdd9dc4ea08c482325321f7ff7"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"06d506a939c44ea2bd7a805984fe6234422e67d4","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            params \u003d {\u0027tenant_id\u0027: tenant_id, \u0027user_id\u0027: user_id}"},{"line_number":44,"context_line":"            url +\u003d \u0027?user_id\u003d%(user_id)s\u0027"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            params \u003d {\u0027tenant_id\u0027: tenant_id}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        return self._get(url % params, \"quota_set\")"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_37494f61","line":46,"in_reply_to":"3aaa91ec_1c18ba1d","updated":"2016-06-29 15:09:42.000000000","message":"this url construction is pretty confusing to me","commit_id":"0b2de530053d93cdd9dc4ea08c482325321f7ff7"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"d642f87df8a97dd87ffcfa056482751c8129ac24","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            params \u003d {\u0027tenant_id\u0027: tenant_id, \u0027user_id\u0027: user_id}"},{"line_number":44,"context_line":"            url +\u003d \u0027?user_id\u003d%(user_id)s\u0027"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            params \u003d {\u0027tenant_id\u0027: tenant_id}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        return self._get(url % params, \"quota_set\")"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_41e992b6","line":46,"in_reply_to":"3aaa91ec_32f03d91","updated":"2016-06-30 09:56:30.000000000","message":"Yeah, that\u0027s the only reason I put it this way :(","commit_id":"0b2de530053d93cdd9dc4ea08c482325321f7ff7"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"2aec38cf1fa5d5dd021a1b9720711417e832a36b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            params \u003d {\u0027tenant_id\u0027: tenant_id, \u0027user_id\u0027: user_id}"},{"line_number":44,"context_line":"            url +\u003d \u0027?user_id\u003d%(user_id)s\u0027"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            params \u003d {\u0027tenant_id\u0027: tenant_id}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        return self._get(url % params, \"quota_set\")"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_32f03d91","line":46,"in_reply_to":"3aaa91ec_37494f61","updated":"2016-06-29 15:24:48.000000000","message":"Well, yeah, I\u0027d prefer if query parameters were encoded using urlencode(), but this style of string construction occurs throughout novaclient, so… *shrug*","commit_id":"0b2de530053d93cdd9dc4ea08c482325321f7ff7"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"d5361474a8b09fbabcefce87f673a0d23461e9ce","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            params \u003d {\u0027tenant_id\u0027: tenant_id, \u0027user_id\u0027: user_id}"},{"line_number":44,"context_line":"            url +\u003d \u0027?user_id\u003d%(user_id)s\u0027"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            params \u003d {\u0027tenant_id\u0027: tenant_id}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        return self._get(url % params, \"quota_set\")"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_1c18ba1d","line":46,"in_reply_to":"3aaa91ec_f9f6a05b","updated":"2016-06-29 14:58:00.000000000","message":"Er, would help if I got the syntax correct; chalk it up to being early in the morning %)  That should of course read:\n\n    params[\u0027user_id\u0027] \u003d user_id\n\n:)","commit_id":"0b2de530053d93cdd9dc4ea08c482325321f7ff7"}]}