)]}'
{"id":"openstack%2Fpython-novaclient~337154","triplet_id":"openstack%2Fpython-novaclient~master~Ia6e495d38b0b50bf2094302757c02c5eb69719db","project":"openstack/python-novaclient","branch":"master","topic":"use_oslo_utils_reflection","hashtags":[],"change_id":"Ia6e495d38b0b50bf2094302757c02c5eb69719db","subject":"Use oslo.utils.reflection to get class names","status":"ABANDONED","created":"2016-07-04 11:45:37.000000000","updated":"2016-12-09 21:04:19.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ce957f947671c5204c9645aa8c7a986d2c138ef8","_number":337154,"virtual_id_number":337154,"owner":{"_account_id":14762,"name":"Zhihai Song","email":"zhhsng@gmail.com","username":"ZhihaiSong"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2016-09-15 13:55:09.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-07-07 17:51:50.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"date":"2016-07-08 11:15:07.000000000","_account_id":14762,"name":"Zhihai Song","email":"zhhsng@gmail.com","username":"ZhihaiSong"},{"date":"2016-12-09 21:04:19.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14762,"name":"Zhihai Song","email":"zhhsng@gmail.com","username":"ZhihaiSong"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":14762,"name":"Zhihai Song","email":"zhhsng@gmail.com","username":"ZhihaiSong"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":14762,"name":"Zhihai Song","email":"zhhsng@gmail.com","username":"ZhihaiSong"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":14762,"name":"Zhihai Song","email":"zhhsng@gmail.com","username":"ZhihaiSong"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-07-07 17:51:50.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-09-15 13:55:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-12-09 21:04:19.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"}],"messages":[{"id":"7b96b900ac3aea197e68f35d6e5d1819815e869b","author":{"_account_id":14762,"name":"Zhihai Song","email":"zhhsng@gmail.com","username":"ZhihaiSong"},"date":"2016-07-04 11:45:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"180fd1cb48cf47c24798a3379242229d56c402e7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-04 12:51:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs http://docs-draft.openstack.org/54/337154/1/check/gate-python-novaclient-docs/d03aa99//doc/build/html/ : SUCCESS in 2m 00s\n- gate-python-novaclient-pep8 http://logs.openstack.org/54/337154/1/check/gate-python-novaclient-pep8/6a61ffa/ : SUCCESS in 5m 04s\n- gate-python-novaclient-python27 http://logs.openstack.org/54/337154/1/check/gate-python-novaclient-python27/b17fc34/ : SUCCESS in 5m 15s\n- gate-python-novaclient-python34 http://logs.openstack.org/54/337154/1/check/gate-python-novaclient-python34/ba84539/ : SUCCESS in 4m 48s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/54/337154/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/5eb9039/ : SUCCESS in 58m 18s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/54/337154/1/check/gate-novaclient-dsvm-functional/27a4c9f/ : SUCCESS in 26m 41s\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/54/337154/1/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/6afa341/ : SUCCESS in 27m 02s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"cd776b750bcff67fd9231a45f5f26d79d48be022","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-07-07 17:51:50.000000000","message":"Patch Set 1:\n\nI see no reason to use reflection just to get the class name, particularly given that we\u0027re not going for fully qualified names.  Why should this go in?","accounts_in_message":[],"_revision_number":1},{"id":"49c1dc997c8cc333535d51491d1d6671296c9524","author":{"_account_id":14762,"name":"Zhihai Song","email":"zhhsng@gmail.com","username":"ZhihaiSong"},"date":"2016-07-08 11:15:07.000000000","message":"Patch Set 1:\n\n\u003e I see no reason to use reflection just to get the class name,\n \u003e particularly given that we\u0027re not going for fully qualified names. \n \u003e Why should this go in?\n\nThanks for the review. In commit [1],  the get_class_name is added. In  some cases this function does simplify the code. Besides, getting the class name is quite a common operation over all projects. Using this reflection module gets rid of manipulating python things and make the code focus on the code logic itself.\n[1]https://github.com/openstack/oslo.utils/commit/3d42b05bce4eaa266b6b3740c2a2b892b7ddf7c9","accounts_in_message":[],"_revision_number":1},{"id":"cd63bec8b73be976609b41f6b36b9b5fcbfe61d9","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-07-08 16:13:29.000000000","message":"Patch Set 1:\n\nI\u0027m not convinced.  All of these places are currently using cls.__name__ or obj.__class__.__name__, which has been used for quite some time.  I agree you would have an argument if we wanted the fully qualified name, but that\u0027s not requested or required for any of these points.  I\u0027m not -1\u0027ing the review, but I would need a lot more convincing to +2 this, particularly given that I seem to recall seeing a similar review rejected by other reviewers in the past.","accounts_in_message":[],"_revision_number":1},{"id":"58fd31245c7463b2606463ae6112ce973ec181a7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-15 13:55:09.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"58f7fc08a728d13077354a318fe6a72ab41a6641","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-12-09 21:04:19.000000000","message":"Abandoned\n\nThis review is \u003e 6 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1},{"id":"60dcf54ff95f545eee00ef44ebc789eafd5f748b","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-12-09 21:04:19.000000000","message":"Patch Set 1:\n\nThis review is \u003e 6 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"beb7ad384d4ad6a89bede940a0cda6de18881793","revisions":{"beb7ad384d4ad6a89bede940a0cda6de18881793":{"kind":"REWORK","_number":1,"created":"2016-07-04 11:45:37.000000000","uploader":{"_account_id":14762,"name":"Zhihai Song","email":"zhhsng@gmail.com","username":"ZhihaiSong"},"ref":"refs/changes/54/337154/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/54/337154/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/54/337154/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/54/337154/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/54/337154/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/54/337154/1"}}},"commit":{"parents":[{"commit":"d052f2609f1f46440a01ef7701591e17da20418e","subject":"Merge \"functional: fix a deprecation warning in test_auth.TestAuthentication\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d052f2609f1f46440a01ef7701591e17da20418e"}]}],"author":{"name":"Zhihai Song","email":"zhihai.song@easystack.cn","date":"2016-07-04 11:12:20.000000000","tz":480},"committer":{"name":"Zhihai Song","email":"zhihai.song@easystack.cn","date":"2016-07-04 11:45:08.000000000","tz":480},"subject":"Use oslo.utils.reflection to get class names","message":"Use oslo.utils.reflection to get class names\n\nThis patch update the method of getting the class name with oslo\nutils\u0027 reflection module.\n\nChange-Id: Ia6e495d38b0b50bf2094302757c02c5eb69719db\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/beb7ad384d4ad6a89bede940a0cda6de18881793"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/beb7ad384d4ad6a89bede940a0cda6de18881793"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}