)]}'
{"id":"openstack%2Fpython-novaclient~34202","triplet_id":"openstack%2Fpython-novaclient~master~I8b07dc2a89d790ec275d45f859e1644e9b00c837","project":"openstack/python-novaclient","branch":"master","topic":"(detached","hashtags":[],"change_id":"I8b07dc2a89d790ec275d45f859e1644e9b00c837","subject":"python3: Compatibility for iteritems differences","status":"MERGED","created":"2013-06-24 13:36:19.000000000","updated":"2013-07-02 22:10:45.000000000","submitted":"2013-07-02 22:10:44.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6fa0b713061143ca0ed886e0bfad3af21037a232","_number":34202,"virtual_id_number":34202,"owner":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-07-02 22:10:44.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"recommended":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-07-02 13:45:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":2,"date":"2013-06-24 18:05:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":2,"date":"2013-07-02 21:12:13.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"date":"2013-06-24 18:05:15.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":1,"date":"2013-07-02 21:12:13.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-06-24 18:05:15.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-07-02 13:45:14.000000000","updated_by":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"reviewer":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"state":"REVIEWER"},{"updated":"2013-07-02 21:12:13.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-07-02 22:10:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"de84c1006c68a351da94794b3a66a00ed218fb41","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-24 14:27:36.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/34202/1/check/gate-python-novaclient-requirements/26 : SUCCESS in 4s\n- http://logs.openstack.org/34202/1/check/gate-python-novaclient-pep8/1687 : SUCCESS in 46s\n- http://docs-draft.openstack.org/34202/1/check/gate-python-novaclient-docs/1378/doc/build/html/ : SUCCESS in 52s\n- http://logs.openstack.org/34202/1/check/gate-python-novaclient-python26/1477 : SUCCESS in 1m 34s\n- http://logs.openstack.org/34202/1/check/gate-python-novaclient-python27/1696 : SUCCESS in 1m 02s\n- http://logs.openstack.org/34202/1/check/gate-tempest-devstack-vm-full/25785 : SUCCESS in 41m 09s\n- http://logs.openstack.org/34202/1/check/gate-tempest-devstack-vm-postgres-full/25491 : SUCCESS in 51m 10s\n- http://logs.openstack.org/34202/1/check/gate-tempest-devstack-vm-quantum/33382 : FAILURE in 20m 05s\n- http://logs.openstack.org/34202/1/check/gate-grenade-devstack-vm/12444 : FAILURE in 20m 23s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"e13c60222b1fb98fa3b05f7623d03fff0b68f009","author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"date":"2013-06-24 15:04:22.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"ff3d26f56aed282e5e027704514ae33f55f01a23","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-06-24 15:31:22.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\nSee in-line comments on base.py.  Also, I would strongly lobby to have hacking checks added and/or enabled to enforce standards like this in the future.  (Ultimately, we need to run the test suite under Python 3 directly, but until we get to that point, we can limit the proliferation of non-Python 3 syntax through style checks.)","accounts_in_message":[],"_revision_number":1},{"id":"34ea31b853f941b75e6eaa42ada4b1b7703fe3dd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-24 15:50:34.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/34202/1/check/gate-python-novaclient-requirements/27 : SUCCESS in 4s\n- http://logs.openstack.org/34202/1/check/gate-python-novaclient-pep8/1688 : SUCCESS in 50s\n- http://docs-draft.openstack.org/34202/1/check/gate-python-novaclient-docs/1379/doc/build/html/ : SUCCESS in 49s\n- http://logs.openstack.org/34202/1/check/gate-python-novaclient-python26/1478 : SUCCESS in 1m 42s\n- http://logs.openstack.org/34202/1/check/gate-python-novaclient-python27/1697 : SUCCESS in 1m 03s\n- http://logs.openstack.org/34202/1/check/gate-tempest-devstack-vm-full/25806 : SUCCESS in 46m 07s\n- http://logs.openstack.org/34202/1/check/gate-tempest-devstack-vm-postgres-full/25512 : SUCCESS in 42m 12s\n- http://logs.openstack.org/34202/1/check/gate-tempest-devstack-vm-quantum/33410 : SUCCESS in 18m 20s\n- http://logs.openstack.org/34202/1/check/gate-grenade-devstack-vm/12464 : FAILURE in 20m 32s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"a1e02b61cd9c43df4cbabd21a9a351e4a632a3e1","author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"date":"2013-06-24 16:51:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"221062780e85e8aa56655fab43350fe1daf16596","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-24 17:41:45.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/34202/2/check/gate-python-novaclient-requirements/30 : SUCCESS in 5s\n- http://logs.openstack.org/34202/2/check/gate-python-novaclient-pep8/1691 : SUCCESS in 42s\n- http://docs-draft.openstack.org/34202/2/check/gate-python-novaclient-docs/1382/doc/build/html/ : SUCCESS in 1m 26s\n- http://logs.openstack.org/34202/2/check/gate-python-novaclient-python26/1481 : SUCCESS in 1m 51s\n- http://logs.openstack.org/34202/2/check/gate-python-novaclient-python27/1700 : SUCCESS in 56s\n- http://logs.openstack.org/34202/2/check/gate-tempest-devstack-vm-full/25839 : SUCCESS in 49m 33s\n- http://logs.openstack.org/34202/2/check/gate-tempest-devstack-vm-postgres-full/25545 : SUCCESS in 50m 34s\n- http://logs.openstack.org/34202/2/check/gate-tempest-devstack-vm-quantum/33445 : SUCCESS in 16m 04s\n- http://logs.openstack.org/34202/2/check/gate-grenade-devstack-vm/12497 : FAILURE in 20m 36s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"1f3b9548d58d0e4b33357daad97d4823d4350a0c","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-06-24 18:05:15.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"69fbf3de36b196f76296fa4e4bcbed7862bbbf29","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2013-07-02 13:45:14.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"4acfb5108806ee8ab50921bdd39229611c1f936e","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-07-02 21:12:13.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"97b3d386c2ab28fa9bd577f9e779b18adc829ca9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-02 21:16:41.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"f6df4eb8e716091a25df8f376e6ced6f81ba6097","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-02 22:10:44.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"4c511a919d6b9e71073bc254e5ba87d7eeb9e24e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-02 22:10:45.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/34202/2/gate/gate-python-novaclient-requirements/35 : SUCCESS in 25s\n- http://docs-draft.openstack.org/34202/2/gate/gate-python-novaclient-docs/1416/doc/build/html/ : SUCCESS in 1m 11s\n- http://logs.openstack.org/34202/2/gate/gate-python-novaclient-pep8/1725 : SUCCESS in 1m 03s\n- http://logs.openstack.org/34202/2/gate/gate-python-novaclient-python26/1515 : SUCCESS in 2m 32s\n- http://logs.openstack.org/34202/2/gate/gate-python-novaclient-python27/1734 : SUCCESS in 1m 19s\n- http://logs.openstack.org/34202/2/gate/gate-tempest-devstack-vm-full/27987 : SUCCESS in 51m 39s\n- http://logs.openstack.org/34202/2/gate/gate-tempest-devstack-vm-postgres-full/27693 : SUCCESS in 52m 54s\n- http://logs.openstack.org/34202/2/gate/gate-tempest-devstack-vm-quantum/35842 : SUCCESS in 29m 37s\n- http://logs.openstack.org/34202/2/gate/gate-grenade-devstack-vm/14378 : FAILURE in 34m 41s (non-voting)\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a25d4fe59aac92eece3f080f16fdca7ffc453064","revisions":{"227c75658d66b28558f2f6fbf5fc3edb83ec36a7":{"kind":"REWORK","_number":1,"created":"2013-06-24 13:36:19.000000000","uploader":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"ref":"refs/changes/02/34202/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/02/34202/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/34202/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/34202/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/34202/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/02/34202/1"}}},"commit":{"parents":[{"commit":"05ca996e6757bb5241b2ed7e080344b66fda4598","subject":"Merge \"Update help for --nic opt and make net-id or port-id required\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/05ca996e6757bb5241b2ed7e080344b66fda4598"}]}],"author":{"name":"Chuck Short","email":"chuck.short@canonical.com","date":"2013-06-24 13:32:05.000000000","tz":-300},"committer":{"name":"Chuck Short","email":"chuck.short@canonical.com","date":"2013-06-24 13:36:17.000000000","tz":-300},"subject":"python3: Compatibility for iteritems differences","message":"python3: Compatibility for iteritems differences\n\nIn python3 dict.iteritems(), dict.iterkeys(), and\ndict.itervalues() are no longer supported. So use\nsix.iteriems() where it is approiate.\n\nChange-Id: I8b07dc2a89d790ec275d45f859e1644e9b00c837\nSigned-off-by: Chuck Short \u003cchuck.short@canonical.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/227c75658d66b28558f2f6fbf5fc3edb83ec36a7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/227c75658d66b28558f2f6fbf5fc3edb83ec36a7"}]},"branch":"refs/heads/master"},"a25d4fe59aac92eece3f080f16fdca7ffc453064":{"kind":"REWORK","_number":2,"created":"2013-06-24 16:51:06.000000000","uploader":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"ref":"refs/changes/02/34202/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/02/34202/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/34202/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/34202/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/34202/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/02/34202/2"}}},"commit":{"parents":[{"commit":"05ca996e6757bb5241b2ed7e080344b66fda4598","subject":"Merge \"Update help for --nic opt and make net-id or port-id required\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/05ca996e6757bb5241b2ed7e080344b66fda4598"}]}],"author":{"name":"Chuck Short","email":"chuck.short@canonical.com","date":"2013-06-24 13:32:05.000000000","tz":-300},"committer":{"name":"Chuck Short","email":"chuck.short@canonical.com","date":"2013-06-24 16:51:04.000000000","tz":-300},"subject":"python3: Compatibility for iteritems differences","message":"python3: Compatibility for iteritems differences\n\nIn python3 dict.iteritems(), dict.iterkeys(), and\ndict.itervalues() are no longer supported. So use\nsix.iteritems() where it is appropriate.\n\nChange-Id: I8b07dc2a89d790ec275d45f859e1644e9b00c837\nSigned-off-by: Chuck Short \u003cchuck.short@canonical.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a25d4fe59aac92eece3f080f16fdca7ffc453064"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a25d4fe59aac92eece3f080f16fdca7ffc453064"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}