)]}'
{"id":"openstack%2Fpython-novaclient~34769","triplet_id":"openstack%2Fpython-novaclient~master~I7ab518886abf8d449caf1c70563a79a990d7765e","project":"openstack/python-novaclient","branch":"master","topic":"bug/1199539","hashtags":[],"change_id":"I7ab518886abf8d449caf1c70563a79a990d7765e","subject":"Skip setting volume_size if not given","status":"MERGED","created":"2013-06-27 17:14:05.000000000","updated":"2013-07-23 01:01:32.000000000","submitted":"2013-07-23 01:01:32.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e1ab03c188eb2af1de2009e15996665b250f5c54","_number":34769,"virtual_id_number":34769,"owner":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":2,"date":"2013-07-23 01:01:32.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-07-16 19:37:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2013-07-22 22:32:47.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-07-16 19:37:14.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2013-07-22 22:32:47.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-07-16 19:37:14.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-07-22 22:32:47.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-07-23 01:01:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b94a370b7821e2c9056d92bc3cfee644f6317bd5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-27 18:07:31.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/34769/1/check/gate-python-novaclient-pep8/1702 : SUCCESS in 1m 14s\n- http://docs-draft.openstack.org/34769/1/check/gate-python-novaclient-docs/1393/doc/build/html/ : SUCCESS in 47s\n- http://logs.openstack.org/34769/1/check/gate-python-novaclient-python26/1492 : FAILURE in 1m 51s\n- http://logs.openstack.org/34769/1/check/gate-python-novaclient-python27/1711 : FAILURE in 59s\n- http://logs.openstack.org/34769/1/check/gate-tempest-devstack-vm-full/26851 : SUCCESS in 53m 19s\n- http://logs.openstack.org/34769/1/check/gate-tempest-devstack-vm-postgres-full/26557 : SUCCESS in 42m 40s\n- http://logs.openstack.org/34769/1/check/gate-tempest-devstack-vm-quantum/34545 : SUCCESS in 20m 15s\n- http://logs.openstack.org/34769/1/check/gate-grenade-devstack-vm/13362 : FAILURE in 21m 16s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"169bf6baf4b2ae8323c7b3a8d232626532b15eba","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2013-06-29 10:52:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cc7741d79d3dc227b3e407a3da7b1190570a4d72","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-29 11:40:53.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/34769/2/check/gate-python-novaclient-pep8/1720 : SUCCESS in 44s\n- http://docs-draft.openstack.org/34769/2/check/gate-python-novaclient-docs/1411/doc/build/html/ : SUCCESS in 52s\n- http://logs.openstack.org/34769/2/check/gate-python-novaclient-python26/1510 : SUCCESS in 1m 49s\n- http://logs.openstack.org/34769/2/check/gate-python-novaclient-python27/1729 : SUCCESS in 58s\n- http://logs.openstack.org/34769/2/check/gate-tempest-devstack-vm-full/27330 : SUCCESS in 43m 15s\n- http://logs.openstack.org/34769/2/check/gate-tempest-devstack-vm-postgres-full/27036 : SUCCESS in 48m 32s\n- http://logs.openstack.org/34769/2/check/gate-tempest-devstack-vm-quantum/35099 : SUCCESS in 20m 43s\n- http://logs.openstack.org/34769/2/check/gate-grenade-devstack-vm/13795 : FAILURE in 20m 33s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"b06f687fdc5b92062514771d448c23ea70e069f3","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2013-07-10 15:09:57.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5764ba52193eaa6b8b44ed6825243ca9a093b3ee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-10 16:06:53.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/34769/3/check/gate-python-novaclient-pep8/1765 : SUCCESS in 1m 20s\n- http://docs-draft.openstack.org/34769/3/check/gate-python-novaclient-docs/1456/doc/build/html/ : SUCCESS in 52s\n- http://logs.openstack.org/34769/3/check/gate-python-novaclient-python26/1551 : SUCCESS in 3m 42s\n- http://logs.openstack.org/34769/3/check/gate-python-novaclient-python27/1774 : SUCCESS in 1m 16s\n- http://logs.openstack.org/34769/3/check/gate-tempest-devstack-vm-full/30373 : SUCCESS in 55m 26s\n- http://logs.openstack.org/34769/3/check/gate-tempest-devstack-vm-postgres-full/30077 : SUCCESS in 44m 39s\n- http://logs.openstack.org/34769/3/check/gate-tempest-devstack-vm-neutron/1598 : SUCCESS in 17m 13s\n- http://logs.openstack.org/34769/3/check/gate-grenade-devstack-vm/16518 : FAILURE in 28m 18s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"be4466af78293c58fa8cf28440f0ca4b1113b87f","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-07-16 19:37:14.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"c7d8283c01b6ff327b45a31ee323e1e3ea225482","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-07-22 22:32:47.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"bb525dcb739f4f797ecd83da06a9d63053fbfa49","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-22 22:32:48.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"b28e25fe7b4ffe47f344d4d171df032e6e4a6d02","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-22 23:32:56.000000000","message":"Patch Set 3: Fails\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/69/34769/3/gate/gate-python-novaclient-docs/1499 : UNSTABLE in 1m 16s\n- http://logs.openstack.org/69/34769/3/gate/gate-python-novaclient-pep8/1808 : SUCCESS in 43s\n- http://logs.openstack.org/69/34769/3/gate/gate-python-novaclient-python26/1594 : SUCCESS in 3m 06s\n- http://logs.openstack.org/69/34769/3/gate/gate-python-novaclient-python27/1817 : SUCCESS in 1m 13s\n- http://logs.openstack.org/69/34769/3/gate/gate-tempest-devstack-vm-full/34553 : SUCCESS in 46m 22s\n- http://logs.openstack.org/69/34769/3/gate/gate-tempest-devstack-vm-postgres-full/34242 : SUCCESS in 59m 48s\n- http://logs.openstack.org/69/34769/3/gate/gate-tempest-devstack-vm-neutron/6379 : SUCCESS in 19m 59s (non-voting)\n- http://logs.openstack.org/69/34769/3/gate/gate-grenade-devstack-vm/20234 : FAILURE in 13m 12s\n","accounts_in_message":[],"_revision_number":3},{"id":"3af2bc12a207cbe0a9b423b0353fb8b2d68d64b7","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2013-07-23 00:01:56.000000000","message":"Patch Set 3:\n\nreverify no bug","accounts_in_message":[],"_revision_number":3},{"id":"7d6aeee80d0e7cf8cefafc00158e82bb329bbfb0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-23 00:02:00.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"145d778f919c9c951787bc5246c4987bec5c2746","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-23 01:01:32.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"0c5ca7f446c65cca74d7d2043572d99177aca4c1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-23 01:01:32.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/69/34769/3/gate/gate-python-novaclient-docs/1500/doc/build/html/ : SUCCESS in 1m 39s\n- http://logs.openstack.org/69/34769/3/gate/gate-python-novaclient-pep8/1809 : SUCCESS in 1m 12s\n- http://logs.openstack.org/69/34769/3/gate/gate-python-novaclient-python26/1595 : SUCCESS in 2m 22s\n- http://logs.openstack.org/69/34769/3/gate/gate-python-novaclient-python27/1818 : SUCCESS in 1m 32s\n- http://logs.openstack.org/69/34769/3/gate/gate-tempest-devstack-vm-full/34592 : SUCCESS in 46m 29s\n- http://logs.openstack.org/69/34769/3/gate/gate-tempest-devstack-vm-postgres-full/34282 : SUCCESS in 59m 28s\n- http://logs.openstack.org/69/34769/3/gate/gate-tempest-devstack-vm-neutron/6422 : SUCCESS in 19m 45s (non-voting)\n- http://logs.openstack.org/69/34769/3/gate/gate-grenade-devstack-vm/20272 : SUCCESS in 28m 26s\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"f50ff361e27a8ca688c0f1ba448bbc8bfb284905","revisions":{"5c2bbbcbca7617b2e633c987ee73b0f3a86931a6":{"kind":"REWORK","_number":1,"created":"2013-06-27 17:14:05.000000000","uploader":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"ref":"refs/changes/69/34769/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/69/34769/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/69/34769/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/69/34769/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/69/34769/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/69/34769/1"}}},"commit":{"parents":[{"commit":"05ca996e6757bb5241b2ed7e080344b66fda4598","subject":"Merge \"Update help for --nic opt and make net-id or port-id required\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/05ca996e6757bb5241b2ed7e080344b66fda4598"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-06-27 17:13:01.000000000","tz":120},"committer":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-06-27 17:13:45.000000000","tz":120},"subject":"Skip setting volume_size if not given","message":"Skip setting volume_size if not given\n\nWhen the block-device parameters skip volume_size,\ndon\u0027t set it.\n\nFixes bug LP #1047568\n\nChange-Id: I7ab518886abf8d449caf1c70563a79a990d7765e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5c2bbbcbca7617b2e633c987ee73b0f3a86931a6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5c2bbbcbca7617b2e633c987ee73b0f3a86931a6"}]},"branch":"refs/heads/master"},"fb37111665dfcd3b082dc3fd2ab3fce195fc6f8c":{"kind":"REWORK","_number":2,"created":"2013-06-29 10:52:16.000000000","uploader":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"ref":"refs/changes/69/34769/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/69/34769/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/69/34769/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/69/34769/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/69/34769/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/69/34769/2"}}},"commit":{"parents":[{"commit":"b526c9beff3f88d792d4c5a17d68f357eaf139ac","subject":"Remove Diablo compatibility options","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b526c9beff3f88d792d4c5a17d68f357eaf139ac"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-06-27 17:13:01.000000000","tz":120},"committer":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-06-29 10:51:40.000000000","tz":120},"subject":"Skip setting volume_size if not given","message":"Skip setting volume_size if not given\n\nWhen the block-device parameters skip volume_size,\ndon\u0027t set it. Setting to an empty volume_size\nwould be invalid as it has to be an integer,\nand Nova API will reject the request if api validation\nis implemented. (proposed e.g. at\nhttps://review.openstack.org/#/c/34749/)\n\nFixes bug LP #1047568\n\nChange-Id: I7ab518886abf8d449caf1c70563a79a990d7765e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/fb37111665dfcd3b082dc3fd2ab3fce195fc6f8c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/fb37111665dfcd3b082dc3fd2ab3fce195fc6f8c"}]},"branch":"refs/heads/master"},"f50ff361e27a8ca688c0f1ba448bbc8bfb284905":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2013-07-10 15:09:57.000000000","uploader":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"ref":"refs/changes/69/34769/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/69/34769/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/69/34769/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/69/34769/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/69/34769/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/69/34769/3"}}},"commit":{"parents":[{"commit":"b526c9beff3f88d792d4c5a17d68f357eaf139ac","subject":"Remove Diablo compatibility options","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b526c9beff3f88d792d4c5a17d68f357eaf139ac"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-06-27 17:13:01.000000000","tz":120},"committer":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-07-10 15:09:38.000000000","tz":120},"subject":"Skip setting volume_size if not given","message":"Skip setting volume_size if not given\n\nWhen the block-device parameters skip volume_size,\ndon\u0027t set it. Setting to an empty volume_size\nwould be invalid as it has to be an integer,\nand Nova API will reject the request if api validation\nis implemented. (proposed e.g. at\nhttps://review.openstack.org/#/c/34749/)\n\nFixes bug LP #1199539\n\nChange-Id: I7ab518886abf8d449caf1c70563a79a990d7765e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f50ff361e27a8ca688c0f1ba448bbc8bfb284905"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f50ff361e27a8ca688c0f1ba448bbc8bfb284905"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}