)]}'
{"novaclient/tests/v1_1/fakes.py":[{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"99f096034595a9fdb0f2875b64d4fb58992df890","unresolved":false,"context_lines":[{"line_number":1380,"context_line":"    def put_os_services_disable_log_reason(self, body, **kw):"},{"line_number":1381,"context_line":"        return (200, {}, {\u0027service\u0027: {\u0027host\u0027: body[\u0027host\u0027],"},{"line_number":1382,"context_line":"                                      \u0027binary\u0027: body[\u0027binary\u0027],"},{"line_number":1383,"context_line":"                                      \u0027status\u0027: \u0027disabled\u0027}})"},{"line_number":1384,"context_line":""},{"line_number":1385,"context_line":"    #"},{"line_number":1386,"context_line":"    # Fixed IPs"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FbHQ%3D","line":1383,"updated":"2013-07-02 09:29:08.000000000","message":"Please add the disabled_reason field to that dictionary","commit_id":"83eba6daf9cc07da0c61ea2b50ab60efcf0b0a53"}],"novaclient/v1_1/shell.py":[{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"99f096034595a9fdb0f2875b64d4fb58992df890","unresolved":false,"context_lines":[{"line_number":2565,"context_line":"                                                args.reason)"},{"line_number":2566,"context_line":"    else:"},{"line_number":2567,"context_line":"        result \u003d cs.services.disable(args.host, args.binary)"},{"line_number":2568,"context_line":"    utils.print_list([result], [\u0027Host\u0027, \u0027Binary\u0027, \u0027Status\u0027])"},{"line_number":2569,"context_line":""},{"line_number":2570,"context_line":""},{"line_number":2571,"context_line":"@utils.arg(\u0027fixed_ip\u0027, metavar\u003d\u0027\u003cfixed_ip\u003e\u0027, help\u003d\u0027Fixed IP Address.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FbHo%3D","line":2568,"updated":"2013-07-02 09:29:08.000000000","message":"if the new extension is enabled and you are using the disable_log_reason method the response returns the disabled_reason field as well. \ni think you should add it to the print_list","commit_id":"83eba6daf9cc07da0c61ea2b50ab60efcf0b0a53"},{"author":{"_account_id":4340,"name":"Sulochan Acharya","email":"sulochan@gmail.com","username":"sulochan-acharya"},"change_message_id":"e165358d6c5782a3a293adc52c7a3d0f76a1a919","unresolved":false,"context_lines":[{"line_number":2565,"context_line":"                                                args.reason)"},{"line_number":2566,"context_line":"    else:"},{"line_number":2567,"context_line":"        result \u003d cs.services.disable(args.host, args.binary)"},{"line_number":2568,"context_line":"    utils.print_list([result], [\u0027Host\u0027, \u0027Binary\u0027, \u0027Status\u0027])"},{"line_number":2569,"context_line":""},{"line_number":2570,"context_line":""},{"line_number":2571,"context_line":"@utils.arg(\u0027fixed_ip\u0027, metavar\u003d\u0027\u003cfixed_ip\u003e\u0027, help\u003d\u0027Fixed IP Address.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FY1U%3D","line":2568,"in_reply_to":"AAAAPn%2F%2FbHo%3D","updated":"2013-07-02 21:10:27.000000000","message":"ah thanks for catching this, fixing this.","commit_id":"83eba6daf9cc07da0c61ea2b50ab60efcf0b0a53"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"b53d4e81a18e18f55a8929d3c4c16a5f072886b2","unresolved":false,"context_lines":[{"line_number":2543,"context_line":"    \"\"\"Show a list of all running services. Filter by host \u0026 binary.\"\"\""},{"line_number":2544,"context_line":"    result \u003d cs.services.list(host\u003dargs.host, binary\u003dargs.binary)"},{"line_number":2545,"context_line":"    columns \u003d [\"Binary\", \"Host\", \"Zone\", \"Status\", \"State\", \"Updated_at\","},{"line_number":2546,"context_line":"               \"Disabled Reason\"]"},{"line_number":2547,"context_line":"    utils.print_list(result, columns)"},{"line_number":2548,"context_line":""},{"line_number":2549,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FXGE%3D","line":2546,"updated":"2013-07-03 10:17:58.000000000","message":"I\u0027d prefer to show the Disabled Reason column when that column is returned.\nIf the new extension is not enabled the return value from service list doesn\u0027t contain the \"disabled_reason\" field.\nIf the new extension is enabled the response has the new field with value, if any.\nIn my opinion the client could work using the same logic. If the new extension is not enable it doesn\u0027t make sense to show an (always) empty field in the output","commit_id":"66b5ab2ce3ef82f5dd6d45e1acc8cdc87f7d4f7d"},{"author":{"_account_id":4340,"name":"Sulochan Acharya","email":"sulochan@gmail.com","username":"sulochan-acharya"},"change_message_id":"096af03acc71389e90d07c91f95e95e7b1b180fe","unresolved":false,"context_lines":[{"line_number":2543,"context_line":"    \"\"\"Show a list of all running services. Filter by host \u0026 binary.\"\"\""},{"line_number":2544,"context_line":"    result \u003d cs.services.list(host\u003dargs.host, binary\u003dargs.binary)"},{"line_number":2545,"context_line":"    columns \u003d [\"Binary\", \"Host\", \"Zone\", \"Status\", \"State\", \"Updated_at\","},{"line_number":2546,"context_line":"               \"Disabled Reason\"]"},{"line_number":2547,"context_line":"    utils.print_list(result, columns)"},{"line_number":2548,"context_line":""},{"line_number":2549,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FW2k%3D","line":2546,"in_reply_to":"AAAAPn%2F%2FXGE%3D","updated":"2013-07-03 12:44:07.000000000","message":"Nice suggestion! thanks. I am not sure if there is a nice way to check if the extension is enabled from the client other than to check if the result has disabled_reason attribute present. I will implement a check for that, if there is a better way to do this please let me know.","commit_id":"66b5ab2ce3ef82f5dd6d45e1acc8cdc87f7d4f7d"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"b53d4e81a18e18f55a8929d3c4c16a5f072886b2","unresolved":false,"context_lines":[{"line_number":2566,"context_line":"                                                args.reason)"},{"line_number":2567,"context_line":"    else:"},{"line_number":2568,"context_line":"        result \u003d cs.services.disable(args.host, args.binary)"},{"line_number":2569,"context_line":"    utils.print_list([result], [\u0027Host\u0027, \u0027Binary\u0027, \u0027Status\u0027, \u0027disabled_reason\u0027])"},{"line_number":2570,"context_line":""},{"line_number":2571,"context_line":""},{"line_number":2572,"context_line":"@utils.arg(\u0027fixed_ip\u0027, metavar\u003d\u0027\u003cfixed_ip\u003e\u0027, help\u003d\u0027Fixed IP Address.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FXFk%3D","line":2569,"updated":"2013-07-03 10:17:58.000000000","message":"Same as above and, as output, please use the same field\u0027s name used in the do_service_list.","commit_id":"66b5ab2ce3ef82f5dd6d45e1acc8cdc87f7d4f7d"},{"author":{"_account_id":4340,"name":"Sulochan Acharya","email":"sulochan@gmail.com","username":"sulochan-acharya"},"change_message_id":"096af03acc71389e90d07c91f95e95e7b1b180fe","unresolved":false,"context_lines":[{"line_number":2566,"context_line":"                                                args.reason)"},{"line_number":2567,"context_line":"    else:"},{"line_number":2568,"context_line":"        result \u003d cs.services.disable(args.host, args.binary)"},{"line_number":2569,"context_line":"    utils.print_list([result], [\u0027Host\u0027, \u0027Binary\u0027, \u0027Status\u0027, \u0027disabled_reason\u0027])"},{"line_number":2570,"context_line":""},{"line_number":2571,"context_line":""},{"line_number":2572,"context_line":"@utils.arg(\u0027fixed_ip\u0027, metavar\u003d\u0027\u003cfixed_ip\u003e\u0027, help\u003d\u0027Fixed IP Address.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FW2c%3D","line":2569,"in_reply_to":"AAAAPn%2F%2FXFk%3D","updated":"2013-07-03 12:44:07.000000000","message":"My mistake, will change this.","commit_id":"66b5ab2ce3ef82f5dd6d45e1acc8cdc87f7d4f7d"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"dcc366587cd72c458ab9ff1ff871176e5e9abe60","unresolved":false,"context_lines":[{"line_number":2563,"context_line":"@utils.arg(\u0027--reason\u0027, metavar\u003d\u0027\u003creason\u003e\u0027,"},{"line_number":2564,"context_line":"           help\u003d\u0027Reason for disabling service.\u0027)"},{"line_number":2565,"context_line":"def do_service_disable(cs, args):"},{"line_number":2566,"context_line":"    \"\"\"Disable the service\"\"\""},{"line_number":2567,"context_line":"    if args.reason:"},{"line_number":2568,"context_line":"        result \u003d cs.services.disable_log_reason(args.host, args.binary,"},{"line_number":2569,"context_line":"                                                args.reason)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FWLw%3D","line":2566,"updated":"2013-07-03 15:57:35.000000000","message":"This is a really small thing:\nI like the idea to have a \"default\" set of columns and add a new one only if required (as you did for the do_service_list), can you do the same here?\nSo we have the utils.printList([result], columns)  just once in the code.","commit_id":"78e74e21335f7e8792d1ff2b4fd50a19de5ef8e5"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"6deaa872f92ac88aed028a38651395f04e54ce22","unresolved":false,"context_lines":[{"line_number":2563,"context_line":"@utils.arg(\u0027--reason\u0027, metavar\u003d\u0027\u003creason\u003e\u0027,"},{"line_number":2564,"context_line":"           help\u003d\u0027Reason for disabling service.\u0027)"},{"line_number":2565,"context_line":"def do_service_disable(cs, args):"},{"line_number":2566,"context_line":"    \"\"\"Disable the service\"\"\""},{"line_number":2567,"context_line":"    if args.reason:"},{"line_number":2568,"context_line":"        result \u003d cs.services.disable_log_reason(args.host, args.binary,"},{"line_number":2569,"context_line":"                                                args.reason)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FSDg%3D","line":2566,"in_reply_to":"AAAAPn%2F%2FVtc%3D","updated":"2013-07-05 08:57:28.000000000","message":"I was thinking something like that:\ncolumns \u003d [\u0027Host\u0027, \u0027Binary\u0027, \u0027Status\u0027]\nif args.reason:\n    result \u003d cs.services.disable_log_reason(args.host, args.binary, args.reason)\n    columns.append(\u0027Disabled Reason\u0027)\nelse:\n    result \u003d cs.services.disable(args.host, args.binary)\n\nutils.print_list([result], columns)\n\nbut, as I said, this is not an issue.","commit_id":"78e74e21335f7e8792d1ff2b4fd50a19de5ef8e5"},{"author":{"_account_id":4340,"name":"Sulochan Acharya","email":"sulochan@gmail.com","username":"sulochan-acharya"},"change_message_id":"87904cb578c507a56b3fb9c0fdf9fe7e3f9edd42","unresolved":false,"context_lines":[{"line_number":2563,"context_line":"@utils.arg(\u0027--reason\u0027, metavar\u003d\u0027\u003creason\u003e\u0027,"},{"line_number":2564,"context_line":"           help\u003d\u0027Reason for disabling service.\u0027)"},{"line_number":2565,"context_line":"def do_service_disable(cs, args):"},{"line_number":2566,"context_line":"    \"\"\"Disable the service\"\"\""},{"line_number":2567,"context_line":"    if args.reason:"},{"line_number":2568,"context_line":"        result \u003d cs.services.disable_log_reason(args.host, args.binary,"},{"line_number":2569,"context_line":"                                                args.reason)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FVtc%3D","line":2566,"in_reply_to":"AAAAPn%2F%2FWLw%3D","updated":"2013-07-03 18:17:22.000000000","message":"Not sure i totally agree with this. In the above case we didnt know if disabled_reason was in the response. Here we always know, as you cant call on disabled-reason if the ext is not enabled. I think this keeps it simple. Agree with base set of columns. Since doing like above does not hurt, i can change if this is really an issue.","commit_id":"78e74e21335f7e8792d1ff2b4fd50a19de5ef8e5"}]}