)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"91117f667c7e52efe1f1ec4df917e4c64acea735","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Several variables require renaming and deprecation:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- tenant_id -\u003e project_name"},{"line_number":12,"context_line":"- api_key -\u003e password"},{"line_number":13,"context_line":"- bypass_url -\u003e endpoint_override"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also, this patch adds ability to use bypass-url/endpoint_override in case of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3ac371cc_62804147","line":12,"updated":"2016-08-16 20:57:16.000000000","message":"Can you drop https://review.openstack.org/#/c/307714/ if you\u0027re doing it here?","commit_id":"5cca17e05b7b9e9d44612ce220462a0e2bcf79a8"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"54d862f3232775354dd63de3d8ad50b9aaae89e5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecate several variables"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Several variables require renaming and deprecation:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- tenant_id -\u003e project_name"},{"line_number":12,"context_line":"- api_key -\u003e password"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa6399be_67e7d1ac","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":17},"updated":"2016-10-18 13:06:08.000000000","message":"Several *public contractual parameters* require deprecation, to be clear.\n\nIt\u0027s fine to leave the old variable names in the not contractual APIs (like HTTPClient), but that should be clear IMHO in the commit msg.","commit_id":"ab65afb97639f7a2b1d05ab13681cd75376e0776"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9297f537be947f038b747d1fe8f127ae58c57844","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  implementation, keystoneclient was able to use it."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"NOTE: api_key, interface, bypass_url, tenant_name are deprecated, but you can"},{"line_number":35,"context_line":"      continue use them until deprecation perios is not over:)"},{"line_number":36,"context_line":"NOTE2: names of variables in inner class HTTPClient were not changed, since"},{"line_number":37,"context_line":"       this class will be abandoned soon."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa6399be_52888a22","line":35,"range":{"start_line":35,"start_character":42,"end_line":35,"end_character":48},"updated":"2016-10-19 19:18:58.000000000","message":"period","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9297f537be947f038b747d1fe8f127ae58c57844","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  implementation, keystoneclient was able to use it."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"NOTE: api_key, interface, bypass_url, tenant_name are deprecated, but you can"},{"line_number":35,"context_line":"      continue use them until deprecation perios is not over:)"},{"line_number":36,"context_line":"NOTE2: names of variables in inner class HTTPClient were not changed, since"},{"line_number":37,"context_line":"       this class will be abandoned soon."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa6399be_d2a3ba9c","line":35,"range":{"start_line":35,"start_character":24,"end_line":35,"end_character":29},"updated":"2016-10-19 19:18:58.000000000","message":"while the deprecation period is not over? The \u0027is not over\u0027 reads a bit oddly but I get your meaning.","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"}],"novaclient/client.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"54d862f3232775354dd63de3d8ad50b9aaae89e5","unresolved":false,"context_lines":[{"line_number":737,"context_line":"                          # fully by SessionClient soon, so there are no"},{"line_number":738,"context_line":"                          # reasons to spend time renaming projectid variable"},{"line_number":739,"context_line":"                          # to tenant_name/project_name."},{"line_number":740,"context_line":"                          projectid\u003dproject_name,"},{"line_number":741,"context_line":"                          tenant_id\u003dproject_id,"},{"line_number":742,"context_line":"                          auth_url\u003dauth_url,"},{"line_number":743,"context_line":"                          auth_token\u003dauth_token,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_e7768105","line":740,"updated":"2016-10-18 13:06:08.000000000","message":"While I understand why you\u0027re not changing the parameter name of the HTTPClient constructor, I think the commit msg could be confusing given HTTPClient is public (although not part of the novaclient contractual API)","commit_id":"ab65afb97639f7a2b1d05ab13681cd75376e0776"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"54d862f3232775354dd63de3d8ad50b9aaae89e5","unresolved":false,"context_lines":[{"line_number":753,"context_line":"                          service_name\u003dservice_name,"},{"line_number":754,"context_line":"                          volume_service_name\u003dvolume_service_name,"},{"line_number":755,"context_line":"                          timings\u003dtimings,"},{"line_number":756,"context_line":"                          bypass_url\u003dendpoint_override,"},{"line_number":757,"context_line":"                          os_cache\u003dos_cache,"},{"line_number":758,"context_line":"                          http_log_debug\u003dhttp_log_debug,"},{"line_number":759,"context_line":"                          cacert\u003dcacert,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_075ff50e","line":756,"updated":"2016-10-18 13:06:08.000000000","message":"ditto","commit_id":"ab65afb97639f7a2b1d05ab13681cd75376e0776"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"54d862f3232775354dd63de3d8ad50b9aaae89e5","unresolved":false,"context_lines":[{"line_number":860,"context_line":"                    \"new\": right_name,"},{"line_number":861,"context_line":"                    \"release\": release"},{"line_number":862,"context_line":"                })"},{"line_number":863,"context_line":"            kwargs[right_name] \u003d kwargs.pop(deprecated_name)"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"def Client(version, username\u003dNone, password\u003dNone, project_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_279a39c6","line":863,"updated":"2016-10-18 13:06:08.000000000","message":"Not sure we should have 2 distinct warning messages whether the right name is provided or not, given we\u0027re saying it\u0027s deprecated, but that\u0027s a nit.","commit_id":"ab65afb97639f7a2b1d05ab13681cd75376e0776"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a94e8ac4778453fcb9a75b1b6f68e5512291917e","unresolved":false,"context_lines":[{"line_number":892,"context_line":"                      \"arguments. Note that this will become an error in \""},{"line_number":893,"context_line":"                      \"Ocata.\")"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"    kwargs[\"project_id\"] \u003d project_id"},{"line_number":896,"context_line":"    kwargs[\"password\"] \u003d password"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"    _check_rename_of_argument(kwargs, deprecated_name\u003d\"api_key\","},{"line_number":899,"context_line":"                              right_name\u003d\"password\", release\u003d\"Newton\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_56234ca7","line":896,"range":{"start_line":895,"start_character":4,"end_line":896,"end_character":33},"updated":"2016-10-18 22:17:25.000000000","message":"these lines breaks logic of _check_rename_of_argument .\nfix and proper test will be added in next patch-set","commit_id":"ab65afb97639f7a2b1d05ab13681cd75376e0776"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"54d862f3232775354dd63de3d8ad50b9aaae89e5","unresolved":false,"context_lines":[{"line_number":919,"context_line":"    #   allow additional arguments(kwargs), someone can use this variable name"},{"line_number":920,"context_line":"    #   and face issue about unexpected behavior."},{"line_number":921,"context_line":"    _check_rename_of_argument(kwargs, deprecated_name\u003d\"interface\","},{"line_number":922,"context_line":"                              right_name\u003d\"endpoint_type\", release\u003d\"Newton\")"},{"line_number":923,"context_line":""},{"line_number":924,"context_line":"    api_version, client_class \u003d _get_client_class_and_version(version)"},{"line_number":925,"context_line":"    kwargs.pop(\"direct_use\", None)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_877145e3","line":922,"updated":"2016-10-18 13:06:08.000000000","message":"So that\u0027s just a hack for making sure we don\u0027t change the contractual APIs but we use the same variable name southbound in the method calls ? Fine by me, but maybe the commit msg should comment that.","commit_id":"ab65afb97639f7a2b1d05ab13681cd75376e0776"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9297f537be947f038b747d1fe8f127ae58c57844","unresolved":false,"context_lines":[{"line_number":705,"context_line":"                           region_name\u003dNone, endpoint_type\u003d\u0027publicURL\u0027,"},{"line_number":706,"context_line":"                           extensions\u003dNone, service_type\u003d\u0027compute\u0027,"},{"line_number":707,"context_line":"                           service_name\u003dNone, volume_service_name\u003dNone,"},{"line_number":708,"context_line":"                           timings\u003dFalse, bypass_url\u003dNone, os_cache\u003dFalse,"},{"line_number":709,"context_line":"                           no_cache\u003dTrue, http_log_debug\u003dFalse,"},{"line_number":710,"context_line":"                           auth_system\u003d\u0027keystone\u0027, auth_plugin\u003dNone,"},{"line_number":711,"context_line":"                           auth_token\u003dNone, cacert\u003dNone, tenant_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_b5cd50b9","side":"PARENT","line":708,"range":{"start_line":708,"start_character":42,"end_line":708,"end_character":52},"updated":"2016-10-19 19:18:58.000000000","message":"Since you removed this and replaced it with endpoint_override, what if someone was calling with bypass_url but not endpoint_override? Shouldn\u0027t you at least check kwargs for bypass_url if endpoint_override is None?","commit_id":"33d8a6702af82cb768a0b4884ca7395307dd5a7c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"306152284a59d8e4a669eb97192661f055a6d5bb","unresolved":false,"context_lines":[{"line_number":705,"context_line":"                           region_name\u003dNone, endpoint_type\u003d\u0027publicURL\u0027,"},{"line_number":706,"context_line":"                           extensions\u003dNone, service_type\u003d\u0027compute\u0027,"},{"line_number":707,"context_line":"                           service_name\u003dNone, volume_service_name\u003dNone,"},{"line_number":708,"context_line":"                           timings\u003dFalse, bypass_url\u003dNone, os_cache\u003dFalse,"},{"line_number":709,"context_line":"                           no_cache\u003dTrue, http_log_debug\u003dFalse,"},{"line_number":710,"context_line":"                           auth_system\u003d\u0027keystone\u0027, auth_plugin\u003dNone,"},{"line_number":711,"context_line":"                           auth_token\u003dNone, cacert\u003dNone, tenant_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_0427c964","side":"PARENT","line":708,"range":{"start_line":708,"start_character":42,"end_line":708,"end_character":52},"in_reply_to":"fa6399be_b5cd50b9","updated":"2016-12-02 16:32:15.000000000","message":"see L908","commit_id":"33d8a6702af82cb768a0b4884ca7395307dd5a7c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9297f537be947f038b747d1fe8f127ae58c57844","unresolved":false,"context_lines":[{"line_number":701,"context_line":""},{"line_number":702,"context_line":"def _construct_http_client(username\u003dNone, password\u003dNone, project_id\u003dNone,"},{"line_number":703,"context_line":"                           project_name\u003dNone, auth_url\u003dNone, insecure\u003dFalse,"},{"line_number":704,"context_line":"                           timeout\u003dNone, proxy_tenant_id\u003dNone,"},{"line_number":705,"context_line":"                           proxy_token\u003dNone, region_name\u003dNone,"},{"line_number":706,"context_line":"                           endpoint_type\u003d\u0027publicURL\u0027, service_type\u003d\u0027compute\u0027,"},{"line_number":707,"context_line":"                           service_name\u003dNone, volume_service_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_75ec9829","line":704,"updated":"2016-10-19 19:18:58.000000000","message":"nit: moving stuff around in this massive kwargs list is really confusing to review. It would be easier if the entire list had a kwarg on a separate line, maybe even in alphabetical order. I\u0027m not sure I care to do that in this change, but you could have done it in a cleanup patch that comes before this one to order the kwargs before adding new ones to the mix.","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"306152284a59d8e4a669eb97192661f055a6d5bb","unresolved":false,"context_lines":[{"line_number":701,"context_line":""},{"line_number":702,"context_line":"def _construct_http_client(username\u003dNone, password\u003dNone, project_id\u003dNone,"},{"line_number":703,"context_line":"                           project_name\u003dNone, auth_url\u003dNone, insecure\u003dFalse,"},{"line_number":704,"context_line":"                           timeout\u003dNone, proxy_tenant_id\u003dNone,"},{"line_number":705,"context_line":"                           proxy_token\u003dNone, region_name\u003dNone,"},{"line_number":706,"context_line":"                           endpoint_type\u003d\u0027publicURL\u0027, service_type\u003d\u0027compute\u0027,"},{"line_number":707,"context_line":"                           service_name\u003dNone, volume_service_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_a41615ef","line":704,"in_reply_to":"fa6399be_75ec9829","updated":"2016-12-02 16:32:15.000000000","message":"done","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9297f537be947f038b747d1fe8f127ae58c57844","unresolved":false,"context_lines":[{"line_number":701,"context_line":""},{"line_number":702,"context_line":"def _construct_http_client(username\u003dNone, password\u003dNone, project_id\u003dNone,"},{"line_number":703,"context_line":"                           project_name\u003dNone, auth_url\u003dNone, insecure\u003dFalse,"},{"line_number":704,"context_line":"                           timeout\u003dNone, proxy_tenant_id\u003dNone,"},{"line_number":705,"context_line":"                           proxy_token\u003dNone, region_name\u003dNone,"},{"line_number":706,"context_line":"                           endpoint_type\u003d\u0027publicURL\u0027, service_type\u003d\u0027compute\u0027,"},{"line_number":707,"context_line":"                           service_name\u003dNone, volume_service_name\u003dNone,"},{"line_number":708,"context_line":"                           timings\u003dFalse, endpoint_override\u003dNone,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_b2b3a6e8","line":705,"range":{"start_line":704,"start_character":41,"end_line":705,"end_character":44},"updated":"2016-10-19 19:18:58.000000000","message":"We should also deprecate these proxy_* kwargs, but we could do that separately.\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2016-October/106098.html","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"306152284a59d8e4a669eb97192661f055a6d5bb","unresolved":false,"context_lines":[{"line_number":701,"context_line":""},{"line_number":702,"context_line":"def _construct_http_client(username\u003dNone, password\u003dNone, project_id\u003dNone,"},{"line_number":703,"context_line":"                           project_name\u003dNone, auth_url\u003dNone, insecure\u003dFalse,"},{"line_number":704,"context_line":"                           timeout\u003dNone, proxy_tenant_id\u003dNone,"},{"line_number":705,"context_line":"                           proxy_token\u003dNone, region_name\u003dNone,"},{"line_number":706,"context_line":"                           endpoint_type\u003d\u0027publicURL\u0027, service_type\u003d\u0027compute\u0027,"},{"line_number":707,"context_line":"                           service_name\u003dNone, volume_service_name\u003dNone,"},{"line_number":708,"context_line":"                           timings\u003dFalse, endpoint_override\u003dNone,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_4496214d","line":705,"range":{"start_line":704,"start_character":41,"end_line":705,"end_character":44},"in_reply_to":"fa6399be_b2b3a6e8","updated":"2016-12-02 16:32:15.000000000","message":"ok","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9297f537be947f038b747d1fe8f127ae58c57844","unresolved":false,"context_lines":[{"line_number":706,"context_line":"                           endpoint_type\u003d\u0027publicURL\u0027, service_type\u003d\u0027compute\u0027,"},{"line_number":707,"context_line":"                           service_name\u003dNone, volume_service_name\u003dNone,"},{"line_number":708,"context_line":"                           timings\u003dFalse, endpoint_override\u003dNone,"},{"line_number":709,"context_line":"                           os_cache\u003dFalse, http_log_debug\u003dFalse,"},{"line_number":710,"context_line":"                           auth_system\u003d\u0027keystone\u0027, auth_plugin\u003dNone,"},{"line_number":711,"context_line":"                           auth_token\u003dNone, cacert\u003dNone, user_id\u003dNone,"},{"line_number":712,"context_line":"                           connection_pool\u003dFalse, session\u003dNone, auth\u003dNone,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_f5aa68d1","line":709,"range":{"start_line":709,"start_character":27,"end_line":709,"end_character":35},"updated":"2016-10-19 19:18:58.000000000","message":"I thought you weren\u0027t going to rename the internal httpclient kwargs? Or am I confusing the commit message?","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"306152284a59d8e4a669eb97192661f055a6d5bb","unresolved":false,"context_lines":[{"line_number":706,"context_line":"                           endpoint_type\u003d\u0027publicURL\u0027, service_type\u003d\u0027compute\u0027,"},{"line_number":707,"context_line":"                           service_name\u003dNone, volume_service_name\u003dNone,"},{"line_number":708,"context_line":"                           timings\u003dFalse, endpoint_override\u003dNone,"},{"line_number":709,"context_line":"                           os_cache\u003dFalse, http_log_debug\u003dFalse,"},{"line_number":710,"context_line":"                           auth_system\u003d\u0027keystone\u0027, auth_plugin\u003dNone,"},{"line_number":711,"context_line":"                           auth_token\u003dNone, cacert\u003dNone, user_id\u003dNone,"},{"line_number":712,"context_line":"                           connection_pool\u003dFalse, session\u003dNone, auth\u003dNone,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_24af6595","line":709,"range":{"start_line":709,"start_character":27,"end_line":709,"end_character":35},"in_reply_to":"fa6399be_f5aa68d1","updated":"2016-12-02 16:32:15.000000000","message":"I\u0027ll do this change separately, so it will be more clear. \n\nPS: currently we have two options for same meaning - os_cache(see L708 in old code) and no_cache(L709 in old code). Only one argument is actually used.","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9297f537be947f038b747d1fe8f127ae58c57844","unresolved":false,"context_lines":[{"line_number":724,"context_line":"                             user_agent\u003duser_agent,"},{"line_number":725,"context_line":"                             timings\u003dtimings,"},{"line_number":726,"context_line":"                             api_version\u003dapi_version,"},{"line_number":727,"context_line":"                             endpoint_override\u003dendpoint_override,"},{"line_number":728,"context_line":"                             **kwargs)"},{"line_number":729,"context_line":"    else:"},{"line_number":730,"context_line":"        # FIXME(jamielennox): username and password are now optional. Need"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_957ccc73","line":727,"updated":"2016-10-19 19:18:58.000000000","message":"nit: I know this is called out in the commit message, but this is new function and has less to do with the deprecation going on here, so IMO this is doing too many things in a single change and I\u0027d split this out.","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"306152284a59d8e4a669eb97192661f055a6d5bb","unresolved":false,"context_lines":[{"line_number":724,"context_line":"                             user_agent\u003duser_agent,"},{"line_number":725,"context_line":"                             timings\u003dtimings,"},{"line_number":726,"context_line":"                             api_version\u003dapi_version,"},{"line_number":727,"context_line":"                             endpoint_override\u003dendpoint_override,"},{"line_number":728,"context_line":"                             **kwargs)"},{"line_number":729,"context_line":"    else:"},{"line_number":730,"context_line":"        # FIXME(jamielennox): username and password are now optional. Need"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_c4887125","line":727,"in_reply_to":"fa6399be_957ccc73","updated":"2016-12-02 16:32:15.000000000","message":"ok","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9297f537be947f038b747d1fe8f127ae58c57844","unresolved":false,"context_lines":[{"line_number":842,"context_line":"    if deprecated_name in kwargs:"},{"line_number":843,"context_line":"        if right_name in kwargs:"},{"line_number":844,"context_line":"            warnings.warn("},{"line_number":845,"context_line":"                \"The \u0027%(old)s\u0027 argument is deprecated since %(release)s, \""},{"line_number":846,"context_line":"                \"and its use may result in errors in future releases. \""},{"line_number":847,"context_line":"                \"As \u0027%(new)s\u0027 is provided, the \u0027%(old)s\u0027 argument will be\""},{"line_number":848,"context_line":"                \" ignored.\" % {"},{"line_number":849,"context_line":"                    \"old\": deprecated_name,"},{"line_number":850,"context_line":"                    \"new\": right_name,"},{"line_number":851,"context_line":"                    \"release\": release"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_15f27cd2","line":848,"range":{"start_line":845,"start_character":16,"end_line":848,"end_character":27},"updated":"2016-10-19 19:18:58.000000000","message":"nit: we could mark this for translation using _() or _LW() but I see we\u0027re inconsistent in doing that in other places that use warnings.warn in novaclient.","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"306152284a59d8e4a669eb97192661f055a6d5bb","unresolved":false,"context_lines":[{"line_number":842,"context_line":"    if deprecated_name in kwargs:"},{"line_number":843,"context_line":"        if right_name in kwargs:"},{"line_number":844,"context_line":"            warnings.warn("},{"line_number":845,"context_line":"                \"The \u0027%(old)s\u0027 argument is deprecated since %(release)s, \""},{"line_number":846,"context_line":"                \"and its use may result in errors in future releases. \""},{"line_number":847,"context_line":"                \"As \u0027%(new)s\u0027 is provided, the \u0027%(old)s\u0027 argument will be\""},{"line_number":848,"context_line":"                \" ignored.\" % {"},{"line_number":849,"context_line":"                    \"old\": deprecated_name,"},{"line_number":850,"context_line":"                    \"new\": right_name,"},{"line_number":851,"context_line":"                    \"release\": release"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a74a57a_cdc8f2aa","line":848,"range":{"start_line":845,"start_character":16,"end_line":848,"end_character":27},"in_reply_to":"fa6399be_15f27cd2","updated":"2016-12-02 16:32:15.000000000","message":"Will move this patch to separete method and fix your comment.","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9297f537be947f038b747d1fe8f127ae58c57844","unresolved":false,"context_lines":[{"line_number":892,"context_line":"    :param auth_url: Endpoint to authenticate against"},{"line_number":893,"context_line":"    \"\"\""},{"line_number":894,"context_line":"    if args:"},{"line_number":895,"context_line":"        warnings.warn(\"Only VERSION, USERNAME, PASSWORD, PROJECT_ID and \""},{"line_number":896,"context_line":"                      \"AUTH_URL arguments can be specified as positional \""},{"line_number":897,"context_line":"                      \"arguments. All other variables should be keyword \""},{"line_number":898,"context_line":"                      \"arguments. Note that this will become an error in \""},{"line_number":899,"context_line":"                      \"Ocata.\")"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    if project_id:"},{"line_number":902,"context_line":"        kwargs[\"project_id\"] \u003d project_id"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_d5f9e4c9","line":899,"range":{"start_line":895,"start_character":8,"end_line":899,"end_character":31},"updated":"2016-10-19 19:18:58.000000000","message":"At what point do you want to make this a hard failure?","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"306152284a59d8e4a669eb97192661f055a6d5bb","unresolved":false,"context_lines":[{"line_number":892,"context_line":"    :param auth_url: Endpoint to authenticate against"},{"line_number":893,"context_line":"    \"\"\""},{"line_number":894,"context_line":"    if args:"},{"line_number":895,"context_line":"        warnings.warn(\"Only VERSION, USERNAME, PASSWORD, PROJECT_ID and \""},{"line_number":896,"context_line":"                      \"AUTH_URL arguments can be specified as positional \""},{"line_number":897,"context_line":"                      \"arguments. All other variables should be keyword \""},{"line_number":898,"context_line":"                      \"arguments. Note that this will become an error in \""},{"line_number":899,"context_line":"                      \"Ocata.\")"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    if project_id:"},{"line_number":902,"context_line":"        kwargs[\"project_id\"] \u003d project_id"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_e492cd4a","line":899,"range":{"start_line":895,"start_character":8,"end_line":899,"end_character":31},"in_reply_to":"fa6399be_d5f9e4c9","updated":"2016-12-02 16:32:15.000000000","message":"I think we ready to do it:)","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"71276888f5a7f0930ed6efe43f952d9c02c360a7","unresolved":false,"context_lines":[{"line_number":732,"context_line":"                          # fully by SessionClient soon, so there are no"},{"line_number":733,"context_line":"                          # reasons to spend time renaming projectid variable"},{"line_number":734,"context_line":"                          # to tenant_name/project_name."},{"line_number":735,"context_line":"                          projectid\u003dproject_name,"},{"line_number":736,"context_line":"                          tenant_id\u003dproject_id,"},{"line_number":737,"context_line":"                          auth_url\u003dauth_url,"},{"line_number":738,"context_line":"                          auth_token\u003dauth_token,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a6eadb0_8bf2fc6d","line":735,"updated":"2016-12-14 12:11:23.000000000","message":"this was really a name before?","commit_id":"6db73ad4b94218135e11b3af89e401c0fa3f465e"}],"novaclient/shell.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"54d862f3232775354dd63de3d8ad50b9aaae89e5","unresolved":false,"context_lines":[{"line_number":712,"context_line":"            # service type specified, we use default nova service type."},{"line_number":713,"context_line":"            service_type \u003d DEFAULT_NOVA_SERVICE_TYPE"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"        # If we have an auth token but no management_url, we must auth anyway."},{"line_number":716,"context_line":"        # Expired tokens are handled by client.py:_cs_request"},{"line_number":717,"context_line":"        must_auth \u003d not (auth_token and endpoint_override)"},{"line_number":718,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_e7b8412d","line":715,"range":{"start_line":715,"start_character":10,"end_line":715,"end_character":56},"updated":"2016-10-18 13:06:08.000000000","message":"that comment would require a rewrite like \"we should always auth unless we have a token and we\u0027re passing a specific endpoint\".\n\nThat would clarify the logic here, I guess.","commit_id":"ab65afb97639f7a2b1d05ab13681cd75376e0776"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a94e8ac4778453fcb9a75b1b6f68e5512291917e","unresolved":false,"context_lines":[{"line_number":712,"context_line":"            # service type specified, we use default nova service type."},{"line_number":713,"context_line":"            service_type \u003d DEFAULT_NOVA_SERVICE_TYPE"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"        # If we have an auth token but no management_url, we must auth anyway."},{"line_number":716,"context_line":"        # Expired tokens are handled by client.py:_cs_request"},{"line_number":717,"context_line":"        must_auth \u003d not (auth_token and endpoint_override)"},{"line_number":718,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_cb7c15b8","line":715,"range":{"start_line":715,"start_character":10,"end_line":715,"end_character":56},"in_reply_to":"fa6399be_e7b8412d","updated":"2016-10-18 22:17:25.000000000","message":"Done","commit_id":"ab65afb97639f7a2b1d05ab13681cd75376e0776"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9297f537be947f038b747d1fe8f127ae58c57844","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                \u0027NOVA_ENDPOINT_TYPE\u0027, default\u003dutils.env("},{"line_number":490,"context_line":"                    \u0027OS_ENDPOINT_TYPE\u0027,"},{"line_number":491,"context_line":"                    default\u003dDEFAULT_NOVA_ENDPOINT_TYPE)),"},{"line_number":492,"context_line":"            help\u003d_(\u0027Defaults to env[NOVA_ENDPOINT_TYPE], \u0027"},{"line_number":493,"context_line":"                   \u0027env[OS_ENDPOINT_TYPE] or \u0027) +"},{"line_number":494,"context_line":"                 DEFAULT_NOVA_ENDPOINT_TYPE + \u0027.\u0027)"},{"line_number":495,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_b538f03e","line":492,"updated":"2016-10-19 19:18:58.000000000","message":"Not for this change, but the code below only allows public, internal or admin, so we should add that to the help text.","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9297f537be947f038b747d1fe8f127ae58c57844","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                   \u0027\"X.latest\", defaults to env[OS_COMPUTE_API_VERSION].\u0027))"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        parser.add_argument("},{"line_number":505,"context_line":"            \u0027--bypass-url\u0027,"},{"line_number":506,"context_line":"            metavar\u003d\u0027\u003cbypass-url\u003e\u0027,"},{"line_number":507,"context_line":"            dest\u003d\u0027endpoint_override\u0027,"},{"line_number":508,"context_line":"            default\u003dutils.env(\u0027NOVACLIENT_BYPASS_URL\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_f5c5083d","line":505,"updated":"2016-10-19 19:18:58.000000000","message":"Don\u0027t we want to deprecate and replace this with --endpoint-override? I\u0027m not totally sure what the steps are for that, unless you use action\u003dDeprecatedAction and then add a new option for --endpoint-override.","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"}],"novaclient/tests/unit/v2/fakes.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6d44f2d89c8a452e868b9102dfdb719451d5df30","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        # NOTE(augustina): this is a hacky workaround, ultimately"},{"line_number":81,"context_line":"        # we need to fix our whole mocking architecture (fixtures?)"},{"line_number":82,"context_line":"        if \u0027endpoint_type\u0027 in kwargs:"},{"line_number":83,"context_line":"            self.endpoint_type \u003d kwargs.get(\u0027endpoint_type\u0027)"},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            self.endpoint_type \u003d \u0027endpoint_type\u0027"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_8f54e721","line":83,"updated":"2016-08-02 17:53:46.000000000","message":"This change shouldn\u0027t make any difference whatsoever; this branch of the \u0027if\u0027 won\u0027t be visited unless \u0027endpoint_type\u0027 exists in kwargs.","commit_id":"728181bf1a4d7ecdb9e5d470c06cc0b44f2e8aa1"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6a3d3f96fa28f51c1d78a0ef6b1622d6faa46490","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        # NOTE(augustina): this is a hacky workaround, ultimately"},{"line_number":81,"context_line":"        # we need to fix our whole mocking architecture (fixtures?)"},{"line_number":82,"context_line":"        if \u0027endpoint_type\u0027 in kwargs:"},{"line_number":83,"context_line":"            self.endpoint_type \u003d kwargs.get(\u0027endpoint_type\u0027)"},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            self.endpoint_type \u003d \u0027endpoint_type\u0027"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_44812a4d","line":83,"in_reply_to":"bacf61ea_8f54e721","updated":"2016-08-02 21:24:33.000000000","message":"it was done while experimental work with interface variable. Forgot to remove this change.\n\nDone","commit_id":"728181bf1a4d7ecdb9e5d470c06cc0b44f2e8aa1"}],"novaclient/v2/client.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"54d862f3232775354dd63de3d8ad50b9aaae89e5","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            auth\u003dauth,"},{"line_number":207,"context_line":"            api_version\u003dapi_version,"},{"line_number":208,"context_line":"            logger\u003dlogger,"},{"line_number":209,"context_line":"            **kwargs)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @property"},{"line_number":212,"context_line":"    def api_version(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_820db339","line":209,"range":{"start_line":209,"start_character":12,"end_line":209,"end_character":20},"updated":"2016-10-18 13:06:08.000000000","message":"we\u0027re fortunate to accept kwargs so we can still support the deprecated parameters, but I\u0027d like to make sure we have an unit test verifying that, given you modified all the existing tests to use the new parameter names. \n\nOf course, we would remove that specific UT once we drop support for the old parameters.","commit_id":"ab65afb97639f7a2b1d05ab13681cd75376e0776"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a94e8ac4778453fcb9a75b1b6f68e5512291917e","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            auth\u003dauth,"},{"line_number":207,"context_line":"            api_version\u003dapi_version,"},{"line_number":208,"context_line":"            logger\u003dlogger,"},{"line_number":209,"context_line":"            **kwargs)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @property"},{"line_number":212,"context_line":"    def api_version(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_8b205db2","line":209,"range":{"start_line":209,"start_character":12,"end_line":209,"end_character":20},"in_reply_to":"fa6399be_820db339","updated":"2016-10-18 22:17:25.000000000","message":"\u003ewe can still support the deprecated parameters\n\nit is wrong assumption:) this class should not be initialized directly. Case when user tries to do it should be handled by L112-118","commit_id":"ab65afb97639f7a2b1d05ab13681cd75376e0776"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"54d862f3232775354dd63de3d8ad50b9aaae89e5","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        return self.project_name"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @property"},{"line_number":226,"context_line":"    def tenant_id(self):"},{"line_number":227,"context_line":"        return self.project_id"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    @client._original_only"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_4251db0d","line":226,"updated":"2016-10-18 13:06:08.000000000","message":"Shouldn\u0027t we warn about the deprecation, like you did in L222 ?","commit_id":"ab65afb97639f7a2b1d05ab13681cd75376e0776"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a94e8ac4778453fcb9a75b1b6f68e5512291917e","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        return self.project_name"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @property"},{"line_number":226,"context_line":"    def tenant_id(self):"},{"line_number":227,"context_line":"        return self.project_id"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    @client._original_only"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_11771ea0","line":226,"in_reply_to":"fa6399be_4251db0d","updated":"2016-10-18 22:17:25.000000000","message":"Done","commit_id":"ab65afb97639f7a2b1d05ab13681cd75376e0776"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9297f537be947f038b747d1fe8f127ae58c57844","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      directly. It should be done via `novaclient.client.Client` interface."},{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def __init__(self, username\u003dNone, password\u003dNone, project_id\u003dNone,"},{"line_number":66,"context_line":"                 project_name\u003dNone, auth_url\u003dNone, insecure\u003dFalse,"},{"line_number":67,"context_line":"                 timeout\u003dNone, proxy_tenant_id\u003dNone, proxy_token\u003dNone,"},{"line_number":68,"context_line":"                 region_name\u003dNone, endpoint_type\u003d\u0027publicURL\u0027, extensions\u003dNone,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_753498fa","line":65,"updated":"2016-10-19 19:18:58.000000000","message":"Similar comment as in the other module, this would be easier to review if the list of kwargs were on separate lines and sorted in a previous change that this builds on.","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"306152284a59d8e4a669eb97192661f055a6d5bb","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      directly. It should be done via `novaclient.client.Client` interface."},{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def __init__(self, username\u003dNone, password\u003dNone, project_id\u003dNone,"},{"line_number":66,"context_line":"                 project_name\u003dNone, auth_url\u003dNone, insecure\u003dFalse,"},{"line_number":67,"context_line":"                 timeout\u003dNone, proxy_tenant_id\u003dNone, proxy_token\u003dNone,"},{"line_number":68,"context_line":"                 region_name\u003dNone, endpoint_type\u003d\u0027publicURL\u0027, extensions\u003dNone,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_24b4c5cf","line":65,"in_reply_to":"fa6399be_753498fa","updated":"2016-12-02 16:32:15.000000000","message":"ok","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"}],"releasenotes/notes/rename_arguments-d5eb7bbae7500664.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"91117f667c7e52efe1f1ec4df917e4c64acea735","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - keyword argument **interface** of novaclient.client.Client entry-point was"},{"line_number":13,"context_line":"    deprecated in favor of **endpoint_type**;"},{"line_number":14,"context_line":"fixes:"},{"line_number":15,"context_line":"  - Unability to use bypass-url/endpoint_override in case of Keystone V3"},{"line_number":16,"context_line":"other:"},{"line_number":17,"context_line":"  - The meaning of \u0027project_id\u0027 variable of novaclient.client.Client"},{"line_number":18,"context_line":"    entry-point was not clear. In different cases it was used as ID or Name of"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3ac371cc_a2c0797d","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":13},"updated":"2016-08-16 20:57:16.000000000","message":"Inability.\n\nThis also reads kind of weird. I think you\u0027re saying you\u0027re fixing the inability to do this. The negative usage there makes it read a bit odd, maybe just say \"You can now use bypass-url/endpoint_override when using keystone v3.\"","commit_id":"5cca17e05b7b9e9d44612ce220462a0e2bcf79a8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9297f537be947f038b747d1fe8f127ae58c57844","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - keyword argument **api_key** of novaclient.client.Client entry-point was"},{"line_number":4,"context_line":"    deprecated in favor of **password**. Nothing had changed in case of usage"},{"line_number":5,"context_line":"    positional argument;"},{"line_number":6,"context_line":"  - keyword argument **bypass_url** of novaclient.client.Client entry-point was"},{"line_number":7,"context_line":"    deprecated in favor of **endpoint_override**;"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa6399be_1507dc1c","line":4,"range":{"start_line":4,"start_character":49,"end_line":4,"end_character":52},"updated":"2016-10-19 19:18:58.000000000","message":"has","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9297f537be947f038b747d1fe8f127ae58c57844","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - keyword argument **api_key** of novaclient.client.Client entry-point was"},{"line_number":4,"context_line":"    deprecated in favor of **password**. Nothing had changed in case of usage"},{"line_number":5,"context_line":"    positional argument;"},{"line_number":6,"context_line":"  - keyword argument **bypass_url** of novaclient.client.Client entry-point was"},{"line_number":7,"context_line":"    deprecated in favor of **endpoint_override**;"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa6399be_8009e82e","line":4,"range":{"start_line":4,"start_character":72,"end_line":4,"end_character":77},"updated":"2016-10-19 19:18:58.000000000","message":"suggest rewording this as:\n\n\"Nothing has changed in the case of positional argument usage.\"","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9297f537be947f038b747d1fe8f127ae58c57844","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - keyword argument **interface** of novaclient.client.Client entry-point was"},{"line_number":13,"context_line":"    deprecated in favor of **endpoint_type**;"},{"line_number":14,"context_line":"fixes:"},{"line_number":15,"context_line":"  - You can now use bypass-url/endpoint_override when using keystone v3."},{"line_number":16,"context_line":"other:"},{"line_number":17,"context_line":"  - The meaning of \u0027project_id\u0027 variable of novaclient.client.Client"},{"line_number":18,"context_line":"    entry-point was not clear. In different cases it was used as ID or Name of"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa6399be_001eb862","line":15,"updated":"2016-10-19 19:18:58.000000000","message":"This is less of a fix and more of a feature, and as noted I think this should come in a separate change.","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9297f537be947f038b747d1fe8f127ae58c57844","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  - The meaning of \u0027project_id\u0027 variable of novaclient.client.Client"},{"line_number":18,"context_line":"    entry-point was not clear. In different cases it was used as ID or Name of"},{"line_number":19,"context_line":"    project(in terms of Keystone). The time to identify meaning is come, so now"},{"line_number":20,"context_line":"    project_id/tenant_id variables take care about Project ID(in terms of"},{"line_number":21,"context_line":"    Keystone) and project_name/tenant_name variables take care about Project"},{"line_number":22,"context_line":"    Name(in terms of Keystone)."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa6399be_a0234ca6","line":20,"range":{"start_line":20,"start_character":35,"end_line":20,"end_character":50},"updated":"2016-10-19 19:18:58.000000000","message":"Maybe instead say \"specifically mean\". So:\n\n\"so now project_id/tenant_id variables specifically mean Project ID (in terms of Keystone)...\"","commit_id":"6cb454ff499b5e2ddc391cdc86a2325c16ee1854"}]}