)]}'
{"id":"openstack%2Fpython-novaclient~350230","triplet_id":"openstack%2Fpython-novaclient~master~I22c83b489f1464714b385c47c043500e0b0c3e46","project":"openstack/python-novaclient","branch":"master","hashtags":[],"change_id":"I22c83b489f1464714b385c47c043500e0b0c3e46","subject":"Improve character encoding in client messages","status":"ABANDONED","created":"2016-08-02 18:56:38.000000000","updated":"2016-12-09 21:04:18.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3756253e757f98d41179529e1044f53626378dc4","_number":350230,"virtual_id_number":350230,"owner":{"_account_id":22314,"name":"Ryan Selden","email":"seldenr@icloud.com","username":"seldenr"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":-1,"date":"2016-09-15 13:55:09.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":22314,"name":"Ryan Selden","email":"seldenr@icloud.com","username":"seldenr"},{"date":"2016-12-09 21:04:18.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":-1,"date":"2016-08-04 17:36:30.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-08-03 17:12:42.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22314,"name":"Ryan Selden","email":"seldenr@icloud.com","username":"seldenr"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":22314,"name":"Ryan Selden","email":"seldenr@icloud.com","username":"seldenr"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22314,"name":"Ryan Selden","email":"seldenr@icloud.com","username":"seldenr"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":22314,"name":"Ryan Selden","email":"seldenr@icloud.com","username":"seldenr"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-03 17:12:42.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-08-04 17:36:30.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2016-09-15 13:55:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-12-09 21:04:18.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"}],"messages":[{"id":"bb2d6ce9b2cd6e7457a83bceba658b4bfc484e70","author":{"_account_id":22314,"name":"Ryan Selden","email":"seldenr@icloud.com","username":"seldenr"},"date":"2016-08-02 18:56:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cc600c065ea1250511e2ce876195b42c8feee6b8","author":{"_account_id":22314,"name":"Ryan Selden","email":"seldenr@icloud.com","username":"seldenr"},"date":"2016-08-02 20:34:38.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"3c5472cbe7646891cce287ae89d6e7a172ad3a37","author":{"_account_id":22314,"name":"Ryan Selden","email":"seldenr@icloud.com","username":"seldenr"},"date":"2016-08-02 20:40:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"741754e2c714bdcec1749e7331a2679ddfa406d2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-03 04:23:54.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/30/350230/2/check/gate-python-novaclient-docs-ubuntu-xenial/9e26b86//doc/build/html/ : SUCCESS in 2m 08s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/30/350230/2/check/gate-python-novaclient-pep8-ubuntu-xenial/c1faa5e/ : SUCCESS in 2m 02s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/30/350230/2/check/gate-python-novaclient-python27-ubuntu-xenial/adf24e7/ : SUCCESS in 2m 27s\n- gate-python-novaclient-python34 http://logs.openstack.org/30/350230/2/check/gate-python-novaclient-python34/c036ae8/ : SUCCESS in 4m 23s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/30/350230/2/check/gate-python-novaclient-python35-nv/3413be2/ : FAILURE in 3m 20s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/30/350230/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/79c67be/ : SUCCESS in 1h 13m 49s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/30/350230/2/check/gate-novaclient-dsvm-functional/d574db8/ : SUCCESS in 50m 22s\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/30/350230/2/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/3792214/ : SUCCESS in 50m 26s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"21c31802ebc8ec2103a955bc09f77bb478368828","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-08-03 15:34:41.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"fa4c0b419fbd5defcce326b7770333430641ea24","author":{"_account_id":22314,"name":"Ryan Selden","email":"seldenr@icloud.com","username":"seldenr"},"date":"2016-08-03 16:43:53.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6adadd3dd5dd77e5de0ccb3c42c6b60d797288e9","author":{"_account_id":22314,"name":"Ryan Selden","email":"seldenr@icloud.com","username":"seldenr"},"date":"2016-08-03 16:45:25.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nDone. That was failing some tests but turns out it was something else. Good now. Thanks!","accounts_in_message":[],"_revision_number":2},{"id":"1927cf567abeab29d3dbf74ac628d0f0dbecd8fb","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-08-03 17:12:42.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"ffd9d8a5a9819412745d41aec0c38d7755aea078","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-03 21:57:33.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/30/350230/3/check/gate-python-novaclient-docs-ubuntu-xenial/5c6dd21//doc/build/html/ : SUCCESS in 1m 43s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/30/350230/3/check/gate-python-novaclient-pep8-ubuntu-xenial/e936b0e/ : SUCCESS in 5m 07s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/30/350230/3/check/gate-python-novaclient-python27-ubuntu-xenial/eafdee8/ : SUCCESS in 2m 42s\n- gate-python-novaclient-python34 http://logs.openstack.org/30/350230/3/check/gate-python-novaclient-python34/680783c/ : SUCCESS in 2m 35s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/30/350230/3/check/gate-python-novaclient-python35-nv/e53868f/ : FAILURE in 9m 07s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/30/350230/3/check/gate-tempest-dsvm-neutron-src-python-novaclient/818432e/ : SUCCESS in 1h 04m 25s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/30/350230/3/check/gate-novaclient-dsvm-functional/255ab31/ : SUCCESS in 55m 38s\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/30/350230/3/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/81e85ed/ : SUCCESS in 44m 14s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"28eecc21337e029b3ef0e654aeb3fc4d48bf32c5","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2016-08-04 17:36:30.000000000","message":"Patch Set 3: Code-Review-1\n\n(2 comments)\n\nCould you please add tests to demonstrate this works and catch future regressions? I think two tests can be added to novaclient/tests/unit/test_utils.py in DoActionOnManyTestCase, one for the success case and one for the exception case (where action(resource) raises an exception).","accounts_in_message":[],"_revision_number":3},{"id":"5cc827fa92e0f764bf16f34c55b1cffb7e3a2619","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-15 13:55:09.000000000","message":"Patch Set 3: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":3},{"id":"db250d24ae860ecec803b9d19a6a1d51ab22712c","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-12-09 21:04:18.000000000","message":"Patch Set 3:\n\nThis review is \u003e 6 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":3},{"id":"3756253e757f98d41179529e1044f53626378dc4","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-12-09 21:04:18.000000000","message":"Abandoned\n\nThis review is \u003e 6 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"20150d5d581ce65a9d087e29f51d940021c510d7","revisions":{"d2d4a99f0c729dd3660ccc157d38336736b8b293":{"kind":"REWORK","_number":1,"created":"2016-08-02 18:56:38.000000000","uploader":{"_account_id":22314,"name":"Ryan Selden","email":"seldenr@icloud.com","username":"seldenr"},"ref":"refs/changes/30/350230/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/30/350230/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/30/350230/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/30/350230/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/30/350230/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/30/350230/1"}}},"commit":{"parents":[{"commit":"48da89e2a297e44125cb88aa284cf99bf87c2b1f","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/48da89e2a297e44125cb88aa284cf99bf87c2b1f"}]}],"author":{"name":"Ryan Selden","email":"ryanx.seldon@intel.com","date":"2016-08-02 18:53:48.000000000","tz":0},"committer":{"name":"Ryan Selden","email":"ryanx.seldon@intel.com","date":"2016-08-02 18:56:37.000000000","tz":0},"subject":"Improve character encoding in client messages","message":"Improve character encoding in client messages\n\nThis patch improves handling of the character\nencoding in client success and error messages.\n\nAs noted in the closed-bug, when the name of\nsomething, (ie an instance), is unicode,\nthe client doesn\u0027t handle the success and error\nmessages well.\n\nChange-Id: I22c83b489f1464714b385c47c043500e0b0c3e46\nCloses-Bug: #1403379\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d2d4a99f0c729dd3660ccc157d38336736b8b293"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d2d4a99f0c729dd3660ccc157d38336736b8b293"}]},"branch":"refs/heads/master"},"8178f8678510152f7ed3d1b81d42ef7e74c7c341":{"kind":"REWORK","_number":2,"created":"2016-08-02 20:40:26.000000000","uploader":{"_account_id":22314,"name":"Ryan Selden","email":"seldenr@icloud.com","username":"seldenr"},"ref":"refs/changes/30/350230/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/30/350230/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/30/350230/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/30/350230/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/30/350230/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/30/350230/2"}}},"commit":{"parents":[{"commit":"48da89e2a297e44125cb88aa284cf99bf87c2b1f","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/48da89e2a297e44125cb88aa284cf99bf87c2b1f"}]}],"author":{"name":"Ryan Selden","email":"ryanx.seldon@intel.com","date":"2016-08-02 18:53:48.000000000","tz":0},"committer":{"name":"Ryan Selden","email":"ryanx.seldon@intel.com","date":"2016-08-02 20:40:12.000000000","tz":0},"subject":"Improve character encoding in client messages","message":"Improve character encoding in client messages\n\nThis patch improves handling of the character\nencoding in client success and error messages.\n\nAs noted in the closed-bug, when the name of\nsomething, (ie an instance), is unicode,\nthe client doesn\u0027t handle the success and error\nmessages well.\n\nChange-Id: I22c83b489f1464714b385c47c043500e0b0c3e46\nCloses-Bug: #1403379\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8178f8678510152f7ed3d1b81d42ef7e74c7c341"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8178f8678510152f7ed3d1b81d42ef7e74c7c341"}]},"branch":"refs/heads/master"},"20150d5d581ce65a9d087e29f51d940021c510d7":{"kind":"REWORK","_number":3,"created":"2016-08-03 16:43:53.000000000","uploader":{"_account_id":22314,"name":"Ryan Selden","email":"seldenr@icloud.com","username":"seldenr"},"ref":"refs/changes/30/350230/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/30/350230/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/30/350230/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/30/350230/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/30/350230/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/30/350230/3"}}},"commit":{"parents":[{"commit":"48da89e2a297e44125cb88aa284cf99bf87c2b1f","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/48da89e2a297e44125cb88aa284cf99bf87c2b1f"}]}],"author":{"name":"Ryan Selden","email":"ryanx.seldon@intel.com","date":"2016-08-02 18:53:48.000000000","tz":0},"committer":{"name":"Ryan Selden","email":"ryanx.seldon@intel.com","date":"2016-08-03 16:43:42.000000000","tz":0},"subject":"Improve character encoding in client messages","message":"Improve character encoding in client messages\n\nThis patch improves handling of the character\nencoding in client success and error messages.\n\nAs noted in the closed-bug, when the name of\nsomething, (ie an instance), is unicode,\nthe client doesn\u0027t handle the success and error\nmessages well.\n\nChange-Id: I22c83b489f1464714b385c47c043500e0b0c3e46\nCloses-Bug: #1403379\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/20150d5d581ce65a9d087e29f51d940021c510d7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/20150d5d581ce65a9d087e29f51d940021c510d7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}