)]}'
{"novaclient/tests/functional/v2/test_servers.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"865caff80aef0ab82da37e5bcefc1e8470de2d9f","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    COMPUTE_API_VERSION \u003d \u00272.37\u0027"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _find_network_in_table(self, table):"},{"line_number":182,"context_line":"        # Example:"},{"line_number":183,"context_line":"        # +-----------------+-----------------------------------+"},{"line_number":184,"context_line":"        # |   Property      |               Value               |"},{"line_number":185,"context_line":"        # +-----------------+-----------------------------------+"},{"line_number":186,"context_line":"        # | private network |          192.168.154.128          |"},{"line_number":187,"context_line":"        # +-----------------+-----------------------------------+"},{"line_number":188,"context_line":"        for line in table.split(\u0027\\n\u0027):"},{"line_number":189,"context_line":"            if \u0027|\u0027 in line:"},{"line_number":190,"context_line":"                l_property, l_value \u003d line.split(\u0027|\u0027)[1:3]"},{"line_number":191,"context_line":"                if \u0027 network\u0027 in l_property.strip():"},{"line_number":192,"context_line":"                    return \u0027 \u0027.join(l_property.strip().split()[:-1])"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_boot_server_with_auto_network(self):"},{"line_number":195,"context_line":"        # Tests that the CLI defaults to \u0027auto\u0027 when --nic isn\u0027t specified."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_94bae96c","line":192,"range":{"start_line":181,"start_character":4,"end_line":192,"end_character":68},"updated":"2016-08-09 22:42:25.000000000","message":"https://github.com/openstack/python-novaclient/blob/baeaf60e601d536b94552d3f477b78895df138f9/novaclient/tests/functional/base.py#L310 can replace this method.","commit_id":"b925fbac2bfaa288e71b8bcfedd9c0c532c6135d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cee52f7757b274d9cc24a243fcbda180b6209384","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    COMPUTE_API_VERSION \u003d \u00272.37\u0027"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _find_network_in_table(self, table):"},{"line_number":182,"context_line":"        # Example:"},{"line_number":183,"context_line":"        # +-----------------+-----------------------------------+"},{"line_number":184,"context_line":"        # |   Property      |               Value               |"},{"line_number":185,"context_line":"        # +-----------------+-----------------------------------+"},{"line_number":186,"context_line":"        # | private network |          192.168.154.128          |"},{"line_number":187,"context_line":"        # +-----------------+-----------------------------------+"},{"line_number":188,"context_line":"        for line in table.split(\u0027\\n\u0027):"},{"line_number":189,"context_line":"            if \u0027|\u0027 in line:"},{"line_number":190,"context_line":"                l_property, l_value \u003d line.split(\u0027|\u0027)[1:3]"},{"line_number":191,"context_line":"                if \u0027 network\u0027 in l_property.strip():"},{"line_number":192,"context_line":"                    return \u0027 \u0027.join(l_property.strip().split()[:-1])"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_boot_server_with_auto_network(self):"},{"line_number":195,"context_line":"        # Tests that the CLI defaults to \u0027auto\u0027 when --nic isn\u0027t specified."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_8a5bbef5","line":192,"range":{"start_line":181,"start_character":4,"end_line":192,"end_character":68},"in_reply_to":"9ad45d7e_94bae96c","updated":"2016-08-10 13:51:53.000000000","message":"Nope, this is a fuzzy match on the property name which is why I had to write this.","commit_id":"b925fbac2bfaa288e71b8bcfedd9c0c532c6135d"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"865caff80aef0ab82da37e5bcefc1e8470de2d9f","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_boot_server_with_auto_network(self):"},{"line_number":195,"context_line":"        # Tests that the CLI defaults to \u0027auto\u0027 when --nic isn\u0027t specified."},{"line_number":196,"context_line":"        server_info \u003d self.nova(\u0027boot\u0027, params\u003d("},{"line_number":197,"context_line":"            \u0027%(name)s --flavor %(flavor)s --poll \u0027"},{"line_number":198,"context_line":"            \u0027--image %(image)s \u0027 % {\u0027name\u0027: self.name_generate(\u0027server\u0027),"},{"line_number":199,"context_line":"                                    \u0027flavor\u0027: self.flavor.id,"},{"line_number":200,"context_line":"                                    \u0027image\u0027: self.image.id}))"},{"line_number":201,"context_line":"        server_id \u003d self._get_value_from_the_table(server_info, \u0027id\u0027)"},{"line_number":202,"context_line":"        self.addCleanup(self.wait_for_resource_delete,"},{"line_number":203,"context_line":"                        server_id, self.client.servers)"},{"line_number":204,"context_line":"        self.addCleanup(self.client.servers.delete, server_id)"},{"line_number":205,"context_line":"        # get the server details to verify there is a network, we don\u0027t care"},{"line_number":206,"context_line":"        # what the network name is, we just want to see an entry show up"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_b43c4de3","line":203,"range":{"start_line":196,"start_character":8,"end_line":203,"end_character":55},"updated":"2016-08-09 22:42:25.000000000","message":"can we extend/rework https://github.com/openstack/python-novaclient/blob/baeaf60e601d536b94552d3f477b78895df138f9/novaclient/tests/functional/base.py#L396 to reduce code duplication?","commit_id":"b925fbac2bfaa288e71b8bcfedd9c0c532c6135d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cee52f7757b274d9cc24a243fcbda180b6209384","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_boot_server_with_auto_network(self):"},{"line_number":195,"context_line":"        # Tests that the CLI defaults to \u0027auto\u0027 when --nic isn\u0027t specified."},{"line_number":196,"context_line":"        server_info \u003d self.nova(\u0027boot\u0027, params\u003d("},{"line_number":197,"context_line":"            \u0027%(name)s --flavor %(flavor)s --poll \u0027"},{"line_number":198,"context_line":"            \u0027--image %(image)s \u0027 % {\u0027name\u0027: self.name_generate(\u0027server\u0027),"},{"line_number":199,"context_line":"                                    \u0027flavor\u0027: self.flavor.id,"},{"line_number":200,"context_line":"                                    \u0027image\u0027: self.image.id}))"},{"line_number":201,"context_line":"        server_id \u003d self._get_value_from_the_table(server_info, \u0027id\u0027)"},{"line_number":202,"context_line":"        self.addCleanup(self.wait_for_resource_delete,"},{"line_number":203,"context_line":"                        server_id, self.client.servers)"},{"line_number":204,"context_line":"        self.addCleanup(self.client.servers.delete, server_id)"},{"line_number":205,"context_line":"        # get the server details to verify there is a network, we don\u0027t care"},{"line_number":206,"context_line":"        # what the network name is, we just want to see an entry show up"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_eafb5abf","line":203,"range":{"start_line":196,"start_character":8,"end_line":203,"end_character":55},"in_reply_to":"9ad45d7e_b43c4de3","updated":"2016-08-10 13:51:53.000000000","message":"No because that\u0027s going through the API, this is going through the CLI, much like the 2.32 functional test.","commit_id":"b925fbac2bfaa288e71b8bcfedd9c0c532c6135d"}],"novaclient/tests/unit/v2/test_servers.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a5a61f3e763519f099f81feb4037f87af80b6adf","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                \u0027/etc/passwd\u0027: \u0027some data\u0027,                 # a file"},{"line_number":139,"context_line":"                \u0027/tmp/foo.txt\u0027: six.StringIO(\u0027data\u0027),   # a stream"},{"line_number":140,"context_line":"            },"},{"line_number":141,"context_line":"            nics\u003dself._get_server_create_default_nics()"},{"line_number":142,"context_line":"        )"},{"line_number":143,"context_line":"        self.assert_request_id(s, fakes.FAKE_REQUEST_ID_LIST)"},{"line_number":144,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/servers\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_94e7db11","line":141,"updated":"2016-08-19 16:06:27.000000000","message":"attonit: nice to do a trailing comma.  You have it on some of these and not others, is the only reason I\u0027m mentioning it.","commit_id":"30070520c485d45b126943cbab33f8d33be5e877"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0b5bd130a1855d6ece0d2de125d07051da1cbea9","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                \u0027/etc/passwd\u0027: \u0027some data\u0027,                 # a file"},{"line_number":139,"context_line":"                \u0027/tmp/foo.txt\u0027: six.StringIO(\u0027data\u0027),   # a stream"},{"line_number":140,"context_line":"            },"},{"line_number":141,"context_line":"            nics\u003dself._get_server_create_default_nics()"},{"line_number":142,"context_line":"        )"},{"line_number":143,"context_line":"        self.assert_request_id(s, fakes.FAKE_REQUEST_ID_LIST)"},{"line_number":144,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/servers\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_6379c32f","line":141,"in_reply_to":"1ac06dbe_94e7db11","updated":"2016-08-19 17:55:00.000000000","message":"Yeah I did it on the ones that already had it, and not the others that didn\u0027t. I\u0027m consistent in the inconsistency.","commit_id":"30070520c485d45b126943cbab33f8d33be5e877"}],"novaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ce2777a90c89eafe3520d16dddc5944aaf91dcd8","unresolved":false,"context_lines":[{"line_number":3120,"context_line":"            32,  # doesn\u0027t require separate version-wrapped methods in"},{"line_number":3121,"context_line":"                 # novaclient"},{"line_number":3122,"context_line":"            34,  # doesn\u0027t require any changes in novaclient"},{"line_number":3123,"context_line":"            36,  # FIXME(mriedem): https://review.openstack.org/#/c/347514/"},{"line_number":3124,"context_line":"            37,  # There are no versioned wrapped shell method changes for this"},{"line_number":3125,"context_line":"        ])"},{"line_number":3126,"context_line":"        versions_supported \u003d set(range(0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_44d81af0","line":3123,"range":{"start_line":3123,"start_character":12,"end_line":3123,"end_character":75},"updated":"2016-08-19 15:01:00.000000000","message":"This shouldn\u0027t be in here, rebase fail.","commit_id":"dc25c5e631c5895d2c7fd1981ee41bc103ceaa4a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"40f46f980172a0561085c6625372123d5a0f49a6","unresolved":false,"context_lines":[{"line_number":3120,"context_line":"            32,  # doesn\u0027t require separate version-wrapped methods in"},{"line_number":3121,"context_line":"                 # novaclient"},{"line_number":3122,"context_line":"            34,  # doesn\u0027t require any changes in novaclient"},{"line_number":3123,"context_line":"            36,  # FIXME(mriedem): https://review.openstack.org/#/c/347514/"},{"line_number":3124,"context_line":"            37,  # There are no versioned wrapped shell method changes for this"},{"line_number":3125,"context_line":"        ])"},{"line_number":3126,"context_line":"        versions_supported \u003d set(range(0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_74485f2e","line":3123,"range":{"start_line":3123,"start_character":12,"end_line":3123,"end_character":75},"in_reply_to":"1ac06dbe_44d81af0","updated":"2016-08-19 15:59:09.000000000","message":"Heh, I was wondering :)","commit_id":"dc25c5e631c5895d2c7fd1981ee41bc103ceaa4a"}],"novaclient/v2/shell.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ce2777a90c89eafe3520d16dddc5944aaf91dcd8","unresolved":false,"context_lines":[{"line_number":632,"context_line":"    start_version\u003d\u00272.37\u0027,"},{"line_number":633,"context_line":"    help\u003d_(\"Create a NIC on the server. \""},{"line_number":634,"context_line":"           \"Specify option multiple times to create multiple nics. \""},{"line_number":635,"context_line":"           \"net-id: attach NIC to network with a specific UUID. There are two \""},{"line_number":636,"context_line":"           \"special values for net-id: \u0027auto\u0027 means automatically allocate \""},{"line_number":637,"context_line":"           \"network resources if none are available, and \u0027none\u0027 means do not \""},{"line_number":638,"context_line":"           \"allocate a network at all. Using \u0027auto\u0027 or \u0027none\u0027 cannot be \""},{"line_number":639,"context_line":"           \"specified with any other nic value and cannot be specified \""},{"line_number":640,"context_line":"           \"multiple times. \""},{"line_number":641,"context_line":"           \"net-name: attach NIC to network with this name \""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_849052ee","line":638,"range":{"start_line":635,"start_character":64,"end_line":638,"end_character":38},"updated":"2016-08-19 15:01:00.000000000","message":"Oops this is old info, \u0027auto\u0027 and \u0027none\u0027 are just standalone --nic values, not part of net-id anymore.","commit_id":"dc25c5e631c5895d2c7fd1981ee41bc103ceaa4a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8911e0bd1921aebfc4e5968168742bb92c6fbdc0","unresolved":false,"context_lines":[{"line_number":629,"context_line":"            \"v4-fixed-ip\u003dip-addr,v6-fixed-ip\u003dip-addr,tag\u003dtag\u003e\","},{"line_number":630,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":631,"context_line":"    dest\u003d\u0027nics\u0027,"},{"line_number":632,"context_line":"    default\u003d[],"},{"line_number":633,"context_line":"    start_version\u003d\u00272.37\u0027,"},{"line_number":634,"context_line":"    help\u003d_(\"Create a NIC on the server. \""},{"line_number":635,"context_line":"           \"Specify option multiple times to create multiple nics unless \""}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_c1aa3770","line":632,"range":{"start_line":632,"start_character":12,"end_line":632,"end_character":14},"updated":"2016-08-19 15:48:56.000000000","message":"hmm, I wonder what changing this to \u0027auto\u0027 does. Maybe that would allow me to not have to do the change on L272 above.","commit_id":"30070520c485d45b126943cbab33f8d33be5e877"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a5a61f3e763519f099f81feb4037f87af80b6adf","unresolved":false,"context_lines":[{"line_number":629,"context_line":"            \"v4-fixed-ip\u003dip-addr,v6-fixed-ip\u003dip-addr,tag\u003dtag\u003e\","},{"line_number":630,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":631,"context_line":"    dest\u003d\u0027nics\u0027,"},{"line_number":632,"context_line":"    default\u003d[],"},{"line_number":633,"context_line":"    start_version\u003d\u00272.37\u0027,"},{"line_number":634,"context_line":"    help\u003d_(\"Create a NIC on the server. \""},{"line_number":635,"context_line":"           \"Specify option multiple times to create multiple nics unless \""}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_d44e73c0","line":632,"range":{"start_line":632,"start_character":12,"end_line":632,"end_character":14},"in_reply_to":"1ac06dbe_c1aa3770","updated":"2016-08-19 16:06:27.000000000","message":"Unfortunately not.  The \u0027append\u0027 action seems to assume that the default is a list:\n\n    \u003e\u003e\u003e a \u003d argparse.ArgumentParser()\n    \u003e\u003e\u003e a.add_argument(\u0027--nic\u0027, action\u003d\u0027append\u0027, default\u003d\u0027auto\u0027)\n    \u003e\u003e\u003e args \u003d a.parse_args([\u0027--nic\u0027, \u0027a\u0027, \u0027--nic\u0027, \u0027b\u0027])\n    Traceback (most recent call last):\n    …\n      File \"/usr/lib64/python2.7/argparse.py\", line 930, in __call__\n        items.append(values)\n    AttributeError: \u0027str\u0027 object has no attribute \u0027append\u0027\n\nThat would be so convenient, though…","commit_id":"30070520c485d45b126943cbab33f8d33be5e877"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0b5bd130a1855d6ece0d2de125d07051da1cbea9","unresolved":false,"context_lines":[{"line_number":629,"context_line":"            \"v4-fixed-ip\u003dip-addr,v6-fixed-ip\u003dip-addr,tag\u003dtag\u003e\","},{"line_number":630,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":631,"context_line":"    dest\u003d\u0027nics\u0027,"},{"line_number":632,"context_line":"    default\u003d[],"},{"line_number":633,"context_line":"    start_version\u003d\u00272.37\u0027,"},{"line_number":634,"context_line":"    help\u003d_(\"Create a NIC on the server. \""},{"line_number":635,"context_line":"           \"Specify option multiple times to create multiple nics unless \""}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_83a31f9e","line":632,"range":{"start_line":632,"start_character":12,"end_line":632,"end_character":14},"in_reply_to":"1ac06dbe_d44e73c0","updated":"2016-08-19 17:55:00.000000000","message":"Oh I missed the append, yeah, then it has to be a list.","commit_id":"30070520c485d45b126943cbab33f8d33be5e877"}]}