)]}'
{"id":"openstack%2Fpython-novaclient~35419","triplet_id":"openstack%2Fpython-novaclient~master~I2018bc5b73ce86d6d5383958375d5dbbde2e763c","project":"openstack/python-novaclient","branch":"master","topic":"bug/1197191","hashtags":[],"change_id":"I2018bc5b73ce86d6d5383958375d5dbbde2e763c","subject":"make v2_auth and plugin_auth explictly return their results","status":"MERGED","created":"2013-07-02 23:52:08.000000000","updated":"2013-07-23 21:40:16.000000000","submitted":"2013-07-23 21:40:16.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a7ad9f23e5b7da33d9458e53bf5808e3ea057583","_number":35419,"virtual_id_number":35419,"owner":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},{"value":2,"date":"2013-07-23 21:40:16.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-07-16 19:33:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":2,"date":"2013-07-23 20:41:32.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"all":[{"value":0,"date":"2013-07-08 23:51:02.000000000","_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-07-16 19:33:07.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":1,"date":"2013-07-23 20:41:32.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-07-08 08:08:16.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2013-07-16 19:33:07.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-07-23 20:41:32.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-07-23 21:40:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a76a28d1101ef05a437ad59de6f6cc49a3e9cfff","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-03 00:45:29.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/35419/1/check/gate-python-novaclient-pep8/1728 : SUCCESS in 51s\n- http://docs-draft.openstack.org/35419/1/check/gate-python-novaclient-docs/1419/doc/build/html/ : SUCCESS in 1m 03s\n- http://logs.openstack.org/35419/1/check/gate-python-novaclient-python26/1518 : SUCCESS in 1m 39s\n- http://logs.openstack.org/35419/1/check/gate-python-novaclient-python27/1737 : SUCCESS in 1m 07s\n- http://logs.openstack.org/35419/1/check/gate-tempest-devstack-vm-full/28064 : SUCCESS in 53m 12s\n- http://logs.openstack.org/35419/1/check/gate-tempest-devstack-vm-postgres-full/27770 : SUCCESS in 47m 44s\n- http://logs.openstack.org/35419/1/check/gate-tempest-devstack-vm-quantum/35923 : SUCCESS in 17m 27s\n- http://logs.openstack.org/35419/1/check/gate-grenade-devstack-vm/14449 : FAILURE in 20m 59s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"88019450a5050ee8cda40df997499fee204c58f5","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-07-08 08:08:16.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nThis needs tests","accounts_in_message":[],"_revision_number":1},{"id":"b619b3dd7f74fff8879141d16dc7da46990a5fe8","author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"date":"2013-07-08 23:51:02.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4b991c0a3f0746dd00f25472a554c9cd20d17735","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-09 00:34:55.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/35419/2/check/gate-python-novaclient-pep8/1749 : SUCCESS in 41s\n- http://docs-draft.openstack.org/35419/2/check/gate-python-novaclient-docs/1440/doc/build/html/ : SUCCESS in 45s\n- http://logs.openstack.org/35419/2/check/gate-python-novaclient-python26/1539 : SUCCESS in 2m 44s\n- http://logs.openstack.org/35419/2/check/gate-python-novaclient-python27/1758 : SUCCESS in 59s\n- http://logs.openstack.org/35419/2/check/gate-tempest-devstack-vm-full/29468 : SUCCESS in 41m 22s\n- http://logs.openstack.org/35419/2/check/gate-tempest-devstack-vm-postgres-full/29174 : SUCCESS in 43m 47s\n- http://logs.openstack.org/35419/2/check/gate-tempest-devstack-vm-neutron/582 : SUCCESS in 20m 30s\n- http://logs.openstack.org/35419/2/check/gate-grenade-devstack-vm/15694 : FAILURE in 10m 38s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"745280c50745dc1f858d58032aae4ebba37fbbf0","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-07-16 19:33:07.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"bb8df5987a9079cbcedf792078eccb1d3d106709","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-23 20:41:32.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"b7ecd6915a6529fdc2e54ee89f7b1363bcc2a2dc","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-07-23 20:41:32.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"12ebc988c77a6223226736ab7e7c1f756528f55f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-23 21:40:16.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/19/35419/2/gate/gate-python-novaclient-docs/1502/doc/build/html/ : SUCCESS in 1m 12s\n- http://logs.openstack.org/19/35419/2/gate/gate-python-novaclient-pep8/1811 : SUCCESS in 1m 00s\n- http://logs.openstack.org/19/35419/2/gate/gate-python-novaclient-python26/1597 : SUCCESS in 1m 58s\n- http://logs.openstack.org/19/35419/2/gate/gate-python-novaclient-python27/1820 : SUCCESS in 1m 46s\n- http://logs.openstack.org/19/35419/2/gate/gate-tempest-devstack-vm-full/34873 : SUCCESS in 46m 20s\n- http://logs.openstack.org/19/35419/2/gate/gate-tempest-devstack-vm-postgres-full/34563 : SUCCESS in 58m 39s\n- http://logs.openstack.org/19/35419/2/gate/gate-tempest-devstack-vm-neutron/6751 : SUCCESS in 19m 26s (non-voting)\n- http://logs.openstack.org/19/35419/2/gate/gate-grenade-devstack-vm/20526 : SUCCESS in 28m 01s\n","accounts_in_message":[],"_revision_number":2},{"id":"c7243d0737387158dcb9162d2717b490951a1908","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-23 21:40:16.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"912288c4862e4023cb1952ce3e37453dc5cff883","revisions":{"1fcfe74a64b6cef6e81170528bf8efff5085e601":{"kind":"REWORK","_number":1,"created":"2013-07-02 23:52:08.000000000","uploader":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"ref":"refs/changes/19/35419/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/19/35419/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/19/35419/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/19/35419/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/19/35419/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/19/35419/1"}}},"commit":{"parents":[{"commit":"e3dfc5a40711122841302f9de2f701dcc9f88b6f","subject":"Merge \"python3: Compatibility for iteritems differences\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e3dfc5a40711122841302f9de2f701dcc9f88b6f"}]}],"author":{"name":"Nicolas Simonds","email":"nic@metacloud.com","date":"2013-07-02 23:49:03.000000000","tz":-420},"committer":{"name":"Nicolas Simonds","email":"nic@metacloud.com","date":"2013-07-02 23:49:03.000000000","tz":-420},"subject":"make v2_auth and plugin_auth explictly return their results","message":"make v2_auth and plugin_auth explictly return their results\n\nIn cases where the respective authentication methods return\nnon-NoneTypes, (e.g., HTTP 305 redirects) they would get dropped\non the floor previously.\n\nChange-Id: I2018bc5b73ce86d6d5383958375d5dbbde2e763c\nFixes: Bug 1197191\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/1fcfe74a64b6cef6e81170528bf8efff5085e601"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/1fcfe74a64b6cef6e81170528bf8efff5085e601"}]},"branch":"refs/heads/master"},"912288c4862e4023cb1952ce3e37453dc5cff883":{"kind":"REWORK","_number":2,"created":"2013-07-08 23:51:02.000000000","uploader":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"ref":"refs/changes/19/35419/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/19/35419/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/19/35419/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/19/35419/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/19/35419/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/19/35419/2"}}},"commit":{"parents":[{"commit":"5c8616d03ecc271a79c6c41ce54bfbf719bb940f","subject":"Merge \"python3: Fix print statements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5c8616d03ecc271a79c6c41ce54bfbf719bb940f"}]}],"author":{"name":"Nicolas Simonds","email":"nic@metacloud.com","date":"2013-07-02 23:49:03.000000000","tz":-420},"committer":{"name":"Nicolas Simonds","email":"nic@metacloud.com","date":"2013-07-08 23:49:04.000000000","tz":-420},"subject":"make v2_auth and plugin_auth explictly return their results","message":"make v2_auth and plugin_auth explictly return their results\n\nIn cases where the respective authentication methods return\nnon-NoneTypes, (e.g., HTTP 305 redirects) they would get dropped\non the floor previously.\n\nThis patch set splits the test_auth_redirect unit test into two\nnearly-identical unit tests to exercise the different code paths.\nWithout the patch, the test_v2_auth_redirect unit test fails with\nan HTTP 401 error\n\nChange-Id: I2018bc5b73ce86d6d5383958375d5dbbde2e763c\nFixes: Bug 1197191\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/912288c4862e4023cb1952ce3e37453dc5cff883"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/912288c4862e4023cb1952ce3e37453dc5cff883"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}