)]}'
{"novaclient/tests/functional/base.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5158542846200a3d85c7f21ef18cc314014ab480","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        self.client \u003d novaclient.client.Client(\"2\", session\u003dsession)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        global SERVER_API_VERSIONS"},{"line_number":209,"context_line":"        if SERVER_API_VERSIONS is None:"},{"line_number":210,"context_line":"            version \u003d self.client.versions.get_current()"},{"line_number":211,"context_line":"            if not hasattr(version, \u0027version\u0027) or not version.version:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_d04b295e","line":208,"updated":"2016-08-18 21:45:40.000000000","message":"Can we throw this stuff into a helper method or something? The setUp method is getting pretty big.","commit_id":"c35737de880f0be4df906f7eb483dcfd154e03da"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c2e353c8313113e2780f1b045cacd14995307e31","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        self.client \u003d novaclient.client.Client(\"2\", session\u003dsession)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        global SERVER_API_VERSIONS"},{"line_number":209,"context_line":"        if SERVER_API_VERSIONS is None:"},{"line_number":210,"context_line":"            version \u003d self.client.versions.get_current()"},{"line_number":211,"context_line":"            if not hasattr(version, \u0027version\u0027) or not version.version:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_58e2c9a0","line":208,"in_reply_to":"3ac371cc_d04b295e","updated":"2016-08-19 12:09:42.000000000","message":"Done","commit_id":"c35737de880f0be4df906f7eb483dcfd154e03da"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5158542846200a3d85c7f21ef18cc314014ab480","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                SERVER_API_VERSIONS \u003d ("},{"line_number":217,"context_line":"                    novaclient.api_versions.APIVersion(version.version),"},{"line_number":218,"context_line":"                    novaclient.api_versions.APIVersion(version.min_version))"},{"line_number":219,"context_line":"        if self.COMPUTE_API_VERSION:"},{"line_number":220,"context_line":"            v \u003d novaclient.api_versions.APIVersion(self.COMPUTE_API_VERSION)"},{"line_number":221,"context_line":"            if not v.matches(*SERVER_API_VERSIONS):"},{"line_number":222,"context_line":"                msg \u003d (\"%s is not supported by Nova-API.\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_3036fde7","line":219,"updated":"2016-08-18 21:45:40.000000000","message":"nit: put a newline above this to separate the code blocks a bit.","commit_id":"c35737de880f0be4df906f7eb483dcfd154e03da"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5158542846200a3d85c7f21ef18cc314014ab480","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                    novaclient.api_versions.APIVersion(version.version),"},{"line_number":218,"context_line":"                    novaclient.api_versions.APIVersion(version.min_version))"},{"line_number":219,"context_line":"        if self.COMPUTE_API_VERSION:"},{"line_number":220,"context_line":"            v \u003d novaclient.api_versions.APIVersion(self.COMPUTE_API_VERSION)"},{"line_number":221,"context_line":"            if not v.matches(*SERVER_API_VERSIONS):"},{"line_number":222,"context_line":"                msg \u003d (\"%s is not supported by Nova-API.\" %"},{"line_number":223,"context_line":"                       self.COMPUTE_API_VERSION)"},{"line_number":224,"context_line":"                if not (SERVER_API_VERSIONS[0].is_null() and"},{"line_number":225,"context_line":"                        SERVER_API_VERSIONS[1].is_null()):"},{"line_number":226,"context_line":"                    msg +\u003d \" Supported versions: %s - %s\" % ("},{"line_number":227,"context_line":"                        SERVER_API_VERSIONS[0].get_string(),"},{"line_number":228,"context_line":"                        SERVER_API_VERSIONS[1].get_string())"},{"line_number":229,"context_line":"                self.skipTest(msg)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        if self.COMPUTE_API_VERSION \u003d\u003d \"2.latest\":"},{"line_number":232,"context_line":"            self.client.api_version \u003d SERVER_API_VERSIONS[1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_506739ea","line":229,"range":{"start_line":220,"start_character":12,"end_line":229,"end_character":34},"updated":"2016-08-18 21:45:40.000000000","message":"Something is wrong in this logic, see:\n\nhttp://logs.openstack.org/80/357180/2/check/gate-novaclient-dsvm-functional-mitaka-nv/3438d77/console.html#_2016-08-18_17_49_12_603327\n\nIt\u0027s skipping a test saying 2.1 isn\u0027t supported, which it has to be in mitaka.","commit_id":"c35737de880f0be4df906f7eb483dcfd154e03da"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c2e353c8313113e2780f1b045cacd14995307e31","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                    novaclient.api_versions.APIVersion(version.version),"},{"line_number":218,"context_line":"                    novaclient.api_versions.APIVersion(version.min_version))"},{"line_number":219,"context_line":"        if self.COMPUTE_API_VERSION:"},{"line_number":220,"context_line":"            v \u003d novaclient.api_versions.APIVersion(self.COMPUTE_API_VERSION)"},{"line_number":221,"context_line":"            if not v.matches(*SERVER_API_VERSIONS):"},{"line_number":222,"context_line":"                msg \u003d (\"%s is not supported by Nova-API.\" %"},{"line_number":223,"context_line":"                       self.COMPUTE_API_VERSION)"},{"line_number":224,"context_line":"                if not (SERVER_API_VERSIONS[0].is_null() and"},{"line_number":225,"context_line":"                        SERVER_API_VERSIONS[1].is_null()):"},{"line_number":226,"context_line":"                    msg +\u003d \" Supported versions: %s - %s\" % ("},{"line_number":227,"context_line":"                        SERVER_API_VERSIONS[0].get_string(),"},{"line_number":228,"context_line":"                        SERVER_API_VERSIONS[1].get_string())"},{"line_number":229,"context_line":"                self.skipTest(msg)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        if self.COMPUTE_API_VERSION \u003d\u003d \"2.latest\":"},{"line_number":232,"context_line":"            self.client.api_version \u003d SERVER_API_VERSIONS[1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_f86c550a","line":229,"range":{"start_line":220,"start_character":12,"end_line":229,"end_character":34},"in_reply_to":"3ac371cc_506739ea","updated":"2016-08-19 12:09:42.000000000","message":"I put min and max versions in wrong order...","commit_id":"c35737de880f0be4df906f7eb483dcfd154e03da"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f947337e09f3bf5569d3165aa4c2197a63dee440","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            else:"},{"line_number":245,"context_line":"                USE_NEUTRON \u003d False"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def _get_novaclient(self, session):"},{"line_number":248,"context_line":"        nc \u003d novaclient.client.Client(\"2\", session\u003dsession)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        if self.COMPUTE_API_VERSION:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_61dd4342","line":247,"updated":"2016-08-19 15:46:33.000000000","message":"Can\u0027t we re-use this in here so we can avoid a lot of this duplicated logic?\n\nhttps://github.com/openstack/python-novaclient/blob/c3b5365cdf2500a5bd1d4c2bb940d2b4e394fc02/novaclient/api_versions.py#L258","commit_id":"9c5c8a685be9ca1ca1e2f7bad93e339e12c66a37"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"94f281c746bf726c42a577af94e8cf1379f30218","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            if SERVER_API_VERSIONS is None:"},{"line_number":253,"context_line":"                # Obtain supported versions by API side"},{"line_number":254,"context_line":"                v \u003d nc.versions.get_current()"},{"line_number":255,"context_line":"                if not hasattr(v, \u0027version\u0027) or not v.version:"},{"line_number":256,"context_line":"                    # API doesn\u0027t support microversions"},{"line_number":257,"context_line":"                    SERVER_API_VERSIONS \u003d ("},{"line_number":258,"context_line":"                        novaclient.api_versions.APIVersion(\"2.0\"),"},{"line_number":259,"context_line":"                        novaclient.api_versions.APIVersion(\"2.0\"))"},{"line_number":260,"context_line":"                else:"},{"line_number":261,"context_line":"                    SERVER_API_VERSIONS \u003d ("},{"line_number":262,"context_line":"                        novaclient.api_versions.APIVersion(v.min_version),"},{"line_number":263,"context_line":"                        novaclient.api_versions.APIVersion(v.version))"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"            if self.COMPUTE_API_VERSION \u003d\u003d \"2.latest\":"},{"line_number":266,"context_line":"                requested_version \u003d min(novaclient.API_MAX_VERSION,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_c1518a64","line":263,"range":{"start_line":255,"start_character":3,"end_line":263,"end_character":70},"updated":"2016-08-19 20:11:56.000000000","message":"https://github.com/openstack/python-novaclient/blob/c3b5365cdf2500a5bd1d4c2bb940d2b4e394fc02/novaclient/api_versions.py#L249\n\nseems at least this can be reused","commit_id":"9c5c8a685be9ca1ca1e2f7bad93e339e12c66a37"}]}