)]}'
{"novaclient/tests/functional/base.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"23066dceb85f40f1e7278f00b213c23b65cbbb8d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    firstImage \u003d None"},{"line_number":64,"context_line":"    for image in images:"},{"line_number":65,"context_line":"        firstImage \u003d firstImage or image"},{"line_number":66,"context_line":"        if image.name.startswith(\u0027cirros\u0027) and image.name.endswith(\u0027-uec\u0027):"},{"line_number":67,"context_line":"            return image"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    if firstImage:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_e27475d0","line":66,"range":{"start_line":66,"start_character":47,"end_line":66,"end_character":74},"updated":"2016-08-20 12:34:08.000000000","message":"Based on:\n\nhttps://review.openstack.org/#/c/338435/6/stackrc\n\nI\u0027d probably use:\n\nif image.name.startswith(\u0027cirros\u0027) and (image.name.endswith(\u0027-uec\u0027) or image.name.endswith(\u0027-disk.img\u0027)):","commit_id":"91838a111002a65922e8812f6852a841ded83aff"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"d0886adafb866fcdb1dfcb451a2c38cd60a78d8b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            return image"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    if firstImage:"},{"line_number":70,"context_line":"        return firstImage"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    raise NoImageException()"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_1b25e1aa","line":70,"updated":"2016-08-19 14:16:20.000000000","message":"What\u0027s the reason \"images[0]\" won\u0027t work?","commit_id":"91838a111002a65922e8812f6852a841ded83aff"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"23066dceb85f40f1e7278f00b213c23b65cbbb8d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            return image"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    if firstImage:"},{"line_number":70,"context_line":"        return firstImage"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    raise NoImageException()"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_227fadab","line":70,"in_reply_to":"1ac06dbe_1b25e1aa","updated":"2016-08-20 12:34:08.000000000","message":"I guess in case images is []?","commit_id":"91838a111002a65922e8812f6852a841ded83aff"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c5a5636cc4eccdb22ad491dd7087dad9473396ee","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    # We didn\u0027t find the specific cirros image we\u0027d like to use, so just use"},{"line_number":70,"context_line":"    # the first available."},{"line_number":71,"context_line":"    if images:"},{"line_number":72,"context_line":"        return images[0]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    raise NoImageException()"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_0925dfbf","line":72,"range":{"start_line":72,"start_character":15,"end_line":72,"end_character":24},"updated":"2016-08-29 14:52:13.000000000","message":"Ukesh pointed out on the stable branch changes that this is a generator and [0] won\u0027t work, I would need to test that out and see locally. Will try to do that before releasing novaclient 6.0.0.","commit_id":"01de5a9f68ad474e9bfa213ffeb3501066a52ebd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"95046df4a8283817110b88bf79becefd960254e1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    # We didn\u0027t find the specific cirros image we\u0027d like to use, so just use"},{"line_number":70,"context_line":"    # the first available."},{"line_number":71,"context_line":"    if images:"},{"line_number":72,"context_line":"        return images[0]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    raise NoImageException()"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_747ba28c","line":72,"range":{"start_line":72,"start_character":15,"end_line":72,"end_character":24},"in_reply_to":"fa7ab95a_0925dfbf","updated":"2016-08-29 14:54:04.000000000","message":"Ah yup:\n\nhttps://github.com/openstack/python-glanceclient/blob/master/glanceclient/v2/images.py#L176","commit_id":"01de5a9f68ad474e9bfa213ffeb3501066a52ebd"}]}
