)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"98098ca257949282decd4a88d87318622ffc2f4b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Viswesuwara Nathan \u003cviswesn@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-29 23:22:10 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The incorrect output of \"nova show\" when VM has long user data fixed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7f4869d743f7bf9ff653183a5767134c796c440a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_14440819","line":7,"updated":"2016-08-29 18:04:35.000000000","message":"I\u0027d like to see a little more in the commit message to explain the purpose of the commit.  Please see [1] for more details on how we like commit messages formatted.  Particular critiques I have: The summary could be a little shorter (e.g., \u0027Fix incorrect output of \"nova show\" for long user data\u0027), there should be a more detailed paragraph, and if this is a bug fix, there should be a reference to the bug included among the footers.\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"1d3f991d2752f38e65287c1af50b6b12396be1e9"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"eab786cd7fb204be184d8affcc3375fba775fd63","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix incorrect output of \"nova show\" for long user data"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New argument \"--wrap\" is added for \"nova show\" command to wrap"},{"line_number":10,"context_line":"the output. The default wrap length is set to 80 now."},{"line_number":11,"context_line":"Usage: nova show --wrap 60 \u003cserver-id\u003e"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"closes-bug: 1616415"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a89bdaa_5e3c842f","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":52},"updated":"2016-09-03 05:37:28.000000000","message":"This isn\u0027t accurate anymore.","commit_id":"cac07531e894f5a5d3d14f3d7b83e74bd6b2cd35"}],"novaclient/v2/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"98098ca257949282decd4a88d87318622ffc2f4b","unresolved":false,"context_lines":[{"line_number":2245,"context_line":"    help\u003d_(\u0027Wrap the output to a specified length, or 0 to disable.\u0027))"},{"line_number":2246,"context_line":"def do_show(cs, args):"},{"line_number":2247,"context_line":"    \"\"\"Show details about the given server.\"\"\""},{"line_number":2248,"context_line":"    _print_server(cs, args, wrap\u003dint(args.wrap))"},{"line_number":2249,"context_line":""},{"line_number":2250,"context_line":""},{"line_number":2251,"context_line":"@utils.arg("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_34faec75","line":2248,"updated":"2016-08-29 18:04:35.000000000","message":"I realize you\u0027re going by examples elsewhere in shell.py, but honestly the argument should be specified as \u0027type\u003dint\u0027 so that conversion to int is handled by argparse.  Advantages include having argparse report non-integer values as command syntax errors, rather than having an obscure ValueError thrown in the code itself.\n\nThis also makes me think we may need to regularize how text wrapping is handled throughout novaclient.  I\u0027ve found that \"nova diagnostics\" hard-codes 80 columns, \"nova hypervisor-show\" defaults to 40 columns, and \"nova credentials\" defaults to 64 columns.  Further, I know there are ways of determining the screen column width, and that seems to me to be a good way of picking a default, if those ways turn out to be feasible.  All of this is by way of brainstorming about future changes to novaclient occasioned by your change, rather than things I intend for you to work on, btw; the only change I expect you to make (besides the commit message) is adding \"type\u003dint\" to the @utils.arg() decorator call.","commit_id":"1d3f991d2752f38e65287c1af50b6b12396be1e9"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"81fb94a6eb1971451c9c009cf033a3d5adc5c49a","unresolved":false,"context_lines":[{"line_number":2245,"context_line":"    help\u003d_(\u0027Wrap the output to a specified length, or 0 to disable.\u0027))"},{"line_number":2246,"context_line":"def do_show(cs, args):"},{"line_number":2247,"context_line":"    \"\"\"Show details about the given server.\"\"\""},{"line_number":2248,"context_line":"    _print_server(cs, args, wrap\u003dint(args.wrap))"},{"line_number":2249,"context_line":""},{"line_number":2250,"context_line":""},{"line_number":2251,"context_line":"@utils.arg("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_5b22fba3","line":2248,"updated":"2016-08-30 15:48:55.000000000","message":"This cast to int is now unnecessary; that was the point behind adding \"type\u003dint\" to the @utils.arg() for --wrap.","commit_id":"f0d2949b3de3180650667909a8978514efa02549"}]}