)]}'
{"id":"openstack%2Fpython-novaclient~37202","triplet_id":"openstack%2Fpython-novaclient~master~Ib1ae54f7d13d0ca579dd264e8d0d7630770e92d6","project":"openstack/python-novaclient","branch":"master","topic":"bug/1191874","hashtags":[],"change_id":"Ib1ae54f7d13d0ca579dd264e8d0d7630770e92d6","subject":"recognize 429 as an rate limiting status","status":"MERGED","created":"2013-07-16 09:38:17.000000000","updated":"2013-07-26 08:40:03.000000000","submitted":"2013-07-26 08:40:02.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"eabe9989adaaa762c079f53bafdad0251367c77c","_number":37202,"virtual_id_number":37202,"owner":{"_account_id":2967,"name":"ljjjustin","email":"iamljj@gmail.com","username":"ljjjustin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},{"value":2,"date":"2013-07-26 08:40:02.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2967,"name":"ljjjustin","email":"iamljj@gmail.com","username":"ljjjustin"},{"value":0,"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},{"value":0,"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"recommended":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"all":[{"value":1,"date":"2013-07-23 08:47:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-07-17 15:46:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2967,"name":"ljjjustin","email":"iamljj@gmail.com","username":"ljjjustin"},{"value":1,"date":"2013-07-17 15:55:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},{"value":1,"date":"2013-07-25 01:24:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":2,"date":"2013-07-26 07:39:41.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":0,"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-07-17 15:46:02.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2013-07-17 02:32:45.000000000","_account_id":2967,"name":"ljjjustin","email":"iamljj@gmail.com","username":"ljjjustin"},{"value":0,"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},{"value":0,"date":"2013-07-17 03:15:12.000000000","_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":1,"date":"2013-07-26 07:39:41.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2967,"name":"ljjjustin","email":"iamljj@gmail.com","username":"ljjjustin"},{"value":0,"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},{"value":0,"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"_account_id":2967,"name":"ljjjustin","email":"iamljj@gmail.com","username":"ljjjustin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-07-17 03:15:12.000000000","updated_by":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"reviewer":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"state":"REVIEWER"},{"updated":"2013-07-17 15:46:02.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-07-17 15:55:02.000000000","updated_by":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"reviewer":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"state":"REVIEWER"},{"updated":"2013-07-23 08:47:14.000000000","updated_by":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"reviewer":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"state":"REVIEWER"},{"updated":"2013-07-26 07:39:41.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2013-07-26 08:40:02.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d57e3e4ddeaa737b392d45034cd3e086ab04c56c","author":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"date":"2013-07-16 10:18:45.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nI think you should first change the nova api to return correct\nhttp code. \n\nnow nova api return http 413 by RequestBodySizeLimiter middleware nova/api/sizelimit.py.\n\nhttp code 429 should be returned by RateLimitingMiddleware, but it seems it won\u0027t right now.","accounts_in_message":[],"_revision_number":1},{"id":"21674383ed4b3723e827945283ac8eadff78ce3a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-16 10:24:03.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/37202/1/check/gate-python-novaclient-pep8/1770 : SUCCESS in 52s\n- http://docs-draft.openstack.org/37202/1/check/gate-python-novaclient-docs/1461/doc/build/html/ : SUCCESS in 1m 11s\n- http://logs.openstack.org/37202/1/check/gate-python-novaclient-python26/1556 : SUCCESS in 1m 36s\n- http://logs.openstack.org/37202/1/check/gate-python-novaclient-python27/1779 : SUCCESS in 1m 11s\n- http://logs.openstack.org/37202/1/check/gate-tempest-devstack-vm-full/32523 : SUCCESS in 43m 34s\n- http://logs.openstack.org/37202/1/check/gate-tempest-devstack-vm-cells-full/546 : FAILURE in 14m 07s (non-voting)\n- http://logs.openstack.org/37202/1/check/gate-tempest-devstack-vm-postgres-full/32215 : SUCCESS in 45m 40s\n- http://logs.openstack.org/37202/1/check/gate-tempest-devstack-vm-neutron/4064 : FAILURE in 17m 51s (non-voting)\n- http://logs.openstack.org/37202/1/check/gate-grenade-devstack-vm/18429 : FAILURE in 17m 23s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"da038958ef3501ee075477cd55c74e03f9d4e588","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-07-16 15:25:48.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nnovaclient must maintain backwards compatibility, too.  You will have to accept both 413 and 429, regardless of what changes may be made to nova in the future.","accounts_in_message":[],"_revision_number":1},{"id":"668e9f5a7f6da8f5da14b3541b41296af1aa8246","author":{"_account_id":2967,"name":"ljjjustin","email":"iamljj@gmail.com","username":"ljjjustin"},"date":"2013-07-17 02:32:45.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b3d27037ee582d5ee3654f0de7006c03d0c1f8cf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-17 03:34:20.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/37202/2/check/gate-python-novaclient-pep8/1778 : SUCCESS in 1m 26s\n- http://docs-draft.openstack.org/37202/2/check/gate-python-novaclient-docs/1469/doc/build/html/ : SUCCESS in 59s\n- http://logs.openstack.org/37202/2/check/gate-python-novaclient-python26/1564 : SUCCESS in 1m 49s\n- http://logs.openstack.org/37202/2/check/gate-python-novaclient-python27/1787 : SUCCESS in 1m 03s\n- http://logs.openstack.org/37202/2/check/gate-tempest-devstack-vm-full/32911 : SUCCESS in 1h 00m 24s\n- http://logs.openstack.org/37202/2/check/gate-tempest-devstack-vm-cells-full/817 : FAILURE in 19m 07s (non-voting)\n- http://logs.openstack.org/37202/2/check/gate-tempest-devstack-vm-postgres-full/32603 : SUCCESS in 48m 57s\n- http://logs.openstack.org/37202/2/check/gate-tempest-devstack-vm-neutron/4503 : FAILURE in 21m 22s (non-voting)\n- http://logs.openstack.org/37202/2/check/gate-grenade-devstack-vm/18770 : SUCCESS in 28m 08s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"d6678541c0b5656d0b57148ef86232b169acd1ce","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-07-17 15:46:02.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"3cbd8262e4b1316ad342edd9c90e878f03c20e23","author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"date":"2013-07-17 15:55:02.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"4ee1a68ba0a187a73dc684ee8aa53509fd3ddd49","author":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"date":"2013-07-23 08:47:14.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"d33cafe9d7517b457b1531248b2669b7a99beef1","author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"date":"2013-07-25 01:24:42.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"57310b13d69e8f58d620e6ba8f87ee0b766bbca3","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2013-07-26 07:39:41.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"1a80ddc83842db94c30ee51711a1ab54f629236c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-26 07:39:42.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"e3845729e5154f5fd0595b4027bbd7aa089b1cb0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-26 08:40:02.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/02/37202/2/gate/gate-python-novaclient-docs/1506/doc/build/html/ : SUCCESS in 1m 22s\n- http://logs.openstack.org/02/37202/2/gate/gate-python-novaclient-pep8/1815 : SUCCESS in 55s\n- http://logs.openstack.org/02/37202/2/gate/gate-python-novaclient-python26/1601 : SUCCESS in 2m 02s\n- http://logs.openstack.org/02/37202/2/gate/gate-python-novaclient-python27/1824 : SUCCESS in 59s\n- http://logs.openstack.org/02/37202/2/gate/gate-tempest-devstack-vm-full/35812 : SUCCESS in 58m 21s\n- http://logs.openstack.org/02/37202/2/gate/gate-tempest-devstack-vm-postgres-full/35499 : SUCCESS in 1h 00m 17s\n- http://logs.openstack.org/02/37202/2/gate/gate-tempest-devstack-vm-neutron/7826 : SUCCESS in 18m 53s (non-voting)\n- http://logs.openstack.org/02/37202/2/gate/gate-grenade-devstack-vm/21376 : SUCCESS in 22m 24s\n","accounts_in_message":[],"_revision_number":2},{"id":"bc6ff4d0e0b7973215bbdd6cdb70b75342c6334d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-26 08:40:03.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1b5ed91650c7797fea0701112f95413183fef321","revisions":{"6e3a13c80f4fe2e9bef286eaeda8095a89b898f9":{"kind":"REWORK","_number":1,"created":"2013-07-16 09:38:17.000000000","uploader":{"_account_id":2967,"name":"ljjjustin","email":"iamljj@gmail.com","username":"ljjjustin"},"ref":"refs/changes/02/37202/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/02/37202/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/37202/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/37202/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/37202/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/02/37202/1"}}},"commit":{"parents":[{"commit":"74506b83fedf72de90fd56bb7a978676700e7180","subject":"Merge \"CLI for disable service reason\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/74506b83fedf72de90fd56bb7a978676700e7180"}]}],"author":{"name":"Jiajun Liu","email":"jiajun@unitedstack.com","date":"2013-07-16 09:35:42.000000000","tz":0},"committer":{"name":"Jiajun Liu","email":"jiajun@unitedstack.com","date":"2013-07-16 09:38:06.000000000","tz":0},"subject":"recognize 429 as an rate limiting status","message":"recognize 429 as an rate limiting status\n\ncurrently novaclient recognize 413 as rate limiting status while\nit shoule be 429 according to HTTP protocol.\n\nfixes bug 1191874\n\nChange-Id: Ib1ae54f7d13d0ca579dd264e8d0d7630770e92d6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6e3a13c80f4fe2e9bef286eaeda8095a89b898f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6e3a13c80f4fe2e9bef286eaeda8095a89b898f9"}]},"branch":"refs/heads/master"},"1b5ed91650c7797fea0701112f95413183fef321":{"kind":"REWORK","_number":2,"created":"2013-07-17 02:32:45.000000000","uploader":{"_account_id":2967,"name":"ljjjustin","email":"iamljj@gmail.com","username":"ljjjustin"},"ref":"refs/changes/02/37202/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/02/37202/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/37202/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/37202/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/37202/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/02/37202/2"}}},"commit":{"parents":[{"commit":"74506b83fedf72de90fd56bb7a978676700e7180","subject":"Merge \"CLI for disable service reason\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/74506b83fedf72de90fd56bb7a978676700e7180"}]}],"author":{"name":"Jiajun Liu","email":"jiajun@unitedstack.com","date":"2013-07-16 09:35:42.000000000","tz":0},"committer":{"name":"Jiajun Liu","email":"jiajun@unitedstack.com","date":"2013-07-17 02:32:29.000000000","tz":0},"subject":"recognize 429 as an rate limiting status","message":"recognize 429 as an rate limiting status\n\ncurrently novaclient recognize 413 as rate limiting status while\nit shoule be 429 according to HTTP protocol.\n\nfixes bug 1191874\n\nChange-Id: Ib1ae54f7d13d0ca579dd264e8d0d7630770e92d6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/1b5ed91650c7797fea0701112f95413183fef321"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/1b5ed91650c7797fea0701112f95413183fef321"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}