)]}'
{"id":"openstack%2Fpython-novaclient~373946","triplet_id":"openstack%2Fpython-novaclient~master~I9cb81acddb54909dbcd6d65547dbd9408069f289","project":"openstack/python-novaclient","branch":"master","topic":"bug/1475722","hashtags":[],"change_id":"I9cb81acddb54909dbcd6d65547dbd9408069f289","subject":"Replace MagicMock with Mock class","status":"ABANDONED","created":"2016-09-21 09:20:07.000000000","updated":"2016-12-09 21:03:50.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"136fb83183adc644fb134a2312e6f03d30751d36","_number":373946,"virtual_id_number":373946,"owner":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":-1,"date":"2016-09-21 10:30:09.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"date":"2016-12-09 21:03:50.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"disliked":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"all":[{"value":-1,"date":"2016-09-21 13:39:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2016-09-21 15:03:28.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":-2,"date":"2016-09-21 20:03:51.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-21 10:30:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-09-21 13:39:11.000000000","updated_by":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"reviewer":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"state":"REVIEWER"},{"updated":"2016-09-21 15:03:28.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-09-21 20:03:51.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2016-12-09 21:03:50.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"}],"messages":[{"id":"209a6f3808bbb5a891da35efab7f1753446bf9d8","author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"date":"2016-09-21 09:20:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0966b0672cd0c5e0d95853bdc2eeae0b52ff25ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-21 10:30:09.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/46/373946/1/check/gate-python-novaclient-docs-ubuntu-xenial/5d23f16//doc/build/html/ : SUCCESS in 2m 31s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/46/373946/1/check/gate-python-novaclient-pep8-ubuntu-xenial/c9192ee/ : SUCCESS in 2m 20s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/46/373946/1/check/gate-python-novaclient-python27-ubuntu-xenial/efe69fe/ : FAILURE in 2m 44s\n- gate-python-novaclient-python34 http://logs.openstack.org/46/373946/1/check/gate-python-novaclient-python34/330d69f/ : FAILURE in 2m 42s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/46/373946/1/check/gate-python-novaclient-python35-nv/581bbbd/ : FAILURE in 3m 44s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/46/373946/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/8f1d146/ : SUCCESS in 1h 06m 38s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/46/373946/1/check/gate-novaclient-dsvm-functional/037d52a/ : SUCCESS in 29m 06s\n- gate-novaclient-dsvm-functional-mitaka-nv http://logs.openstack.org/46/373946/1/check/gate-novaclient-dsvm-functional-mitaka-nv/8bfb771/ : SUCCESS in 37m 58s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/46/373946/1/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/4d2926e/ : SUCCESS in 49m 31s (non-voting)\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/46/373946/1/check/gate-novaclient-dsvm-functional-neutron/63904e4/ : SUCCESS in 51m 28s","accounts_in_message":[],"_revision_number":1},{"id":"de25711879016c6d42dfacb977de89e58f39ef60","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2016-09-21 13:39:11.000000000","message":"Patch Set 1: Code-Review-1\n\nThis breaks tests and is not part of a legitimate bug.","accounts_in_message":[],"_revision_number":1},{"id":"8e454e077496c2bb28f4b439324eb562548aa079","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-09-21 15:03:28.000000000","message":"Patch Set 1: Code-Review-1\n\nWhile the test failures are probably simple to resolve (probably a single case where MagicMock could be retained), this produces a lot of code churn for no apparent benefit.","accounts_in_message":[],"_revision_number":1},{"id":"51839ccbaa3a88901b9f4fd73d03b4bd99599cf2","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-09-21 20:03:51.000000000","message":"Patch Set 1: Code-Review-2\n\nSee: http://lists.openstack.org/pipermail/openstack-dev/2016-September/104178.html","accounts_in_message":[],"_revision_number":1},{"id":"284c5b0a04c4346bdc60963f042618087d3749b9","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-12-09 21:03:50.000000000","message":"Abandoned\n\nThis review is \u003e 6 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1},{"id":"862da24987a5616799b5fb44c9e69a448200ec22","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-12-09 21:03:50.000000000","message":"Patch Set 1:\n\nThis review is \u003e 6 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ada9195e5eed0c545794485b8e22a0639fb9f543","revisions":{"ada9195e5eed0c545794485b8e22a0639fb9f543":{"kind":"REWORK","_number":1,"created":"2016-09-21 09:20:07.000000000","uploader":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"ref":"refs/changes/46/373946/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/46/373946/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/46/373946/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/46/373946/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/46/373946/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/46/373946/1"}}},"commit":{"parents":[{"commit":"707105db8a9876b65aaefde958392f57ca989d26","subject":"Merge \"Fix \u0027UnicodeEncodeError\u0027 for unicode values\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/707105db8a9876b65aaefde958392f57ca989d26"}]}],"author":{"name":"Sharat Sharma","email":"sharat.sharma@nectechnologies.in","date":"2016-09-21 09:18:32.000000000","tz":330},"committer":{"name":"Sharat Sharma","email":"sharat.sharma@nectechnologies.in","date":"2016-09-21 09:19:36.000000000","tz":330},"subject":"Replace MagicMock with Mock class","message":"Replace MagicMock with Mock class\n\nMagicMock magically allow things to pass. Any usage should be\nreplaced with the Mock class and explicit attributes should\nbe set on it.\n\nChange-Id: I9cb81acddb54909dbcd6d65547dbd9408069f289\nCloses-Bug: #1475722\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ada9195e5eed0c545794485b8e22a0639fb9f543"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ada9195e5eed0c545794485b8e22a0639fb9f543"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}