)]}'
{"id":"openstack%2Fpython-novaclient~374720","triplet_id":"openstack%2Fpython-novaclient~master~I051dff5e7b940ea36800952f7a82c7e9c2348866","project":"openstack/python-novaclient","branch":"master","topic":"assertisnone","hashtags":[],"change_id":"I051dff5e7b940ea36800952f7a82c7e9c2348866","subject":"Using assertIsNone() instead of assertIs(None, ..)","status":"ABANDONED","created":"2016-09-22 11:20:50.000000000","updated":"2016-12-09 21:00:45.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3aeab9e0ed78a19d0738f3b0cd7353af5f32703f","_number":374720,"virtual_id_number":374720,"owner":{"_account_id":21428,"name":"JiWei","email":"17366060309@163.com","username":"WeiJi"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2016-10-21 11:26:21.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-09-22 14:43:45.000000000","_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"date":"2016-09-22 15:16:41.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"date":"2016-12-09 21:00:44.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2016-09-22 14:43:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-22 14:43:45.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2016-09-22 15:16:41.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-10-21 11:26:21.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-12-09 21:00:44.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"}],"messages":[{"id":"db290ea0a0b37c182721b0b8796b098243ab91ca","author":{"_account_id":21428,"name":"JiWei","email":"17366060309@163.com","username":"WeiJi"},"date":"2016-09-22 11:20:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dd63e6f19b26a6a7d540c71ef2483498442b63da","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-22 12:24:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/20/374720/1/check/gate-python-novaclient-docs-ubuntu-xenial/86a9561//doc/build/html/ : SUCCESS in 1m 30s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/20/374720/1/check/gate-python-novaclient-pep8-ubuntu-xenial/55a5f6f/ : SUCCESS in 1m 34s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/20/374720/1/check/gate-python-novaclient-python27-ubuntu-xenial/076e2f5/ : SUCCESS in 2m 03s\n- gate-python-novaclient-python34 http://logs.openstack.org/20/374720/1/check/gate-python-novaclient-python34/6248a71/ : SUCCESS in 2m 42s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/20/374720/1/check/gate-python-novaclient-python35-nv/94d626e/ : SUCCESS in 2m 51s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/20/374720/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/9d9896f/ : SUCCESS in 1h 00m 09s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/20/374720/1/check/gate-novaclient-dsvm-functional/2544fe7/ : SUCCESS in 28m 12s\n- gate-novaclient-dsvm-functional-mitaka-nv http://logs.openstack.org/20/374720/1/check/gate-novaclient-dsvm-functional-mitaka-nv/36690f1/ : SUCCESS in 39m 17s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/20/374720/1/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/4a05e88/ : SUCCESS in 30m 20s (non-voting)\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/20/374720/1/check/gate-novaclient-dsvm-functional-neutron/bbb0cb6/ : SUCCESS in 35m 40s","accounts_in_message":[],"_revision_number":1},{"id":"ebee03cb3ddd56b4ce1a46fa41808e4e0d7bdf49","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2016-09-22 14:43:45.000000000","message":"Patch Set 1:\n\nThis is fixed in upstream hacking - you should enable it in tox:\n\n    https://github.com/openstack-dev/hacking/commit/7c360d21c7ffc14656dd8d578ec266ec139e6814","accounts_in_message":[],"_revision_number":1},{"id":"e88b7ef6c8166d6b82aa5b200782836b763fce7c","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2016-09-22 14:43:48.000000000","message":"Patch Set 1: Code-Review-1","accounts_in_message":[],"_revision_number":1},{"id":"5ad12ea85a6c33ec067506ea52d40480077532e2","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-09-22 15:16:41.000000000","message":"Patch Set 1:\n\nAgreed, let\u0027s enable the tox check if we\u0027re going to insist on this.","accounts_in_message":[],"_revision_number":1},{"id":"057cd4015265fca90702a07dc896b4bfe4e451a4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-21 11:26:21.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"7f670956eed698a82c0481970c17f9c3fdaef97b","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-12-09 21:00:44.000000000","message":"Patch Set 1:\n\nThis review is \u003e 6 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1},{"id":"052c849f689ff7a1ce9b114a82c2c7c27453dc08","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-12-09 21:00:45.000000000","message":"Abandoned\n\nThis review is \u003e 6 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c2a5e78767d68bccb8b641a21c039dbb85a189a5","revisions":{"c2a5e78767d68bccb8b641a21c039dbb85a189a5":{"kind":"REWORK","_number":1,"created":"2016-09-22 11:20:50.000000000","uploader":{"_account_id":21428,"name":"JiWei","email":"17366060309@163.com","username":"WeiJi"},"ref":"refs/changes/20/374720/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/20/374720/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/20/374720/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/20/374720/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/20/374720/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/20/374720/1"}}},"commit":{"parents":[{"commit":"c0e7785427660ff26bdf7d013b46769699110327","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c0e7785427660ff26bdf7d013b46769699110327"}]}],"author":{"name":"Ji-Wei","email":"ji.wei3@zte.com.cn","date":"2016-09-22 13:00:11.000000000","tz":480},"committer":{"name":"Ji-Wei","email":"ji.wei3@zte.com.cn","date":"2016-09-22 13:01:03.000000000","tz":480},"subject":"Using assertIsNone() instead of assertIs(None, ..)","message":"Using assertIsNone() instead of assertIs(None, ..)\n\nFollowing OpenStack Style Guidelines[1]:\nhttp://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises\n[H203] Unit test assertions tend to give better messages for more\nspecific assertions. As a result, assertIsNone(...) is preferred\nover assertEqual(None, ...) and assertIs(..,None)\n\nChange-Id: I051dff5e7b940ea36800952f7a82c7e9c2348866\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c2a5e78767d68bccb8b641a21c039dbb85a189a5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c2a5e78767d68bccb8b641a21c039dbb85a189a5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}