)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e5b982ffb93a0a1302471aaadf616bec1c661edb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use /resources instead of /resources/detail to resolve"},{"line_number":10,"context_line":"the resource ID out of the name and load the resource"},{"line_number":11,"context_line":"details in a separate step."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"fixes bug #1202179"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2Fe8A%3D","line":11,"updated":"2013-07-17 15:56:04.000000000","message":"Expand the commit message a little bit; I had to refer to the bug report to see why this change you propose is advantageous.","commit_id":"84d79f56c00a675ed7a170301a9a4233e9078157"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"4389b88e129b13e2faa1a31deb36f011d76fe38d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use /resources instead of /resources/detail to resolve"},{"line_number":10,"context_line":"the resource ID out of the name and load the resource"},{"line_number":11,"context_line":"details in a separate step."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"fixes bug #1202179"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2FevA%3D","line":11,"in_reply_to":"AAAAP3%2F%2Fe8A%3D","updated":"2013-07-17 16:28:09.000000000","message":"Will add the details of the bug report here and will also add a note that this patch doesn\u0027t solve the issue in general.","commit_id":"84d79f56c00a675ed7a170301a9a4233e9078157"}],"novaclient/base.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e5b982ffb93a0a1302471aaadf616bec1c661edb","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        detailed \u003d True"},{"line_number":203,"context_line":"        if \u0027detailed\u0027 in inspect.getargspec(self.list).args:"},{"line_number":204,"context_line":"            detailed \u003d not (\"human_id\" in kwargs or \\"},{"line_number":205,"context_line":"                            \"name\" in kwargs or \\"},{"line_number":206,"context_line":"                            \"display_name\" in kwargs)"},{"line_number":207,"context_line":"            listing \u003d self.list(detailed\u003ddetailed)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fe7o%3D","line":204,"updated":"2013-07-17 15:56:04.000000000","message":"The backslashes are unneeded when you\u0027re using parentheses like this.  Also, we discourage the use of parentheses in most instances.","commit_id":"84d79f56c00a675ed7a170301a9a4233e9078157"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"4389b88e129b13e2faa1a31deb36f011d76fe38d","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        detailed \u003d True"},{"line_number":203,"context_line":"        if \u0027detailed\u0027 in inspect.getargspec(self.list).args:"},{"line_number":204,"context_line":"            detailed \u003d not (\"human_id\" in kwargs or \\"},{"line_number":205,"context_line":"                            \"name\" in kwargs or \\"},{"line_number":206,"context_line":"                            \"display_name\" in kwargs)"},{"line_number":207,"context_line":"            listing \u003d self.list(detailed\u003ddetailed)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FevI%3D","line":204,"in_reply_to":"AAAAP3%2F%2Fe7o%3D","updated":"2013-07-17 16:28:09.000000000","message":"Will fix this. Do you prefer removing the parentheses or the slashes?","commit_id":"84d79f56c00a675ed7a170301a9a4233e9078157"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e5b982ffb93a0a1302471aaadf616bec1c661edb","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                    if detailed:"},{"line_number":216,"context_line":"                        found.append(obj)"},{"line_number":217,"context_line":"                    else:"},{"line_number":218,"context_line":"                        found.append(self.get(obj.id))"},{"line_number":219,"context_line":"            except AttributeError:"},{"line_number":220,"context_line":"                continue"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fe6c%3D","line":218,"updated":"2013-07-17 15:56:04.000000000","message":"I thought the bug was that we\u0027re getting the whole list then filtering it on the client side, leading to performance problems?  This does not appear to change that behavior; as far as I can tell, it just ensures that we ask for details if the list() operation supports it and human_id, name, and display_name are not in the search criteria (?)","commit_id":"84d79f56c00a675ed7a170301a9a4233e9078157"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"4389b88e129b13e2faa1a31deb36f011d76fe38d","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                    if detailed:"},{"line_number":216,"context_line":"                        found.append(obj)"},{"line_number":217,"context_line":"                    else:"},{"line_number":218,"context_line":"                        found.append(self.get(obj.id))"},{"line_number":219,"context_line":"            except AttributeError:"},{"line_number":220,"context_line":"                continue"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FevQ%3D","line":218,"in_reply_to":"AAAAP3%2F%2Fe6c%3D","updated":"2013-07-17 16:28:09.000000000","message":"At the moment we always fetch all details of the resources. If there are a lot of resources this results in a big overhead. With this patch we only fetch a list with the names and IDs of the resources and if we have a match we also fetch the whole resource.\n\nDetails are not requested when human_id, name or display_name is set in the kwargs. Because if set we want to resolve the ID of the resource by it\u0027s name.","commit_id":"84d79f56c00a675ed7a170301a9a4233e9078157"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"d7d2a050a40614025b1cf10b963f579e04fdeb11","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        detailed \u003d True"},{"line_number":210,"context_line":"        if \u0027detailed\u0027 in inspect.getargspec(self.list).args:"},{"line_number":211,"context_line":"            detailed \u003d \"human_id\" not in kwargs and \\"},{"line_number":212,"context_line":"                       \"name\" not in kwargs and \\"},{"line_number":213,"context_line":"                       \"display_name\" not in kwargs"},{"line_number":214,"context_line":"            listing \u003d self.list(detailed\u003ddetailed)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F%2F5I%3D","line":211,"updated":"2013-07-17 18:53:19.000000000","message":"Bah, I misstated in my earlier comment; it is *backslashes* we discourage, not parentheses.  I probably meant to say something along the lines of, \"We encourage using parentheses so that backslashes can be eliminated.\"  Sorry for the confusion on that…","commit_id":"3b25a51c50029e3e12b8e066f5b0bc0bc03f4fb4"}]}