)]}'
{"id":"openstack%2Fpython-novaclient~37835","triplet_id":"openstack%2Fpython-novaclient~master~I9adfb699775d2d8f8ca45a7a28621e634bc03055","project":"openstack/python-novaclient","branch":"master","topic":"bug/1202920","hashtags":[],"change_id":"I9adfb699775d2d8f8ca45a7a28621e634bc03055","subject":"Add name argument to hypervisor commands","status":"MERGED","created":"2013-07-19 03:56:37.000000000","updated":"2013-07-26 09:28:55.000000000","submitted":"2013-07-26 09:28:55.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c395aefaf852b1cf5e5b69186b550f4b8a667fbd","_number":37835,"virtual_id_number":37835,"owner":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-07-26 09:28:55.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-07-22 16:03:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":1,"date":"2013-07-22 12:16:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":2,"date":"2013-07-26 07:44:51.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-07-22 16:03:01.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":1,"date":"2013-07-26 07:44:51.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-07-22 12:16:27.000000000","updated_by":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"reviewer":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"state":"REVIEWER"},{"updated":"2013-07-22 16:03:01.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-07-26 07:44:51.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2013-07-26 09:28:55.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5bc4c44f3f06224eb2d333afe8f212e504c0c6a3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-19 04:54:42.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/37835/1/check/gate-python-novaclient-pep8/1789 : SUCCESS in 55s\n- http://docs-draft.openstack.org/37835/1/check/gate-python-novaclient-docs/1480/doc/build/html/ : SUCCESS in 1m 04s\n- http://logs.openstack.org/37835/1/check/gate-python-novaclient-python26/1575 : SUCCESS in 1m 27s\n- http://logs.openstack.org/37835/1/check/gate-python-novaclient-python27/1798 : SUCCESS in 1m 12s\n- http://logs.openstack.org/37835/1/check/gate-tempest-devstack-vm-full/33720 : SUCCESS in 57m 03s\n- http://logs.openstack.org/37835/1/check/gate-tempest-devstack-vm-cells-full/1420 : FAILURE in 14m 02s (non-voting)\n- http://logs.openstack.org/37835/1/check/gate-tempest-devstack-vm-testr-full/273 : SUCCESS in 28m 48s (non-voting)\n- http://logs.openstack.org/37835/1/check/gate-tempest-devstack-vm-postgres-full/33410 : SUCCESS in 58m 01s\n- http://logs.openstack.org/37835/1/check/gate-tempest-devstack-vm-neutron/5459 : FAILURE in 17m 44s (non-voting)\n- http://logs.openstack.org/37835/1/check/gate-grenade-devstack-vm/19473 : SUCCESS in 22m 06s\n","accounts_in_message":[],"_revision_number":1},{"id":"e6fd2deef576f785125998519c5aedadf25ae844","author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"date":"2013-07-19 09:14:03.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nThis change results in the client making two calls to  \"os-hypervisors/detail\"  both of which return details of all hypervisors in the system from which the client then filters the one that it wants.  On a large system that can mean getting the details of 1000\u0027s of hypervisors \n\nIf you really want the convenience of using a name instead of an ID then I think the client should be doing the work to get the list, translate the name to the ID, and then get the details via the ID","accounts_in_message":[],"_revision_number":1},{"id":"74a048d5d9bdbf8682afd99bd38465d866497293","author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"date":"2013-07-19 11:06:13.000000000","message":"Patch Set 1:\n\nThanks for review, Phil,\n\nIf the specified hypervisor is an ID(int), utils.find_resource() calls to \"/os-hypervisors/\u003cID\u003e\".\nThat gets only detail of one hypervisor:\n\nnovaclient/utils.py\n 195 def find_resource(manager, name_or_id):\n 196     \"\"\"Helper for the _find_* methods.\"\"\"\n 197     # first try to get entity as integer id\n 198     try:\n 199         return manager.get(int(name_or_id))\n\nnovaclient/v1_1/hypervisors.py\n 32 class HypervisorManager(base.ManagerWithFind):\n [..]\n 54\n 55     def get(self, hypervisor):\n 56         \"\"\"\n 57         Get a specific hypervisor.\n 58         \"\"\"\n 59         return self._get(\"/os-hypervisors/%s\" % base.getid(hypervisor),\n 60                          \"hypervisor\")\n \nSo I don\u0027t think its workload is so bigger than current one if specifying an ID as its argument.\n\nOn the other hand, if the specified hypervisor is a name, utils.find_resource() calls to \"/os-hypervisors/detail\".\nOn a large system, that results in more workload as you said.\nbut I feel many people execute \"nova hypervisor-list\" command currently before \"nova hypervisor-uptime\" to get its id.\nso the workload on client side will be almost same in real world, I think..","accounts_in_message":[],"_revision_number":1},{"id":"d0437dc72f0c595c850a254d3616f6519199eb6c","author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"date":"2013-07-19 16:05:30.000000000","message":"Patch Set 1:\n\nOK - you won me over :-)\n\nDoes need some unit tests though","accounts_in_message":[],"_revision_number":1},{"id":"f0d8969d1c38b85c0527295ff701bf7f3eddf85d","author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"date":"2013-07-22 00:48:29.000000000","message":"Patch Set 1:\n\nThanks, I see.\nI will add some unittests to next patch.","accounts_in_message":[],"_revision_number":1},{"id":"c416aa56832461d545b7683332aa397d0492f2be","author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"date":"2013-07-22 00:51:15.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"de0b174c52a9b81a8d3747d3d63ad7497ea1c60d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-22 01:48:03.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/35/37835/2/check/gate-python-novaclient-pep8/1803 : SUCCESS in 1m 12s\n- http://docs-draft.openstack.org/35/37835/2/check/gate-python-novaclient-docs/1494/doc/build/html/ : SUCCESS in 47s\n- http://logs.openstack.org/35/37835/2/check/gate-python-novaclient-python26/1589 : SUCCESS in 1m 55s\n- http://logs.openstack.org/35/37835/2/check/gate-python-novaclient-python27/1812 : SUCCESS in 1m 11s\n- http://logs.openstack.org/35/37835/2/check/gate-tempest-devstack-vm-full/34242 : SUCCESS in 45m 17s\n- http://logs.openstack.org/35/37835/2/check/gate-tempest-devstack-vm-cells-full/1857 : FAILURE in 13m 37s (non-voting)\n- http://logs.openstack.org/35/37835/2/check/gate-tempest-devstack-vm-testr-full/705 : FAILURE in 24m 25s (non-voting)\n- http://logs.openstack.org/35/37835/2/check/gate-tempest-devstack-vm-postgres-full/33932 : SUCCESS in 56m 44s\n- http://logs.openstack.org/35/37835/2/check/gate-tempest-devstack-vm-neutron/6041 : SUCCESS in 20m 22s (non-voting)\n- http://logs.openstack.org/35/37835/2/check/gate-grenade-devstack-vm/19944 : SUCCESS in 24m 37s\n","accounts_in_message":[],"_revision_number":2},{"id":"9163efdef874c2e38093b58122a8c31241fa0152","author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"date":"2013-07-22 12:16:27.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"c80323e38b51a6c7c186c42a0a6d86b422fec8e4","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-07-22 16:03:01.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"dde02d618c5c9dcb92d7d65027fcdb351ea1e37c","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2013-07-26 07:44:51.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"c70b919ec93c3da4df68898c1a1a68f9f047e233","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-26 07:44:52.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"bbb5fdab3554e975af4cf0995a878cc4f2f075d9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-26 09:28:55.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"99412a652dbfd2e4c944fed1123d14721af1b0e9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-26 09:28:55.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/35/37835/2/gate/gate-python-novaclient-docs/1511/doc/build/html/ : SUCCESS in 1m 05s\n- http://logs.openstack.org/35/37835/2/gate/gate-python-novaclient-pep8/1820 : SUCCESS in 56s\n- http://logs.openstack.org/35/37835/2/gate/gate-python-novaclient-python26/1606 : SUCCESS in 1m 56s\n- http://logs.openstack.org/35/37835/2/gate/gate-python-novaclient-python27/1829 : SUCCESS in 1m 16s\n- http://logs.openstack.org/35/37835/2/gate/gate-tempest-devstack-vm-full/35828 : SUCCESS in 47m 58s\n- http://logs.openstack.org/35/37835/2/gate/gate-tempest-devstack-vm-postgres-full/35515 : SUCCESS in 48m 46s\n- http://logs.openstack.org/35/37835/2/gate/gate-tempest-devstack-vm-neutron/7846 : SUCCESS in 20m 00s (non-voting)\n- http://logs.openstack.org/35/37835/2/gate/gate-grenade-devstack-vm/21392 : SUCCESS in 23m 26s\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"de250bf170517ae187b14c4c19912964631b4a0e","revisions":{"f9f4183ec2279eb5d8e2a0d6d1aa535eb5433013":{"kind":"REWORK","_number":1,"created":"2013-07-19 03:56:37.000000000","uploader":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"ref":"refs/changes/35/37835/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/35/37835/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/35/37835/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/35/37835/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/35/37835/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/35/37835/1"}}},"commit":{"parents":[{"commit":"32f38fe19e7be3a2fd5ca9116f03c42984a4eb0b","subject":"Merge \"Allow tenant ID for authentication\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/32f38fe19e7be3a2fd5ca9116f03c42984a4eb0b"}]}],"author":{"name":"Ken\u0027ichi Ohmichi","email":"oomichi@mxs.nes.nec.co.jp","date":"2013-07-19 03:29:49.000000000","tz":540},"committer":{"name":"Ken\u0027ichi Ohmichi","email":"oomichi@mxs.nes.nec.co.jp","date":"2013-07-19 03:52:45.000000000","tz":540},"subject":"Add name argument to hypervisor commands","message":"Add name argument to hypervisor commands\n\nFixes #Bug 1202920\n\nThis patch adds name arguments to the following subcommands:\n * hypervisor-show\n * hypervisor-uptime\n\nChange-Id: I9adfb699775d2d8f8ca45a7a28621e634bc03055\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f9f4183ec2279eb5d8e2a0d6d1aa535eb5433013"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f9f4183ec2279eb5d8e2a0d6d1aa535eb5433013"}]},"branch":"refs/heads/master"},"de250bf170517ae187b14c4c19912964631b4a0e":{"kind":"REWORK","_number":2,"created":"2013-07-22 00:51:15.000000000","uploader":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"ref":"refs/changes/35/37835/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/35/37835/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/35/37835/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/35/37835/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/35/37835/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/35/37835/2"}}},"commit":{"parents":[{"commit":"f702c25d4364583d6532bf11b2cce1107994bcce","subject":"Fix backwards-incompatible API change (method signature)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f702c25d4364583d6532bf11b2cce1107994bcce"}]}],"author":{"name":"Ken\u0027ichi Ohmichi","email":"oomichi@mxs.nes.nec.co.jp","date":"2013-07-19 03:29:49.000000000","tz":540},"committer":{"name":"Ken\u0027ichi Ohmichi","email":"oomichi@mxs.nes.nec.co.jp","date":"2013-07-22 00:44:53.000000000","tz":540},"subject":"Add name argument to hypervisor commands","message":"Add name argument to hypervisor commands\n\nFixes #Bug 1202920\n\nThis patch adds name arguments to the following subcommands:\n * hypervisor-show\n * hypervisor-uptime\n\nChange-Id: I9adfb699775d2d8f8ca45a7a28621e634bc03055\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/de250bf170517ae187b14c4c19912964631b4a0e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/de250bf170517ae187b14c4c19912964631b4a0e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}