)]}'
{"id":"openstack%2Fpython-novaclient~381498","triplet_id":"openstack%2Fpython-novaclient~master~Ie91daeb5f0c241eb83b77c04ac1b12e431d6671c","project":"openstack/python-novaclient","branch":"master","topic":"requests-mock-2","hashtags":[],"change_id":"Ie91daeb5f0c241eb83b77c04ac1b12e431d6671c","subject":"Replace requests mocking with requests-mock","status":"MERGED","created":"2016-10-04 08:12:02.000000000","updated":"2016-10-05 16:44:31.000000000","submitted":"2016-10-05 16:44:31.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"54642da5605c10710abb2287385cbd5f26628082","_number":381498,"virtual_id_number":381498,"owner":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-10-05 16:44:31.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-10-05 15:39:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":2,"date":"2016-10-05 08:38:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-10-05 15:39:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-05 08:38:03.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2016-10-05 15:39:24.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-10-05 16:44:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b88f988fbfe323cfcbac58016bdcddecdd938045","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2016-10-04 08:12:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f2cb4b7b3f89b5979ca7d917c52823a086455369","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-04 09:16:12.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/98/381498/1/check/gate-python-novaclient-docs-ubuntu-xenial/917cd9b//doc/build/html/ : SUCCESS in 2m 04s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/98/381498/1/check/gate-python-novaclient-pep8-ubuntu-xenial/d9b6743/ : SUCCESS in 1m 39s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/98/381498/1/check/gate-python-novaclient-python27-ubuntu-xenial/1af433a/ : FAILURE in 2m 19s\n- gate-python-novaclient-python34 http://logs.openstack.org/98/381498/1/check/gate-python-novaclient-python34/a2efb03/ : FAILURE in 1m 47s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/98/381498/1/check/gate-python-novaclient-python35-nv/36cef30/ : FAILURE in 2m 09s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/98/381498/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/c10df2e/ : SUCCESS in 42m 42s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/98/381498/1/check/gate-novaclient-dsvm-functional/cf57774/ : SUCCESS in 28m 19s\n- gate-novaclient-dsvm-functional-mitaka-nv http://logs.openstack.org/98/381498/1/check/gate-novaclient-dsvm-functional-mitaka-nv/e068e43/ : SUCCESS in 33m 45s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/98/381498/1/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/fa9916b/ : SUCCESS in 28m 30s (non-voting)\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/98/381498/1/check/gate-novaclient-dsvm-functional-neutron/a2e904b/ : SUCCESS in 1h 03m 33s","accounts_in_message":[],"_revision_number":1},{"id":"ad1e97b71a57454a70baa312ed620a39b030c29c","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-10-04 15:53:47.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nThese two patches seem a little more intertwined than they should be, given that \"Clean up requests-mock usage\" makes a one-line change to test_client.py, when the bulk of those changes are here.  That\u0027s just my first impression, though…","accounts_in_message":[],"_revision_number":1},{"id":"377cd28329622812e65a0ef558475420b80a7a3e","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2016-10-04 19:47:04.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"883f24eff93a516e0a2573647d9313b9bd239961","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2016-10-04 19:54:08.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"51cf098401e2906f243e1e00f1e60af13ca225a6","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2016-10-04 19:54:17.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9081e6b03f29dc4d8c494d9432564e6f02e4c463","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-04 20:58:40.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/98/381498/3/check/gate-python-novaclient-docs-ubuntu-xenial/3b577be//doc/build/html/ : SUCCESS in 2m 55s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/98/381498/3/check/gate-python-novaclient-pep8-ubuntu-xenial/c3ea3a6/ : SUCCESS in 1m 46s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/98/381498/3/check/gate-python-novaclient-python27-ubuntu-xenial/eed8e7f/ : SUCCESS in 1m 58s\n- gate-python-novaclient-python34 http://logs.openstack.org/98/381498/3/check/gate-python-novaclient-python34/d19a99b/ : SUCCESS in 2m 04s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/98/381498/3/check/gate-python-novaclient-python35-nv/3f05863/ : SUCCESS in 2m 47s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/98/381498/3/check/gate-tempest-dsvm-neutron-src-python-novaclient/b37ab33/ : SUCCESS in 42m 57s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/98/381498/3/check/gate-novaclient-dsvm-functional/68aea17/ : SUCCESS in 29m 02s\n- gate-novaclient-dsvm-functional-mitaka-nv http://logs.openstack.org/98/381498/3/check/gate-novaclient-dsvm-functional-mitaka-nv/d50228d/ : SUCCESS in 25m 11s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/98/381498/3/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/34a4972/ : SUCCESS in 28m 13s (non-voting)\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/98/381498/3/check/gate-novaclient-dsvm-functional-neutron/7b0f0ab/ : SUCCESS in 1h 04m 00s","accounts_in_message":[],"_revision_number":3},{"id":"6416537ff9249e151ca9e5e13a94a94cc94386e6","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-10-05 08:38:03.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"7f68c2444af681ed698eb6e7899b5f2ce94ef6b3","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-10-05 15:39:24.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"9b4c36e170ceeefd64f4f40711532a960dc401a1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-05 15:39:35.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"380d66b9e0d68cd2f0ec120d589c8b10e6da8f77","date":"2016-10-05 16:44:31.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"3ea3076e1bac4f39533133a9b1c92b102a47e5a6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-05 16:44:31.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/98/381498/3/gate/gate-python-novaclient-docs-ubuntu-xenial/014ffc4//doc/build/html/ : SUCCESS in 1m 38s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/98/381498/3/gate/gate-python-novaclient-pep8-ubuntu-xenial/dbd3be2/ : SUCCESS in 2m 48s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/98/381498/3/gate/gate-python-novaclient-python27-ubuntu-xenial/7f456e0/ : SUCCESS in 1m 59s\n- gate-python-novaclient-python34 http://logs.openstack.org/98/381498/3/gate/gate-python-novaclient-python34/a13ce20/ : SUCCESS in 2m 05s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/98/381498/3/gate/gate-tempest-dsvm-neutron-src-python-novaclient/1eb1e38/ : SUCCESS in 53m 16s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/98/381498/3/gate/gate-novaclient-dsvm-functional/1a1a4c6/ : SUCCESS in 28m 27s\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/98/381498/3/gate/gate-novaclient-dsvm-functional-neutron/ee5b5a2/ : SUCCESS in 1h 04m 33s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"749fee334604d0c06dc398c38cb19c51dedb8214","revisions":{"f63d4688e3852e2abe87d8c9ef5d3b0321164c9c":{"kind":"REWORK","_number":1,"created":"2016-10-04 08:12:02.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/98/381498/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/98/381498/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/98/381498/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/98/381498/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/98/381498/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/98/381498/1"}}},"commit":{"parents":[{"commit":"cad8f803bf50b28c2fcb42ee01c98b40dcd68112","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/cad8f803bf50b28c2fcb42ee01c98b40dcd68112"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-10-04 07:59:28.000000000","tz":660},"committer":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-10-04 08:04:06.000000000","tz":660},"subject":"Replace requests mocking with requests-mock","message":"Replace requests mocking with requests-mock\n\nThe novaclient tests are broken with the master (unreleased) branch of\nrequests. This is because most of the mocking that novaclient does with\nrequests in insufficient.\n\nRequests-mock is for exactly this purpose and is already widely used in\nnovaclient so replace using mock with requests-mock where appropriate.\n\nCloses-Bug: #1630157\nChange-Id: Ie91daeb5f0c241eb83b77c04ac1b12e431d6671c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f63d4688e3852e2abe87d8c9ef5d3b0321164c9c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f63d4688e3852e2abe87d8c9ef5d3b0321164c9c"}]},"branch":"refs/heads/master"},"864836022d4ab77719087c4178cd6726b30bf772":{"kind":"REWORK","_number":2,"created":"2016-10-04 19:47:04.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/98/381498/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/98/381498/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/98/381498/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/98/381498/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/98/381498/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/98/381498/2"}}},"commit":{"parents":[{"commit":"cad8f803bf50b28c2fcb42ee01c98b40dcd68112","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/cad8f803bf50b28c2fcb42ee01c98b40dcd68112"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-10-04 07:59:28.000000000","tz":660},"committer":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-10-04 19:46:48.000000000","tz":660},"subject":"Replace requests mocking with requests-mock","message":"Replace requests mocking with requests-mock\n\nThe novaclient tests are broken with the master (unreleased) branch of\nrequests. This is because most of the mocking that novaclient does with\nrequests in insufficient.\n\nRequests-mock is for exactly this purpose and is already widely used in\nnovaclient so replace using mock with requests-mock where appropriate.\n\nCloses-Bug: #1630157\nChange-Id: Ie91daeb5f0c241eb83b77c04ac1b12e431d6671c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/864836022d4ab77719087c4178cd6726b30bf772"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/864836022d4ab77719087c4178cd6726b30bf772"}]},"branch":"refs/heads/master"},"749fee334604d0c06dc398c38cb19c51dedb8214":{"kind":"REWORK","_number":3,"created":"2016-10-04 19:54:17.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/98/381498/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/98/381498/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/98/381498/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/98/381498/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/98/381498/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/98/381498/3"}}},"commit":{"parents":[{"commit":"cad8f803bf50b28c2fcb42ee01c98b40dcd68112","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/cad8f803bf50b28c2fcb42ee01c98b40dcd68112"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-10-04 07:59:28.000000000","tz":660},"committer":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-10-04 19:53:05.000000000","tz":660},"subject":"Replace requests mocking with requests-mock","message":"Replace requests mocking with requests-mock\n\nThe novaclient tests are broken with the master (unreleased) branch of\nrequests. This is because most of the mocking that novaclient does with\nrequests in insufficient.\n\nRequests-mock is for exactly this purpose and is already widely used in\nnovaclient so replace using mock with requests-mock where appropriate.\n\nCloses-Bug: #1630157\nChange-Id: Ie91daeb5f0c241eb83b77c04ac1b12e431d6671c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/749fee334604d0c06dc398c38cb19c51dedb8214"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/749fee334604d0c06dc398c38cb19c51dedb8214"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}