)]}'
{"id":"openstack%2Fpython-novaclient~381499","triplet_id":"openstack%2Fpython-novaclient~master~Id61b88c53478d49f91c3f880ed5b90d638051ba0","project":"openstack/python-novaclient","branch":"master","topic":"requests-mock-2","hashtags":[],"change_id":"Id61b88c53478d49f91c3f880ed5b90d638051ba0","subject":"Clean up requests-mock usage","status":"MERGED","created":"2016-10-04 08:12:02.000000000","updated":"2016-10-05 16:44:45.000000000","submitted":"2016-10-05 16:44:45.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ba79babe7c13afc88e8fd681af90567850ff4068","_number":381499,"virtual_id_number":381499,"owner":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-10-05 16:44:44.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-10-05 15:42:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2016-10-05 08:37:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-10-05 15:42:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-05 08:37:07.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2016-10-05 15:42:03.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-10-05 16:44:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"dd5f7d6479e4fe7864821d33ae4522803682c80e","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2016-10-04 08:12:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a8006f0f3b0317e5c6bdf82723b2eef372d4cdd6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-04 09:16:43.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/99/381499/1/check/gate-python-novaclient-docs-ubuntu-xenial/755f646//doc/build/html/ : SUCCESS in 1m 37s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/99/381499/1/check/gate-python-novaclient-pep8-ubuntu-xenial/a8b934f/ : SUCCESS in 1m 37s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/99/381499/1/check/gate-python-novaclient-python27-ubuntu-xenial/d5d67f9/ : FAILURE in 1m 48s\n- gate-python-novaclient-python34 http://logs.openstack.org/99/381499/1/check/gate-python-novaclient-python34/1892e7b/ : FAILURE in 1m 47s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/99/381499/1/check/gate-python-novaclient-python35-nv/b83f68c/ : FAILURE in 2m 03s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/99/381499/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/ea85ad7/ : SUCCESS in 44m 23s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/99/381499/1/check/gate-novaclient-dsvm-functional/a165b8e/ : SUCCESS in 28m 35s\n- gate-novaclient-dsvm-functional-mitaka-nv http://logs.openstack.org/99/381499/1/check/gate-novaclient-dsvm-functional-mitaka-nv/68d7038/ : SUCCESS in 33m 55s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/99/381499/1/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/d2ed394/ : SUCCESS in 31m 05s (non-voting)\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/99/381499/1/check/gate-novaclient-dsvm-functional-neutron/49f32a1/ : SUCCESS in 1h 03m 26s","accounts_in_message":[],"_revision_number":1},{"id":"2dbb88013c4c2f47ddcab2753d5522e29c975326","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2016-10-04 19:47:04.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"1649c8d9219fb4616ca99d68de6b1a865cb80f0e","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2016-10-04 19:54:17.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"da67bd84c8271c39bd72536a33843a0d2ba42969","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-04 21:01:31.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/99/381499/3/check/gate-python-novaclient-docs-ubuntu-xenial/01e293e//doc/build/html/ : SUCCESS in 2m 14s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/99/381499/3/check/gate-python-novaclient-pep8-ubuntu-xenial/0757706/ : SUCCESS in 1m 41s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/99/381499/3/check/gate-python-novaclient-python27-ubuntu-xenial/06c3346/ : SUCCESS in 2m 14s\n- gate-python-novaclient-python34 http://logs.openstack.org/99/381499/3/check/gate-python-novaclient-python34/fecb2e0/ : SUCCESS in 2m 03s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/99/381499/3/check/gate-python-novaclient-python35-nv/9388cd1/ : SUCCESS in 2m 24s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/99/381499/3/check/gate-tempest-dsvm-neutron-src-python-novaclient/7363e08/ : SUCCESS in 1h 06m 04s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/99/381499/3/check/gate-novaclient-dsvm-functional/ec4b914/ : SUCCESS in 44m 40s\n- gate-novaclient-dsvm-functional-mitaka-nv http://logs.openstack.org/99/381499/3/check/gate-novaclient-dsvm-functional-mitaka-nv/14a021f/ : FAILURE in 24m 52s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/99/381499/3/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/704739f/ : SUCCESS in 29m 02s (non-voting)\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/99/381499/3/check/gate-novaclient-dsvm-functional-neutron/494e952/ : SUCCESS in 1h 05m 31s","accounts_in_message":[],"_revision_number":3},{"id":"1139f2b79a80780e3dd999cceec73052c8148b09","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-10-05 08:37:07.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"7234622b8b0a71fc7c37572be9a5cdb6ceccab24","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-10-05 15:42:03.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"9c7dce785c13279c77b49cc4348a0e2fcb540f24","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-05 15:42:24.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"74b32f859acee12b8da835f93cbc596d5219efc3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-05 16:44:44.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/99/381499/3/gate/gate-python-novaclient-docs-ubuntu-xenial/50485e8//doc/build/html/ : SUCCESS in 1m 59s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/99/381499/3/gate/gate-python-novaclient-pep8-ubuntu-xenial/cb6fe17/ : SUCCESS in 1m 57s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/99/381499/3/gate/gate-python-novaclient-python27-ubuntu-xenial/a711270/ : SUCCESS in 2m 26s\n- gate-python-novaclient-python34 http://logs.openstack.org/99/381499/3/gate/gate-python-novaclient-python34/f3c390f/ : SUCCESS in 4m 01s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/99/381499/3/gate/gate-tempest-dsvm-neutron-src-python-novaclient/8e5155a/ : SUCCESS in 43m 39s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/99/381499/3/gate/gate-novaclient-dsvm-functional/4e4ddb5/ : SUCCESS in 28m 28s\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/99/381499/3/gate/gate-novaclient-dsvm-functional-neutron/9268181/ : SUCCESS in 39m 44s","accounts_in_message":[],"_revision_number":3},{"id":"d1c4eec21b39ae8f15ebe54831a3822d24ca9836","date":"2016-10-05 16:44:45.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"e88afc046b2ab833a307869d775b820252341612","revisions":{"8295887fd2cd88fd28759ccd8a311e21481de3b4":{"kind":"REWORK","_number":1,"created":"2016-10-04 08:12:02.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/99/381499/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/99/381499/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/99/381499/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/99/381499/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/99/381499/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/99/381499/1"}}},"commit":{"parents":[{"commit":"f63d4688e3852e2abe87d8c9ef5d3b0321164c9c","subject":"Replace requests mocking with requests-mock","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f63d4688e3852e2abe87d8c9ef5d3b0321164c9c"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-10-04 07:10:06.000000000","tz":660},"committer":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-10-04 08:11:36.000000000","tz":660},"subject":"Clean up requests-mock usage","message":"Clean up requests-mock usage\n\nIn line with other clients testing we\u0027ve found that having the\nrequests-mock fixture at self.requests can be misleading for new people\nas it looks like you\u0027re calling requests itself.\n\nAlso make use of some of the new features of requests-mock like query\nparsing, json handling, method names.\n\nChange-Id: Id61b88c53478d49f91c3f880ed5b90d638051ba0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8295887fd2cd88fd28759ccd8a311e21481de3b4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8295887fd2cd88fd28759ccd8a311e21481de3b4"}]},"branch":"refs/heads/master"},"4ddcbbdede1b4f5e72408126127e1d85482da679":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2016-10-04 19:47:04.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/99/381499/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/99/381499/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/99/381499/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/99/381499/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/99/381499/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/99/381499/2"}}},"commit":{"parents":[{"commit":"864836022d4ab77719087c4178cd6726b30bf772","subject":"Replace requests mocking with requests-mock","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/864836022d4ab77719087c4178cd6726b30bf772"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-10-04 07:10:06.000000000","tz":660},"committer":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-10-04 19:46:48.000000000","tz":660},"subject":"Clean up requests-mock usage","message":"Clean up requests-mock usage\n\nIn line with other clients testing we\u0027ve found that having the\nrequests-mock fixture at self.requests can be misleading for new people\nas it looks like you\u0027re calling requests itself.\n\nAlso make use of some of the new features of requests-mock like query\nparsing, json handling, method names.\n\nChange-Id: Id61b88c53478d49f91c3f880ed5b90d638051ba0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4ddcbbdede1b4f5e72408126127e1d85482da679"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4ddcbbdede1b4f5e72408126127e1d85482da679"}]},"branch":"refs/heads/master"},"e88afc046b2ab833a307869d775b820252341612":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2016-10-04 19:54:17.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/99/381499/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/99/381499/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/99/381499/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/99/381499/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/99/381499/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/99/381499/3"}}},"commit":{"parents":[{"commit":"749fee334604d0c06dc398c38cb19c51dedb8214","subject":"Replace requests mocking with requests-mock","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/749fee334604d0c06dc398c38cb19c51dedb8214"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-10-04 07:10:06.000000000","tz":660},"committer":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-10-04 19:53:05.000000000","tz":660},"subject":"Clean up requests-mock usage","message":"Clean up requests-mock usage\n\nIn line with other clients testing we\u0027ve found that having the\nrequests-mock fixture at self.requests can be misleading for new people\nas it looks like you\u0027re calling requests itself.\n\nAlso make use of some of the new features of requests-mock like query\nparsing, json handling, method names.\n\nChange-Id: Id61b88c53478d49f91c3f880ed5b90d638051ba0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e88afc046b2ab833a307869d775b820252341612"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e88afc046b2ab833a307869d775b820252341612"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}