)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"51a7d88fdb196df8f184e04bfbbfb7f790fd7dff","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jabar Ali \u003cjabbar.ali@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-06 16:59:37 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Chnages for bug 1613105"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie85779efeaa6ba11d4695aeb1f516264c75c0933"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a95cdbc_837d7070","line":7,"updated":"2016-10-06 15:36:16.000000000","message":"The commit message needs more detail.  There should be a summary line (recommended 50 characters or less, but you can go up to 72 characters) that summarizes what the change does, followed by one or more paragraphs (set off from the summary line by a blank line) going into more details about the bug being fixed and how this change fixes it.  Finally, a bug reference should be given as a \u0027Closes-Bug\u0027 footer.  For more details about how we like commit messages formatted, please see [1].\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"cc963fcdde86c6b5724bd8fa80cd4a2eb7d4b02c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e6558edf972eba91d0cf37d167df2b9a3af4eccc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"commit cc963fcdde86c6b5724bd8fa80cd4a2eb7d4b02c"},{"line_number":8,"context_line":"Author: Jabar Ali \u003cjabbar.ali@gmail.com\u003e"},{"line_number":9,"context_line":"Date:   Thu Oct 6 16:59:37 2016 +0530"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    Chnages for bug 1613105"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a95cdbc_0ba7b24f","line":9,"updated":"2016-10-06 17:16:32.000000000","message":"These three lines above have become the summary of the commit, which is not what I\u0027m looking for; besides, they don\u0027t provide any information at all about the content of the commit.  Did you read [1]?\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"91c9e8c5672e0853c51f8dfbd1de98584c310ac9"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e6558edf972eba91d0cf37d167df2b9a3af4eccc","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"While tracking this issue it is found that when nova api is called for the volume detach it is creating sync problem"},{"line_number":18,"context_line":"So to do the proper cleanup I modified nova api to – glance api and it is resolving sync issue."},{"line_number":19,"context_line":"And cleanup procedure become smooth for the test cases."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Chnages for bug 1613105"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a95cdbc_2b4b8e88","line":19,"updated":"2016-10-06 17:16:32.000000000","message":"This is better, but doesn\u0027t fully explain the change.  Also, we like commit messages word-wrapped at about 72 columns.","commit_id":"91c9e8c5672e0853c51f8dfbd1de98584c310ac9"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e6558edf972eba91d0cf37d167df2b9a3af4eccc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"So to do the proper cleanup I modified nova api to – glance api and it is resolving sync issue."},{"line_number":19,"context_line":"And cleanup procedure become smooth for the test cases."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Chnages for bug 1613105"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ie85779efeaa6ba11d4695aeb1f516264c75c0933"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a95cdbc_4b353af5","line":21,"updated":"2016-10-06 17:16:32.000000000","message":"The bug link should be made using an appropriate footer, as described in the linked wiki page.","commit_id":"91c9e8c5672e0853c51f8dfbd1de98584c310ac9"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"da54bed9843fd5e483a56551c79a397476da1d42","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Summary : It is found that after running the test cases it is found that voulmes were leaking and it is not detaching."},{"line_number":10,"context_line":"as per the expectation when nova api is used to detach the volume before cleaning the volume.detach it is creating sync probllem !!"},{"line_number":11,"context_line":"So to do the proper cleanup I modified nova api to – glance api and it is resolving sync issue."},{"line_number":12,"context_line":"And cleanup procedure become smooth for the test cases."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie85779efeaa6ba11d4695aeb1f516264c75c0933"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a95cdbc_2eafee2a","line":12,"updated":"2016-10-07 15:25:22.000000000","message":"This is still not an acceptable formatting.  Have you read [1]?  The first line of the commit message MUST be a summary consisting of no more than 72 characters, and MUST be followed by a blank line and one or more paragraphs, word-wrapped at 72 columns, describing the change in enough detail that it is not necessary to refer to the bug link.  Further, in this version, you have eliminated the bug link; the bug SHOULD be linked using an appropriate footer, likely the \"Closes-Bug\" footer described in [1].\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"b1fb92ee7bdf5abaa5b077072a9594a0fe608fce"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b58b8e34c6d6791dedd34579055928eae1ad7845","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Summary : It is found that after running the test cases(functional) volumes were leaking and it is not detaching properly due to wrong api calling"},{"line_number":10,"context_line":"as per the expectation so the functional test cases are failing.  This problem is visible when nova api is used to detach the volume before"},{"line_number":11,"context_line":"deleting the volume. In this scenarios it is creating sync problem !!So to do the proper cleanup I modified nova api to – glance api to resolving sync issue."},{"line_number":12,"context_line":"And cleanup procedure become smooth for the test cases."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This problem is in the functional test cases execution in scenarios like"},{"line_number":15,"context_line":"Volume create --\u003e Attach volume with instance --\u003e Detach volume from instance --\u003e Delete volume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a95cdbc_6aa8f9db","line":12,"updated":"2016-10-07 18:40:43.000000000","message":"This is better, but I still want you to word-wrap these paragraphs at 72 columns.  Also, you\u0027re still missing the bug link, expressed as a \"Closes-Bug\" footer at the bottom of the commit message.","commit_id":"b4b6dfa6354ac9a19d9e9acbbd86e85ae0d12851"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bfeca48322ba01bf833b94330828c4251c6f380c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Problem is in the functional test cases execution in"},{"line_number":19,"context_line":"Volume create --\u003e Attach volume with instance"},{"line_number":20,"context_line":"                   --\u003e Detach volume from instance"},{"line_number":21,"context_line":"                          --\u003e Delete volume"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-bug: 1613105"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a95cdbc_79e6d944","line":21,"updated":"2016-10-10 15:38:47.000000000","message":"Thank you, this commit message is much better than what you started with.  However, you mention the glance api on line 15, and I suspect you mean the cinder api.","commit_id":"f7e68363ffd49bd79e2308af21930e9184c56a31"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1a44fd29fe048e7a719173d6c0cea2739def65af","unresolved":false,"context_lines":[{"line_number":11,"context_line":"api calling as per the expectation so the functional test cases are"},{"line_number":12,"context_line":"failing.  This problem is visible when nova api is used to detach"},{"line_number":13,"context_line":"the volume before deleting the volume. In this scenarios it is"},{"line_number":14,"context_line":"creating sync problem !!So to do the proper cleanup I added"},{"line_number":15,"context_line":"cinder api along with the nova api for detach to resolving sync issue."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem is in the functional test cases execution in"},{"line_number":18,"context_line":"Volume create --\u003e Attach volume with instance"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa6399be_f94e37c0","line":15,"range":{"start_line":14,"start_character":22,"end_line":15,"end_character":70},"updated":"2016-10-11 12:42:46.000000000","message":"This sounds like the nova-api should be doing this for us but isn\u0027t? If so, why are we not fixing the nova-api?","commit_id":"a1655e7d76900e19e99efcda218cac42e6cf10be"},{"author":{"_account_id":20477,"name":"Jabbar Ali","email":"jabbar.ali@gmail.com","username":"jabbar-ali"},"change_message_id":"40a3b172b91b02fa27964c4b6aad59570eb91bd1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"api calling as per the expectation so the functional test cases are"},{"line_number":12,"context_line":"failing.  This problem is visible when nova api is used to detach"},{"line_number":13,"context_line":"the volume before deleting the volume. In this scenarios it is"},{"line_number":14,"context_line":"creating sync problem !!So to do the proper cleanup I added"},{"line_number":15,"context_line":"cinder api along with the nova api for detach to resolving sync issue."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem is in the functional test cases execution in"},{"line_number":18,"context_line":"Volume create --\u003e Attach volume with instance"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa6399be_177ec718","line":15,"range":{"start_line":14,"start_character":22,"end_line":15,"end_character":70},"in_reply_to":"fa6399be_f94e37c0","updated":"2016-10-14 04:28:37.000000000","message":"Ideally nova api should doing this,But problem here is that databases are not acting as expected. For solving sync issue  blueprint are already proposed.\nhttps://specs.openstack.org/openstack/cinder-specs/specs/liberty/implement-force-detach-for-safe-cleanup.html \nFor the scope of this functional test case, to come up gracefully from the sync issue this solution is working as a fix. \nHope I am able to make point clear here","commit_id":"a1655e7d76900e19e99efcda218cac42e6cf10be"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"629912e555414eafd20ee61f9696ac55a7244fe7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"creating sync problem !!So to do the proper cleanup I added"},{"line_number":15,"context_line":"cinder api along with the nova api for detach to resolving sync issue."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"currently this is working as a work around solution once actual root cause is found"},{"line_number":18,"context_line":"then this step will be removed"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Problem is in the functional test cases execution in"},{"line_number":21,"context_line":"Volume create --\u003e Attach volume with instance"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ba5201f7_d4c9135c","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":30},"updated":"2017-01-10 11:44:04.000000000","message":"I hate to be that guy but if we merge this as is then there is no reason to identify the root cause of this issue and actually resolve the bug. If there\u0027s a real issue it should be fixed rather than masked","commit_id":"52ee6e581fca0af494cf25339d375896f74b6eb3"}],"novaclient/tests/functional/v2/legacy/test_extended_attributes.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"421907cf1305ecd5abef945829a3557266de5c19","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        return server, volume"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _release_volume(self, server, volume):"},{"line_number":34,"context_line":"        self.cinder.volumes.detach(volume.id)"},{"line_number":35,"context_line":"        self.wait_for_volume_status(volume, \u0027available\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_extended_server_attributes(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_e8127a56","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":45},"updated":"2016-10-06 22:20:10.000000000","message":"As far as I remember, `cinder detach` action changes only db entry and doesn\u0027t perform real detach.","commit_id":"91c9e8c5672e0853c51f8dfbd1de98584c310ac9"},{"author":{"_account_id":20477,"name":"Jabbar Ali","email":"jabbar.ali@gmail.com","username":"jabbar-ali"},"change_message_id":"cac3de8f00bbfa0c2a367515e50019a6ae97f85f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        return server, volume"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _release_volume(self, server, volume):"},{"line_number":34,"context_line":"        self.cinder.volumes.detach(volume.id)"},{"line_number":35,"context_line":"        self.wait_for_volume_status(volume, \u0027available\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_extended_server_attributes(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_e327f8c7","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":45},"in_reply_to":"1a95cdbc_e8127a56","updated":"2016-10-07 05:28:07.000000000","message":"For this test case - it is working and it detaching the volume\nAs per the test case first detach the volume and then delete it. \n-- It can be checked with the command \ncinder list after executing the test cases.","commit_id":"91c9e8c5672e0853c51f8dfbd1de98584c310ac9"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bfeca48322ba01bf833b94330828c4251c6f380c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        return server, volume"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _release_volume(self, server, volume):"},{"line_number":34,"context_line":"        self.cinder.volumes.detach(volume.id)"},{"line_number":35,"context_line":"        self.wait_for_volume_status(volume, \u0027available\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_extended_server_attributes(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a95cdbc_d93c4d95","line":34,"updated":"2016-10-10 15:38:47.000000000","message":"So, I wonder if we should do both the nova volume-detach and the cinder.volumes.detach?  Something is causing the functional tests to fail with this change, after all.","commit_id":"f7e68363ffd49bd79e2308af21930e9184c56a31"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"06a7486f414a96a73e41ace65fd6faf82ae37070","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        return server, volume"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _release_volume(self, server, volume):"},{"line_number":34,"context_line":"        self.cinder.volumes.detach(volume.id)"},{"line_number":35,"context_line":"        self.wait_for_volume_status(volume, \u0027available\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_extended_server_attributes(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a95cdbc_fc9d770a","line":34,"in_reply_to":"1a95cdbc_3c6b5fb8","updated":"2016-10-10 16:12:10.000000000","message":"I suggested that that may be the required proper approach.  I could be wrong, however, and it could be something else.  My comment was intended to provide you with an idea to start with as you debug and correct the functional test failures that are occurring on your change.  Remember, no change can go in until it passes the tests in the gate; right now, this change isn\u0027t passing those tests.","commit_id":"f7e68363ffd49bd79e2308af21930e9184c56a31"},{"author":{"_account_id":20477,"name":"Jabbar Ali","email":"jabbar.ali@gmail.com","username":"jabbar-ali"},"change_message_id":"3862fbbb69a1f1358ebba959c5bcb7b98e5a725a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        return server, volume"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _release_volume(self, server, volume):"},{"line_number":34,"context_line":"        self.cinder.volumes.detach(volume.id)"},{"line_number":35,"context_line":"        self.wait_for_volume_status(volume, \u0027available\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_extended_server_attributes(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a95cdbc_3c6b5fb8","line":34,"in_reply_to":"1a95cdbc_d93c4d95","updated":"2016-10-10 15:56:17.000000000","message":"I did,\u0027t get your concern !! \n Are you saying that we should use both api cinder and nova ?","commit_id":"f7e68363ffd49bd79e2308af21930e9184c56a31"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c17f8a220742488187282fe081d272a9de3de230","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _release_volume(self, server, volume):"},{"line_number":34,"context_line":"        self.nova(\u0027volume-detach\u0027, params\u003d\"%s %s\" % (server.id, volume.id))"},{"line_number":35,"context_line":"        self.cinder.volumes.detach(volume.id)"},{"line_number":36,"context_line":"        self.wait_for_volume_status(volume, \u0027available\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_extended_server_attributes(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_c2aafdd1","line":35,"updated":"2016-10-20 02:15:05.000000000","message":"We shouldn\u0027t need this as nova volume-detach will do it for us.","commit_id":"a1655e7d76900e19e99efcda218cac42e6cf10be"},{"author":{"_account_id":20477,"name":"Jabbar Ali","email":"jabbar.ali@gmail.com","username":"jabbar-ali"},"change_message_id":"d11b84d03bf1e42f642c2821997ffc47c2bbf571","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _release_volume(self, server, volume):"},{"line_number":34,"context_line":"        self.nova(\u0027volume-detach\u0027, params\u003d\"%s %s\" % (server.id, volume.id))"},{"line_number":35,"context_line":"        self.cinder.volumes.detach(volume.id)"},{"line_number":36,"context_line":"        self.wait_for_volume_status(volume, \u0027available\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_extended_server_attributes(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"da6895a0_80092198","line":35,"in_reply_to":"fa6399be_c2aafdd1","updated":"2016-10-23 05:36:40.000000000","message":"Although it a temporary work around. Removing nova volume detach is causing failure of jenkin test cases.","commit_id":"a1655e7d76900e19e99efcda218cac42e6cf10be"}],"novaclient/tests/functional/v2/legacy/test_instances.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c17f8a220742488187282fe081d272a9de3de230","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        # clean up on success"},{"line_number":69,"context_line":"        self.nova(\u0027volume-detach\u0027, params\u003d\"%s %s\" % (name, volume.id))"},{"line_number":70,"context_line":"        self.cinder.volumes.detach(volume.id)"},{"line_number":71,"context_line":"        self.wait_for_volume_status(volume, \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_e2b9c12f","line":70,"updated":"2016-10-20 02:15:05.000000000","message":"similar","commit_id":"a1655e7d76900e19e99efcda218cac42e6cf10be"}]}