)]}'
{"id":"openstack%2Fpython-novaclient~39444","triplet_id":"openstack%2Fpython-novaclient~master~I2194d6538a5c5475b876ee026b5d625be2df076f","project":"openstack/python-novaclient","branch":"master","topic":"bug/1206847","hashtags":[],"change_id":"I2194d6538a5c5475b876ee026b5d625be2df076f","subject":"Check whether the security group id is integer","status":"MERGED","created":"2013-07-31 09:55:08.000000000","updated":"2013-08-04 13:31:50.000000000","submitted":"2013-08-04 13:31:50.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7dc2edae4c211a4a307236e0707f660b2c96b391","_number":39444,"virtual_id_number":39444,"owner":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-08-04 13:31:50.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-08-02 16:08:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2013-08-01 14:01:17.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},{"value":2,"date":"2013-08-04 11:50:53.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-08-01 15:13:28.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},{"value":1,"date":"2013-08-04 11:50:53.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-08-01 15:13:28.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-08-04 11:50:53.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2013-08-04 13:31:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"2a28bcfd4feb34ded91e2a40f505c9297c025a2b","author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"date":"2013-07-31 09:59:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f0cceb498ecf312e718c81e403cbd87d20c56284","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-31 10:46:21.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/44/39444/2/check/gate-python-novaclient-pep8/1877 : SUCCESS in 53s\n- http://docs-draft.openstack.org/44/39444/2/check/gate-python-novaclient-docs/1568/doc/build/html/ : SUCCESS in 1m 16s\n- http://logs.openstack.org/44/39444/2/check/gate-python-novaclient-python26/1668 : SUCCESS in 1m 46s\n- http://logs.openstack.org/44/39444/2/check/gate-python-novaclient-python27/1883 : SUCCESS in 1m 45s\n- http://logs.openstack.org/44/39444/2/check/gate-tempest-devstack-vm-full/37722 : FAILURE in 5s\n- http://logs.openstack.org/44/39444/2/check/gate-tempest-devstack-vm-cells-full/4267 : FAILURE in 35m 39s (non-voting)\n- http://logs.openstack.org/44/39444/2/check/gate-tempest-devstack-vm-testr-full/3081 : SUCCESS in 29m 08s (non-voting)\n- http://logs.openstack.org/44/39444/2/check/gate-tempest-devstack-vm-postgres-full/37398 : SUCCESS in 45m 28s\n- http://logs.openstack.org/44/39444/2/check/gate-tempest-devstack-vm-neutron/9875 : SUCCESS in 22m 14s (non-voting)\n- http://logs.openstack.org/44/39444/2/check/gate-grenade-devstack-vm/23055 : FAILURE in 25m 51s\n","accounts_in_message":[],"_revision_number":2},{"id":"6ecb86cdeeb35a763a2f13e5be9b99ae67906489","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-07-31 15:22:00.000000000","message":"Patch Set 2: (1 inline comment)\n\nWhy are we changing from a uuid-like test to an integer-like test?  Will this break backwards compatibility?  That is, does any version of nova use UUIDs for identifying security groups, as opposed to integer IDs?  Also, I would like to see some sort of test on this.","accounts_in_message":[],"_revision_number":2},{"id":"535f3e720cdb1b49de2879cdbcb456aad2d8923e","author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"date":"2013-08-01 13:59:48.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"d587f685e3b5f2d4817da42c7a1e27c5eb4945b5","author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"date":"2013-08-01 14:01:17.000000000","message":"Patch Set 3:\n\nThe security group id starts from integer 1 and then increases. When updating, deleting and getting a security group by specifying the sec-group id, we need to check whether it is integer instead of checking whether it is like uuid.\r\nCurrently \"sec group id or name not found\" is returned with the command line, though the sec-group ID exists.","accounts_in_message":[],"_revision_number":3},{"id":"dd0ee40548f9cf03189f3669ad6abe4fa4e02519","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-01 14:57:04.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/44/39444/3/check/gate-python-novaclient-pep8/fe7dac9 : SUCCESS in 1m 02s\n- http://docs-draft.openstack.org/44/39444/3/check/gate-python-novaclient-docs/1b146d0/doc/build/html/ : SUCCESS in 1m 53s\n- http://logs.openstack.org/44/39444/3/check/gate-python-novaclient-python26/1940c69 : SUCCESS in 2m 20s\n- http://logs.openstack.org/44/39444/3/check/gate-python-novaclient-python27/cfcccc6 : SUCCESS in 1m 15s\n- http://logs.openstack.org/44/39444/3/check/gate-tempest-devstack-vm-full/132bd43 : SUCCESS in 56m 37s\n- http://logs.openstack.org/44/39444/3/check/gate-tempest-devstack-vm-cells-full/f01174d : FAILURE in 27m 28s (non-voting)\n- http://logs.openstack.org/44/39444/3/check/gate-tempest-devstack-vm-testr-full/d437b77 : SUCCESS in 28m 51s (non-voting)\n- http://logs.openstack.org/44/39444/3/check/gate-tempest-devstack-vm-postgres-full/0b48ba6 : SUCCESS in 50m 59s\n- http://logs.openstack.org/44/39444/3/check/gate-tempest-devstack-vm-neutron/8f34a3a : FAILURE in 10m 03s (non-voting)\n- http://logs.openstack.org/44/39444/3/check/gate-grenade-devstack-vm/d51ac06 : SUCCESS in 28m 30s\n","accounts_in_message":[],"_revision_number":3},{"id":"30a9a9836972113b1151ce241a4da4d600778369","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-08-01 15:13:28.000000000","message":"Patch Set 3:\n\nOK, but you haven\u0027t answered my question about backwards-compatibility.  Has any prior version of nova used UUIDs?  If so, in which version did security groups switch to integer IDs?","accounts_in_message":[],"_revision_number":3},{"id":"3ac864a74ead6762d171e71ececb1eab60611d52","author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"date":"2013-08-02 04:28:52.000000000","message":"Patch Set 3:\n\nHi Kevin. The ID security_groups in Nova has already been integer since Austin version and there is no issue about backward-compatibility.","accounts_in_message":[],"_revision_number":3},{"id":"82f71e7e53c9eb059945034c4c53eb754343c065","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-08-02 16:08:10.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"7fba952ff6d196ca551cd0a97c10727765d7cfb1","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2013-08-04 11:50:53.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"dab14507d23539f13402feb1731cb44391bbd50e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-04 11:50:54.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"f042dce6151904419b1a7796e56b68697cf5539a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-04 13:31:50.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/44/39444/3/gate/gate-python-novaclient-docs/6693439/doc/build/html/ : SUCCESS in 44s\n- http://logs.openstack.org/44/39444/3/gate/gate-python-novaclient-pep8/1860b76 : SUCCESS in 44s\n- http://logs.openstack.org/44/39444/3/gate/gate-python-novaclient-python26/b8cd37e : SUCCESS in 2m 08s\n- http://logs.openstack.org/44/39444/3/gate/gate-python-novaclient-python27/7c80775 : SUCCESS in 1m 07s\n- http://logs.openstack.org/44/39444/3/gate/gate-tempest-devstack-vm-full/2e5d936 : SUCCESS in 55m 38s\n- http://logs.openstack.org/44/39444/3/gate/gate-tempest-devstack-vm-postgres-full/9d8bf45 : SUCCESS in 44m 03s\n- http://logs.openstack.org/44/39444/3/gate/gate-tempest-devstack-vm-neutron/270c0aa : SUCCESS in 22m 45s (non-voting)\n- http://logs.openstack.org/44/39444/3/gate/gate-grenade-devstack-vm/f8987c4 : SUCCESS in 22m 12s\n","accounts_in_message":[],"_revision_number":3},{"id":"43fabbade17c57f1e4f5914f7a39553f9b1d9ed4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-04 13:31:50.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"852e2e5f3116844ea996bec6a1c9b15a463928da","revisions":{"1967278e026ab8c7b64921b44dde89f498f6b02e":{"kind":"REWORK","_number":1,"created":"2013-07-31 09:55:08.000000000","uploader":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"ref":"refs/changes/44/39444/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/44/39444/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/44/39444/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/44/39444/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/44/39444/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/44/39444/1"}}},"commit":{"parents":[{"commit":"4ab2b60850239851824c801275ad8f2b09274a35","subject":"Merge \"Fixing host-action on V2\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4ab2b60850239851824c801275ad8f2b09274a35"}]}],"author":{"name":"Vincent Hou","email":"sbhou@cn.ibm.com","date":"2013-07-31 09:47:53.000000000","tz":-240},"committer":{"name":"Vincent Hou","email":"sbhou@cn.ibm.com","date":"2013-07-31 09:55:02.000000000","tz":-240},"subject":"Check whether the security group id is integer","message":"Check whether the security group id is integer\n\nFixed Bug 1206847.\n\nChange-Id: I2194d6538a5c5475b876ee026b5d625be2df076f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/1967278e026ab8c7b64921b44dde89f498f6b02e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/1967278e026ab8c7b64921b44dde89f498f6b02e"}]},"branch":"refs/heads/master"},"7add1b3e6da58440ff451c75957c5fbff6af65ae":{"kind":"REWORK","_number":2,"created":"2013-07-31 09:59:54.000000000","uploader":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"ref":"refs/changes/44/39444/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/44/39444/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/44/39444/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/44/39444/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/44/39444/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/44/39444/2"}}},"commit":{"parents":[{"commit":"4ab2b60850239851824c801275ad8f2b09274a35","subject":"Merge \"Fixing host-action on V2\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4ab2b60850239851824c801275ad8f2b09274a35"}]}],"author":{"name":"Vincent Hou","email":"sbhou@cn.ibm.com","date":"2013-07-31 09:47:53.000000000","tz":-240},"committer":{"name":"Vincent Hou","email":"sbhou@cn.ibm.com","date":"2013-07-31 09:59:37.000000000","tz":-240},"subject":"Check whether the security group id is integer","message":"Check whether the security group id is integer\n\nFixed Bug 1206847.\n\nChange-Id: I2194d6538a5c5475b876ee026b5d625be2df076f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7add1b3e6da58440ff451c75957c5fbff6af65ae"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7add1b3e6da58440ff451c75957c5fbff6af65ae"}]},"branch":"refs/heads/master"},"852e2e5f3116844ea996bec6a1c9b15a463928da":{"kind":"REWORK","_number":3,"created":"2013-08-01 13:59:48.000000000","uploader":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"ref":"refs/changes/44/39444/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/44/39444/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/44/39444/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/44/39444/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/44/39444/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/44/39444/3"}}},"commit":{"parents":[{"commit":"4ab2b60850239851824c801275ad8f2b09274a35","subject":"Merge \"Fixing host-action on V2\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4ab2b60850239851824c801275ad8f2b09274a35"}]}],"author":{"name":"Vincent Hou","email":"sbhou@cn.ibm.com","date":"2013-07-31 09:47:53.000000000","tz":-240},"committer":{"name":"Vincent Hou","email":"sbhou@cn.ibm.com","date":"2013-08-01 13:59:29.000000000","tz":-240},"subject":"Check whether the security group id is integer","message":"Check whether the security group id is integer\n\nFixed Bug 1206847.\n\nChange-Id: I2194d6538a5c5475b876ee026b5d625be2df076f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/852e2e5f3116844ea996bec6a1c9b15a463928da"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/852e2e5f3116844ea996bec6a1c9b15a463928da"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}