)]}'
{"novaclient/__init__.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e228441258a0cc8ae6994526330df37df8a06c4f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# when client supported the max version, and bumped sequentially, otherwise"},{"line_number":26,"context_line":"# the client may break due to server side new version may include some"},{"line_number":27,"context_line":"# backward incompatible change."},{"line_number":28,"context_line":"API_MAX_VERSION \u003d api_versions.APIVersion(\"2.39\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_ed472449","line":28,"updated":"2016-11-08 16:48:18.000000000","message":"I note you\u0027ve set this as WIP, so you may be aware of this, but note that we cannot jump directly from 2.37 to 2.39; this change will need to be based on top of one that implements 2.38.","commit_id":"af3329a6886444c8903eecc4b6d96291b9f72403"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"3243518629c75772316cd875706f395b2058f3e3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# when client supported the max version, and bumped sequentially, otherwise"},{"line_number":26,"context_line":"# the client may break due to server side new version may include some"},{"line_number":27,"context_line":"# backward incompatible change."},{"line_number":28,"context_line":"API_MAX_VERSION \u003d api_versions.APIVersion(\"2.39\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_403612e8","line":28,"in_reply_to":"9a629dbe_943070ea","updated":"2016-11-08 18:57:46.000000000","message":"Done.\n\n- Bump client microversion to 2.38\n- https://review.openstack.org/395117\n\nThanks for the heads up! I wouldn\u0027t have known that this needed its own patch otherwise.\n\nPS. I followed this example:\n\n- Added support for microversion 2.34\n- https://review.openstack.org/#/c/337084","commit_id":"af3329a6886444c8903eecc4b6d96291b9f72403"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"6923fca79ce4ad3b64e8d57674fdc92903b383c8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# when client supported the max version, and bumped sequentially, otherwise"},{"line_number":26,"context_line":"# the client may break due to server side new version may include some"},{"line_number":27,"context_line":"# backward incompatible change."},{"line_number":28,"context_line":"API_MAX_VERSION \u003d api_versions.APIVersion(\"2.39\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_943070ea","line":28,"in_reply_to":"9a629dbe_ed472449","updated":"2016-11-08 17:27:45.000000000","message":"Good timing :)\n\nI was literally just looking into what changes were made in microversion 2.38 [1] and the impact on python-novaclient.\n\nReturn HTTP 400 on list for invalid status\n[1] https://review.openstack.org/#/c/315964/","commit_id":"af3329a6886444c8903eecc4b6d96291b9f72403"}],"novaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"8e23bc41c28be649842cb11d2d85842ee59b6daa","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def tearDown(self):"},{"line_number":51,"context_line":"        # For some method like test_image_meta_bad_action we are"},{"line_number":52,"context_line":"        # testing a SystemExit to be thrown and object self.shell has"},{"line_number":53,"context_line":"        # no time to get instantiated which is OK in this case, so"},{"line_number":54,"context_line":"        # we make sure the method is there before launching it."},{"line_number":55,"context_line":"        if hasattr(self.shell, \u0027cs\u0027):"},{"line_number":56,"context_line":"            self.shell.cs.clear_callstack()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_8b15b3e6","line":53,"updated":"2016-11-30 23:29:36.000000000","message":"unrelated but appreciated :)","commit_id":"cda9799a4ba6144f30d64af1f7a54955d6d778c7"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"8e23bc41c28be649842cb11d2d85842ee59b6daa","unresolved":false,"context_lines":[{"line_number":1751,"context_line":""},{"line_number":1752,"context_line":"    def test_usage_list(self):"},{"line_number":1753,"context_line":"        cmd \u003d \u0027usage-list --start 2000-01-20 --end 2005-02-01\u0027"},{"line_number":1754,"context_line":"        stdout, _ \u003d self.run_command(cmd)"},{"line_number":1755,"context_line":"        self.assert_called(\u0027GET\u0027,"},{"line_number":1756,"context_line":"                           \u0027/os-simple-tenant-usage?\u0027 +"},{"line_number":1757,"context_line":"                           \u0027start\u003d2000-01-20T00:00:00\u0026\u0027 +"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_2bce5f83","line":1754,"range":{"start_line":1754,"start_character":16,"end_line":1754,"end_character":17},"updated":"2016-11-30 23:29:36.000000000","message":"femtonit: I like to avoid using _ as a throw-away because we\u0027re using it for translation.  This would be a -1 in production code, but only a femtonit in test code…","commit_id":"cda9799a4ba6144f30d64af1f7a54955d6d778c7"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"f7c0990835c5bd81fe29d0613ef589c38bf6c21d","unresolved":false,"context_lines":[{"line_number":1751,"context_line":""},{"line_number":1752,"context_line":"    def test_usage_list(self):"},{"line_number":1753,"context_line":"        cmd \u003d \u0027usage-list --start 2000-01-20 --end 2005-02-01\u0027"},{"line_number":1754,"context_line":"        stdout, _ \u003d self.run_command(cmd)"},{"line_number":1755,"context_line":"        self.assert_called(\u0027GET\u0027,"},{"line_number":1756,"context_line":"                           \u0027/os-simple-tenant-usage?\u0027 +"},{"line_number":1757,"context_line":"                           \u0027start\u003d2000-01-20T00:00:00\u0026\u0027 +"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_602f8ea1","line":1754,"range":{"start_line":1754,"start_character":16,"end_line":1754,"end_character":17},"in_reply_to":"5a74a57a_2bce5f83","updated":"2016-12-01 04:08:36.000000000","message":"Indeed. I was also surprised to see underscores used in this file for throw-away values, but since that was already the established pattern for this file, I just rolled with it ;)","commit_id":"cda9799a4ba6144f30d64af1f7a54955d6d778c7"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"ced3c39c82ea2e9fbaa30f18659a3046dca3951b","unresolved":false,"context_lines":[{"line_number":1751,"context_line":""},{"line_number":1752,"context_line":"    def test_usage_list(self):"},{"line_number":1753,"context_line":"        cmd \u003d \u0027usage-list --start 2000-01-20 --end 2005-02-01\u0027"},{"line_number":1754,"context_line":"        stdout, _ \u003d self.run_command(cmd)"},{"line_number":1755,"context_line":"        self.assert_called(\u0027GET\u0027,"},{"line_number":1756,"context_line":"                           \u0027/os-simple-tenant-usage?\u0027 +"},{"line_number":1757,"context_line":"                           \u0027start\u003d2000-01-20T00:00:00\u0026\u0027 +"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_9c6a9019","line":1754,"range":{"start_line":1754,"start_character":16,"end_line":1754,"end_character":17},"in_reply_to":"5a74a57a_602f8ea1","updated":"2016-12-01 16:21:35.000000000","message":"eh, could always update to the preferred pattern, but like I say, femtonit :)","commit_id":"cda9799a4ba6144f30d64af1f7a54955d6d778c7"}],"novaclient/v2/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"8e23bc41c28be649842cb11d2d85842ee59b6daa","unresolved":false,"context_lines":[{"line_number":3397,"context_line":"    _print_absolute_limits(limits.absolute)"},{"line_number":3398,"context_line":""},{"line_number":3399,"context_line":""},{"line_number":3400,"context_line":"@api_versions.wraps(\"2.0\", \"2.39\")"},{"line_number":3401,"context_line":"@utils.arg("},{"line_number":3402,"context_line":"    \u0027--start\u0027,"},{"line_number":3403,"context_line":"    metavar\u003d\u0027\u003cstart\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_6b9f775f","line":3400,"updated":"2016-11-30 23:29:36.000000000","message":"So, \"usage-list\" doesn\u0027t exist after microversion 2.39?","commit_id":"cda9799a4ba6144f30d64af1f7a54955d6d778c7"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"f7c0990835c5bd81fe29d0613ef589c38bf6c21d","unresolved":false,"context_lines":[{"line_number":3397,"context_line":"    _print_absolute_limits(limits.absolute)"},{"line_number":3398,"context_line":""},{"line_number":3399,"context_line":""},{"line_number":3400,"context_line":"@api_versions.wraps(\"2.0\", \"2.39\")"},{"line_number":3401,"context_line":"@utils.arg("},{"line_number":3402,"context_line":"    \u0027--start\u0027,"},{"line_number":3403,"context_line":"    metavar\u003d\u0027\u003cstart\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_807caab6","line":3400,"in_reply_to":"5a74a57a_6b9f775f","updated":"2016-12-01 04:08:36.000000000","message":"Oops, thanks :) Removed in the next revision.","commit_id":"cda9799a4ba6144f30d64af1f7a54955d6d778c7"}]}