)]}'
{"id":"openstack%2Fpython-novaclient~395011","triplet_id":"openstack%2Fpython-novaclient~master~I084a7088e2b8151b90795db1128118e257f22066","project":"openstack/python-novaclient","branch":"master","topic":"bug/1640089","hashtags":[],"change_id":"I084a7088e2b8151b90795db1128118e257f22066","subject":"Fix inconsistent behaviour of \"nova delete\".","status":"ABANDONED","created":"2016-11-08 15:01:54.000000000","updated":"2017-11-16 15:37:02.000000000","total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a124e16b698114319390be2de43cc9e5f769dbce","_number":395011,"virtual_id_number":395011,"owner":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":22771,"name":"Christopher Martin","email":"cm876n@att.com","username":"cm876n"},{"value":1,"date":"2016-11-14 14:52:56.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":1,"date":"2016-11-14 14:53:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":22771,"name":"Christopher Martin","email":"cm876n@att.com","username":"cm876n"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2016-11-15 16:35:15.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":-1,"date":"2017-11-16 15:37:00.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2016-11-16 07:45:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22771,"name":"Christopher Martin","email":"cm876n@att.com","username":"cm876n"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22771,"name":"Christopher Martin","email":"cm876n@att.com","username":"cm876n"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22771,"name":"Christopher Martin","email":"cm876n@att.com","username":"cm876n"},{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-14 14:52:56.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-11-14 14:53:11.000000000","updated_by":{"_account_id":22771,"name":"Christopher Martin","email":"cm876n@att.com","username":"cm876n"},"reviewer":{"_account_id":22771,"name":"Christopher Martin","email":"cm876n@att.com","username":"cm876n"},"state":"REVIEWER"},{"updated":"2016-11-15 16:35:15.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2017-11-16 15:37:00.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"}],"messages":[{"id":"18a5137b2236024e7fbd2b2cd6ae45d17beb0409","author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"date":"2016-11-08 15:01:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d19f254fa2f27d89a383487627c71dbefb3dc8ed","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-08 16:04:37.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/11/395011/1/check/gate-python-novaclient-docs-ubuntu-xenial/067c305//doc/build/html/ : SUCCESS in 3m 35s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/11/395011/1/check/gate-python-novaclient-pep8-ubuntu-xenial/ed166fe/ : SUCCESS in 2m 05s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/11/395011/1/check/gate-python-novaclient-python27-ubuntu-xenial/d26d6a0/ : FAILURE in 3m 32s\n- gate-python-novaclient-python34 http://logs.openstack.org/11/395011/1/check/gate-python-novaclient-python34/5f01c87/ : FAILURE in 2m 21s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/11/395011/1/check/gate-python-novaclient-python35-nv/c7b20c0/ : FAILURE in 1m 49s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/11/395011/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/c74318c/ : SUCCESS in 1h 02m 28s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/11/395011/1/check/gate-novaclient-dsvm-functional/3268fbf/ : SUCCESS in 47m 19s\n- gate-novaclient-dsvm-functional-mitaka-nv http://logs.openstack.org/11/395011/1/check/gate-novaclient-dsvm-functional-mitaka-nv/6910906/ : SUCCESS in 26m 24s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/11/395011/1/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/a18f46e/ : SUCCESS in 48m 49s (non-voting)\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/11/395011/1/check/gate-novaclient-dsvm-functional-neutron/d54f5e8/ : SUCCESS in 50m 52s","accounts_in_message":[],"_revision_number":1},{"id":"43112c497854d76e844c4772f30bb8d4f23c70bc","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-11-08 16:51:19.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\n1. I don\u0027t understand this insistence on a \"name-only or id-only but not both\" policy.\n\n2. This change is lacking tests for the altered behavior.","accounts_in_message":[],"_revision_number":1},{"id":"0817fe9dedd0ddce73b2aa71b66195a5fadcd8ce","author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"date":"2016-11-09 06:15:50.000000000","message":"Patch Set 1:\n\n(2 comments)\n\n\u003e (2 comments)\n \u003e \n \u003e 1. I don\u0027t understand this insistence on a \"name-only or id-only\n \u003e but not both\" policy.\n\nThis is to avoid the inconsistent behavior seen, as described in the bug #1640089, with mix of VM-Names and VM-Ids mentioned while deleting those VMs using \"nova delete\" command.\n\n \u003e \n \u003e 2. This change is lacking tests for the altered behavior.\n\nModified Existing Test case.","accounts_in_message":[],"_revision_number":1},{"id":"70a94e5a9c3696f7ddbd06651ca0b61cfb3b1a0e","author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"date":"2016-11-09 06:16:55.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"25845a2b4858f857766db47b6919a953f5f49b92","author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"date":"2016-11-09 06:23:57.000000000","message":"Patch Set 3: Published edit on patch set 2","accounts_in_message":[],"_revision_number":3},{"id":"cea24cb1680e64a1f9113aee06c4b91059976ff1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-09 07:06:16.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/11/395011/3/check/gate-python-novaclient-docs-ubuntu-xenial/dbeb9d3//doc/build/html/ : SUCCESS in 1m 59s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/11/395011/3/check/gate-python-novaclient-pep8-ubuntu-xenial/33952e7/ : FAILURE in 1m 22s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/11/395011/3/check/gate-python-novaclient-python27-ubuntu-xenial/532ca23/ : SUCCESS in 2m 09s\n- gate-python-novaclient-python34 http://logs.openstack.org/11/395011/3/check/gate-python-novaclient-python34/476947b/ : SUCCESS in 1m 32s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/11/395011/3/check/gate-python-novaclient-python35-nv/53c77e6/ : SUCCESS in 1m 34s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/11/395011/3/check/gate-tempest-dsvm-neutron-src-python-novaclient/01d99a1/ : SUCCESS in 42m 07s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/11/395011/3/check/gate-novaclient-dsvm-functional/ed3612c/ : SUCCESS in 29m 33s\n- gate-novaclient-dsvm-functional-mitaka-nv http://logs.openstack.org/11/395011/3/check/gate-novaclient-dsvm-functional-mitaka-nv/6368585/ : SUCCESS in 25m 57s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/11/395011/3/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/cb0d70c/ : SUCCESS in 29m 08s (non-voting)\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/11/395011/3/check/gate-novaclient-dsvm-functional-neutron/6a8e4b1/ : SUCCESS in 36m 15s","accounts_in_message":[],"_revision_number":3},{"id":"2d8e113545c11b2e612823053068b2c731a6656d","author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"date":"2016-11-09 07:22:41.000000000","message":"Patch Set 4: Published edit on patch set 3","accounts_in_message":[],"_revision_number":4},{"id":"75a6996f513bf4da16973adcb034bc5c2019a64f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-09 08:05:49.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/11/395011/4/check/gate-python-novaclient-docs-ubuntu-xenial/d7567ae//doc/build/html/ : SUCCESS in 1m 31s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/11/395011/4/check/gate-python-novaclient-pep8-ubuntu-xenial/f6fca1f/ : SUCCESS in 1m 30s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/11/395011/4/check/gate-python-novaclient-python27-ubuntu-xenial/4eb3bb3/ : SUCCESS in 4m 29s\n- gate-python-novaclient-python34 http://logs.openstack.org/11/395011/4/check/gate-python-novaclient-python34/40fda85/ : SUCCESS in 1m 36s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/11/395011/4/check/gate-python-novaclient-python35-nv/d9e05b1/ : SUCCESS in 1m 40s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/11/395011/4/check/gate-tempest-dsvm-neutron-src-python-novaclient/086662b/ : SUCCESS in 42m 56s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/11/395011/4/check/gate-novaclient-dsvm-functional/21bd64c/ : SUCCESS in 31m 12s\n- gate-novaclient-dsvm-functional-mitaka-nv http://logs.openstack.org/11/395011/4/check/gate-novaclient-dsvm-functional-mitaka-nv/104a989/ : SUCCESS in 28m 27s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/11/395011/4/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/a31e95c/ : SUCCESS in 30m 23s (non-voting)\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/11/395011/4/check/gate-novaclient-dsvm-functional-neutron/5f007ce/ : SUCCESS in 37m 49s","accounts_in_message":[],"_revision_number":4},{"id":"88b916764ef744a0118c083913b7f1371c6b7353","author":{"_account_id":22771,"name":"Christopher Martin","email":"cm876n@att.com","username":"cm876n"},"date":"2016-11-09 15:40:57.000000000","message":"Patch Set 4: Code-Review-1\n\nWhile it may complicate things, what about a change that instead of limiting to names/IDs in one delete command, we change it to check each one by one. Basically delete the first object given (either by ID or name) then update the list and delete the next one. So in your second case described in the bugfix after the first one with the ID is deleted, the list would be updated and when trying to delete with the name \u0027vm1\u0027 it would be the only one remaining so it too would be deleted.","accounts_in_message":[],"_revision_number":4},{"id":"dda8acb712c8d5b5ce151900b95de931a85f2167","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-11-09 16:33:53.000000000","message":"Patch Set 4: Code-Review-1\n\n(2 comments)\n\nI\u0027m still not happy with this, even after reviewing the bug.  I think the first thing to do, though, is to pull the resolution of the list of IDs and names out into a separate function, since you also need to do that for your \"delete-all\" command.  (Even if you merge that into \"delete\", you would want that function to avoid code duplication within the do_delete() function.)  The function should probably have one argument regarding whether to allow ambiguity (allow turning \"name\" into multiple instances) or not; you would want to allow the ambiguity for an --exclude option, but not for a \"delete\" command.  I would still expect to see a mix of ID and name.","accounts_in_message":[],"_revision_number":4},{"id":"6f2d2294f1ae7449c9aabf68cead042318bfd97a","author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"date":"2016-11-14 13:42:57.000000000","message":"Patch Set 5: Published edit on patch set 4","accounts_in_message":[],"_revision_number":5},{"id":"d573a374528d565dfbaab56d16f68acc8bc31934","author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"date":"2016-11-14 13:44:54.000000000","message":"Patch Set 6: Published edit on patch set 5","accounts_in_message":[],"_revision_number":6},{"id":"55e15a0a665023411ebce0475907d5501ef1819c","author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"date":"2016-11-14 13:46:12.000000000","message":"Patch Set 7: Published edit on patch set 6","accounts_in_message":[],"_revision_number":7},{"id":"a52af761dccc825016b18294bae6bf1bc0ed9267","author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"date":"2016-11-14 13:49:59.000000000","message":"Patch Set 4:\n\n(2 comments)\n\nI have tried with an alternate solution, where a delay of 10 seconds is introduced between each delete request, which will resolve this bug by allowing the database to update the existing number of VMs before new delete request.","accounts_in_message":[],"_revision_number":4},{"id":"58508e59de2fe667c0b6b7fd5f775b121b759762","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-14 14:52:56.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/11/395011/7/check/gate-python-novaclient-docs-ubuntu-xenial/d6c8d89//doc/build/html/ : SUCCESS in 2m 59s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/11/395011/7/check/gate-python-novaclient-pep8-ubuntu-xenial/f4b4c9a/ : SUCCESS in 1m 28s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/11/395011/7/check/gate-python-novaclient-python27-ubuntu-xenial/dfde7c0/ : SUCCESS in 6m 16s\n- gate-python-novaclient-python34 http://logs.openstack.org/11/395011/7/check/gate-python-novaclient-python34/a861801/ : SUCCESS in 4m 44s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/11/395011/7/check/gate-python-novaclient-python35-nv/e5db664/ : SUCCESS in 5m 33s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/11/395011/7/check/gate-tempest-dsvm-neutron-src-python-novaclient/6fa27f5/ : SUCCESS in 40m 51s\n- gate-novaclient-dsvm-functional-mitaka-nv http://logs.openstack.org/11/395011/7/check/gate-novaclient-dsvm-functional-mitaka-nv/30fcdac/ : SUCCESS in 25m 26s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/11/395011/7/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/adf2a21/ : SUCCESS in 1h 06m 04s (non-voting)\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/11/395011/7/check/gate-novaclient-dsvm-functional-neutron/2601087/ : SUCCESS in 1h 05m 51s","accounts_in_message":[],"_revision_number":7},{"id":"05da7548e797d130774e24fa51c53c28707e190a","author":{"_account_id":22771,"name":"Christopher Martin","email":"cm876n@att.com","username":"cm876n"},"date":"2016-11-14 14:53:11.000000000","message":"Patch Set 7: Code-Review+1\n\nLooks fine to me, but not sure if others will have a problem with a 10 second sleep. Need more reviews.","accounts_in_message":[],"_revision_number":7},{"id":"85a7f9418f0abdd2f3aed6ccf2f1769341bb1a8b","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-11-15 16:35:15.000000000","message":"Patch Set 7: Code-Review-1\n\nI am not happy with introducing a 10 second sleep.  Now you\u0027ve taken that potential race and made it so nova will win…but only much of the time.  I agree, though, that more reviews are needed…","accounts_in_message":[],"_revision_number":7},{"id":"670028d14075bde31617534897067218d9e8de74","author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"date":"2016-11-16 07:45:50.000000000","message":"Patch Set 7: Code-Review+1\n\n\u003e I am not happy with introducing a 10 second sleep.  Now you\u0027ve\n \u003e taken that potential race and made it so nova will win…but only\n \u003e much of the time.  I agree, though, that more reviews are needed…\n\nHere, i tried to delay the request sent for server deletion by 10 seconds (5 seconds not seems to be enough), and, not blocking any request, be it is for deletion or any other.\n\nJust Delaying. Not Blocking.\n\nSo, i can\u0027t see any race condition here.","accounts_in_message":[],"_revision_number":7},{"id":"04b81c931004144fd09c8ff8f87951317032a53a","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-11-16 15:56:33.000000000","message":"Patch Set 7:\n\nThe race condition comes if nova happens to take longer than 10 seconds to process the delete, which it might in busier installations than you\u0027ve so far experimented with.  In fact, the fact that you found 5 seconds inadequate highlights the race condition.  Now, I consider it a minor race, since I don\u0027t consider this bug to be all that critical—more of a minor interface inconsistency—but a 10 second delay just to work around the race most of the time seems like a bad tradeoff to me.","accounts_in_message":[],"_revision_number":7},{"id":"4dd68b01b4af4a2fa15d1f996aa339f224d17829","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-11-16 15:37:00.000000000","message":"Patch Set 7: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"01f2caee9ce2d42b95fab572f3dac1216377b6c5","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-11-16 15:37:02.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"2703f18299c9f2580abb4d6d43db5b183a29616d","revisions":{"8d8f4bfb56078e339a78292a82b73b6fce80d5cb":{"kind":"REWORK","_number":1,"created":"2016-11-08 15:01:54.000000000","uploader":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"ref":"refs/changes/11/395011/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/11/395011/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/1"}}},"commit":{"parents":[{"commit":"09e82e8a240bfd74aca698ce190ecad06f25d0ad","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/09e82e8a240bfd74aca698ce190ecad06f25d0ad"}]}],"author":{"name":"nitin-29-gupta","email":"nitin291989@gmail.com","date":"2016-11-08 14:54:42.000000000","tz":330},"committer":{"name":"nitin-29-gupta","email":"nitin291989@gmail.com","date":"2016-11-08 15:01:44.000000000","tz":330},"subject":"Modified \"nova delete\" command usage.","message":"Modified \"nova delete\" command usage.\n\nRestricted the usage of \"nova delete\" command to use either only\nVM-Names or only VM-Ids, while deleting multiple VMs in a single\ncommand, and not allowing the mix of both VM-Names and VM-Ids.\n\nCloses Bug: #1640089\n\nChange-Id: I084a7088e2b8151b90795db1128118e257f22066\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8d8f4bfb56078e339a78292a82b73b6fce80d5cb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8d8f4bfb56078e339a78292a82b73b6fce80d5cb"}]},"branch":"refs/heads/master"},"8dc00da37d7f466e862401307e882337df56d7dc":{"kind":"REWORK","_number":2,"created":"2016-11-09 06:16:55.000000000","uploader":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"ref":"refs/changes/11/395011/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/11/395011/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/2"}}},"commit":{"parents":[{"commit":"09e82e8a240bfd74aca698ce190ecad06f25d0ad","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/09e82e8a240bfd74aca698ce190ecad06f25d0ad"}]}],"author":{"name":"nitin-29-gupta","email":"nitin291989@gmail.com","date":"2016-11-08 14:54:42.000000000","tz":330},"committer":{"name":"NITIN GUPTA","email":"nitin291989@gmail.com","date":"2016-11-09 05:46:23.000000000","tz":0},"subject":"Modified \"nova delete\" command usage and test case.","message":"Modified \"nova delete\" command usage and test case.\n\nRestricted the usage of \"nova delete\" command to use either only\nVM-Names or only VM-Ids, while deleting multiple VMs in a single\ncommand, and not allowing the mix of both VM-Names and VM-Ids.\n\nAdded assertion call for getting servers of all tenants.\n\nCloses Bug: #1640089\n\nChange-Id: I084a7088e2b8151b90795db1128118e257f22066\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8dc00da37d7f466e862401307e882337df56d7dc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8dc00da37d7f466e862401307e882337df56d7dc"}]},"branch":"refs/heads/master"},"d9535704156d939186bb103815d1d70e09e21391":{"kind":"REWORK","_number":3,"created":"2016-11-09 06:23:57.000000000","uploader":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"ref":"refs/changes/11/395011/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/11/395011/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/3"}}},"commit":{"parents":[{"commit":"09e82e8a240bfd74aca698ce190ecad06f25d0ad","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/09e82e8a240bfd74aca698ce190ecad06f25d0ad"}]}],"author":{"name":"nitin-29-gupta","email":"nitin291989@gmail.com","date":"2016-11-08 14:54:42.000000000","tz":330},"committer":{"name":"NITIN GUPTA","email":"nitin291989@gmail.com","date":"2016-11-09 06:22:30.000000000","tz":0},"subject":"Modified \"nova delete\" command usage and test case.","message":"Modified \"nova delete\" command usage and test case.\n\nRestricted the usage of \"nova delete\" command to use either only\nVM-Names or only VM-Ids, while deleting multiple VMs in a single\ncommand, and not allowing the mix of both VM-Names and VM-Ids.\n\nAdded assertion call in test case for getting servers of all tenants.\n\nCloses Bug: #1640089\n\nChange-Id: I084a7088e2b8151b90795db1128118e257f22066\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d9535704156d939186bb103815d1d70e09e21391"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d9535704156d939186bb103815d1d70e09e21391"}]},"branch":"refs/heads/master"},"d6947bd88d2e916beb1b21bca150037613d64e03":{"kind":"REWORK","_number":4,"created":"2016-11-09 07:22:41.000000000","uploader":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"ref":"refs/changes/11/395011/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/11/395011/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/4"}}},"commit":{"parents":[{"commit":"09e82e8a240bfd74aca698ce190ecad06f25d0ad","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/09e82e8a240bfd74aca698ce190ecad06f25d0ad"}]}],"author":{"name":"nitin-29-gupta","email":"nitin291989@gmail.com","date":"2016-11-08 14:54:42.000000000","tz":330},"committer":{"name":"NITIN GUPTA","email":"nitin291989@gmail.com","date":"2016-11-09 07:22:08.000000000","tz":0},"subject":"Modified \"nova delete\" command usage and test case.","message":"Modified \"nova delete\" command usage and test case.\n\nRestricted the usage of \"nova delete\" command to use either only\nVM-Names or only VM-Ids, while deleting multiple VMs in a single\ncommand, and not allowing the mix of both VM-Names and VM-Ids.\n\nAdded assertion call in test case for getting servers of all tenants.\n\nCloses Bug: #1640089\n\nChange-Id: I084a7088e2b8151b90795db1128118e257f22066\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d6947bd88d2e916beb1b21bca150037613d64e03"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d6947bd88d2e916beb1b21bca150037613d64e03"}]},"branch":"refs/heads/master"},"61e8bed557e456a01030647e76aace0cb5387e3b":{"kind":"REWORK","_number":5,"created":"2016-11-14 13:42:57.000000000","uploader":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"ref":"refs/changes/11/395011/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/11/395011/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/5"}}},"commit":{"parents":[{"commit":"09e82e8a240bfd74aca698ce190ecad06f25d0ad","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/09e82e8a240bfd74aca698ce190ecad06f25d0ad"}]}],"author":{"name":"nitin-29-gupta","email":"nitin291989@gmail.com","date":"2016-11-08 14:54:42.000000000","tz":330},"committer":{"name":"NITIN GUPTA","email":"nitin291989@gmail.com","date":"2016-11-14 13:39:27.000000000","tz":0},"subject":"Fix inconsistent behaviour of \"nova delete\".","message":"Fix inconsistent behaviour of \"nova delete\".\n\nIntroduced a delay of 15 seconds between each delete request.\n\nCloses-Bug: #1640089\n\nChange-Id: I084a7088e2b8151b90795db1128118e257f22066","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/61e8bed557e456a01030647e76aace0cb5387e3b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/61e8bed557e456a01030647e76aace0cb5387e3b"}]},"branch":"refs/heads/master"},"751937db0bb558818a09a6c3ba3ec65a0bddc1ea":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2016-11-14 13:44:54.000000000","uploader":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"ref":"refs/changes/11/395011/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/11/395011/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/6"}}},"commit":{"parents":[{"commit":"09e82e8a240bfd74aca698ce190ecad06f25d0ad","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/09e82e8a240bfd74aca698ce190ecad06f25d0ad"}]}],"author":{"name":"nitin-29-gupta","email":"nitin291989@gmail.com","date":"2016-11-08 14:54:42.000000000","tz":330},"committer":{"name":"NITIN GUPTA","email":"nitin291989@gmail.com","date":"2016-11-14 13:44:50.000000000","tz":0},"subject":"Fix inconsistent behaviour of \"nova delete\".","message":"Fix inconsistent behaviour of \"nova delete\".\n\nIntroduced a delay of 10 seconds between each delete request.\n\nCloses-Bug: #1640089\n\nChange-Id: I084a7088e2b8151b90795db1128118e257f22066","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/751937db0bb558818a09a6c3ba3ec65a0bddc1ea"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/751937db0bb558818a09a6c3ba3ec65a0bddc1ea"}]},"branch":"refs/heads/master"},"2703f18299c9f2580abb4d6d43db5b183a29616d":{"kind":"REWORK","_number":7,"created":"2016-11-14 13:46:12.000000000","uploader":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"ref":"refs/changes/11/395011/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/11/395011/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/11/395011/7"}}},"commit":{"parents":[{"commit":"09e82e8a240bfd74aca698ce190ecad06f25d0ad","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/09e82e8a240bfd74aca698ce190ecad06f25d0ad"}]}],"author":{"name":"nitin-29-gupta","email":"nitin291989@gmail.com","date":"2016-11-08 14:54:42.000000000","tz":330},"committer":{"name":"NITIN GUPTA","email":"nitin291989@gmail.com","date":"2016-11-14 13:45:40.000000000","tz":0},"subject":"Fix inconsistent behaviour of \"nova delete\".","message":"Fix inconsistent behaviour of \"nova delete\".\n\nIntroduced a delay of 10 seconds between each delete request.\n\nCloses-Bug: #1640089\n\nChange-Id: I084a7088e2b8151b90795db1128118e257f22066","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2703f18299c9f2580abb4d6d43db5b183a29616d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2703f18299c9f2580abb4d6d43db5b183a29616d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}