)]}'
{"novaclient/base.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f946cecd1f2dea3d39dfd501822317aa6451f786","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        if disk_config is not None:"},{"line_number":366,"context_line":"            if disk_config not in [\u0027AUTO\u0027, \u0027MANUAL\u0027]:"},{"line_number":367,"context_line":"                raise Exception(\"disk_config must be either \u0027AUTO\u0027 or \""},{"line_number":368,"context_line":"                                \"\u0027MANUAL\u0027, not \u0027%s\u0027\" % disk_config)"},{"line_number":369,"context_line":"            body[\u0027server\u0027][\u0027OS-DCF:diskConfig\u0027] \u003d disk_config"},{"line_number":370,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FWGk%3D","line":367,"updated":"2013-08-01 17:13:21.000000000","message":"Is that the correct type of exception? what do we do elsewhere?","commit_id":"f7fa32768ef0611c50ad5e44dba05f424005b092"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"ba2d3e0ebc4678c4a1e70895007204d02198a3ea","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        if disk_config is not None:"},{"line_number":366,"context_line":"            if disk_config not in [\u0027AUTO\u0027, \u0027MANUAL\u0027]:"},{"line_number":367,"context_line":"                raise Exception(\"disk_config must be either \u0027AUTO\u0027 or \""},{"line_number":368,"context_line":"                                \"\u0027MANUAL\u0027, not \u0027%s\u0027\" % disk_config)"},{"line_number":369,"context_line":"            body[\u0027server\u0027][\u0027OS-DCF:diskConfig\u0027] \u003d disk_config"},{"line_number":370,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FVzQ%3D","line":367,"in_reply_to":"AAAAQn%2F%2FWGk%3D","updated":"2013-08-01 18:48:20.000000000","message":"Actually it looks like value checking is done on the server side already.  I don\u0027t see much client side checking, so I\u0027ll drop this.","commit_id":"f7fa32768ef0611c50ad5e44dba05f424005b092"}],"novaclient/tests/v1_1/fakes.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a45c9234200bbde2b7ee52deb07052a28b1fa163","unresolved":false,"context_lines":[{"line_number":477,"context_line":"            _body \u003d self.get_servers_1234()[2]"},{"line_number":478,"context_line":"        elif action \u003d\u003d \u0027resize\u0027:"},{"line_number":479,"context_line":"            keys \u003d body[action].keys()"},{"line_number":480,"context_line":"            assert \u0027flavorRef\u0027 in keys"},{"line_number":481,"context_line":"        elif action \u003d\u003d \u0027confirmResize\u0027:"},{"line_number":482,"context_line":"            assert body[action] is None"},{"line_number":483,"context_line":"            # This one method returns a different response code"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FZPI%3D","line":480,"updated":"2013-07-31 21:05:26.000000000","message":"These changes don\u0027t seem to be related; could you make them a separate patch?","commit_id":"f84c25bc9f33ca0df0cd52e3d77a93b57936e68a"}],"novaclient/tests/v1_1/test_servers.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a45c9234200bbde2b7ee52deb07052a28b1fa163","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.assertTrue(isinstance(s, servers.Server))"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        # verify disk config param was used in the request:"},{"line_number":149,"context_line":"        _, _, body \u003d cs.client.callstack[-1]"},{"line_number":150,"context_line":"        server \u003d body[\u0027server\u0027]"},{"line_number":151,"context_line":"        self.assertTrue(\u0027OS-DCF:diskConfig\u0027 in server)"},{"line_number":152,"context_line":"        self.assertEqual(disk_config, server[\u0027OS-DCF:diskConfig\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FZO4%3D","line":149,"updated":"2013-07-31 21:05:26.000000000","message":"Let\u0027s avoid using \u0027_\u0027 as the dummy…","commit_id":"f84c25bc9f33ca0df0cd52e3d77a93b57936e68a"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"4b14233dd3d3b49fee4d519164379109fd7edf07","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.assertTrue(isinstance(s, servers.Server))"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        # verify disk config param was used in the request:"},{"line_number":149,"context_line":"        _, _, body \u003d cs.client.callstack[-1]"},{"line_number":150,"context_line":"        server \u003d body[\u0027server\u0027]"},{"line_number":151,"context_line":"        self.assertTrue(\u0027OS-DCF:diskConfig\u0027 in server)"},{"line_number":152,"context_line":"        self.assertEqual(disk_config, server[\u0027OS-DCF:diskConfig\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FWOw%3D","line":149,"in_reply_to":"AAAAQn%2F%2FZO4%3D","updated":"2013-08-01 16:46:28.000000000","message":"Done","commit_id":"f84c25bc9f33ca0df0cd52e3d77a93b57936e68a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a45c9234200bbde2b7ee52deb07052a28b1fa163","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/servers/1234/action\u0027)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # verify disk config param was used in the request:"},{"line_number":238,"context_line":"        _, _, body \u003d cs.client.callstack[-1]"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        d \u003d body[operation]"},{"line_number":241,"context_line":"        self.assertTrue(\u0027OS-DCF:diskConfig\u0027 in d)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FZO0%3D","line":238,"updated":"2013-07-31 21:05:26.000000000","message":"ibid","commit_id":"f84c25bc9f33ca0df0cd52e3d77a93b57936e68a"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"4b14233dd3d3b49fee4d519164379109fd7edf07","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/servers/1234/action\u0027)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # verify disk config param was used in the request:"},{"line_number":238,"context_line":"        _, _, body \u003d cs.client.callstack[-1]"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        d \u003d body[operation]"},{"line_number":241,"context_line":"        self.assertTrue(\u0027OS-DCF:diskConfig\u0027 in d)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FWOs%3D","line":238,"in_reply_to":"AAAAQn%2F%2FZO0%3D","updated":"2013-08-01 16:46:28.000000000","message":"Done","commit_id":"f84c25bc9f33ca0df0cd52e3d77a93b57936e68a"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"ba2d3e0ebc4678c4a1e70895007204d02198a3ea","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        cs.servers.resize(s, flavor\u003d1)"},{"line_number":261,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/servers/1234/action\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def test_resize_server_disk_config_auto(self):"},{"line_number":264,"context_line":"        self._rebuild_resize_disk_config(\u0027AUTO\u0027, \u0027resize\u0027)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def test_resize_server_disk_config_manual(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FVzA%3D","line":263,"updated":"2013-08-01 18:48:20.000000000","message":"John - the following tests hit the resize case you flagged.","commit_id":"f7fa32768ef0611c50ad5e44dba05f424005b092"}],"novaclient/v1_1/servers.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a45c9234200bbde2b7ee52deb07052a28b1fa163","unresolved":false,"context_lines":[{"line_number":570,"context_line":"               max_count\u003dNone, security_groups\u003dNone, userdata\u003dNone,"},{"line_number":571,"context_line":"               key_name\u003dNone, availability_zone\u003dNone,"},{"line_number":572,"context_line":"               block_device_mapping\u003dNone, nics\u003dNone, scheduler_hints\u003dNone,"},{"line_number":573,"context_line":"               config_drive\u003dNone, disk_config\u003dNone, **kwargs):"},{"line_number":574,"context_line":"        # TODO(anthony): indicate in doc string if param is an extension"},{"line_number":575,"context_line":"        # and/or optional"},{"line_number":576,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FZOY%3D","line":573,"updated":"2013-07-31 21:05:26.000000000","message":"Could the disk_config be absorbed into kwargs somehow?","commit_id":"f84c25bc9f33ca0df0cd52e3d77a93b57936e68a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f946cecd1f2dea3d39dfd501822317aa6451f786","unresolved":false,"context_lines":[{"line_number":691,"context_line":"        body \u003d {\u0027imageRef\u0027: base.getid(image)}"},{"line_number":692,"context_line":"        if password is not None:"},{"line_number":693,"context_line":"            body[\u0027adminPass\u0027] \u003d password"},{"line_number":694,"context_line":"        if disk_config is not None:"},{"line_number":695,"context_line":"            if disk_config not in [\u0027AUTO\u0027, \u0027MANUAL\u0027]:"},{"line_number":696,"context_line":"                raise Exception(\"disk_config must be either \u0027AUTO\u0027 or \""},{"line_number":697,"context_line":"                                \"\u0027MANUAL\u0027\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FWHA%3D","line":694,"updated":"2013-08-01 17:13:21.000000000","message":"Should have tests for this I guess?","commit_id":"f7fa32768ef0611c50ad5e44dba05f424005b092"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f946cecd1f2dea3d39dfd501822317aa6451f786","unresolved":false,"context_lines":[{"line_number":695,"context_line":"            if disk_config not in [\u0027AUTO\u0027, \u0027MANUAL\u0027]:"},{"line_number":696,"context_line":"                raise Exception(\"disk_config must be either \u0027AUTO\u0027 or \""},{"line_number":697,"context_line":"                                \"\u0027MANUAL\u0027\")"},{"line_number":698,"context_line":"            body[\u0027OS-DCF:diskConfig\u0027] \u003d disk_config"},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"        _resp, body \u003d self._action(\u0027rebuild\u0027, server, body, **kwargs)"},{"line_number":701,"context_line":"        return Server(self, body[\u0027server\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FWG0%3D","line":698,"updated":"2013-08-01 17:13:21.000000000","message":"is there a util we could share all this repeated code?","commit_id":"f7fa32768ef0611c50ad5e44dba05f424005b092"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f946cecd1f2dea3d39dfd501822317aa6451f786","unresolved":false,"context_lines":[{"line_number":723,"context_line":"        automatically confirmed after 24 hours."},{"line_number":724,"context_line":"        \"\"\""},{"line_number":725,"context_line":"        info \u003d {\u0027flavorRef\u0027: base.getid(flavor)}"},{"line_number":726,"context_line":"        if disk_config is not None:"},{"line_number":727,"context_line":"            if disk_config not in [\u0027AUTO\u0027, \u0027MANUAL\u0027]:"},{"line_number":728,"context_line":"                raise Exception(\"disk_config must be either \u0027AUTO\u0027 or \""},{"line_number":729,"context_line":"                                \"\u0027MANUAL\u0027\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FWG8%3D","line":726,"updated":"2013-08-01 17:13:21.000000000","message":"Should we have tests for this too?","commit_id":"f7fa32768ef0611c50ad5e44dba05f424005b092"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"ba2d3e0ebc4678c4a1e70895007204d02198a3ea","unresolved":false,"context_lines":[{"line_number":723,"context_line":"        automatically confirmed after 24 hours."},{"line_number":724,"context_line":"        \"\"\""},{"line_number":725,"context_line":"        info \u003d {\u0027flavorRef\u0027: base.getid(flavor)}"},{"line_number":726,"context_line":"        if disk_config is not None:"},{"line_number":727,"context_line":"            if disk_config not in [\u0027AUTO\u0027, \u0027MANUAL\u0027]:"},{"line_number":728,"context_line":"                raise Exception(\"disk_config must be either \u0027AUTO\u0027 or \""},{"line_number":729,"context_line":"                                \"\u0027MANUAL\u0027\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FVzI%3D","line":726,"in_reply_to":"AAAAQn%2F%2FWG8%3D","updated":"2013-08-01 18:48:20.000000000","message":"Yeah, there are resize tests.  I\u0027ll drop a comment on them.","commit_id":"f7fa32768ef0611c50ad5e44dba05f424005b092"}]}