)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3c4abeef2f16cbb751202374ab511c5bae595e81","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Show other project servers using --all-tenants option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We can list all servers using `--all-tenants`, but we can\u0027t show"},{"line_number":10,"context_line":"the server we list if not in current project event though we have enough"},{"line_number":11,"context_line":"permisions. It seems inconsistent and weird."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This feature adds the possibility to show a server which is not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a77a97e_b38e61ce","line":10,"range":{"start_line":10,"start_character":45,"end_line":10,"end_character":50},"updated":"2016-11-22 17:39:01.000000000","message":"s/event/even/ (attonit)","commit_id":"0144811235f15f01c5c35d89fba043c83cc41c73"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3c4abeef2f16cbb751202374ab511c5bae595e81","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We can list all servers using `--all-tenants`, but we can\u0027t show"},{"line_number":10,"context_line":"the server we list if not in current project event though we have enough"},{"line_number":11,"context_line":"permisions. It seems inconsistent and weird."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This feature adds the possibility to show a server which is not"},{"line_number":14,"context_line":"current context project if permitted. The proposal is to add a new"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a77a97e_53b0ad8b","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":10},"updated":"2016-11-22 17:39:01.000000000","message":"s/permisions/permissions/ (attonit)","commit_id":"0144811235f15f01c5c35d89fba043c83cc41c73"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"9ea66f812b053a1927e8eb45edbe6b5cd5bd7440","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We can list all servers using `--all-tenants`, but we can\u0027t show"},{"line_number":10,"context_line":"the server we list if not in current project even though we have enough"},{"line_number":11,"context_line":"permision. It seems inconsistent and weird."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This feature adds the possibility to show a server which is not"},{"line_number":14,"context_line":"current context project if permitted. The proposal is to add a new"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a77a97e_67d87f80","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":9},"updated":"2016-11-22 18:51:53.000000000","message":"s/permision/permissions/ (attonit)","commit_id":"26077c507d8a2c716cf786ee0e1d6afa58b9f64a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9ae6b3f98f522d64fcc0dee67d07a2886912533e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"flag ``--all-tenants`` in ``nova show`` subcommand. If ``--all-tenants``"},{"line_number":16,"context_line":"is present, we will find a server from all projects by id or name."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"bp show-server-all-tenants"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ie46b0e89723022c12ff2dae301f248c56178b2ad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a74a57a_5808f828","line":18,"updated":"2016-11-30 11:10:47.000000000","message":"Nit: This isn\u0027t approved, we don\u0027t really use blueprints for python-novaclient, I would just drop it really.","commit_id":"dc7967096992b560b5562888070c64cb5dc5a6ed"}],"novaclient/utils.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9ae6b3f98f522d64fcc0dee67d07a2886912533e","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            resource \u003d getattr(manager, \u0027resource_class\u0027, None)"},{"line_number":302,"context_line":"            name_attr \u003d resource.NAME_ATTR if resource else \u0027name\u0027"},{"line_number":303,"context_line":"            kwargs \u003d {name_attr: name_or_id}"},{"line_number":304,"context_line":"            kwargs.update(find_args)"},{"line_number":305,"context_line":"            return manager.find(**kwargs)"},{"line_number":306,"context_line":"        except exceptions.NotFound:"},{"line_number":307,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_f868e489","line":304,"updated":"2016-11-30 11:10:47.000000000","message":"I was expecting to see all_tenants\u003dTrue added here, optionally.","commit_id":"dc7967096992b560b5562888070c64cb5dc5a6ed"},{"author":{"_account_id":21479,"name":"int32bit","email":"krystism@gmail.com","username":"int32bit"},"change_message_id":"e430a9652f0b01d2e881e0859d5719b297d8be23","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            resource \u003d getattr(manager, \u0027resource_class\u0027, None)"},{"line_number":302,"context_line":"            name_attr \u003d resource.NAME_ATTR if resource else \u0027name\u0027"},{"line_number":303,"context_line":"            kwargs \u003d {name_attr: name_or_id}"},{"line_number":304,"context_line":"            kwargs.update(find_args)"},{"line_number":305,"context_line":"            return manager.find(**kwargs)"},{"line_number":306,"context_line":"        except exceptions.NotFound:"},{"line_number":307,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_d5cd9d87","line":304,"in_reply_to":"5a74a57a_f868e489","updated":"2016-12-01 02:26:25.000000000","message":"I think it won\u0027t work, let\u0027s  assume we pass uuid, we will find it by name in this place, in other word, we will add \"name\" filter in search opts, so in fact we will get empty list below:\nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/base.py#L463\n\nIn addition, even though we define \"os_compute_api:servers:index:get_all_tenants\" in policy, we can list all servers, but will fail to get by \"/servers/uuid\", so\nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/utils.py#L294\nWill fail to get  the server.","commit_id":"dc7967096992b560b5562888070c64cb5dc5a6ed"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9ae6b3f98f522d64fcc0dee67d07a2886912533e","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    if find_args.get(\"all_tenants\", False):"},{"line_number":331,"context_line":"        try:"},{"line_number":332,"context_line":"            servers \u003d manager.list(search_opts\u003d{\"all_tenants\": 1})"},{"line_number":333,"context_line":"            for server in servers:"},{"line_number":334,"context_line":"                if str(server.id) \u003d\u003d name_or_id or server.name \u003d\u003d name_or_id:"},{"line_number":335,"context_line":"                    return server"},{"line_number":336,"context_line":"        except exceptions.Forbidden as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_580e38e6","line":333,"updated":"2016-11-30 11:10:47.000000000","message":"This is a massive list of servers, and could well be paged so you don\u0027t see the one you are looking for.\n\nCould you not instead just add all_tenants\u003dtrue (if requested) into the ln 304? Or does that not work like that?","commit_id":"dc7967096992b560b5562888070c64cb5dc5a6ed"},{"author":{"_account_id":21479,"name":"int32bit","email":"krystism@gmail.com","username":"int32bit"},"change_message_id":"e430a9652f0b01d2e881e0859d5719b297d8be23","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    if find_args.get(\"all_tenants\", False):"},{"line_number":331,"context_line":"        try:"},{"line_number":332,"context_line":"            servers \u003d manager.list(search_opts\u003d{\"all_tenants\": 1})"},{"line_number":333,"context_line":"            for server in servers:"},{"line_number":334,"context_line":"                if str(server.id) \u003d\u003d name_or_id or server.name \u003d\u003d name_or_id:"},{"line_number":335,"context_line":"                    return server"},{"line_number":336,"context_line":"        except exceptions.Forbidden as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_3ae22702","line":333,"in_reply_to":"5a74a57a_580e38e6","updated":"2016-12-01 02:26:25.000000000","message":"I admit this is not a very good way but may be a last chance to get the server. It shouldn\u0027t be paged as both \u0027limit\u0027 and \u0027marker\u0027 are None in this place by default.\n\nWe create a readonly-admin role, all users in this role can list all servers in any project implemented by policy. But our users complain that  they can\u0027t show some servers they list.\n\nOur client can get all servers from NOVA API, why not get one?","commit_id":"dc7967096992b560b5562888070c64cb5dc5a6ed"}],"novaclient/v2/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6039c14288ec7cd438d9f4e72882a6ad2e6eb03c","unresolved":false,"context_lines":[{"line_number":2279,"context_line":"    dest\u003d\u0027all_tenants\u0027,"},{"line_number":2280,"context_line":"    action\u003d\"store_true\","},{"line_number":2281,"context_line":"    default\u003dstrutils.bool_from_string("},{"line_number":2282,"context_line":"        os.environ.get(\"ALL_TENANTS\", \u0027false\u0027), True),"},{"line_number":2283,"context_line":"    help\u003d_(\u0027Retrieve from all tenants (Admin only).\u0027))"},{"line_number":2284,"context_line":"@utils.arg("},{"line_number":2285,"context_line":"    \u0027--minimal\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_8e4a4182","line":2282,"updated":"2016-11-15 16:46:16.000000000","message":"I might like to see a \"NOVA_\" prefix on this environment variable; I believe that\u0027s the convention we\u0027re using.","commit_id":"0d0cd3b70ff91fd4fee07d763c1c2bf2d0e2bc0b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9ae6b3f98f522d64fcc0dee67d07a2886912533e","unresolved":false,"context_lines":[{"line_number":1492,"context_line":"    type\u003dint,"},{"line_number":1493,"context_line":"    const\u003d1,"},{"line_number":1494,"context_line":"    default\u003dint(strutils.bool_from_string("},{"line_number":1495,"context_line":"        os.environ.get(\"NOVA_ALL_TENANTS\", \u0027false\u0027), True)),"},{"line_number":1496,"context_line":"    help\u003d_(\u0027Display information from all tenants (Admin only).\u0027))"},{"line_number":1497,"context_line":"@utils.arg("},{"line_number":1498,"context_line":"    \u0027--tenant\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_18fe8005","line":1495,"range":{"start_line":1495,"start_character":24,"end_line":1495,"end_character":40},"updated":"2016-11-30 11:10:47.000000000","message":"Doesn\u0027t this break all the existing users that are using ALL_TENANTS?\n\nCan we just also check for ALL_TENANTS?","commit_id":"dc7967096992b560b5562888070c64cb5dc5a6ed"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a1d38028eebfd886abfc2a468a2f3caded0a61b4","unresolved":false,"context_lines":[{"line_number":1492,"context_line":"    type\u003dint,"},{"line_number":1493,"context_line":"    const\u003d1,"},{"line_number":1494,"context_line":"    default\u003dint(strutils.bool_from_string("},{"line_number":1495,"context_line":"        os.environ.get(\"NOVA_ALL_TENANTS\", \u0027false\u0027), True)),"},{"line_number":1496,"context_line":"    help\u003d_(\u0027Display information from all tenants (Admin only).\u0027))"},{"line_number":1497,"context_line":"@utils.arg("},{"line_number":1498,"context_line":"    \u0027--tenant\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_ff6ef894","line":1495,"range":{"start_line":1495,"start_character":24,"end_line":1495,"end_character":40},"in_reply_to":"5a74a57a_18fe8005","updated":"2016-11-30 16:17:02.000000000","message":"I had suggested using NOVA_ALL_TENANTS if there wasn\u0027t a good reason to not include the prefix, but I didn\u0027t look to see if we were already using ALL_TENANTS.  Since we are, that\u0027s a good reason to not use the prefix…","commit_id":"dc7967096992b560b5562888070c64cb5dc5a6ed"}]}