)]}'
{"id":"openstack%2Fpython-novaclient~398050","triplet_id":"openstack%2Fpython-novaclient~master~I6b27d9c1629656dcc9b18497187c79ca96f6cd67","project":"openstack/python-novaclient","branch":"master","topic":"bug/1642113","hashtags":[],"change_id":"I6b27d9c1629656dcc9b18497187c79ca96f6cd67","subject":"Change fake server id as str to fit real server id type","status":"MERGED","created":"2016-11-16 02:50:09.000000000","updated":"2016-11-17 13:01:47.000000000","submitted":"2016-11-17 13:01:47.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d286a83159f86155966dd9864a49451f9ba8c771","_number":398050,"virtual_id_number":398050,"owner":{"_account_id":21479,"name":"int32bit","email":"krystism@gmail.com","username":"int32bit"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-11-17 13:01:47.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-11-16 16:00:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2016-11-17 12:06:26.000000000","_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2016-11-17 12:06:26.000000000","_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-16 16:00:43.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-11-17 12:06:26.000000000","updated_by":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"reviewer":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"state":"REVIEWER"},{"updated":"2016-11-17 13:01:47.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9cffd485b82daa728a8b9959e62bd549ce5a023a","author":{"_account_id":21479,"name":"int32bit","email":"krystism@gmail.com","username":"int32bit"},"date":"2016-11-16 02:50:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5647f444f6c4f325c86cbc979a03bed369d7bc40","author":{"_account_id":21479,"name":"int32bit","email":"krystism@gmail.com","username":"int32bit"},"date":"2016-11-16 11:15:43.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"a2677305b24452677702755bcb108ec6c6f1bc87","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-16 12:09:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/50/398050/1/check/gate-python-novaclient-docs-ubuntu-xenial/6650072//doc/build/html/ : SUCCESS in 2m 22s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/50/398050/1/check/gate-python-novaclient-pep8-ubuntu-xenial/0052aeb/ : SUCCESS in 1m 58s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/50/398050/1/check/gate-python-novaclient-python27-ubuntu-xenial/1c9e1a9/ : SUCCESS in 2m 30s\n- gate-python-novaclient-python34 http://logs.openstack.org/50/398050/1/check/gate-python-novaclient-python34/3a22246/ : SUCCESS in 1m 46s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/50/398050/1/check/gate-python-novaclient-python35-nv/1cdb6ca/ : SUCCESS in 2m 24s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/50/398050/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/bbb60ba/ : SUCCESS in 41m 59s\n- gate-novaclient-dsvm-functional-mitaka-nv http://logs.openstack.org/50/398050/1/check/gate-novaclient-dsvm-functional-mitaka-nv/ca9c909/ : SUCCESS in 26m 26s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/50/398050/1/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/544394d/ : SUCCESS in 53m 33s (non-voting)\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/50/398050/1/check/gate-novaclient-dsvm-functional-neutron/6bd4233/ : SUCCESS in 36m 42s","accounts_in_message":[],"_revision_number":1},{"id":"225bdf7c2f3654a4350a154d6c519b7eacbb29b7","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-11-16 16:00:43.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4b5b64759a835fdb879b5b943a21813d7ec9690a","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2016-11-17 12:06:26.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"cac80a58695124eacf4f72faa62bcea856bf15d3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-17 12:06:36.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"73a1ac454ad4286f9bc9a1ed13a5417b98be6ebe","date":"2016-11-17 13:01:47.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"1168fa30feeac2045db2726de1907fb8bfef4d4b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-17 13:01:47.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/50/398050/1/gate/gate-python-novaclient-docs-ubuntu-xenial/a25c7d9//doc/build/html/ : SUCCESS in 1m 30s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/50/398050/1/gate/gate-python-novaclient-pep8-ubuntu-xenial/d3a349e/ : SUCCESS in 2m 19s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/50/398050/1/gate/gate-python-novaclient-python27-ubuntu-xenial/dd032e6/ : SUCCESS in 1m 53s\n- gate-python-novaclient-python34 http://logs.openstack.org/50/398050/1/gate/gate-python-novaclient-python34/af4c067/ : SUCCESS in 1m 41s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/50/398050/1/gate/gate-tempest-dsvm-neutron-src-python-novaclient/bfaacb9/ : SUCCESS in 55m 09s\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/50/398050/1/gate/gate-novaclient-dsvm-functional-neutron/2940763/ : SUCCESS in 35m 31s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5c1efa52737900fda853379ca897377b8c21bde5","revisions":{"5c1efa52737900fda853379ca897377b8c21bde5":{"kind":"REWORK","_number":1,"created":"2016-11-16 02:50:09.000000000","uploader":{"_account_id":21479,"name":"int32bit","email":"krystism@gmail.com","username":"int32bit"},"ref":"refs/changes/50/398050/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/50/398050/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/50/398050/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/50/398050/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/50/398050/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/50/398050/1"}}},"commit":{"parents":[{"commit":"ccae3f0951b9ad956c6fef0aa572dc1d6dd51659","subject":"Merge \"Replace oslo_utils.timeutils.isotime\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ccae3f0951b9ad956c6fef0aa572dc1d6dd51659"}]}],"author":{"name":"int32bit","email":"krystism@gmail.com","date":"2016-11-16 02:40:43.000000000","tz":480},"committer":{"name":"int32bit","email":"krystism@gmail.com","date":"2016-11-16 02:49:52.000000000","tz":480},"subject":"Change fake server id as str to fit real server id type","message":"Change fake server id as str to fit real server id type\n\nServer id should be always str type not int, but currently in our unit test,\nwe still use int type. It may harmless in current test cases, but **there\u0027s a\npotential danger** in future. For example, we may compare server id in our\ncode, in our test will be 1234 \u003d\u003d \"1234\" which certainly return false but it\u0027s\nnot our expected result and yields a false positive. it trouble me a lot to run\nunit test to solve \u0027bp show-server-all-tenants\u0027. I re-check many times and\ncompletely certain work well but fail to unit test. Honestly I almost couldn\u0027t\nfind any advantage to use int type. So I think the id should be change to str\nin fake servers to fit real server uuid type.\n\nChange-Id: I6b27d9c1629656dcc9b18497187c79ca96f6cd67\nCloses-Bug: #1642113\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5c1efa52737900fda853379ca897377b8c21bde5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5c1efa52737900fda853379ca897377b8c21bde5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}