)]}'
{"tools/tox_install.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"16377923b027b6eeff8d980d93ea1ebbe074e9b1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# with installing the client from source. We should replace the version pin in"},{"line_number":5,"context_line":"# the constraints file before applying it for from-source installation."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ZUUL_CLONER\u003d/usr/zuul-env/bin/zuul-cloner"},{"line_number":8,"context_line":"BRANCH_NAME\u003dmaster"},{"line_number":9,"context_line":"CLIENT_NAME\u003dpython-novaclient"},{"line_number":10,"context_line":"requirements_installed\u003d$(echo \"import openstack_requirements\" | python 2\u003e/dev/null ; echo $?)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a74a57a_77009102","line":7,"updated":"2016-11-29 15:18:44.000000000","message":"Shouldn\u0027t this script match this now?\n\nhttps://review.openstack.org/#/c/394721/6/tools/tox_install.sh","commit_id":"a396d6892442e63350b4c62a2378efa6bd09c0cd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0395ccc4086f43ad4e6851046f3189168e0b1288","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# with installing the client from source. We should replace the version pin in"},{"line_number":5,"context_line":"# the constraints file before applying it for from-source installation."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ZUUL_CLONER\u003d/usr/zuul-env/bin/zuul-cloner"},{"line_number":8,"context_line":"BRANCH_NAME\u003dmaster"},{"line_number":9,"context_line":"CLIENT_NAME\u003dpython-novaclient"},{"line_number":10,"context_line":"requirements_installed\u003d$(echo \"import openstack_requirements\" | python 2\u003e/dev/null ; echo $?)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a74a57a_3508d02d","line":7,"in_reply_to":"5a74a57a_77009102","updated":"2016-11-29 16:10:12.000000000","message":"I\u0027ve gone with another approach here:\n\nhttps://review.openstack.org/#/c/404302/\n\nUsing the template from the patch in oslo.messaging.","commit_id":"a396d6892442e63350b4c62a2378efa6bd09c0cd"}],"tox.ini":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8fc0b275a5435ba9523e158a9bd4a9911383bd88","unresolved":false,"context_lines":[{"line_number":10,"context_line":"whitelist_externals \u003d find"},{"line_number":11,"context_line":"                    bash"},{"line_number":12,"context_line":"install_command \u003d"},{"line_number":13,"context_line":"    {toxinidir}/tools/tox_install.sh {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":14,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":3,"id":"5a74a57a_17de7ddc","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":36},"updated":"2016-11-29 15:16:11.000000000","message":"This additional script seems really excessive, why can\u0027t we just do something like this in nova?\n\nhttps://github.com/openstack/nova/blob/master/tox.ini#L12","commit_id":"a396d6892442e63350b4c62a2378efa6bd09c0cd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7f2cd7ac1370555e68f198e951d9ad3bbdf6ec3f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"whitelist_externals \u003d find"},{"line_number":11,"context_line":"                    bash"},{"line_number":12,"context_line":"install_command \u003d"},{"line_number":13,"context_line":"    {toxinidir}/tools/tox_install.sh {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":14,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":3,"id":"5a74a57a_77525136","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":36},"in_reply_to":"5a74a57a_17de7ddc","updated":"2016-11-29 15:17:54.000000000","message":"Nevermind I see the review comment history now.","commit_id":"a396d6892442e63350b4c62a2378efa6bd09c0cd"}]}