)]}'
{"id":"openstack%2Fpython-novaclient~402364","triplet_id":"openstack%2Fpython-novaclient~master~If6c7d8ed58a94d262ac6c300e75aca4cdf99ff1d","project":"openstack/python-novaclient","branch":"master","topic":"bug/1644725","hashtags":[],"change_id":"If6c7d8ed58a94d262ac6c300e75aca4cdf99ff1d","subject":"Check source_type and destination_type when booting with bdm provided","status":"MERGED","created":"2016-11-25 09:02:13.000000000","updated":"2017-02-08 01:52:28.000000000","submitted":"2016-12-13 16:11:10.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":16,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c82880a43793e4fea6e9c3898fe6ea7f64cb52c8","_number":402364,"virtual_id_number":402364,"owner":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":2,"date":"2016-12-13 16:11:10.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2017-02-08 01:51:34.000000000","post_submit":true,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-12-07 16:24:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"value":2,"date":"2016-12-13 14:52:56.000000000","_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"all":[{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"value":1,"date":"2016-12-13 14:52:56.000000000","_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-30 12:47:31.000000000","updated_by":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"reviewer":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"state":"REVIEWER"},{"updated":"2016-12-07 16:24:31.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-12-13 14:52:56.000000000","updated_by":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"reviewer":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"state":"REVIEWER"},{"updated":"2016-12-13 16:11:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-02-08 01:51:34.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"}],"messages":[{"id":"1dc59ad2b684f54e6e31a392899d69afccfb2099","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2016-11-25 09:02:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"23a2990409c7028b88ce942391f26763e03ae492","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-25 10:19:15.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/64/402364/1/check/gate-python-novaclient-docs-ubuntu-xenial/3a127dd//doc/build/html/ : SUCCESS in 1m 22s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/64/402364/1/check/gate-python-novaclient-pep8-ubuntu-xenial/7f9ff45/ : SUCCESS in 1m 30s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/64/402364/1/check/gate-python-novaclient-python27-ubuntu-xenial/01bde2f/ : FAILURE in 1m 37s\n- gate-python-novaclient-python34 http://logs.openstack.org/64/402364/1/check/gate-python-novaclient-python34/716e470/ : FAILURE in 1m 41s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/64/402364/1/check/gate-python-novaclient-python35-nv/8d3342a/ : FAILURE in 1m 43s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/64/402364/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/83925d3/ : SUCCESS in 1h 03m 00s\n- gate-novaclient-dsvm-functional-mitaka-nv http://logs.openstack.org/64/402364/1/check/gate-novaclient-dsvm-functional-mitaka-nv/6529893/ : FAILURE in 36m 39s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/64/402364/1/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/5e7aa2b/ : FAILURE in 1h 16m 49s (non-voting)\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/64/402364/1/check/gate-novaclient-dsvm-functional-neutron/545d268/ : FAILURE in 35m 14s","accounts_in_message":[],"_revision_number":1},{"id":"4dd7b699c5dfe7c539b199db4b80ad6e0503c955","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2016-11-26 02:00:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"049f2fe749e59c35ae750fc60f6797527aaf242b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-26 03:24:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/64/402364/2/check/gate-python-novaclient-docs-ubuntu-xenial/a511911//doc/build/html/ : SUCCESS in 2m 33s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/64/402364/2/check/gate-python-novaclient-pep8-ubuntu-xenial/3c6cada/ : SUCCESS in 1m 27s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/64/402364/2/check/gate-python-novaclient-python27-ubuntu-xenial/5492a53/ : SUCCESS in 2m 36s\n- gate-python-novaclient-python34 http://logs.openstack.org/64/402364/2/check/gate-python-novaclient-python34/dbac3d0/ : SUCCESS in 4m 50s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/64/402364/2/check/gate-python-novaclient-python35-nv/1a13ddd/ : SUCCESS in 3m 38s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/64/402364/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/bce33b0/ : SUCCESS in 43m 43s\n- gate-novaclient-dsvm-functional-mitaka-nv http://logs.openstack.org/64/402364/2/check/gate-novaclient-dsvm-functional-mitaka-nv/6487860/ : SUCCESS in 42m 35s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/64/402364/2/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/3cf088d/ : SUCCESS in 1h 23m 19s (non-voting)\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/64/402364/2/check/gate-novaclient-dsvm-functional-neutron/2e28cc2/ : SUCCESS in 1h 24m 04s","accounts_in_message":[],"_revision_number":2},{"id":"09e92f654d62286e553f9cfb5688b59066338a64","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2016-11-28 13:47:50.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"d4c3f6fb988b1b99864829921dbb2f59b7145d8e","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-11-28 14:40:40.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nI\u0027d like to see an added test here.","accounts_in_message":[],"_revision_number":2},{"id":"9b56a8722402a6873ecb32cd6c784e7c5c99a6d1","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2016-11-29 01:39:12.000000000","message":"Patch Set 2:\n\n\u003e (1 comment)\n \u003e \n \u003e I\u0027d like to see an added test here.\n\nsure, I will work on that","accounts_in_message":[],"_revision_number":2},{"id":"50b6a6babd5535f42ffaac95c1e47a39340a5f50","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2016-11-30 06:51:12.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"d3ef8e47cdf60638ae2a7e7476f2369a73dd7312","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-30 08:17:42.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/64/402364/3/check/gate-python-novaclient-docs-ubuntu-xenial/b0b1685//doc/build/html/ : SUCCESS in 2m 05s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/64/402364/3/check/gate-python-novaclient-pep8-ubuntu-xenial/dc41412/ : SUCCESS in 1m 45s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/64/402364/3/check/gate-python-novaclient-python27-ubuntu-xenial/f9630b7/ : SUCCESS in 2m 44s\n- gate-python-novaclient-python34 http://logs.openstack.org/64/402364/3/check/gate-python-novaclient-python34/af375c7/ : SUCCESS in 2m 27s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/64/402364/3/check/gate-python-novaclient-python35-nv/0110066/ : SUCCESS in 1m 46s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/64/402364/3/check/gate-tempest-dsvm-neutron-src-python-novaclient/f517b92/ : SUCCESS in 49m 45s\n- gate-novaclient-dsvm-functional-mitaka-nv http://logs.openstack.org/64/402364/3/check/gate-novaclient-dsvm-functional-mitaka-nv/e1a3bdb/ : SUCCESS in 46m 03s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/64/402364/3/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/f7f6168/ : SUCCESS in 1h 26m 13s (non-voting)\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/64/402364/3/check/gate-novaclient-dsvm-functional-neutron/1b852b0/ : FAILURE in 32m 43s","accounts_in_message":[],"_revision_number":3},{"id":"9d3b9cd7a4d97ec9fa89ea090030bf78069f0711","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2016-11-30 08:21:00.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"7bd68cd6fc4427eba5851ebcad868f1388b86ae2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-30 09:43:28.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/64/402364/3/check/gate-python-novaclient-docs-ubuntu-xenial/afac12f//doc/build/html/ : SUCCESS in 1m 32s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/64/402364/3/check/gate-python-novaclient-pep8-ubuntu-xenial/d5ed084/ : SUCCESS in 1m 40s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/64/402364/3/check/gate-python-novaclient-python27-ubuntu-xenial/8a9d54f/ : SUCCESS in 2m 52s\n- gate-python-novaclient-python34 http://logs.openstack.org/64/402364/3/check/gate-python-novaclient-python34/a7d8942/ : SUCCESS in 1m 48s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/64/402364/3/check/gate-python-novaclient-python35-nv/a8f67b0/ : SUCCESS in 2m 21s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/64/402364/3/check/gate-tempest-dsvm-neutron-src-python-novaclient/40b1959/ : SUCCESS in 46m 38s\n- gate-novaclient-dsvm-functional-mitaka-nv http://logs.openstack.org/64/402364/3/check/gate-novaclient-dsvm-functional-mitaka-nv/5a2fc56/ : SUCCESS in 44m 06s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/64/402364/3/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/e34a790/ : SUCCESS in 1h 06m 24s (non-voting)\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/64/402364/3/check/gate-novaclient-dsvm-functional-neutron/16a949c/ : SUCCESS in 1h 21m 46s","accounts_in_message":[],"_revision_number":3},{"id":"6ba4b024830f0a1fc7c8507761508bab23a7bec9","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2016-11-30 12:47:31.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"d0121d4d004e4aaeaac2ad37944605d75658522b","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-11-30 16:27:19.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"87b738bd72433070325a434ae41425eec309f858","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2016-12-01 01:39:41.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"e8717f09480f43fae09a5842d1e8393e61a9d9b2","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2016-12-01 01:49:40.000000000","message":"Patch Set 3:\n\nLooks like the source_type is also not checked here, I may also add it","accounts_in_message":[],"_revision_number":3},{"id":"64ea4853a67985d31144f51f5bddc58291b80c42","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2016-12-01 02:01:49.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"5b02994c0babc7fe2a499a1d21258412e00ea129","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-01 02:59:34.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/64/402364/4/check/gate-python-novaclient-docs-ubuntu-xenial/7771d3a//doc/build/html/ : SUCCESS in 1m 24s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/64/402364/4/check/gate-python-novaclient-pep8-ubuntu-xenial/7944da2/ : SUCCESS in 1m 38s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/64/402364/4/check/gate-python-novaclient-python27-ubuntu-xenial/7ff50a0/ : SUCCESS in 3m 15s\n- gate-python-novaclient-python34 http://logs.openstack.org/64/402364/4/check/gate-python-novaclient-python34/1f5d40a/ : SUCCESS in 1m 51s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/64/402364/4/check/gate-python-novaclient-python35-nv/f6f164a/ : SUCCESS in 2m 19s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/64/402364/4/check/gate-tempest-dsvm-neutron-src-python-novaclient/9081d88/ : SUCCESS in 47m 21s\n- gate-novaclient-dsvm-functional-mitaka-nv http://logs.openstack.org/64/402364/4/check/gate-novaclient-dsvm-functional-mitaka-nv/2ced4e6/ : SUCCESS in 27m 03s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/64/402364/4/check/gate-novaclient-dsvm-functional-identity-v3-only-nv/51042a7/ : SUCCESS in 57m 32s (non-voting)\n- gate-novaclient-dsvm-functional-neutron http://logs.openstack.org/64/402364/4/check/gate-novaclient-dsvm-functional-neutron/9f18e2b/ : SUCCESS in 39m 23s","accounts_in_message":[],"_revision_number":4},{"id":"707b7225a27f11d21bb5b84d15cd0d59975d22c9","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-12-01 16:33:49.000000000","message":"Patch Set 4: Code-Review-1\n\n(4 comments)\n\nOne error noted at novaclient/v2/shell.py#166","accounts_in_message":[],"_revision_number":4},{"id":"a6e8cd2ae54b4206199c6e6a178254d2ad4f09bc","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2016-12-06 07:41:52.000000000","message":"Patch Set 4:\n\n(4 comments)","accounts_in_message":[],"_revision_number":4},{"id":"ee1f64cf866ded4edb287319e8af52990306521e","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2016-12-06 07:44:38.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"df708e05d6a41c54f3876053d9abc201bc387f89","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2016-12-06 07:45:40.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"a26335b093b98738dcc9af2dd5d6397e7d6a1f2e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-06 09:10:23.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/64/402364/5/check/gate-python-novaclient-docs-ubuntu-xenial/9273f19//doc/build/html/ : SUCCESS in 1m 26s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/64/402364/5/check/gate-python-novaclient-pep8-ubuntu-xenial/f9bad7e/ : SUCCESS in 1m 33s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/64/402364/5/check/gate-python-novaclient-python27-ubuntu-xenial/0aaf5fe/ : SUCCESS in 1m 47s\n- gate-python-novaclient-python34 http://logs.openstack.org/64/402364/5/check/gate-python-novaclient-python34/3ce99f4/ : SUCCESS in 1m 46s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/64/402364/5/check/gate-python-novaclient-python35-nv/f7fe7f3/ : SUCCESS in 4m 12s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/64/402364/5/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/5cc8e39/ : SUCCESS in 47m 09s\n- gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv http://logs.openstack.org/64/402364/5/check/gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv/2b2b283/ : SUCCESS in 38m 12s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/64/402364/5/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/4ac1924/ : FAILURE in 1h 24m 37s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/64/402364/5/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/30438c9/ : FAILURE in 1h 08m 26s","accounts_in_message":[],"_revision_number":5},{"id":"44bb9b21bda7b22f5b4d33cd99e5f92536525983","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2016-12-06 09:18:14.000000000","message":"Patch Set 5:\n\nrecheck","accounts_in_message":[],"_revision_number":5},{"id":"c1b4324ae1058cac41dfd86c256a642fb9b0d202","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-06 10:11:09.000000000","message":"Patch Set 5:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/64/402364/5/check/gate-python-novaclient-docs-ubuntu-xenial/d99fb5b//doc/build/html/ : SUCCESS in 2m 12s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/64/402364/5/check/gate-python-novaclient-pep8-ubuntu-xenial/648cbb4/ : SUCCESS in 2m 36s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/64/402364/5/check/gate-python-novaclient-python27-ubuntu-xenial/9e77618/ : SUCCESS in 3m 08s\n- gate-python-novaclient-python34 http://logs.openstack.org/64/402364/5/check/gate-python-novaclient-python34/4c3e2c5/ : SUCCESS in 2m 00s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/64/402364/5/check/gate-python-novaclient-python35-nv/6c178e0/ : SUCCESS in 1m 54s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/64/402364/5/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/1bacc64/ : SUCCESS in 50m 30s\n- gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv http://logs.openstack.org/64/402364/5/check/gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv/0d86336/ : SUCCESS in 25m 41s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/64/402364/5/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/9dbdfe7/ : FAILURE in 39m 46s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/64/402364/5/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/2e0956b/ : FAILURE in 37m 21s","accounts_in_message":[],"_revision_number":5},{"id":"e8256758f11ffeaca1cdd30864fbf0a68e3b2464","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-12-06 16:06:11.000000000","message":"Patch Set 5:\n\n(1 comment)\n\nTest failures are probably unrelated to your change, but they seem too consistent for a recheck to be valuable :/","accounts_in_message":[],"_revision_number":5},{"id":"3ee0919b57fc9016ec88b6d618796b20e99aa4ec","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2016-12-07 01:31:08.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"fbfbf7343c6a529044d2ce5383360f279b9eea4f","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2016-12-07 07:35:26.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"05f0bba1eff135aa4b45ecb352a6cd3209e9ef93","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-07 09:02:49.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/64/402364/6/check/gate-python-novaclient-docs-ubuntu-xenial/4dc650b//doc/build/html/ : SUCCESS in 1m 24s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/64/402364/6/check/gate-python-novaclient-pep8-ubuntu-xenial/128b501/ : SUCCESS in 1m 42s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/64/402364/6/check/gate-python-novaclient-python27-ubuntu-xenial/2125f48/ : FAILURE in 1m 46s\n- gate-python-novaclient-python34 http://logs.openstack.org/64/402364/6/check/gate-python-novaclient-python34/5eb8314/ : FAILURE in 1m 43s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/64/402364/6/check/gate-python-novaclient-python35-nv/4a521d0/ : FAILURE in 1m 43s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/64/402364/6/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/bb2a115/ : SUCCESS in 49m 58s\n- gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv http://logs.openstack.org/64/402364/6/check/gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv/5b1e9eb/ : SUCCESS in 29m 21s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/64/402364/6/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/f6d1522/ : SUCCESS in 56m 37s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/64/402364/6/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/a202751/ : SUCCESS in 1h 26m 36s","accounts_in_message":[],"_revision_number":6},{"id":"fee037318d52928b972ed5188c0131d87d9b5592","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2016-12-07 09:20:27.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"663b15147db7a34df7393a9a5b39d20340b8e822","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-07 10:19:18.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/64/402364/7/check/gate-python-novaclient-docs-ubuntu-xenial/706105a//doc/build/html/ : SUCCESS in 2m 25s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/64/402364/7/check/gate-python-novaclient-pep8-ubuntu-xenial/86d05ea/ : SUCCESS in 1m 45s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/64/402364/7/check/gate-python-novaclient-python27-ubuntu-xenial/ae89ec9/ : SUCCESS in 1m 47s\n- gate-python-novaclient-python34 http://logs.openstack.org/64/402364/7/check/gate-python-novaclient-python34/689f7ed/ : SUCCESS in 1m 55s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/64/402364/7/check/gate-python-novaclient-python35-nv/cf5c083/ : SUCCESS in 3m 03s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/64/402364/7/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/51a6841/ : SUCCESS in 53m 37s\n- gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv http://logs.openstack.org/64/402364/7/check/gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv/2791ea3/ : SUCCESS in 28m 10s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/64/402364/7/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/9efb3d4/ : SUCCESS in 52m 24s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/64/402364/7/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/9f20542/ : SUCCESS in 56m 45s","accounts_in_message":[],"_revision_number":7},{"id":"c709ada980705ac1cdb5c1361737d0f5729eb545","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-12-07 16:24:31.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"8af066e63d712252b68b1a8e470e66f1a65bd5b8","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2016-12-13 14:52:56.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1\n\nThis seems like a good fix, given I see the fix in Nova for the deeper issue.","accounts_in_message":[],"_revision_number":7},{"id":"319c76802718062e2db203736bd33357bc12ba3c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-13 14:53:06.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"2105670671f63c917406de45ccbc77998f98783e","date":"2016-12-13 16:11:10.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":7},{"id":"e11004f7fcfd28ce7d6b8823b7a5b9706c6b6eb1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-13 16:11:10.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/64/402364/7/gate/gate-python-novaclient-docs-ubuntu-xenial/d5a80a1//doc/build/html/ : SUCCESS in 2m 44s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/64/402364/7/gate/gate-python-novaclient-pep8-ubuntu-xenial/942a40e/ : SUCCESS in 2m 12s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/64/402364/7/gate/gate-python-novaclient-python27-ubuntu-xenial/714ea22/ : SUCCESS in 9m 32s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/64/402364/7/gate/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/c8c26e2/ : SUCCESS in 1h 17m 15s\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/64/402364/7/gate/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/0ec033b/ : SUCCESS in 54m 13s","accounts_in_message":[],"_revision_number":7},{"id":"c516640cbca1e0c19c64a778a7f356a1662d3bec","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-02-08 01:51:34.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"58e744b422cec38d7b69c5c56b441423a4614fb2","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-02-08 01:52:28.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"a58959dd9ec3962cbb6d273f136286809678b0c4","revisions":{"5a6d833902cac96b4808a30dc79b15b417189153":{"kind":"REWORK","_number":1,"created":"2016-11-25 09:02:13.000000000","uploader":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"ref":"refs/changes/64/402364/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/64/402364/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/1"}}},"commit":{"parents":[{"commit":"94aec599c64e7c7bcc14f6fca2f5131fd8fb67bf","subject":"Merge \"Remove unused test code\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/94aec599c64e7c7bcc14f6fca2f5131fd8fb67bf"}]}],"author":{"name":"Kevin_Zheng","email":"zhengzhenyu@huawei.com","date":"2016-11-25 08:55:18.000000000","tz":480},"committer":{"name":"Kevin_Zheng","email":"zhengzhenyu@huawei.com","date":"2016-11-25 08:55:18.000000000","tz":480},"subject":"Check destination_type when booting with bdm provided","message":"Check destination_type when booting with bdm provided\n\nWhen booting instance with block_device_mapping provided,\nin the current implementation, the \"destination_type\" is\nallowed to be None, and this lead to un-sync between Nova\nand Cinder: Nova will have a bdm in its record while the\nvolume is still in \"available\" status in cinder.\n\nThis pathc adds a check for destination_type\n\nChange-Id: If6c7d8ed58a94d262ac6c300e75aca4cdf99ff1d\npartial-bug: #1644725\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5a6d833902cac96b4808a30dc79b15b417189153"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5a6d833902cac96b4808a30dc79b15b417189153"}]},"branch":"refs/heads/master"},"a53c58ae6144bffe76f7ddf2fc800b48730174ea":{"kind":"REWORK","_number":2,"created":"2016-11-26 02:00:32.000000000","uploader":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"ref":"refs/changes/64/402364/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/64/402364/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/2"}}},"commit":{"parents":[{"commit":"94aec599c64e7c7bcc14f6fca2f5131fd8fb67bf","subject":"Merge \"Remove unused test code\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/94aec599c64e7c7bcc14f6fca2f5131fd8fb67bf"}]}],"author":{"name":"Kevin_Zheng","email":"zhengzhenyu@huawei.com","date":"2016-11-25 08:55:18.000000000","tz":480},"committer":{"name":"Kevin_Zheng","email":"zhengzhenyu@huawei.com","date":"2016-11-26 01:49:51.000000000","tz":480},"subject":"Check destination_type when booting with bdm provided","message":"Check destination_type when booting with bdm provided\n\nWhen booting instance with block_device_mapping provided,\nin the current implementation, the \"destination_type\" is\nallowed to be None, and this lead to un-sync between Nova\nand Cinder: Nova will have a bdm in its record while the\nvolume is still in \"available\" status in cinder.\n\nThis pathc adds a check for destination_type\n\nChange-Id: If6c7d8ed58a94d262ac6c300e75aca4cdf99ff1d\npartial-bug: #1644725\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a53c58ae6144bffe76f7ddf2fc800b48730174ea"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a53c58ae6144bffe76f7ddf2fc800b48730174ea"}]},"branch":"refs/heads/master"},"7f9ce3253fb527fca919e5bae27881d5404cf8c2":{"kind":"REWORK","_number":3,"created":"2016-11-30 06:51:12.000000000","uploader":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"ref":"refs/changes/64/402364/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/64/402364/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/3"}}},"commit":{"parents":[{"commit":"94aec599c64e7c7bcc14f6fca2f5131fd8fb67bf","subject":"Merge \"Remove unused test code\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/94aec599c64e7c7bcc14f6fca2f5131fd8fb67bf"}]}],"author":{"name":"Kevin_Zheng","email":"zhengzhenyu@huawei.com","date":"2016-11-25 08:55:18.000000000","tz":480},"committer":{"name":"Kevin_Zheng","email":"zhengzhenyu@huawei.com","date":"2016-11-30 06:51:07.000000000","tz":480},"subject":"Check destination_type when booting with bdm provided","message":"Check destination_type when booting with bdm provided\n\nWhen booting instance with block_device_mapping provided,\nin the current implementation, the \"destination_type\" is\nallowed to be None, and this lead to un-sync between Nova\nand Cinder: Nova will have a bdm in its record while the\nvolume is still in \"available\" status in cinder.\n\nThis pathc adds a check for destination_type\n\nChange-Id: If6c7d8ed58a94d262ac6c300e75aca4cdf99ff1d\npartial-bug: #1644725\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7f9ce3253fb527fca919e5bae27881d5404cf8c2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7f9ce3253fb527fca919e5bae27881d5404cf8c2"}]},"branch":"refs/heads/master"},"5be5428f03d44916c5f61924d7ae75d58b16f57b":{"kind":"REWORK","_number":4,"created":"2016-12-01 02:01:49.000000000","uploader":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"ref":"refs/changes/64/402364/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/64/402364/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/4"}}},"commit":{"parents":[{"commit":"94aec599c64e7c7bcc14f6fca2f5131fd8fb67bf","subject":"Merge \"Remove unused test code\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/94aec599c64e7c7bcc14f6fca2f5131fd8fb67bf"}]}],"author":{"name":"Kevin_Zheng","email":"zhengzhenyu@huawei.com","date":"2016-11-25 08:55:18.000000000","tz":480},"committer":{"name":"Kevin_Zheng","email":"zhengzhenyu@huawei.com","date":"2016-12-01 02:01:16.000000000","tz":480},"subject":"Check source_type and destination_type when booting with bdm provided","message":"Check source_type and destination_type when booting with bdm provided\n\nWhen booting instance with block_device_mapping provided,\nin the current implementation, the \"destination_type\" is\nallowed to be None, and this lead to un-sync between Nova\nand Cinder: Nova will have a bdm in its record while the\nvolume is still in \"available\" status in cinder.\n\nAlso we should check source_type here\n\nThis patch adds a check for source_type and\ndestination_type, source_type shoud be within\n\u0027volume\u0027, \u0027image\u0027, \u0027snapshot\u0027 or \u0027blank\u0027;\nWhen empty destination_type is provided, it\nwill be assigned to an default value according\nto source_type, if it is provided with a wrong\nvalue, command error will raise and information\nwill shown.\n\nChange-Id: If6c7d8ed58a94d262ac6c300e75aca4cdf99ff1d\npartial-bug: #1644725\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5be5428f03d44916c5f61924d7ae75d58b16f57b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5be5428f03d44916c5f61924d7ae75d58b16f57b"}]},"branch":"refs/heads/master"},"4b8dcc2f27ecd4355e73efaa0d9a602c0a4666ec":{"kind":"REWORK","_number":5,"created":"2016-12-06 07:44:38.000000000","uploader":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"ref":"refs/changes/64/402364/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/64/402364/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/5"}}},"commit":{"parents":[{"commit":"94aec599c64e7c7bcc14f6fca2f5131fd8fb67bf","subject":"Merge \"Remove unused test code\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/94aec599c64e7c7bcc14f6fca2f5131fd8fb67bf"}]}],"author":{"name":"Kevin_Zheng","email":"zhengzhenyu@huawei.com","date":"2016-11-25 08:55:18.000000000","tz":480},"committer":{"name":"Kevin_Zheng","email":"zhengzhenyu@huawei.com","date":"2016-12-06 07:42:17.000000000","tz":480},"subject":"Check source_type and destination_type when booting with bdm provided","message":"Check source_type and destination_type when booting with bdm provided\n\nWhen booting instance with block_device_mapping provided,\nin the current implementation, the \"destination_type\" is\nallowed to be None, and this lead to un-sync between Nova\nand Cinder: Nova will have a bdm in its record while the\nvolume is still in \"available\" status in cinder.\n\nAlso we should check source_type here\n\nThis patch adds a check for source_type and\ndestination_type, source_type shoud be within\n\u0027volume\u0027, \u0027image\u0027, \u0027snapshot\u0027 or \u0027blank\u0027;\nWhen empty destination_type is provided, it\nwill be assigned to an default value according\nto source_type, if it is provided with a wrong\nvalue, command error will raise and information\nwill shown.\n\nChange-Id: If6c7d8ed58a94d262ac6c300e75aca4cdf99ff1d\npartial-bug: #1644725\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4b8dcc2f27ecd4355e73efaa0d9a602c0a4666ec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4b8dcc2f27ecd4355e73efaa0d9a602c0a4666ec"}]},"branch":"refs/heads/master"},"03aa59cc21b18c35d33b3ec34e522ffe7eee0581":{"kind":"REWORK","_number":6,"created":"2016-12-07 07:35:26.000000000","uploader":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"ref":"refs/changes/64/402364/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/64/402364/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/6"}}},"commit":{"parents":[{"commit":"94aec599c64e7c7bcc14f6fca2f5131fd8fb67bf","subject":"Merge \"Remove unused test code\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/94aec599c64e7c7bcc14f6fca2f5131fd8fb67bf"}]}],"author":{"name":"Kevin_Zheng","email":"zhengzhenyu@huawei.com","date":"2016-11-25 08:55:18.000000000","tz":480},"committer":{"name":"Kevin_Zheng","email":"zhengzhenyu@huawei.com","date":"2016-12-07 07:20:29.000000000","tz":480},"subject":"Check source_type and destination_type when booting with bdm provided","message":"Check source_type and destination_type when booting with bdm provided\n\nWhen booting instance with block_device_mapping provided,\nin the current implementation, the \"destination_type\" is\nallowed to be None, and this lead to un-sync between Nova\nand Cinder: Nova will have a bdm in its record while the\nvolume is still in \"available\" status in cinder.\n\nAlso we should check source_type here\n\nThis patch adds a check for source_type and\ndestination_type, source_type shoud be within\n\u0027volume\u0027, \u0027image\u0027, \u0027snapshot\u0027 or \u0027blank\u0027;\nWhen empty destination_type is provided, it\nwill be assigned to an default value according\nto source_type, if it is provided with a wrong\nvalue, command error will raise and information\nwill shown.\n\nChange-Id: If6c7d8ed58a94d262ac6c300e75aca4cdf99ff1d\npartial-bug: #1644725\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/03aa59cc21b18c35d33b3ec34e522ffe7eee0581"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/03aa59cc21b18c35d33b3ec34e522ffe7eee0581"}]},"branch":"refs/heads/master"},"a58959dd9ec3962cbb6d273f136286809678b0c4":{"kind":"REWORK","_number":7,"created":"2016-12-07 09:20:27.000000000","uploader":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"ref":"refs/changes/64/402364/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/64/402364/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/64/402364/7"}}},"commit":{"parents":[{"commit":"94aec599c64e7c7bcc14f6fca2f5131fd8fb67bf","subject":"Merge \"Remove unused test code\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/94aec599c64e7c7bcc14f6fca2f5131fd8fb67bf"}]}],"author":{"name":"Kevin_Zheng","email":"zhengzhenyu@huawei.com","date":"2016-11-25 08:55:18.000000000","tz":480},"committer":{"name":"Kevin_Zheng","email":"zhengzhenyu@huawei.com","date":"2016-12-07 09:17:23.000000000","tz":480},"subject":"Check source_type and destination_type when booting with bdm provided","message":"Check source_type and destination_type when booting with bdm provided\n\nWhen booting instance with block_device_mapping provided,\nin the current implementation, the \"destination_type\" is\nallowed to be None, and this lead to un-sync between Nova\nand Cinder: Nova will have a bdm in its record while the\nvolume is still in \"available\" status in cinder.\n\nAlso we should check source_type here\n\nThis patch adds a check for source_type and\ndestination_type, source_type shoud be within\n\u0027volume\u0027, \u0027image\u0027, \u0027snapshot\u0027 or \u0027blank\u0027;\nWhen empty destination_type is provided, it\nwill be assigned to an default value according\nto source_type, if it is provided with a wrong\nvalue, command error will raise and information\nwill shown.\n\nChange-Id: If6c7d8ed58a94d262ac6c300e75aca4cdf99ff1d\npartial-bug: #1644725\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a58959dd9ec3962cbb6d273f136286809678b0c4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a58959dd9ec3962cbb6d273f136286809678b0c4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}