)]}'
{"novaclient/client.py":[{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"a65b504541191ebf07c2831cf942f5abe3ac01c6","unresolved":false,"context_lines":[{"line_number":874,"context_line":""},{"line_number":875,"context_line":"    _check_arguments(kwargs, \"Ocata\", \"auth_plugin\")"},{"line_number":876,"context_line":"    _check_arguments(kwargs, \"Ocata\", \"auth_system\")"},{"line_number":877,"context_line":"    _check_arguments(kwargs, \"Ocata\", \"no_cache\", \"os_cache\")"},{"line_number":878,"context_line":""},{"line_number":879,"context_line":"    api_version, client_class \u003d _get_client_class_and_version(version)"},{"line_number":880,"context_line":"    kwargs.pop(\"direct_use\", None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_d5c5c40a","line":877,"updated":"2016-12-07 18:55:21.000000000","message":"From what I can tell quickly reading the code, \"no_cache\" and \"os_cache\" are negations of each other.\n\nAre you sure \"os_cache\" can be considered a direct replacement (via \"right_name\") for the deprecated \"no_cache\"?\n\nFor example, this test passes:\n\n    @mock.patch(\"novaclient.client.warnings\")\n    def test__check_arguments_no_cache(self, mock_warnings):\n        kwargs \u003d {\u0027no_cache\u0027: True}\n        novaclient.client._check_arguments(kwargs, \"Ocata\", \n                                           deprecated_name\u003d\"no_cache\",\n                                           right_name\u003d\"os_cache\")\n        self.assertTrue(mock_warnings.warn.called)\n        self.assertEqual(kwargs, {\u0027os_cache\u0027: True})\n\nSetting \u0027no_cache\u0027 to True would result in \u0027os_cache\u0027 being True, but historically \u0027os_cache\u0027 it would have been False in this case, right?\n\nPerhaps I\u0027ve just misunderstood...","commit_id":"eae6f9caea424adfc59e0ee67c0138b28f317019"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"f267a16122d5d3e1dde4623c28776e5ae339a2b8","unresolved":false,"context_lines":[{"line_number":874,"context_line":""},{"line_number":875,"context_line":"    _check_arguments(kwargs, \"Ocata\", \"auth_plugin\")"},{"line_number":876,"context_line":"    _check_arguments(kwargs, \"Ocata\", \"auth_system\")"},{"line_number":877,"context_line":"    if \"no_cache\" in kwargs:"},{"line_number":878,"context_line":"        _check_arguments(kwargs, \"Ocata\", \"no_cache\", \"os_cache\")"},{"line_number":879,"context_line":"        # os_cache is not a fully compatible with no_cache, so we need to"},{"line_number":880,"context_line":"        # apply this custom processing"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_963a4433","line":877,"range":{"start_line":877,"start_character":4,"end_line":877,"end_character":28},"updated":"2016-12-08 16:56:50.000000000","message":"I wonder about the case where both no_cache \u0026 os_cache are in kwargs, both set to True or both set to False... but then I decided that\u0027s a user error and they just shouldn\u0027t do that ;) And another reason why one of the options should just be deprecated.","commit_id":"5598cc34badca5dd679f7e972d4548b352bdc1ac"}],"novaclient/v2/client.py":[{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"a65b504541191ebf07c2831cf942f5abe3ac01c6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                 http_log_debug\u003dFalse,"},{"line_number":83,"context_line":"                 insecure\u003dFalse,"},{"line_number":84,"context_line":"                 logger\u003dNone,"},{"line_number":85,"context_line":"                 no_cache\u003dTrue,"},{"line_number":86,"context_line":"                 os_cache\u003dFalse,"},{"line_number":87,"context_line":"                 project_id\u003dNone,"},{"line_number":88,"context_line":"                 proxy_tenant_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_8064ece5","line":85,"range":{"start_line":85,"start_character":17,"end_line":85,"end_character":31},"updated":"2016-12-07 18:55:21.000000000","message":"Should this be removed?","commit_id":"eae6f9caea424adfc59e0ee67c0138b28f317019"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"a65b504541191ebf07c2831cf942f5abe3ac01c6","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        self.services \u003d services.ServiceManager(self)"},{"line_number":191,"context_line":"        self.fixed_ips \u003d fixed_ips.FixedIPsManager(self)"},{"line_number":192,"context_line":"        self.floating_ips_bulk \u003d floating_ips_bulk.FloatingIPBulkManager(self)"},{"line_number":193,"context_line":"        self.os_cache \u003d os_cache or not no_cache"},{"line_number":194,"context_line":"        self.availability_zones \u003d \\"},{"line_number":195,"context_line":"            availability_zones.AvailabilityZoneManager(self)"},{"line_number":196,"context_line":"        self.server_groups \u003d server_groups.ServerGroupsManager(self)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_40801447","line":193,"range":{"start_line":193,"start_character":32,"end_line":193,"end_character":48},"updated":"2016-12-07 18:55:21.000000000","message":"Should this be removed?","commit_id":"eae6f9caea424adfc59e0ee67c0138b28f317019"}],"releasenotes/notes/deprecate-no-cache-arg-7814806b4f79c1b9.yaml":[{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"f267a16122d5d3e1dde4623c28776e5ae339a2b8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - novaclient.client.Client entry-point accepted two arguments with same"},{"line_number":4,"context_line":"    meaning (**no_cache** and **os_cache**). Since **os_cache** is more widely"},{"line_number":5,"context_line":"    used in our code, **no_cache** was deprecated."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a71b18c_56126c0a","line":4,"range":{"start_line":3,"start_character":50,"end_line":4,"end_character":11},"updated":"2016-12-08 16:56:50.000000000","message":"This isn\u0027t strictly true since they were negations of each other, but you could probably argue that they control the same lever. Anyhoo, I don\u0027t think you need to respin, but if you do I would clarify.","commit_id":"5598cc34badca5dd679f7e972d4548b352bdc1ac"}]}