)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"28bffa01f3d1145a403f2deef3305b84b1a7c5b4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Rename interface to endpoint_type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027interface\u0027 argument was not described anywhere in novaclient\u0027s docs,"},{"line_number":10,"context_line":"but since we transmit all additional(unexpected) arguments to"},{"line_number":11,"context_line":"SessionClient implementation, keystoneclient was able to use it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id7200a6df416694173b9a02206c53cef984f0fec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_4e67dbe8","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":37},"updated":"2016-12-05 16:45:13.000000000","message":"attonit: Needs a space before the open parenthesis.","commit_id":"d6b7ebbb8abdc7a3b6c8ec58a90b4f0c22bf73ae"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a3fb7b83f07ef149ccb8f7e81ee478864131d84e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Rename interface to endpoint_type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027interface\u0027 argument was not described anywhere in novaclient\u0027s docs,"},{"line_number":10,"context_line":"but since we transmit all additional(unexpected) arguments to"},{"line_number":11,"context_line":"SessionClient implementation, keystoneclient was able to use it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id7200a6df416694173b9a02206c53cef984f0fec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_9cad0d8b","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":37},"in_reply_to":"3a71b18c_4e67dbe8","updated":"2016-12-08 16:26:25.000000000","message":"After your comments, I started checking spaces even when I\u0027m writing in my native language:)","commit_id":"d6b7ebbb8abdc7a3b6c8ec58a90b4f0c22bf73ae"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"498aec0ef7dd85dc1dc415ebbd00d08b85e00953","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Rename interface to endpoint_type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027interface\u0027 argument was not described anywhere in novaclient\u0027s docs,"},{"line_number":10,"context_line":"but since we transmit all additional(unexpected) arguments to"},{"line_number":11,"context_line":"SessionClient implementation, keystoneclient was able to use it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id7200a6df416694173b9a02206c53cef984f0fec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_7672087e","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":37},"in_reply_to":"3a71b18c_9cad0d8b","updated":"2016-12-08 16:47:04.000000000","message":"Heh :)","commit_id":"d6b7ebbb8abdc7a3b6c8ec58a90b4f0c22bf73ae"}],"novaclient/client.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"9b7bc23a6d7683fece7ad1eeec32713d2668b58c","unresolved":false,"context_lines":[{"line_number":713,"context_line":"        return SessionClient(api_version\u003dapi_version,"},{"line_number":714,"context_line":"                             auth\u003dauth,"},{"line_number":715,"context_line":"                             endpoint_override\u003dendpoint_override,"},{"line_number":716,"context_line":"                             interface\u003dendpoint_type,"},{"line_number":717,"context_line":"                             region_name\u003dregion_name,"},{"line_number":718,"context_line":"                             service_name\u003dservice_name,"},{"line_number":719,"context_line":"                             service_type\u003dservice_type,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da4df55a_17de2e6d","line":716,"range":{"start_line":716,"start_character":29,"end_line":716,"end_character":52},"updated":"2016-12-23 11:15:03.000000000","message":"Looks like this is a backward incompatible change and not inline with how SessionClient is used in other projects.\n\nIt\u0027s mentioned below that \u0027face issue about unexpected behavior\u0027. Actually it would break whoever is passing \u0027interface\u0027.","commit_id":"9df9aff6fc921e7d4b5439f6bde76384f1d31d2f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e4e58f024dc6c44245cb191eaca2738cd4e3babf","unresolved":false,"context_lines":[{"line_number":713,"context_line":"        return SessionClient(api_version\u003dapi_version,"},{"line_number":714,"context_line":"                             auth\u003dauth,"},{"line_number":715,"context_line":"                             endpoint_override\u003dendpoint_override,"},{"line_number":716,"context_line":"                             interface\u003dendpoint_type,"},{"line_number":717,"context_line":"                             region_name\u003dregion_name,"},{"line_number":718,"context_line":"                             service_name\u003dservice_name,"},{"line_number":719,"context_line":"                             service_type\u003dservice_type,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da4df55a_4be80b11","line":716,"range":{"start_line":716,"start_character":29,"end_line":716,"end_character":52},"in_reply_to":"da4df55a_17de2e6d","updated":"2016-12-23 12:37:42.000000000","message":"please check L901 and method _check_arguments from L826-849 . Everything is done in backward compatible way. You can continue to use \u0027interface\u0027 variable till L901 will not be removed.","commit_id":"9df9aff6fc921e7d4b5439f6bde76384f1d31d2f"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"5ee0eeb565a53bc58ee047248a064b9da9e397b3","unresolved":false,"context_lines":[{"line_number":713,"context_line":"        return SessionClient(api_version\u003dapi_version,"},{"line_number":714,"context_line":"                             auth\u003dauth,"},{"line_number":715,"context_line":"                             endpoint_override\u003dendpoint_override,"},{"line_number":716,"context_line":"                             interface\u003dendpoint_type,"},{"line_number":717,"context_line":"                             region_name\u003dregion_name,"},{"line_number":718,"context_line":"                             service_name\u003dservice_name,"},{"line_number":719,"context_line":"                             service_type\u003dservice_type,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da4df55a_cbb6bb89","line":716,"range":{"start_line":716,"start_character":29,"end_line":716,"end_character":52},"in_reply_to":"da4df55a_4be80b11","updated":"2016-12-23 12:56:02.000000000","message":"Ah, I missed that. Thanks, However, I still don\u0027t see the reason to deprecate it. IMO, all clients should be consistent, whether it\u0027s interface or endpoint_type.","commit_id":"9df9aff6fc921e7d4b5439f6bde76384f1d31d2f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5d4e4fe7ddbbdf8186bebe7454a2f7e3f8e38cd3","unresolved":false,"context_lines":[{"line_number":713,"context_line":"        return SessionClient(api_version\u003dapi_version,"},{"line_number":714,"context_line":"                             auth\u003dauth,"},{"line_number":715,"context_line":"                             endpoint_override\u003dendpoint_override,"},{"line_number":716,"context_line":"                             interface\u003dendpoint_type,"},{"line_number":717,"context_line":"                             region_name\u003dregion_name,"},{"line_number":718,"context_line":"                             service_name\u003dservice_name,"},{"line_number":719,"context_line":"                             service_type\u003dservice_type,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da4df55a_06427a3e","line":716,"range":{"start_line":716,"start_character":29,"end_line":716,"end_character":52},"in_reply_to":"da4df55a_cbb6bb89","updated":"2016-12-23 13:00:24.000000000","message":"I think my comment at line L886-900 describes the reason of deprecation.\nIn short: interface argument was not documented anywhere; endpoint_type is a name of cli argument; if we rename endpoint_type to interface at cli level, we will have a conflict with another argument; usage different names at cli and at python levels is a bad thing","commit_id":"9df9aff6fc921e7d4b5439f6bde76384f1d31d2f"}]}