)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"1be7dbc4c2fda8bd4f6e53c008207042c34845f3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Nova API allows user filter flavors by minDisk and minRam,"},{"line_number":10,"context_line":"but that is not implemented in the current novaclient yet."},{"line_number":11,"context_line":"This patch introduce \u0027--minDisk\u0027 and \u0027--minRam\u0027 options to support"},{"line_number":12,"context_line":"it. In addition, We also append \u0027--sort-key\u0027 and \u0027--sort-dir\u0027 to"},{"line_number":13,"context_line":"the flavor-list subcommand to support sort the result list."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_a0e3af32","line":11,"range":{"start_line":11,"start_character":24,"end_line":11,"end_character":31},"updated":"2016-12-07 16:31:15.000000000","message":"Let\u0027s keep camelCase out of option names, please.","commit_id":"1d30ab95144cc7297cdcfe4056ed48aeb589286b"},{"author":{"_account_id":21479,"name":"int32bit","email":"krystism@gmail.com","username":"int32bit"},"change_message_id":"aa73627ab25aef7f25cb3c2bcd06195ad07a1786","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Nova API allows user filter flavors by minDisk and minRam,"},{"line_number":10,"context_line":"but that is not implemented in the current novaclient yet."},{"line_number":11,"context_line":"This patch introduce \u0027--minDisk\u0027 and \u0027--minRam\u0027 options to support"},{"line_number":12,"context_line":"it. In addition, We also append \u0027--sort-key\u0027 and \u0027--sort-dir\u0027 to"},{"line_number":13,"context_line":"the flavor-list subcommand to support sort the result list."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_8c6dfbce","line":11,"range":{"start_line":11,"start_character":24,"end_line":11,"end_character":31},"in_reply_to":"3a71b18c_a0e3af32","updated":"2016-12-08 02:16:27.000000000","message":"Yea, in fact I\u0027m really don\u0027t like camel case as well, but should we keep consistency with Nova API:\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/flavors.py#L93-L106","commit_id":"1d30ab95144cc7297cdcfe4056ed48aeb589286b"}],"novaclient/tests/unit/v2/test_flavors.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"1be7dbc4c2fda8bd4f6e53c008207042c34845f3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.assert_request_id(fl, fakes.FAKE_REQUEST_ID_LIST)"},{"line_number":52,"context_line":"        self.cs.assert_called(\u0027GET\u0027, \u0027/flavors/detail?limit\u003d4\u0026marker\u003d1234\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_list_flavors_with_minDisk(self):"},{"line_number":55,"context_line":"        fl \u003d self.cs.flavors.list(minDisk\u003d20)"},{"line_number":56,"context_line":"        self.assert_request_id(fl, fakes.FAKE_REQUEST_ID_LIST)"},{"line_number":57,"context_line":"        self.cs.assert_called(\u0027GET\u0027, \u0027/flavors/detail?minDisk\u003d20\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_c0350ba9","line":54,"range":{"start_line":54,"start_character":31,"end_line":54,"end_character":38},"updated":"2016-12-07 16:31:15.000000000","message":"Let\u0027s avoid camelCase please, except in class names.","commit_id":"1d30ab95144cc7297cdcfe4056ed48aeb589286b"}],"novaclient/v2/flavors.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"1be7dbc4c2fda8bd4f6e53c008207042c34845f3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    resource_class \u003d Flavor"},{"line_number":93,"context_line":"    is_alphanum_id_allowed \u003d True"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def list(self, detailed\u003dTrue, is_public\u003dTrue, marker\u003dNone, minDisk\u003dNone,"},{"line_number":96,"context_line":"             minRam\u003dNone, limit\u003dNone, sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":97,"context_line":"        \"\"\"Get a list of all flavors."},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_c05c2bf3","line":95,"range":{"start_line":95,"start_character":63,"end_line":95,"end_character":70},"updated":"2016-12-07 16:31:15.000000000","message":"camelCase.","commit_id":"1d30ab95144cc7297cdcfe4056ed48aeb589286b"}],"novaclient/v2/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"1be7dbc4c2fda8bd4f6e53c008207042c34845f3","unresolved":false,"context_lines":[{"line_number":866,"context_line":"           \u0027 after \"marker\".\u0027))"},{"line_number":867,"context_line":"@utils.arg("},{"line_number":868,"context_line":"    \u0027--min-disk\u0027,"},{"line_number":869,"context_line":"    dest\u003d\u0027minDisk\u0027,"},{"line_number":870,"context_line":"    metavar\u003d\u0027\u003cmin-disk\u003e\u0027,"},{"line_number":871,"context_line":"    default\u003dNone,"},{"line_number":872,"context_line":"    help\u003d_(\u0027Filters the flavors by a minimum disk space, in GiB.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_606ef797","line":869,"range":{"start_line":869,"start_character":10,"end_line":869,"end_character":17},"updated":"2016-12-07 16:31:15.000000000","message":"camelCase","commit_id":"1d30ab95144cc7297cdcfe4056ed48aeb589286b"}]}