)]}'
{"id":"openstack%2Fpython-novaclient~408909","triplet_id":"openstack%2Fpython-novaclient~master~I6289f46344876d19d9a6793875f896cedc85a01c","project":"openstack/python-novaclient","branch":"master","topic":"bug/gengchc","hashtags":[],"change_id":"I6289f46344876d19d9a6793875f896cedc85a01c","subject":"Replace six.iteritems() with .items()","status":"MERGED","created":"2016-12-09 02:43:41.000000000","updated":"2016-12-10 18:48:48.000000000","submitted":"2016-12-10 18:48:48.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"debb4c888ccd38a14b80eb281bda8c17eaf0373c","_number":408909,"virtual_id_number":408909,"owner":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-12-10 18:48:48.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"recommended":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-12-09 17:17:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},{"value":2,"date":"2016-12-09 16:07:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2016-12-10 17:42:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2016-12-10 17:42:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-12-09 16:07:49.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-12-09 17:17:00.000000000","updated_by":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"reviewer":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"state":"REVIEWER"},{"updated":"2016-12-10 17:42:57.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2016-12-10 18:48:48.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c2793e4836e09cbed1d1961c56e63682a2842947","author":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"date":"2016-12-09 02:43:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5590e718a1d9da5f6145c78c72c6575e6874aa1c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-09 03:51:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/09/408909/1/check/gate-python-novaclient-docs-ubuntu-xenial/e1ffb77//doc/build/html/ : SUCCESS in 1m 27s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/09/408909/1/check/gate-python-novaclient-pep8-ubuntu-xenial/f774359/ : SUCCESS in 1m 37s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/09/408909/1/check/gate-python-novaclient-python27-ubuntu-xenial/a393b79/ : SUCCESS in 3m 33s\n- gate-python-novaclient-python34 http://logs.openstack.org/09/408909/1/check/gate-python-novaclient-python34/66221b4/ : SUCCESS in 1m 44s\n- gate-python-novaclient-python35-nv http://logs.openstack.org/09/408909/1/check/gate-python-novaclient-python35-nv/92ffd33/ : SUCCESS in 1m 49s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/09/408909/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/fc7d607/ : SUCCESS in 49m 29s\n- gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv http://logs.openstack.org/09/408909/1/check/gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv/01878d8/ : SUCCESS in 27m 58s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/09/408909/1/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/545ae70/ : SUCCESS in 36m 20s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/09/408909/1/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/c1a6966/ : SUCCESS in 1h 06m 51s","accounts_in_message":[],"_revision_number":1},{"id":"f101a0b5be0381861eb52f2cd994d526b129ddd3","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-12-09 16:07:49.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"054c47a09ba8126c6ff22fe4584cac559e49c6c4","author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"date":"2016-12-09 17:17:00.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"571aa75269aa5a6cf4a180a2aea43c987c8fb56c","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-12-10 17:42:57.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"1d4cd3fe4283a00431c34fc0f066415c79f51684","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-10 17:43:08.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"74ba412c8b65705b804ff9d992a64dc4e77e9526","date":"2016-12-10 18:48:48.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"4eb342b77b73ca30880794420b4a1a4f7cd4b16d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-10 18:48:48.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/09/408909/1/gate/gate-python-novaclient-docs-ubuntu-xenial/62bbe44//doc/build/html/ : SUCCESS in 1m 22s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/09/408909/1/gate/gate-python-novaclient-pep8-ubuntu-xenial/9eea3e6/ : SUCCESS in 1m 36s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/09/408909/1/gate/gate-python-novaclient-python27-ubuntu-xenial/f771532/ : SUCCESS in 1m 38s\n- gate-python-novaclient-python34 http://logs.openstack.org/09/408909/1/gate/gate-python-novaclient-python34/93b1bf2/ : SUCCESS in 1m 40s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/09/408909/1/gate/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/d13bb4d/ : SUCCESS in 49m 19s\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/09/408909/1/gate/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/23a3f81/ : SUCCESS in 1h 05m 37s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"56bb3dae5ff2a3a51e54d8fa42277602e7b50710","revisions":{"56bb3dae5ff2a3a51e54d8fa42277602e7b50710":{"kind":"REWORK","_number":1,"created":"2016-12-09 02:43:41.000000000","uploader":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"ref":"refs/changes/09/408909/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/09/408909/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/09/408909/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/09/408909/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/09/408909/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/09/408909/1"}}},"commit":{"parents":[{"commit":"e490688b119786d8e59d6b72248d2484c032f761","subject":"Merge \"Add min-disk and min-ram filters to list flavors\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e490688b119786d8e59d6b72248d2484c032f761"}]}],"author":{"name":"gengchc2","email":"geng.changcai2@zte.com.cn","date":"2016-12-09 03:04:16.000000000","tz":480},"committer":{"name":"gengchc2","email":"geng.changcai2@zte.com.cn","date":"2016-12-09 03:04:16.000000000","tz":480},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using\nsix.iteritems to achieve iterators. We can\nuse dict.items instead, as it will return\niterators in PY3 as well. And dict.items/keys\nwill more readable. 2.In py2, the performance\nabout list should be negligible, see the link [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I6289f46344876d19d9a6793875f896cedc85a01c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/56bb3dae5ff2a3a51e54d8fa42277602e7b50710"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/56bb3dae5ff2a3a51e54d8fa42277602e7b50710"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}