)]}'
{"novaclient/base.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3930581aee15f27a26c863c350743f9439b370e8","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        return self._info \u003d\u003d other._info"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def __ne__(self, other):"},{"line_number":213,"context_line":"        return not self \u003d\u003d other"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def is_loaded(self):"},{"line_number":216,"context_line":"        return self._loaded"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_e73a2ae7","line":213,"updated":"2016-12-12 16:23:56.000000000","message":"Why not just call __eq__() directly?  I don\u0027t understand how this change benefits us.","commit_id":"5fc18ecdc6b8f78522c37cca4fbcb0d9404f44fe"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7ecca11aaa4320e1a9677ad4791d92a26ca556cf","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        return self._info \u003d\u003d other._info"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def __ne__(self, other):"},{"line_number":213,"context_line":"        return not self \u003d\u003d other"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def is_loaded(self):"},{"line_number":216,"context_line":"        return self._loaded"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_aa172943","line":213,"updated":"2016-12-16 21:38:28.000000000","message":"It would be nice to include a short comment here explaining why to use \u0027\u003d\u003d\u0027 rather than directly calling __eq__().  If you can\u0027t come up with a comment of two lines or less that explains it, no big deal; as I say, it\u0027s a \"nice to have\".","commit_id":"41dd64e90394cde3fd7706c2bb2aec7e85b934b8"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e3f338ba9b56922336ab18adb7e30f542476759b","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        return self._info \u003d\u003d other._info"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def __ne__(self, other):"},{"line_number":213,"context_line":"        return not self \u003d\u003d other"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def is_loaded(self):"},{"line_number":216,"context_line":"        return self._loaded"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_3d76c13e","line":213,"updated":"2016-12-19 17:58:34.000000000","message":"I assume you couldn\u0027t come up with a two-line comment like I requested?","commit_id":"734a6558e2640fca766ded0fdbd2ce0a6708e07e"}],"novaclient/tests/unit/test_base.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7ecca11aaa4320e1a9677ad4791d92a26ca556cf","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        # Two resources of different types: never equal"},{"line_number":76,"context_line":"        r1 \u003d base.Resource(None, {\u0027id\u0027: 1, \u0027name\u0027: \u0027test\u0027})"},{"line_number":77,"context_line":"        r2 \u003d None"},{"line_number":78,"context_line":"        self.assertNotEqual(r1, r2)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def test_findall_invalid_attribute(self):"},{"line_number":81,"context_line":"        cs \u003d fakes.FakeClient(api_versions.APIVersion(\"2.0\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_8a4a6d53","line":78,"updated":"2016-12-16 21:38:28.000000000","message":"My only concern here is that, not infrequently, we have people dig through the code base looking for places where comparisons to None are made and rewrite the asserts to be of the form \"assertIsNone()\" or \"assertIsNotNone()\".  If this bug would be demonstrated by comparisons to any other type of object, then perhaps you could exercise this using:\n\n    r2 \u003d object()","commit_id":"41dd64e90394cde3fd7706c2bb2aec7e85b934b8"}]}